aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-0417-19/+127
|\ | | | | Add Active Storage to Rails
| * Make sure the test fails if the code chagesRafael Mendonça França2017-08-041-8/+10
| | | | | | | | | | | | | | | | The test was passing before because it was not being testes correctly. Now we create a different engine that is loaded before the already exising and we make sure that the first call for isolate_namespace is what takes effect.
| * Do not call isolate_namespace on the applicationRafael Mendonça França2017-08-041-1/+9
| | | | | | | | | | | | | | | | | | What we want to test is that two different calls to isolate_namespace with the same module doesn't change the original railtie. We can do that defining two different railties. We can't call in the application because this method is not supposed to be called in an Application class.
| * Include active_storage in all generated application.rb filesDavid Heinemeier Hansson2017-08-043-1/+4
| | | | | | | | And deal with a temporary test fix until we allow you to skip active storage.
| * Convert to strings so array can be sorted deterministicallyDavid Heinemeier Hansson2017-08-041-3/+3
| |
| * Deterministic comparisons pleaseDavid Heinemeier Hansson2017-08-031-3/+3
| |
| * Do not eager load ActiveRecord::BaseRafael Mendonça França2017-08-032-10/+6
| | | | | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
| * Active Storage routes are now part of the default routesDavid Heinemeier Hansson2017-08-031-9/+37
| | | | | | | | It's worth considering whether we should hide these by default, but I'm kinda thinking no. It's very reasonable that someone would want to call these directly, so they should be documented.
| * Same issue from AR getting loaded earlierDavid Heinemeier Hansson2017-08-031-3/+3
| | | | | | | | cc @rafaelfranca
| * Including new default classes in loading testDavid Heinemeier Hansson2017-08-031-3/+3
| |
| * Active Storage loads AR earlier to extend it so require env laterDavid Heinemeier Hansson2017-08-031-3/+7
| |
| * Generating the app is where the exception is now raisedDavid Heinemeier Hansson2017-08-031-1/+1
| |
| * Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-023-3/+3
| |\
| * \ Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-017-8/+10
| |\ \
| * | | Prevent interpolation of ERB elementsDavid Heinemeier Hansson2017-08-011-6/+6
| | | |
| * | | Add the storage.yml file by defaultDavid Heinemeier Hansson2017-08-011-0/+1
| | | |
| * | | We moved to storage.ymlDavid Heinemeier Hansson2017-08-012-35/+1
| | | |
| * | | Add Azure configuration to Active Storage templateMike Gunderloy2017-08-011-0/+8
| | | | | | | | | | | | | | | | | | | | With Active Storage supporting Azure, we should show people how to set it up. Incorporates the minor changes originally in https://github.com/rails/activestorage/pull/88 as well
| * | | Create the skeleton directories needed and ignore accordinglyDavid Heinemeier Hansson2017-07-312-0/+8
| | | |
| * | | Load activestorage by defaultDavid Heinemeier Hansson2017-07-312-0/+8
| | | |
| * | | Use config/storage.yml as part of the skeleton and loadingDavid Heinemeier Hansson2017-07-315-6/+45
| | | |
| * | | Require activestorage per default with asset pipelineDavid Heinemeier Hansson2017-07-311-0/+1
| | | |
| * | | Include default storage configurationDavid Heinemeier Hansson2017-07-315-0/+36
| | | |
* | | | Merge pull request #30058 from ↵Rafael França2017-08-041-1/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | y-yagi/use_assert_nil_if_value_is_nil_in_assert_field_default_value_ Use `assert_nil` if `value` is nil in `assert_field_default_value`
| * | | | Use `assert_nil` if `value` is nil in `assert_field_default_value`yuuji.yaginuma2017-08-031-1/+5
| | |_|/ | |/| | | | | | | | | | | | | | It is deprecate to specify nil for expect argument of `assert_equal`. Ref: https://github.com/seattlerb/minitest/commit/922bc9151a622cb3ef0b9f170aa09c3bb72c7eb8
* | | | Merge pull request #30022 from y-yagi/remove_extra_empty_lineEileen M. Uchitelle2017-08-041-1/+5
|\ \ \ \ | | | | | | | | | | Remove extra empty line
| * | | | Remove extra empty lineyuuji.yaginuma2017-08-021-1/+5
| | |/ / | |/| |
* | | | Merge pull request #29967 from naw/binstub-error-msgRichard Schneeman2017-08-031-5/+16
|\ \ \ \ | | | | | | | | | | Improve bundler binstub error message
| * | | | Revise bundle binstub error messageNathan Wenneker2017-08-031-8/+13
| | | | |
| * | | | Improve bundler binstub error messageNathan Wenneker2017-07-261-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails displays an error message if you have a bundler-generated binstub at `./bin/rails` instead of a Rails-generated binstub. This error message is misleading because it makes it seem as though Rails 5 introduced recent changes in how binstubs are used, when these changes were actually introduced way back in Rails 4. The suggested upgrade steps are appropriate for an app that was created in Rails 3, but they likely aren't the correct fix for someone who sees this error message today on a modern app. I believe the `--binstubs` option on bundler is a more likely culprit and troubleshooting path.
* | | | | Merge pull request #30011 from guilherme/fix-migration-generator-special-casesSean Griffin2017-08-031-0/+22
|\ \ \ \ \ | |_|_|/ / |/| | | | Handling add/remove to/from migration edge cases
| * | | | Handling add/remove to/from migration edge casesGuilherme Reis Campos2017-08-031-0/+22
| | | | | | | | | | | | | | | | | | | | Making sure the table name is parsed correctly when an add/remove column migration have 'from'/'to' in the table name.
* | | | | Merge remote-tracking branch 'origin/master' into unlock-minitestRafael Mendonça França2017-08-0159-490/+827
|\ \ \ \ \ | | |_|_|/ | |/| | |
| * | | | Merge pull request #30015 from larskanis/use-duktake-on-mingwGuillermo Iguaran2017-08-012-0/+4
| |\ \ \ \ | | | | | | | | | | | | Use duktape gem as default JS engine on Windows-MINGW
| | * | | | Use duktape gem as default JS engine on Windows-MINGW and MS-Visual-C buildsLars Kanis2017-08-012-0/+4
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fallback javascript engine on Windows is Windows Script Host (JScript). However this engine isn't able to process the default assets, because it supports ES3 only but the coffeescript compiler requires ES5. Fixes #30014
| * | | | Merge pull request #30023 from y-yagi/remove_unnecessary_doc_directory_deletionGuillermo Iguaran2017-08-012-2/+0
| |\ \ \ \ | | | | | | | | | | | | Remove unnecessary `doc` directory deletion
| | * | | | Remove unnecessary `doc` directory deletionyuuji.yaginuma2017-08-012-2/+0
| | | |_|/ | | |/| | | | | | | | | | | | Since 553b695, `doc` directory is not created in application.
| * | | | Merge pull request #30029 from yhirano55/fix_rails_command_commentsSean Griffin2017-08-011-3/+3
| |\ \ \ \ | | | | | | | | | | | | [ci skip] Fix rails_command comments
| | * | | | [ci skip] Fix rails_command commentsYoshiyuki Hirano2017-08-011-3/+3
| | | |_|/ | | |/| |
| * | | | Fix rubocop style issues in yarn and spring.rb templates"roberts10002017-07-312-3/+3
| | |/ / | |/| |
| * | | Set Ruby version in Gemfile and .ruby-version by defaultAlberto Almagro2017-07-315-0/+25
| | |/ | |/|
| * | Fix `warning: method redefined;`yuuji.yaginuma2017-07-281-3/+3
| |/ | | | | | | | | | | | | | | | | This fixes the following warning: ``` /tmp/d20170727-7039-kmdtb1/app/app/models/user.rb:5: warning: method redefined; discarding old model_name rails/activemodel/lib/active_model/naming.rb:222: warning: previous definition of model_name was here ```
| * Merge pull request #29926 from pawandubey:fix-test-with-absolute-pathsKasper Timm Hansen2017-07-252-1/+30
| |\
| | * Allow bin/rails test task to take absolute paths as argumentsPawan Dubey2017-07-252-3/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Solves #29923 This regression was caused due to a wrong regex to filter out paths, introduced in commit 796a1cf0e The regex was /^\w+\// which did not accept paths with a leading slash and hence all absolute paths were filtered out. This change introduces a change in regex which allows for a leading slash and acts on the matched term accordingly. While cascading through the case block, the paths are checked for line number specification, existence of a directory at that path and if none of those match, then it is considered to be a path to the file. The regex matchers specified are filtered out via the call to `Array#compact` since they do not match any of these conditions.
| * | Merge pull request #29931 from ↵Sean Griffin2017-07-254-65/+36
| |\ \ | | |/ | |/| | | | | | | y-yagi/extract_assert_output_and_available_pty_to_module Extract `assert_output` and `available_pty?` into `ConsoleHelpers` module
| | * Extract `assert_output` and `available_pty?` into `ConsoleHelpers` moduleyuuji.yaginuma2017-07-254-65/+36
| | | | | | | | | | | | | | | We define almost the same method with multiple tests. Therefore, it extract into module.
| * | Fix `dbconsole` test when tempdir is a long pathSean Griffin2017-07-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | The output of `.databases` in SQLite will truncate to a certain size. This causes the test to fail when run locally from a mac, or anything which has a tempdir with more than a few characters. This pragma has the same output, but presented as a normal query, meaning no truncation will occur.
| * | Merge pull request #29916 from lugray/stop_generating_application_recordEileen M. Uchitelle2017-07-256-34/+35
| |\ \ | | |/ | |/| Stop creating ApplicationRecord on model generation
| | * Stop creating ApplicationRecord on model generationLisa Ugray2017-07-246-34/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When generating models, we created ApplicationRecord in the default location if no file existed there. That was annoying for people who moved it to somewhere else in the autoload path. At this point, the vast majority of apps should have either run the upgrade script or generated a model since upgrading. For those that haven't the error message after generating a new model should be helpful: NameError: uninitialized constant ApplicationRecord To ease friction in that case, this also adds a generator for ApplicationRecord.
| * | Fix `warning: ambiguous first argument`yuuji.yaginuma2017-07-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This fixes the following warning: ``` railties/test/application/rake/dbs_test.rb:265: warning: ambiguous first argument; put parentheses or a space even after `/' operator ```
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-26 06:48:37 +0000