aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
* Current default Rails app encoding "utf-8" looks more like a W3C charset ↵Akira Matsuda2017-01-111-1/+1
| | | | than a ruby encoding
* Revert "Merge pull request #27619 from dixpac/add_missing_generator_test"yuuji.yaginuma2017-01-101-5/+0
| | | | | | | | | | This reverts commit 8cb3cdffdb70f3575518d24ea96ec891e40d21d0, reversing changes made to 3bc747bd8676dc940b531067e2861dcd4ac28efc. Reason: This test already exists in `SharedGeneratorTests`. Ref: https://github.com/rails/rails/blob/master/railties/test/generators/shared_generator_tests.rb#L109..L112 https://github.com/rails/rails/blob/master/railties/test/generators/app_generator_test.rb#L55..L56
* Test `--skip-git` generator optiondixpac2017-01-091-0/+5
|
* Don't generate HTML/ERB templates for scaffold controller with --api flagPrathamesh Sonpatki2017-01-073-1/+18
| | | | - Fixes #27591.
* `self.` is not needed when calling its own instance methodAkira Matsuda2017-01-058-9/+9
| | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
* Fix style guide violationsRafael Mendonça França2017-01-051-1/+0
|
* Merge pull request #27399 from sinogermany/rails-env-for-empty-string-env-varsRafael Mendonça França2017-01-033-1/+18
|\ | | | | | | Rails env for empty string env vars
| * Rails.env falls back to dev mode when env var is emptyDaniel Deng2017-01-043-1/+18
| |
* | Fix configuration test now that Metal#env was removedRafael Mendonça França2017-01-031-1/+1
| |
* | Revert "Merge pull request #27550 from ↵Rafael Mendonça França2017-01-036-26/+6
| | | | | | | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine" This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1. Reason: It breaks the public API
* | Merge pull request #27550 from ↵Rafael França2017-01-036-6/+26
|\ \ | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine Fix generator command for nested (namespaced) rails engine
| * | Fix generator command for nested (namespaced) rails engineFumiaki MATSUSHIMA2017-01-036-6/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
* | | Remove test to the db:test:cloneRafael Mendonça França2017-01-031-10/+0
| | |
* | | Remove deprecated CONTROLLER environment variable for routes taskRafael Mendonça França2017-01-033-49/+29
| | |
* | | Remove deprecated tasks in railtiesRafael Mendonça França2017-01-032-12/+5
| | |
* | | Remove deprecated file `rails/rack/debuggerRafael Mendonça França2017-01-032-3/+4
| | |
* | | Remove deprecated config.serve_static_filesRafael Mendonça França2017-01-033-29/+4
| | |
* | | Remove deprecated `config.static_cache_control`Rafael Mendonça França2017-01-034-24/+6
| | |
* | | Merge pull request #24814 from vipulnsward/24811-fix-double-tasksArthur Nogueira Neves2017-01-031-1/+0
|\ \ \ | | | | | | | | Don't list out tasks as separately that are under lib, which cause them to be listed twice under Libraries and tasks.
| * | | Don't list out tasks as separately that are under lib, which cause them to ↵Vipul A M2016-07-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | be listed twice under Libraries and tasks. We already count and list it under libraries. Fixes #24811
* | | | Merge pull request #27435 from kamipo/follow_up_25307Sean Griffin2017-01-032-2/+2
|\ \ \ \ | |_|/ / |/| | | Active Record supports MySQL >= 5.1.10
| * | | Active Record supports MySQL >= 5.1.10Ryuta Kamizono2016-12-222-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #25307 and #23458. Related with #27422. We are using `information_schema.referential_constraints` since #25307. The table was introduced in MySQL 5.1.10. MySQL 5.0 is too old. It is enough to support >= 5.1.10 at least. MySQL 5.0 GA was released in Dec 2005 and already EOL in Dec 2011. MySQL 5.1 GA was released in Dec 2008 and already EOL in Dec 2013.
* | | | Remove bin/yarn if yarn is skipped, tidy up testsPrathamesh Sonpatki2017-01-012-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | - No need to remove bin/yarn separately for API only apps because :skip_yarn is set to true for API only apps. - Added a test for :skip_yarn config.
* | | | Merge pull request #27535 from y-yagi/add_test_script_for_railtiesKasper Timm Hansen2017-01-011-0/+4
|\ \ \ \ | | | | | | | | | | add `bin/test` script for railties
| * | | | add `bin/test` script for railtiesyuuji.yaginuma2017-01-011-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | The railties test does not require specific setup performed in the rake-tasks, so we can use test runner as well as other components.
* | | | | remove unnecessary `remove_file`yuuji.yaginuma2017-01-011-1/+0
|/ / / / | | | | | | | | | | | | | | | | | | | | It deletes the `app/mailers` directory itself, it is not necessary to delete the file individually. https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/app_generator.rb#L329
* | | | Match Thor's `desc` signature.Kasper Timm Hansen2016-12-311-1/+1
| | | | | | | | | | | | | | | | It can also take an options hash.
* | | | Prevent command name being printed twice.Kasper Timm Hansen2016-12-311-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Thor would inadvertantly duplicate the command usage because of the help method in a command class. Fixes #26664. [ Yuji Yaginuma & Kasper Timm Hansen ]
* | | | Bump license years for 2017Jon Moss2016-12-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip]
* | | | remove `skip_bundle` option from plugin generatoryuuji.yaginuma2016-12-312-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Because `bundle install` is not executed regardless of whether the option is specified or not. Ref: fbd1e98cf983572ca9884f17f933ffe92833632a
* | | | Enforce middleware ordering with a test, instead of commentsMatthew Draper2016-12-312-6/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want the actual order to be very predictable, so it's rightly defined in code -- not with an on-the-fly tsort. But we can do the tsort here, and then verify that it matches the implemented ordering. This way we don't leave future readers guessing which parts of the ordering are deliberate and which are arbitrary.
* | | | Merge pull request #27515 from ↵Matthew Draper2016-12-312-3/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | kbrock/fix_log_remote_ip_before_dispatcher_ips_settings Allow log remote ip addres when config.action_dispatch.trusted_proxie…
| * | | | Allow log remote ip addres when config.action_dispatch.trusted_proxies passedLeonid Batizhevsky2016-12-302-2/+3
|/ / / /
* | | | Remove needless `ActiveSupport::Deprecation.silence`Ryuta Kamizono2016-12-311-3/+1
| | | |
* | | | `#tables` and `#table_exists?` and returns only tables and not viewsRafael Mendonça França2016-12-291-5/+3
| | | |
* | | | Remove deprecated support to passing a column to #quoteRafael Mendonça França2016-12-292-18/+2
| | | |
* | | | Merge branch 'master' into fix_26964Kasper Timm Hansen2016-12-2960-522/+551
|\ \ \ \
| * \ \ \ Merge branch 'master' into clear_all_environments_log_by_defaultRafael França2016-12-29100-588/+816
| |\ \ \ \
| | * | | | Fix Rubocop violations and fix documentation visibilityRafael Mendonça França2016-12-281-38/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API.
| | * | | | Add backticks to show shell commandJon Moss2016-12-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| | * | | | Remove random extra spaces from Action Pack and Railties CHANGELOG.mdJon Moss2016-12-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| | * | | | assert_equal takes expectation firstAkira Matsuda2016-12-261-1/+1
| | | | | |
| | * | | | Correct indent-accounting in controller route generationMatthew Draper2016-12-252-12/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #27447 [Matthew Draper & Yuuji Yaginuma]
| | * | | | "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-255-8/+8
| | | | | |
| | * | | | Privatize unneededly protected methods in RailtiesAkira Matsuda2016-12-2525-135/+136
| | | | | |
| | * | | | Privatize some methods that were originally protectedAkira Matsuda2016-12-251-25/+27
| | | | | |
| | * | | | Prefer class << self; def over def self.Akira Matsuda2016-12-251-200/+200
| | | | | |
| | * | | | `protected` here doesn't protect anythingAkira Matsuda2016-12-251-26/+25
| | | | | | | | | | | | | | | | | | | | | | | | there aren't any instance method defined in this class
| | * | | | Privatize unneededly protected methods in Railties testsAkira Matsuda2016-12-246-6/+6
| | | | | |
| | * | | | Describe what we are protectingAkira Matsuda2016-12-232-0/+4
| | |/ / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 00:19:33 +0000