| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| | |
Rails env for empty string env vars
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
mtsmfm/fix-generator-command-for-nested-rails-engine"
This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing
changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1.
Reason: It breaks the public API
|
|\ \
| | |
| | |
| | |
| | | |
mtsmfm/fix-generator-command-for-nested-rails-engine
Fix generator command for nested (namespaced) rails engine
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If we create nested (namespaced) rails engine such like bukkits-admin,
`bin/rails g scaffold User name:string age:integer`
will create
`bukkits-admin/app/controllers/bukkits/users_controller.rb`
but it should create
`bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.
In #6643, we changed `namespaced_path` as root path
because we supposed application_controller is always in root
but nested rails engine's application_controller will not.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Don't list out tasks as separately that are under lib, which cause them to be listed twice under Libraries and tasks.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
be listed twice under Libraries and tasks.
We already count and list it under libraries.
Fixes #24811
|
|\ \ \ \
| |_|/ /
|/| | | |
Active Record supports MySQL >= 5.1.10
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Follow up to #25307 and #23458. Related with #27422.
We are using `information_schema.referential_constraints` since #25307.
The table was introduced in MySQL 5.1.10. MySQL 5.0 is too old. It is
enough to support >= 5.1.10 at least.
MySQL 5.0 GA was released in Dec 2005 and already EOL in Dec 2011.
MySQL 5.1 GA was released in Dec 2008 and already EOL in Dec 2013.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- No need to remove bin/yarn separately for API only apps because
:skip_yarn is set to true for API only apps.
- Added a test for :skip_yarn config.
|
|\ \ \ \
| | | | |
| | | | | |
add `bin/test` script for railties
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The railties test does not require specific setup performed in the rake-tasks,
so we can use test runner as well as other components.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
It deletes the `app/mailers` directory itself, it is not necessary to delete
the file individually.
https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/app_generator.rb#L329
|
| | | |
| | | |
| | | |
| | | | |
It can also take an options hash.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Thor would inadvertantly duplicate the command usage because
of the help method in a command class.
Fixes #26664.
[ Yuji Yaginuma & Kasper Timm Hansen ]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Per https://www.timeanddate.com/counters/firstnewyear.html, it's already
2017 in a lot of places, so we should bump the Rails license years to
2017.
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Because `bundle install` is not executed regardless of whether the option
is specified or not.
Ref: fbd1e98cf983572ca9884f17f933ffe92833632a
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We want the actual order to be very predictable, so it's rightly defined
in code -- not with an on-the-fly tsort.
But we can do the tsort here, and then verify that it matches the
implemented ordering. This way we don't leave future readers guessing
which parts of the ordering are deliberate and which are arbitrary.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
kbrock/fix_log_remote_ip_before_dispatcher_ips_settings
Allow log remote ip addres when config.action_dispatch.trusted_proxie…
|
|/ / / / |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \ |
|
| |\ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Some methods were added to public API in
5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of
the public API.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes #27447
[Matthew Draper & Yuuji Yaginuma]
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
there aren't any instance method defined in this class
|
| | | | | | |
|
| | |/ / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This quiet the following log.
```
create app/mailers/notifier_mailer.rb
invoke erb
create app/views/notifier_mailer
identical app/views/layouts/mailer.text.erb
identical app/views/layouts/mailer.html.erb
create app/views/notifier_mailer/foo.text.erb
create app/views/notifier_mailer/foo.html.erb
invoke test_unit
create test/mailers/notifier_mailer_test.rb
create test/mailers/previews/notifier_mailer_preview.rb
```
|
| | | | |
| | | | |
| | | | |
| | | | | |
Very similar to PR #25758, see more in depth reasoning there.
|
| | | |/
| | |/|
| | | |
| | | |
| | | |
| | | | |
Gems like rspec-rails depend on `ARGV` being shifted, and `scaffold`
(for example) not being the first item in `ARGV`. This should allow
rspec-rails to be passing on Rails master.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
```
$ git grep namespaced_file_path
railties/lib/rails/generators/named_base.rb: def namespaced_file_path
railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/")
```
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This fixes the following warning.
```
Expected boolean default value for '--rc'; got "~/.railsrc" (string)
```
|
| | |\ \
| | | | |
| | | | | |
Schema cache in YAML
|