| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
set to activerecord session store
- Use keyword args as it is possible to use them now.
- The error message for activerecord-session_store gem was added in 1807384.
- But it was added for a code path which gets called when we try to
**access** the session store, not when we **set** it.
- So the test expecting the exception started failing because now the
session store is set via railtie again **after** setting it first with
:active_record_store in the test.
- As the error is not raised while setting the store to
:active_record_store, the store gets overwritten by railtie and when
we access it via `session_store` while building the default middleware
stack, the exception is not raised.
- This commit moves the code for raising the exception to the path where
we try to set the store.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
by Rails
- We need to ability to check whether the session store it is set or
not so that we can set it ourselves in an internal initializer.
- We can't rely on return value of `config.session_store` as it can
return `nil` when set to `disabled` and we will accidentally override it
and set to default cookie store.
- So introduced new method which just tells us whether it is set or not.
|
| | |
|
| |
| |
| |
| | |
- Also minor weekly CHANGELOG cleanup.
|
| |
| |
| |
| |
| | |
A mailer preview test description misspelled the word configuration.
This commit updates the test description to spell the word correctly.
|
|\ \
| | |
| | | |
Give importance to rails command [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Speed up RDoc generation when it's already been done once
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Only include files that contain changes since the last generation
of the API documentation.
Thus, only modified files are re-generated instead of the whole API.
The `created.rid` file won't contain the whole list of files anymore
if we generate several times the API but we don't really care about it,
only the generation date and time is important.
It is possible to fall back to the previous behavior by defining the ALL
environment variable running the `rake rdoc` task.
|
| |/ /
|/| | |
|
| |/
|/|
| |
| |
| | |
`class_variable_get` is public from Ruby 1.9.
Ref: http://ruby-doc.org/core-2.2.0/Module.html#method-i-class_variable_get
|
| |
| |
| |
| |
| |
| | |
- Cleanup Active Record CHANGELOG.
- Add missing CHANGELOG for https://github.com/rails/rails/pull/25688.
- Clarify that assets requests logging is suppressed.
|
|\ \
| | |
| | | |
Remove unused boot_rails method and it's usage
|
| |/
| |
| |
| |
| | |
- The `boot_rails` method from abstract_unit.rb is empty after 2abcdfd978fdcd491576a237e8c6b.
- So let's remove it and its usage.
|
|\ \
| | |
| | | |
Use the HOST environment variable for rails server #25677
|
| |/ |
|
|\ \
| | |
| | |
| | | |
Add a changelog entry for #25692
|
| | | |
|
|\ \ \
| | | |
| | | | |
No need to set `cookie_only` option from Rails
|
| |/ /
| | |
| | |
| | | |
it false
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
fledman/add_respond_to_missing_to_rails_application_configuration_custom
implement respond_to_missing? to match method_missing
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
johnmeehan/allow-registering-directory-for-rake-notes
Allow rake notes to work with other directories.
|
| | |
| | |
| | |
| | |
| | |
| | | |
accidently set it to.
Made the change and test still passes.
|
| | | |
|
| |/
| |
| |
| |
| |
| |
| | |
Additional directories can be added using
SourceAnnotationExtractor::Annotation.register_directories("spec", "other_dir")
Result: rake notes will now extract notes from these directories.
|
|\ \
| | |
| | | |
Display railtie class name in `rails initializers`
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The options used in this file are *not* directly described in the Rails 5.0
release notes (http://edgeguides.rubyonrails.org/5_0_release_notes.html), but
instead in section 2 of the Guide for Upgrading Ruby on Rails document
(http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html).
|
| |/
|/| |
|
|\ \
| | |
| | | |
refer to rails command instead of rake in doc of `SourceAnnotationExtractor`
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| |/ /
|/| | |
Clean backtrace in IRB
|
| | |
| | |
| | |
| | |
| | |
| | | |
user/lib code
- Cleaned up backtrace cleaner test code and removed instaces variables
|
| | |
| | |
| | |
| | | |
Add handling of cleaning up backtrace from IRB console in case of errors
|
| | |
| | |
| | |
| | | |
Follow up to #25431
|
|/ /
| |
| |
| |
| |
| | |
Since bundler 1.12.0, the gemspec is validated so the `bundle install`
command will fail just after the gem is created causing confusion to the
users. This change was a bug fix to correctly validate gemspecs.
|
|\ \
| | |
| | |
| | |
| | | |
prathamesh-sonpatki/add-note-about-upgrade-guide-at-the-end-of-update
Display link to Rails upgrade guide at the end of `rails app:update` task.
|
| | |
| | |
| | |
| | |
| | | |
- This will nudge people in the direction of going through upgrade
guides.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Update to Turbolinks 5.0.0 final
|
| |/ / |
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
This will fix the failures fixed by
41488adbb89a09fa96188486f8414842ff28c848
and keep this new option that is semi-private
outside of the generated configurations
|
| |
| |
| |
| |
| | |
Railties tests didn't know about the new config option added in 80b416f so
it needed to be added to the railties generators for configs.
|
| |
| |
| |
| |
| |
| |
| |
| | |
This will make easier to applications that rely on having const_missing
hooks in production upgrade to Rails 5.
This option is going to be remove in the future and the default behavior
will be to disable the dependency loading.
|