| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\
| |
| |
| |
| | |
Add option to verify Origin header in CSRF checks
[Jeremy Daer + Rafael Mendonça França]
|
| | |
|
|\ \
| | |
| | | |
Remove <br> from scaffold form, in favor of using CSS
|
| | | |
|
|\ \ \
| |/ /
|/| | |
do not show Active Job test generator
|
| | |
| | |
| | |
| | |
| | | |
Like the other generator, for also Active Job, I think that there is no need to
display for test generator.
|
|\ \ \
| | | |
| | | | |
Remove a blank line from a template for plugin `routes.rb`
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Move the desc one level up
|
| | |/ /
| |/| |
| | | | |
Make the task visible (from rake -T) by moving the desc one level up
|
|\ \ \ \
| |_|/ /
|/| | | |
don't package test files in plugin gemspec
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | | |
In rails engine, there is a dummy application under test,
the size of the test file is increased.
However, there is no need test files for most users,
I think it good to have so as not included by default.
|
| |/
|/|
| |
| | |
Also call it `public_server.index_name` so it'll make more sense.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When running tests, the Rails test runner would report the start of the test method as the test failure.
For this test:
```ruby
1 require 'test_helper
2
3 class BunnyTest < ActiveSupport::TestCase
4 test "something failing" do
5 assert false, 'This failed'
6 end
7 end
```
The runner outputs 5 instead of 4:
```
............................................F
This failed
bin/rails test test/models/bunny_test.rb:5
........
```
|
| |
| |
| |
| | |
The overall syntax of the file path is more important, not the exact line it was on.
|
| | |
|
| | |
|
| |
| |
| |
| | |
3.0.3 has a bug in OS X.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is the implementation of the file update checker written
by Puneet Agarwal for GSoC 2015 (except for the tiny version
of the listen gem, which was 3.0.2 in the original patch).
Puneet's branch became too out of sync with upstream. This is
the final work in one single clean commit.
Credit goes in the first line using a convention understood
by the contrib app.
|
|/
|
|
|
|
|
|
|
| |
generator
In the app generator, regardless of the namespace, it is adapted to read the same `application_controller.rb`,
modified to api generator also be the same behavior.
ref 686966a1861e6761021d45f6795de753e8a62216, 06ac63b4c602e4b26cb3bfbf0dfd2bed8b00e786
|
|
|
|
|
|
| |
It was deprecated in https://github.com/rails/rails/pull/19135.
We're now favoring `public_file_server.headers`.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Fix the message by wrapping the value in missing quotes and adding
the missing backtick at the end. Finally, :lipstick: by adding a space
inside the curly braces.
Before:
`config.public_file_server.headers = {'Cache-Control' => public,
max-age=31536000}
Now:
`config.public_file_server.headers = { 'Cache-Control' => 'public,
max-age=31536000' }`
2. Display `static_cache_control` instead of static_cache_control. This
follows what the 2 neighboring methods are doing.
3. Use strip_heredoc to improve the code formatting and readability
like the 2 neighboring methods and wrap to 80 characters.
|
|
|
|
| |
Forgot to do it in 748b2f9, when deprecating `serve_static_files`.
|
|\
| |
| | |
Add enabled flag to the public file server settings.
|
| |
| |
| |
| |
| |
| |
| | |
The configuration for `config.static_cache_control`, and its replacement
`config.public_file_server.headers` are implemented in Railties.
People would configure this in environment files, which is Railties domain too.
|
| |
| |
| |
| |
| |
| |
| |
| | |
As discussed in https://github.com/rails/rails/pull/19135#issuecomment-153385986.
Replaces `serve_static_files` to unify the static options under the `public_file_server` wing.
Deprecates `serve_static_files` accessors, but make them use the newer config internally.
|
|/
|
|
|
|
|
| |
we can just reuse the parent process. We should figure out what files
are commonly required among the test files and try to require them in
the parent so that the require time cost is amortized across the
processes.
|
|
|
|
|
| |
`config.middleware.insert_before` changes require to restart the server
Also added missing `.` at the EOL.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
`1_valid_people_have_last_names.rb` and
`20150823202140_create_users.rb` are valid migration file name.
But `1_valid_people_have_last_names.rb` is rendered as
`********** NO FILE **********` when `rake db:migrate:status`.
Fix to this bug, this commit includes
* define some API private methdos and a Constant
`match_to_migration_filename?`, `parse_migration_filename`, and
`MigrationFilenameRegexp`
* use these methods in `db:migrate:status` task
Example:
These files are in `db/migrate`
* 1_valid_people_have_last_names.rb
* 20150819202140_irreversible_migration.rb
* 20150823202140_add_admin_flag_to_users.rb
* 20150823202141_migration_tests.rb
* 2_we_need_reminders.rb
* 3_innocent_jointable.rb
we can migrate all of them.
Before
```shell
$ bundle exec rake db:migrate:status
...
Status Migration ID Migration Name
--------------------------------------------------
up 001 ********** NO FILE **********
up 002 ********** NO FILE **********
up 003 ********** NO FILE **********
up 20150819202140 Irreversible migration
up 20150823202140 Add admin flag to users
up 20150823202141 Migration tests
```
After
```shell
$ bundle exec rake db:migrate:status
...
Status Migration ID Migration Name
--------------------------------------------------
up 001 Valid people have last names
up 002 We need reminders
up 003 Innocent jointable
up 20150819202140 Irreversible migration
up 20150823202140 Add admin flag to users
up 20150823202141 Migration tests
```
|
|\
| |
| | |
remove unnecessary `.sass-cache` from plugin's gitignore template
|
| |
| |
| |
| | |
Since the sass cache is output to the `tmp/cache/sass`.
|
|/ |
|
| |
|
|
|
|
|
|
| |
We are using the same version constraint in the database adapters so
when a new version of the adapter that doesn't work with the version of
rails is released we don't break new applications.
|
| |
|
|\
| |
| | |
Allow rake:stats to account for rake tasks
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
If `SECRET_KEY_BASE` or other `secret` gets passed as other then string
we need to raise `ArgumentError` to know that it's a wrong argument.
Closes #22072
|
|\ \
| | |
| | |
| | | |
Explicitly exit with status "1" for create and drop failures
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* If the drop task fails for a reason other than the database not
existing, processing should end. This is indicated by a non-zero
exit status.
* Since the backtrace is already printed to screen, we forgo
printing it again by using an explicit call to `exit`.
* :warning: This modifies the behavior of the db:create task slightly in
that the stack trace is no longer printed by default. If the `--trace`
option is used, it will print the trace _after_ the error message.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* If the create task fails for a reason other than the database already
existing, processing should end. This is indicated by a non-zero exit
status.
* Since the backtrace is already printed to screen, we forgo printing it
again by using an explicit call to `exit`.
* :warning: This modifies the behavior of the db:create task slightly in
that the stack trace is no longer printed by default. If the `--trace`
option is used, it will print the trace _after_ the error message.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Previously the sqlite3 adapter could not "fail" on drop. Now an error
is raised when no file exists.
* Also updates purge to be resilient of drop failures. This is how purge
is expected to behave.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Running the db:create task when the database already exists isn't
really an error case. That is processing may proceed in this case
because the database exists as requested. So let's validate that
behavior with a test.
* Likewise, if the database doesn't exist when running the db:drop task
processing may continue as the requested condition is already met.
Thus a test.
|
| | | |
|
| | |
| | |
| | |
| | | |
Also move the method to the right class
|
| | | |
|
| | |
| | |
| | |
| | | |
`README` it is changed to `README.rdoc` in 6b126e2, it has been changed to` README.md` further 89a12c9.
|
|/ /
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| | |
multiple environments in secrets.yml"
|