Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | favor includes over old AR way | Vijay Dev | 2011-06-11 | 1 | -1/+1 | |
| | | ||||||
| * | fixed incorrect command usage. (This section needs to be updated in any case). | Vijay Dev | 2011-06-11 | 1 | -1/+1 | |
| | | ||||||
| * | minor fixes in action view guide | Vijay Dev | 2011-06-11 | 1 | -3/+3 | |
| | | ||||||
* | | Attributes on scaffold and model generators default to string. | José Valim | 2011-06-17 | 5 | -17/+24 | |
| | | | | | | | | This allows the following: "rails g scaffold Post title body:text author" | |||||
* | | AS guide: expands safe string docs regarding destructive methods, coercion, ↵ | Xavier Noria | 2011-06-17 | 1 | -2/+20 | |
| | | | | | | | | copying, etc. | |||||
* | | Patch for #1458 - [3.1.0.rc1] App plugins initialized before engines | Joseph Wong | 2011-06-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and plugins inside engines It seems that plugins inside a Rails 3.1 application proper (i.e. in /vendor/plugins) are initialized before engines and plugins inside engines. After some debugging, I found the culprit in Rails::Application::Railties#all: def all(&block) @all ||= railties + engines + super @all.each(&block) if block @all end The call to super here implicitly passes the &block argument, which has the unfortunate side-effect of adding the plugin initializers first (in front of other railties and engines) in the case of Rails::Engine#initializers: def initializers initializers = [] railties.all { |r| initializers += r.initializers } initializers += super initializers end The solution here is to replace the super call with a call to #plugins. | |||||
* | | Make the API for compression consistent between JS and CSS. By default, ↵ | wycats | 2011-06-16 | 1 | -3/+0 | |
| | | | | | | | | | | | | users just need to say whether they want compression or not, and a default will be chosen by a Railtie. In the case of CSS, this default is already chosen by the sass-rails gem. Users can still explicitly choose a compressor in their application.rb if they have a preference, but will usually want to let plugins choose defaults in their Railties. | |||||
* | | Merge pull request #1733 from SAP-Oxygen/master-plugins_in_engine_patch | José Valim | 2011-06-16 | 2 | -8/+10 | |
|\ \ | | | | | | | Cherry-picking patch for https://github.com/rails/rails/issues/1460 from 3-1-stable to master | |||||
| * | | Cherry-picking patch for https://github.com/rails/rails/issues/1460 | Joseph Wong | 2011-06-16 | 2 | -8/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from 3-1-stable to master [3.1.0.rc1] Plugins inside engines not eager-loaded properly and their rake tasks ignored Working with the new support for plugins inside engines in Rails 3.1, I found that certain things that work for regular plugins don't work for these new nested plugins. In particular, these methods in Rails::Engine don't seem to understand that an engine could have nested plugins: #load_tasks #load_generators #load_console #eager_load! A solution which worked out for me is to move the calls to railties.all { ... } from the overriding methods in Rails::Application into Rails::Engine. | |||||
* | | | replace dev.ror.com plugin url with a dummy one | Vijay Dev | 2011-06-16 | 1 | -2/+2 | |
| | | | ||||||
* | | | Improve the legacy wild controller route in app templates | Wen-Tien Chang | 2011-06-16 | 1 | -1/+1 | |
|/ / | ||||||
* | | load_generators from engine should also handle self automatically. | José Valim | 2011-06-15 | 1 | -3/+3 | |
| | | ||||||
* | | Merge pull request #1676 from neerajdotname/make_test_name_meaningful | Santiago Pastorino | 2011-06-13 | 1 | -1/+1 | |
|\ \ | | | | | | | Remove "is_assed" with something more meaningful | |||||
| * | | Remove "is_assed" with something more meaningful | Neeraj Singh | 2011-06-13 | 1 | -1/+1 | |
| | | | ||||||
* | | | namespace engine assets | Ryan Bates | 2011-06-12 | 3 | -19/+37 | |
|/ / | ||||||
* | | Make i18n tests more robust. | José Valim | 2011-06-12 | 1 | -3/+3 | |
| | | ||||||
* | | Remove utf8_enforcer_param config option | David Lee | 2011-06-11 | 2 | -17/+0 | |
| | | ||||||
* | | Make utf8 enforcer param customizeable | David Lee | 2011-06-11 | 2 | -1/+18 | |
| | | ||||||
* | | s/Bundle/Bundler/ | Xavier Noria | 2011-06-11 | 1 | -1/+1 | |
|/ | ||||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-06-11 | 6 | -118/+24 | |
|\ | ||||||
| * | update palmist link on performance_testing | John Hinnegan | 2011-06-09 | 1 | -1/+1 | |
| | | ||||||
| * | Merge branch 'master' of github.com:lifo/docrails | Mohammad Typaldos | 2011-06-09 | 1 | -1/+1 | |
| |\ | ||||||
| | * | Describe the user name 'variable' in a way that doesn't confuse the textile ↵ | Ben Orenstein | 2011-06-08 | 1 | -1/+1 | |
| | | | | | | | | | | | | parser. | |||||
| * | | Match tone already established | Mohammad Typaldos | 2011-06-09 | 1 | -1/+1 | |
| |/ | ||||||
| * | require_tree is pretty simple | Mohammad Typaldos | 2011-06-08 | 1 | -2/+2 | |
| | | ||||||
| * | minor corrections in configuring guide | Vijay Dev | 2011-06-08 | 1 | -11/+11 | |
| | | ||||||
| * | remove generators section from command line guide in favor of the separate ↵ | Vijay Dev | 2011-06-08 | 1 | -94/+0 | |
| | | | | | | | | generator guide | |||||
| * | fix generators guide url | Vijay Dev | 2011-06-08 | 1 | -2/+2 | |
| | | ||||||
| * | use git: rather than https: in git remote urls; else, github asks for ↵ | Vijay Dev | 2011-06-08 | 1 | -1/+1 | |
| | | | | | | | | passwords everytime we push | |||||
| * | minor fixes from 5acf76d | Vijay Dev | 2011-06-08 | 1 | -2/+2 | |
| | | ||||||
| * | fix incorrect validation examples | Vijay Dev | 2011-06-08 | 1 | -5/+5 | |
| | | ||||||
* | | shell out to run bundler on app generation, see rationale in the comment | Xavier Noria | 2011-06-10 | 1 | -6/+12 | |
| | | ||||||
* | | make 'rails runner' show usage when run without any options | Vijay Dev | 2011-06-10 | 2 | -0/+8 | |
| | | ||||||
* | | Updated test to ensure correct sequence when copying engine/plugin migrations. | Brian Quinn | 2011-06-10 | 1 | -4/+11 | |
| | | ||||||
* | | Fix issue #1598 by adding a dependency to the RDoc gem. | Jacob Poulsgaard Tjoernholm | 2011-06-09 | 1 | -0/+1 | |
| | | ||||||
* | | Merge pull request #1356 from flippingbits/fix_engine_generator | José Valim | 2011-06-09 | 18 | -50/+209 | |
|\ \ | |/ |/| | Fix engine's generator | |||||
| * | Prepend bundle exec to get the correct Rake version | Stefan Sprenger | 2011-06-07 | 1 | -3/+3 | |
| | | ||||||
| * | Use RAILS_ISOLATED_ENGINE and fix namespaced generators tests | Stefan Sprenger | 2011-06-07 | 4 | -12/+3 | |
| | | ||||||
| * | Use mattr_accessor :namespace | Stefan Sprenger | 2011-06-07 | 2 | -13/+2 | |
| | | ||||||
| * | Don't create full Rails application if RAILS_ISOLATION_COMMAND equals engine | Stefan Sprenger | 2011-06-07 | 1 | -1/+1 | |
| | | ||||||
| * | Use namespace if it's a mountable engine | Stefan Sprenger | 2011-06-07 | 5 | -12/+61 | |
| | | ||||||
| * | Added regression tests | Stefan Sprenger | 2011-06-07 | 1 | -12/+5 | |
| | | ||||||
| * | Move test/engine/generators_test.rb to test/railties/generators_test.rb | Stefan Sprenger | 2011-06-07 | 1 | -1/+1 | |
| | | ||||||
| * | Add test for helper generator | Stefan Sprenger | 2011-06-07 | 1 | -3/+10 | |
| | | ||||||
| * | Clean up engine's generator test and use bundle exec for invoking generators | Stefan Sprenger | 2011-06-07 | 1 | -13/+30 | |
| | | ||||||
| * | Clean up engine generators_test code and add test for models correctly ↵ | Ryan Bigg | 2011-06-07 | 1 | -7/+19 | |
| | | | | | | | | namespaced | |||||
| * | Add beginnings of test for generators within the context of an engine | Ryan Bigg | 2011-06-07 | 1 | -0/+54 | |
| | | ||||||
| * | We moved engine commands to rails/engine/commands | Stefan Sprenger | 2011-05-27 | 1 | -5/+1 | |
| | | ||||||
| * | Add destroy to engine's commands | Stefan Sprenger | 2011-05-27 | 1 | -2/+3 | |
| | | ||||||
| * | Generate script/rails only if --full is given | Stefan Sprenger | 2011-05-27 | 3 | -5/+7 | |
| | |