Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Bring comment in line with rest of initializers | David Heinemeier Hansson | 2015-12-18 | 1 | -2/+2 | |
| | | | ||||||
* | | | Explain the concept of config initializers for backwards compatibility | David Heinemeier Hansson | 2015-12-18 | 3 | -2/+5 | |
| | | | ||||||
* | | | Fix spacing | David Heinemeier Hansson | 2015-12-18 | 1 | -1/+1 | |
| | | | ||||||
* | | | These options are not changed nearly often enough to warrant inclusion like ↵ | David Heinemeier Hansson | 2015-12-18 | 1 | -8/+0 | |
| | | | | | | | | | | | | this at a high level | |||||
* | | | Better explanation | David Heinemeier Hansson | 2015-12-18 | 1 | -2/+6 | |
| | | | ||||||
* | | | Use the rails command, not rake, for all rails commands | David Heinemeier Hansson | 2015-12-18 | 2 | -6/+6 | |
| | | | ||||||
* | | | README.md in the app is now used to describe the app itself, not Rails | David Heinemeier Hansson | 2015-12-18 | 1 | -1/+0 | |
| | | | ||||||
* | | | More sensible ordering with the more important options first | David Heinemeier Hansson | 2015-12-18 | 1 | -12/+12 | |
| | | | ||||||
* | | | List the major frameworks you can remove together | David Heinemeier Hansson | 2015-12-18 | 1 | -3/+3 | |
| | | | ||||||
* | | | fix indentation of generated controller test | yuuji.yaginuma | 2015-12-18 | 2 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` # before module Bukkits class UsersControllerTest < ActionDispatch::IntegrationTest include Engine.routes.url_helpers setup do @user = bukkits_users(:one) end ``` ``` # after module Bukkits class UsersControllerTest < ActionDispatch::IntegrationTest include Engine.routes.url_helpers setup do @user = bukkits_users(:one) end ``` | |||||
* | | | Ignore Byebug command history file | Akira Matsuda | 2015-12-18 | 1 | -0/+3 | |
| | | | | | | | | | | | | | | | This file is generated by a gem that is bundled by default in the generated Rails app, just like .sqlite3 files. Hence it might be natural to be ignored here rather than in each developer's .gitignore_global. | |||||
* | | | Use released rack | Rafael Mendonça França | 2015-12-18 | 1 | -2/+1 | |
|/ / | ||||||
* | | Merge pull request #22642 from seuros/remove-mysql-adapter | Matthew Draper | 2015-12-18 | 1 | -3/+3 | |
|\ \ | | | | | | | | | | Remove legacy mysql adapter | |||||
| * | | Remove legacy mysql adapter | Abdelkader Boudih | 2015-12-17 | 1 | -3/+3 | |
| | | | ||||||
* | | | Use release sprockets-rails | Rafael Mendonça França | 2015-12-17 | 1 | -1/+0 | |
| | | | ||||||
* | | | Merge pull request #22627 from rails/application-mailer-by-default | Rafael França | 2015-12-17 | 12 | -42/+29 | |
|\ \ \ | | | | | | | | | ApplicationMailer should be generated by default just like every other Application* parent | |||||
| * | | | ApplicationMailer should be generated by default just like every other ↵ | David Heinemeier Hansson | 2015-12-17 | 11 | -41/+28 | |
| | | | | | | | | | | | | | | | | Application* parent | |||||
| * | | | Fix warning | Rafael Mendonça França | 2015-12-17 | 1 | -1/+1 | |
| |/ / | ||||||
* / / | Use released arel | Rafael Mendonça França | 2015-12-17 | 1 | -1/+0 | |
|/ / | ||||||
* | | Generate API doc for actioncable | Arun Agrawal | 2015-12-17 | 1 | -0/+7 | |
| | | ||||||
* | | Merge pull request #22068 from y-yagi/change_default_to_markdown | Rafael França | 2015-12-17 | 7 | -9/+13 | |
|\ \ | | | | | | | README.rdoc -> README.md for newly generated plugins | |||||
| * | | README.rdoc -> README.md for newly generated plugins | yuuji.yaginuma | 2015-12-17 | 7 | -9/+13 | |
| | | | | | | | | | | | | I think Markdown is nowadays a better default. | |||||
* | | | Merge pull request #22629 from ↵ | Rafael França | 2015-12-17 | 1 | -1/+0 | |
|\ \ \ | | | | | | | | | | | | | | | | | prathamesh-sonpatki/kill-extra-line-in-manifest-js Kill extra newline at the start of generated manifest.js | |||||
| * | | | Kill extra newline at the start of generated manifest.js | Prathamesh Sonpatki | 2015-12-17 | 1 | -1/+0 | |
| | | | | ||||||
* | | | | Puma 2.15.3 actually works fine | David Heinemeier Hansson | 2015-12-17 | 1 | -1/+1 | |
| |/ / |/| | | ||||||
* | | | Deal with leading CR when its not a mountable engine | David Heinemeier Hansson | 2015-12-17 | 1 | -1/+1 | |
| | | | ||||||
* | | | Include example of allowed_request_origins | David Heinemeier Hansson | 2015-12-17 | 1 | -1/+2 | |
|/ / | ||||||
* | | Fix tests | David Heinemeier Hansson | 2015-12-17 | 1 | -2/+0 | |
| | | ||||||
* | | Don't mount the ActionCable server by default | David Heinemeier Hansson | 2015-12-17 | 2 | -2/+2 | |
| | | | | | | | | | | | | Since we require you to enable it on the client-side, let us do the same on the server-side. Then you’re not running an EventMachine unless you need to. | |||||
* | | No longer uses keep now that we have ApplicationRecord | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+0 | |
| | | ||||||
* | | Fix test | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+10 | |
| | | ||||||
* | | No need to check for puma | Rafael Mendonça França | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | Rack::Server already does it work for us if the server is installed. | |||||
* | | Fix test now that cable is in there by default too | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | ||||||
* | | Avoid Action Cable stubs on --skip-action-cable | David Heinemeier Hansson | 2015-12-16 | 3 | -3/+7 | |
| | | | | | | | | | | Still missing the stuff in app/ – we need to basically switch from a * match to specifically picking out what we need. | |||||
* | | No longer needed now that we prefill with app/models/application_record.rb | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+0 | |
| | | ||||||
* | | Generate all the ApplicationCable stubs by default, like all other ↵ | David Heinemeier Hansson | 2015-12-16 | 5 | -1/+20 | |
| | | | | | | | | Application* stubs | |||||
* | | Saner increments | David Heinemeier Hansson | 2015-12-16 | 1 | -3/+3 | |
| | | ||||||
* | | Use puma as the default development server, if available | David Heinemeier Hansson | 2015-12-16 | 2 | -4/+4 | |
| | | ||||||
* | | Eager loading is required for Action Cable and we should use the logging too | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+4 | |
| | | ||||||
* | | Only mount the ActionCable server if ApplicationCable has been defined | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | ||||||
* | | By default, mount Action Cable on the router | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+3 | |
| | | ||||||
* | | Add default redis config for Action Cable | David Heinemeier Hansson | 2015-12-16 | 2 | -0/+9 | |
| | | ||||||
* | | Merge branch 'master' into merge-action-cable | Rafael Mendonça França | 2015-12-16 | 20 | -69/+102 | |
|\ \ | ||||||
| * | | Use sprockets 3 in the Rails 5 release | Rafael Mendonça França | 2015-12-16 | 3 | -8/+7 | |
| | | | ||||||
| * | | Merge pull request #22567 from gsamokovarov/introduce-application-record | Rafael França | 2015-12-16 | 7 | -1/+29 | |
| |\ \ | | | | | | | | | Introduce ApplicationRecord, an Active Record layer supertype | |||||
| | * | | Introduce ApplicationRecord, an Active Record layer supertype | Genadi Samokovarov | 2015-12-16 | 7 | -1/+29 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's pretty common for folks to monkey patch `ActiveRecord::Base` to work around an issue or introduce extra functionality. Instead of shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can hold all those custom work the apps may need. Now, we don't wanna encourage all of the application models to inherit from `ActiveRecord::Base`, but we can encourage all the models that do, to inherit from `ApplicationRecord`. Newly generated applications have `app/models/application_record.rb` present by default. The model generators are smart enough to recognize that newly generated models have to inherit from `ApplicationRecord`, but only if it's present. | |||||
| * | | | Run railties generated app tests in test env | eileencodes | 2015-12-15 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Running railties generated app tests in development env can cause unintended consequences. The environments are different and tests aren't meant to be run in development mode. The changes to the generator exposed this issue where the random test order in the generated apps could cause problems when those tests are run in development mode. Particularly we saw failures in `railties/test/application/rake_test.rb` generated apps that used the scaffold to create applications and then run the migration and immediately run the tests. The error we saw was `ActiveRecord::RecordNotFound: Couldn't find User with 'id'=980190962` and seemed to only occur if the destroy test ran first. I'm not entirely sure _why_ this causes that error to be thrown but I believe it is related to the environments being different. | |||||
| * | | | Update test generators to use ActionDispatch::IntegrationTest | Abdelkader Boudih | 2015-12-15 | 8 | -49/+61 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Rails 5.1 `ActionController::TestCase` will be moved out of Rails into it's own gem. Please use `ActionDispatch::IntegrationTest` going forward. This changes the generators to use `ActionDispatch::IntegrationTest` and the required URL setup (rather than symbols) for each of the controller actions. Updated fix to #22076. | |||||
| * | | | Do not default to any Serializer | Santiago Pastorino | 2015-12-15 | 3 | -8/+2 | |
| |/ / | | | | | | | | | | We will wait until 5.1 to make a decision | |||||
* | | | Only include action cable meta tags if it is not skipped | Rafael Mendonça França | 2015-12-16 | 1 | -0/+2 | |
| | | |