aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
* Patch for #1458 - [3.1.0.rc1] App plugins initialized before enginesJoseph Wong2011-06-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and plugins inside engines It seems that plugins inside a Rails 3.1 application proper (i.e. in /vendor/plugins) are initialized before engines and plugins inside engines. After some debugging, I found the culprit in Rails::Application::Railties#all: def all(&block) @all ||= railties + engines + super @all.each(&block) if block @all end The call to super here implicitly passes the &block argument, which has the unfortunate side-effect of adding the plugin initializers first (in front of other railties and engines) in the case of Rails::Engine#initializers: def initializers initializers = [] railties.all { |r| initializers += r.initializers } initializers += super initializers end The solution here is to replace the super call with a call to #plugins.
* Make the API for compression consistent between JS and CSS. By default, ↵wycats2011-06-161-3/+0
| | | | | | users just need to say whether they want compression or not, and a default will be chosen by a Railtie. In the case of CSS, this default is already chosen by the sass-rails gem. Users can still explicitly choose a compressor in their application.rb if they have a preference, but will usually want to let plugins choose defaults in their Railties.
* Merge pull request #1733 from SAP-Oxygen/master-plugins_in_engine_patchJosé Valim2011-06-162-8/+10
|\ | | | | Cherry-picking patch for https://github.com/rails/rails/issues/1460 from 3-1-stable to master
| * Cherry-picking patch for https://github.com/rails/rails/issues/1460Joseph Wong2011-06-162-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from 3-1-stable to master [3.1.0.rc1] Plugins inside engines not eager-loaded properly and their rake tasks ignored Working with the new support for plugins inside engines in Rails 3.1, I found that certain things that work for regular plugins don't work for these new nested plugins. In particular, these methods in Rails::Engine don't seem to understand that an engine could have nested plugins: #load_tasks #load_generators #load_console #eager_load! A solution which worked out for me is to move the calls to railties.all { ... } from the overriding methods in Rails::Application into Rails::Engine.
* | replace dev.ror.com plugin url with a dummy oneVijay Dev2011-06-161-2/+2
| |
* | Improve the legacy wild controller route in app templatesWen-Tien Chang2011-06-161-1/+1
|/
* load_generators from engine should also handle self automatically.José Valim2011-06-151-3/+3
|
* Merge pull request #1676 from neerajdotname/make_test_name_meaningfulSantiago Pastorino2011-06-131-1/+1
|\ | | | | Remove "is_assed" with something more meaningful
| * Remove "is_assed" with something more meaningfulNeeraj Singh2011-06-131-1/+1
| |
* | namespace engine assetsRyan Bates2011-06-123-19/+37
|/
* Make i18n tests more robust.José Valim2011-06-121-3/+3
|
* Remove utf8_enforcer_param config optionDavid Lee2011-06-112-17/+0
|
* Make utf8 enforcer param customizeableDavid Lee2011-06-112-1/+18
|
* s/Bundle/Bundler/Xavier Noria2011-06-111-1/+1
|
* Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-06-116-118/+24
|\
| * update palmist link on performance_testingJohn Hinnegan2011-06-091-1/+1
| |
| * Merge branch 'master' of github.com:lifo/docrailsMohammad Typaldos2011-06-091-1/+1
| |\
| | * Describe the user name 'variable' in a way that doesn't confuse the textile ↵Ben Orenstein2011-06-081-1/+1
| | | | | | | | | | | | parser.
| * | Match tone already establishedMohammad Typaldos2011-06-091-1/+1
| |/
| * require_tree is pretty simpleMohammad Typaldos2011-06-081-2/+2
| |
| * minor corrections in configuring guideVijay Dev2011-06-081-11/+11
| |
| * remove generators section from command line guide in favor of the separate ↵Vijay Dev2011-06-081-94/+0
| | | | | | | | generator guide
| * fix generators guide urlVijay Dev2011-06-081-2/+2
| |
| * use git: rather than https: in git remote urls; else, github asks for ↵Vijay Dev2011-06-081-1/+1
| | | | | | | | passwords everytime we push
| * minor fixes from 5acf76dVijay Dev2011-06-081-2/+2
| |
| * fix incorrect validation examplesVijay Dev2011-06-081-5/+5
| |
* | shell out to run bundler on app generation, see rationale in the commentXavier Noria2011-06-101-6/+12
| |
* | make 'rails runner' show usage when run without any optionsVijay Dev2011-06-102-0/+8
| |
* | Updated test to ensure correct sequence when copying engine/plugin migrations.Brian Quinn2011-06-101-4/+11
| |
* | Fix issue #1598 by adding a dependency to the RDoc gem.Jacob Poulsgaard Tjoernholm2011-06-091-0/+1
| |
* | Merge pull request #1356 from flippingbits/fix_engine_generatorJosé Valim2011-06-0918-50/+209
|\ \ | |/ |/| Fix engine's generator
| * Prepend bundle exec to get the correct Rake versionStefan Sprenger2011-06-071-3/+3
| |
| * Use RAILS_ISOLATED_ENGINE and fix namespaced generators testsStefan Sprenger2011-06-074-12/+3
| |
| * Use mattr_accessor :namespaceStefan Sprenger2011-06-072-13/+2
| |
| * Don't create full Rails application if RAILS_ISOLATION_COMMAND equals engineStefan Sprenger2011-06-071-1/+1
| |
| * Use namespace if it's a mountable engineStefan Sprenger2011-06-075-12/+61
| |
| * Added regression testsStefan Sprenger2011-06-071-12/+5
| |
| * Move test/engine/generators_test.rb to test/railties/generators_test.rbStefan Sprenger2011-06-071-1/+1
| |
| * Add test for helper generatorStefan Sprenger2011-06-071-3/+10
| |
| * Clean up engine's generator test and use bundle exec for invoking generatorsStefan Sprenger2011-06-071-13/+30
| |
| * Clean up engine generators_test code and add test for models correctly ↵Ryan Bigg2011-06-071-7/+19
| | | | | | | | namespaced
| * Add beginnings of test for generators within the context of an engineRyan Bigg2011-06-071-0/+54
| |
| * We moved engine commands to rails/engine/commandsStefan Sprenger2011-05-271-5/+1
| |
| * Add destroy to engine's commandsStefan Sprenger2011-05-271-2/+3
| |
| * Generate script/rails only if --full is givenStefan Sprenger2011-05-273-5/+7
| |
| * Refactor identifying generator's destination rootStefan Sprenger2011-05-271-5/+2
| |
| * Fix appending 'Stefan Sprenger2011-05-271-1/+1
| |
| * We're using module not class for namespacingStefan Sprenger2011-05-271-8/+8
| |
| * Move requiring engine out of the switch caseStefan Sprenger2011-05-271-4/+3
| |
| * Fix and test ENGINE_PATH and ENGINE_ROOTStefan Sprenger2011-05-272-2/+10
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-31 20:17:30 +0000