| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| | |
Correctly generate application_mailer.rb in mountable engines
|
| |
| |
| |
| | |
- Followup of https://github.com/rails/rails/pull/24161.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When generating a plugin without ActiveRecord (-O),
ActionCable wasn't include, which causes problems with the
require action_cable statement in cable.js
add active_job require statement
also updated order of require statements to match with all.rb
|
| |
| |
| |
| |
| | |
Didn't feel we were clear enough about our motivation for placing Rails first
and why we needed to call `load_plugins`.
|
| |
| |
| |
| | |
The useless explicit self calls were driving me nuts.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When calling `load_plugins` minitest would fill out its extensions, then
we'd tackle ourselves on as the last plugin. Because minitest loads plugins
in order we will ultimately have the last say on what reporters will be used.
Invert that strategy by putting ourselves first and give other plugins plenty
of leeway to override our default reporter setup.
Fixes #24179.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
[ci skip]
This updates the 5.0 release notes guide to reflect changes that
happened after beta1 has been released.
I'll sync the other changelogs later today but I'll push this batch to
prevent against cumbersome merge conflicts.
|
| |
| |
| |
| |
| |
| | |
In https://github.com/rails/rails/commit/dfa48f200cbc5c1ca18457a8cde14642e12af5,
a call to `#sum` was added. For that to always work, we need to require the
core_ext/enumerable module.
|
|\ \
| | |
| | | |
changed default value of `caching` option to `nil`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The default is that's false, caching even if you do not specify the caching option is determined not to use,
and `tmp/caching-dev.txt` will be deleted.
If it is this, regardless of whether or not there is `tmp/caching-dev.txt`, be sure to order would be necessary to specify the caching option,
I think that in than good to so as not to do anything by default.
|
|\ \ \
| | | |
| | | |
| | | | |
Comment out config.file_watcher during Rails upgrade process
|
| | | |
| | | |
| | | |
| | | | |
[related #24243]
|
| |/ / |
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Due to that `ActionDispatch::Flash` (the flash API's middleware) is not
included for API controllers, the `request.reset_session` method, which
relies on there being a `flash=` method which is in fact defined by the
middleware, was previously breaking. Similarly to how
add46482a540b33184f3011c5c307f4b8e90c9cc created a method to be
overridden by the flash middleware in order to ensure non-breakage, this
is how flashes are now reset.
Fixes #24222
|
| |
| |
| |
| |
| |
| | |
The logger interface to get all Rails features is not obvious. This change adds documentation on how to assign a logger that will use all Rails features.
We are also matching the stdout logging interface to the default logger in bootstrap https://github.com/rails/rails/blob/f5a5988352b165143f0f9d622707c351c1470882/railties/lib/rails/application/bootstrap.rb#L42-L45.
|
|/
|
|
|
| |
Lets have the server and the Rake task go through the same ropes, so we can
share all the file lookup, adding, and deleting code.
|
| |
|
|
|
|
|
|
|
| |
If we're gonna do this right, it will look mighty different from this anyway.
(Looking at you, Rails 5.1).
It isn't being used in any code as of now, so yanking is the best option.
|
|
|
|
| |
References https://github.com/rails/homepage/issues/46.
|
| |
|
|\
| |
| | |
Remove passing `with_dispatchers` to AppGenerator
|
| |
| |
| |
| |
| |
| |
| | |
- While working on https://github.com/rails/rails/pull/22790 I found out
that we pass `with_dispatchers: true` but it's not used at all by Rails.
- We were passing `with_dispatchers: true` in few tests too but again
it's not used by Rails.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit comes from the comments made by @matthewd at https://github.com/rails/rails/pull/23795/files#r54469637
and by @rafaelfranca at https://github.com/rails/rails/pull/23795/files#r54609364
The idea is that if you type (for example) "rake db:migrate" in an AppGenerator,
then this should actually invoke `rake db:migrate` on the command line, whereas
if you type "rails_command db:migrate", this should invoke `rails db:migrate`.
|
|\ \
| | |
| | | |
Remove redundant regexp escapes in generators
|
| | | |
|
|\ \ \
| | | |
| | | | |
Advertise the console web-console feature
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In the latest version of Web Console, you can call `console` anywhere in
your application and get a console with that binding in it. I think this
is worth advertising, as it may be useful to do outside of controllers
and views.
[ci skip]
|
|/ / / |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Between major versions 2 and 3, we hit a bug. It's fixed in version 3,
however, the explicit 2.x requirement of `~> '2.0'` will prevent people
from getting the fix with `bundle update` and they would have to
explicitly set the constraint to `~> '3.0'`.
For more information see: rails/web-console#178.
I propose we drop the explicit version constraints in the Gemfile. Web
Console has been relatively stable for the past couple of years, and I
don't anticipate any major alterations, like we saw between major
versions 1 and 2.
|
|\ \
| | |
| | | |
Fixed semantics of couple of tests in the configuration_test.rb [ci skip]
|
| |/ |
|
|\ \
| | |
| | | |
i18n fallbacks test fixes
|
| | |
| | |
| | |
| | |
| | |
| | | |
using map
- Fixed test name for setting fallbacks to config.i18n.fallbacks = [{ :ca => :'es-ES' }]
|
| | |
| | |
| | |
| | | |
Reads much better doesn't it.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Stuff I see in passing while I am doing a walkthrough.
See rationale in 5b8738c.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Stuff I see in passing while I am doing a walkthrough.
See rationale in 5b8738c.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Stuff I see in passing while I am doing a walkthrough.
See rationale in 5b8738c.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Stuff I see in passing while I am doing a walkthrough.
See rationale in 5b8738c.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
y-yagi/remove_unnecessary_config_in_sprockets-rails-3
remove config that are no longer needed in sprockets-rails 3
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`config.assets.raise_runtime_errors` and `config.assets.digest` are enabled
by default in sprockets-rails 3.
|
|/ / /
| | |
| | |
| | |
| | | |
Defining paths relative to a file name has always hurt my soul,
with __dir__ we can restore order in the Universe.
|
| | |
| | |
| | |
| | | |
Follow up to #24050.
|
|\ \ \
| | | |
| | | | |
using rails dev:cache instead of rake dev:cache in test case
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] correcting test case specifying `rails routes` instead of `rake routes`
|
| | | | | |
|