aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | Updated links from http to https in guides, docs, etcAbhay Nikam2019-03-092-2/+2
| | | | | |
* | | | | | [ci skip] Minor documentation fixes for consistencyShailesh Kalamkar2019-03-091-1/+1
| | | | | |
* | | | | | Don't lock the webpacker gem by its patch versionSharang Dashputre2019-03-091-1/+1
| | | | | |
* | | | | | Fix "DEPRECATION WARNING: ActionView::Template#initialize requires a locals ↵yuuji.yaginuma2019-03-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | parameter" Ref: #35411
* | | | | | Merge pull request #35538 from sharang-d/use-latest-webpackerGuillermo Iguaran2019-03-081-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use the latest stable release of webpacker
| * | | | | | Use the latest stable release of webpackerSharang Dashputre2019-03-091-1/+1
| |/ / / / /
* | | | | | Minor text changes to the db:seed:replant testsSharang Dashputre2019-03-091-2/+2
| | | | | |
* | | | | | moves a require to the file that needs itXavier Noria2019-03-082-1/+2
| | | | | |
* | | | | | Allow autoloader inflectors to be swaped outJean Boussier2019-03-083-2/+13
|/ / / / /
* | | | | Merge pull request #35522 from gmcgibbon/rails_db_system_change_versioningKasper Timm Hansen2019-03-082-5/+30
|\ \ \ \ \ | | | | | | | | | | | | Add version awareness to rails db:system:change
| * | | | | Add version awareness to rails db:system:changeGannon McGibbon2019-03-082-5/+30
| | | | | |
* | | | | | Build assets automatically if necessaryyuuji.yaginuma2019-03-081-0/+7
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | In CI, these are unnecessary because done by preprocessing. To test locally, you need to do it manually. If assets not exist, it will fail when a run specific test, so force to build those only when necessary.
* | | | | Load YAML for rake tasks without parsing ERBeileencodes2019-03-063-12/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds a new method that loads the YAML for the database config without parsing the ERB. This may seem odd but bear with me: When we added the ability to have rake tasks for multiple databases we started looping through the configurations to collect the namespaces so we could do `rake db:create:my_second_db`. See #32274. This caused a problem where if you had `Rails.config.max_threads` set in your database.yml it will blow up because the environment that defines `max_threads` isn't loaded during `rake -T`. See #35468. We tried to fix this by adding the ability to just load the YAML and ignore ERB all together but that caused a bug in GitHub's YAML loading where if you used multi-line ERB the YAML was invalid. That led us to reverting some changes in #33748. After trying to resolve this a bunch of ways `@tenderlove` came up with replacing the ERB values so that we don't need to load the environment but we also can load the YAML. This change adds a DummyCompiler for ERB that will replace all the values so we can load the database yaml and create the rake tasks. Nothing else uses this method so it's "safe". DO NOT use this method in your application. Fixes #35468
* | | | | Allow `truncate` for SQLite3 adapter and add `rails db:seed:replant` (#34779)Bogdan2019-03-041-1/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add `ActiveRecord::Base.connection.truncate` for SQLite3 adapter. SQLite doesn't support `TRUNCATE TABLE`, but SQLite3 adapter can support `ActiveRecord::Base.connection.truncate` by using `DELETE FROM`. `DELETE` without `WHERE` uses "The Truncate Optimization", see https://www.sqlite.org/lang_delete.html. * Add `rails db:seed:replant` that truncates database tables and loads the seeds Closes #34765
* | | | | Correctly escape ERB tagyuuji.yaginuma2019-03-041-1/+1
| | | | | | | | | | | | | | | | | | | | Ref: https://travis-ci.org/rails/rails/jobs/501220262#L1194
* | | | | Add an example about how to load images under app/javascript/imagesGuillermo Iguaran2019-03-031-0/+8
| |_|_|/ |/| | | | | | | Similarly to https://github.com/rails/webpacker/pull/1976
* | | | Preparing for 6.0.0.beta2 releaseRafael Mendonça França2019-02-252-1/+3
| | | |
* | | | Depend on bootsnap 1.4.1Rafael Mendonça França2019-02-251-1/+1
| | | | | | | | | | | | | | | | This is needed to fix #35278.
* | | | Make this test strongerXavier Noria2019-02-231-0/+7
| | | | | | | | | | | | | | | | | | | | We test the inflections for both autoloaders, but we can also autoload the constant as a sort of integration test.
* | | | Let Zeitwerk autoloaders inflect with Active SupportXavier Noria2019-02-231-0/+18
| | | | | | | | | | | | | | | | [Harry Brundage & Xavier Noria]
* | | | simplifies Rails.autoloaders.logger=Xavier Noria2019-02-212-4/+3
| | | | | | | | | | | | | | | | Possible thanks to Zeitwerk 1.3.0.
* | | | simplify AS::Dependencies.verbose=Xavier Noria2019-02-211-4/+4
| | | | | | | | | | | | | | | | Possible thanks to Zeitwerk 1.3.0.
* | | | Define Rails.autoloaders.logger=Xavier Noria2019-02-212-0/+28
| | | |
* | | | Explains a detail re eager loading [ci skip]Xavier Noria2019-02-201-0/+3
| | | |
* | | | let Zeitwerk integration unhook AS::DependenciesXavier Noria2019-02-195-2/+35
| | | |
* | | | Auto correct rubocop offensesYoshiyuki Hirano2019-02-171-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Offenses: railties/lib/rails/autoloaders.rb:1:1: C: [Corrected] Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Rails ^ actionmailer/test/base_test.rb:917:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. actionmailer/test/base_test.rb:917:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. actionmailer/test/base_test.rb:917:5: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ actionmailer/test/base_test.rb:918:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. events = [] ^^^^ actionmailer/test/base_test.rb:930:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end. actionmailer/test/base_test.rb:930:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
* | | | Implement AS::Dependencies.verbose= compatibility for :zeitwerk modeXavier Noria2019-02-151-0/+36
| | | |
* | | | Replace autoloader accessors with Rails.autoloaders.{main,once}Xavier Noria2019-02-145-41/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails.autoloader and Rails.once_autoloader was just tentative API good enough for a first patch. Rails.autoloader is singular and does not convey in its name that there is another autoloader. That might be confusing, for example if you set a logger and miss traces. On the other hand, the name `once_autoloader` is very close to being horrible. Rails.autoloaders.main and Rails.autoloaders.once read better for my taste, and have a nice symmetry. Also, both "main" and "once" are four letters long, short and same length. They are tagged as "rails.main" and "rails.once", respectively. References #35235.
* | | | Merge pull request #35249 from Edouard-chin/ec-config-for-hash-in-arrauRafael Mendonça França2019-02-142-4/+40
|\ \ \ \ | | | | | | | | | | | | | | | Fix the `config_for` to always return a NonSymbolAccessDeprecatedHash:
| * | | | Fix the `config_for` to always return a NonSymbolAccessDeprecatedHash:Edouard CHIN2019-02-143-4/+45
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - If you have hashes inside array, the hashes were getting initialized as regular HWIA wereas we want them to be NonSymbolAccessDeprecatedHash in order to trigger a deprecation warning when keys are accessed with string. This patch fixes that by overwriting the `[]=` to to the same as what HWIA does (with the difference that we don't call `convert_key` to not trigger a deprecation when setting value). I also took the liberty to extract `hash.nested_under_indifferent_access`, into a separate method to allow subclasses to return whatever they want. Inheriting HWIA is not common, but I think it's useful for cases like this one where we want to preprocess reading and writing values in the hash (for deprecation purposes or other reasons).
* / / / Let Zeitwerk be a dependency of Active SupportXavier Noria2019-02-134-18/+7
|/ / / | | | | | | | | | | | | Zeitwerk is a strong dependency, planned to replace AS::Dependencies. A line in the generated Gemfile does not convey this as much.
* | | styleXavier Noria2019-02-121-3/+3
| | |
* | | Zeitwerk integrationXavier Noria2019-02-1213-51/+289
| | |
* | | Add missing packages (#35227)Yuji Yaginuma2019-02-121-0/+2
| | | | | | | | | | | | If generate application without specified options,`actioncable` and `activestorage` loads by default.
* | | Merge pull request #35198 from paracycle/uk-change-config-for-behaviourGannon McGibbon2019-02-113-9/+149
|\ \ \ | | | | | | | | Allow deprecated non-symbol access to nested `config_for` hashes
| * | | Fix assertion excpected/actual orderUfuk Kayserilioglu2019-02-111-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The assertion from the previous PR had the expected and the actual values in the wrong order, so when a test failed the error message was confusing. This commit fixes the problem by switching the order.
| * | | Allow deprecated non-symbol access to nested `config_for` hashesUfuk Kayserilioglu2019-02-113-3/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A change to `Rails::Application.config_for` in https://github.com/rails/rails/pull/33815 and https://github.com/rails/rails/pull/33882 has altered the behaviour of the returned object in a breaking manner. Before that change, nested hashes returned from `config_for` could be accessed using non-symbol keys. After the change, all keys are recursively symbolized so non-symbol access fails to read the expected values. This is a breaking change for any app that might be relying on the nested hashes returned from `config_for` calls, and thus should be deprecated before being removed from the codebase. This commit introduces a temporary `NonSymbolAccessDeprecatedHash` class that recursively wraps any nested hashes inside the `OrderedOptions` object returned from `config_for` and issues a deprecation notice when a non-symbol based access is performed. This way, apps that are still relying on the ability to access these nested hashes using non-symbol keys will be able to observe the deprecation notices and have time to implement changes before non-symbol access is removed for good. A CHANGELOG entry is also added to note that non-symbol access to nested `config_for` hashes is deprecated.
* | | | Optimized namespaces_to_paths method.alkesh262019-02-111-2/+3
|/ / /
* | | Merge pull request #35184 from y-yagi/avoid_extra_package_installMatthew Draper2019-02-118-12/+35
|\ \ \ | | | | | | | | Avoid extra package install
| * | | Install JavaScript packages before run testyuuji.yaginuma2019-02-118-12/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some tests are running yarn install during the test. The directory used for isolation test is not subject to yarn workspace, and it occurs because the required package is not installed. In order to avoid this, I fixed all necessary packages to be installed before run test and use symlink to `node_modules`. This is a bit complicated, as `yarn install` needs to be run in a specific directory before running the test. However, running `yarn install` every time run the test is expensive when testing locally and should be avoided.
* | | | Revert "Merge pull request #35211 from y-yagi/fix_broken_association_test" ↵Yuji Yaginuma2019-02-111-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#35217) This reverts commit 38f9e41f2c4b64377ffb036c53873dbfb51546cf, reversing changes made to 5e493c3b839f10d639f5cce1f1b9ff9292702821. Reason: The ajv@6.9.1 was released that fixes issue.
* | | | Avoid ajv@6.9.0 for nowyuuji.yaginuma2019-02-101-0/+16
| | | | | | | | | | | | | | | | | | | | Because ajv@6.9.0 does not work with webpack. Ref: https://github.com/epoberezkin/ajv/issues/941
* | | | Fix rubocop violationsyuuji.yaginuma2019-02-091-9/+7
| | | |
* | | | Rename database_operations config to *_contextJohn Hawthorn2019-02-071-4/+5
| | | |
* | | | Merge pull request #35036 from rails/av-base-subclassAaron Patterson2019-02-062-5/+6
|\ \ \ \ | |/ / / |/| | | Move compiled ERB to an AV::Base subclass
| * | | Deprecate finalizer configuration (it doesn't do anything)Aaron Patterson2019-02-061-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | Revert "Remove finalizer and configuration" This reverts commit 9e7b4a3173788ea43b11e74a4d2f69a5f1565daa.
| * | | Remove finalizer and configurationAaron Patterson2019-02-062-20/+0
| | | |
* | | | Preload all component gemsyuuji.yaginuma2019-02-061-0/+2
| | | | | | | | | | | | | | | | To avoid running require individually.
* | | | Restrict frameworks to load in engine testyuuji.yaginuma2019-02-061-4/+22
|/ / / | | | | | | | | | | | | For avoid to affect tests. Also, `action_text:install` task execute `yarn add`. This is an expensive and should be avoided if it is not needed.
* | | Set sqlite3 gem version explicitly in generated GemfileSergey Ponomarev2019-02-052-1/+2
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-20 00:19:32 +0000