| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Here `app` needed to be `get` because we're getting a route. This fixes
the typo so the test passes.
|
|
|
|
|
|
| |
Vaguely related to #21605 where I proposed to remove index route since it was redirecting to the 'routes' action,
but this was kept so I thought it made sense to add some tests regarding this.
|
| |
|
| |
|
| |
|
|
|
|
| |
Accessing mime types via constants is deprecated.
|
| |
|
| |
|
|
|
|
|
|
|
| |
generator
This is follow up to #6643.
In #6643, the controller generator only had been fixed, in this commit to fix the scaffold generator.
|
|
|
|
|
| |
This can still be added to the middleware stack, but is really not
necessary. I'll follow up with a commit that deprecates the constant
|
| |
|
|
|
|
|
| |
When config `action_mailer.show_previews` is set, previews are displayed
regardless of local request check.
|
| |
|
|\
| |
| | |
Updated MySQL documentation link to MySQL latest version 5.7 everywhe…
|
| |
| |
| |
| |
| | |
skip]
Bumps from `5.6` to `5.7`
|
|/ |
|
| |
|
|\
| |
| | |
raise LoadError when a non-existent file or directory is specified to the test runner
|
| |
| |
| |
| |
| |
| |
| |
| | |
test runner sets file to be tested in plugin_rails_options,
but in plugin_rails_options, processing has been made to the argument of the
actual command rather than the argument of Minitest.run.
For example, if you run `./bin rake db:migrate test`, the options[:patterns], `db:migrate test` was incorrectly set.
|
| |
| |
| |
| |
| |
| |
| |
| | |
test runner
Currently, if a file or directory that does not exist was specified in the test runner,
that argument is ignored.
This commit has been modified to cause an error if there is no file or directory.
|
|/ |
|
| |
|
| |
|
| |
|
|\
| |
| | |
remove require of files under support that do not use
|
| |
| |
| |
| |
| |
| | |
I do not know why files under the support has been require.
However, under the support even rails application does not use.
In addition, since the default under the support file nor is generated, it requires I think not necessary
|
|/
|
|
| |
method_call_assertions
|
| |
|
|
|
|
|
| |
Just like the other places. We need to refactor this because the code
is almost identical to that in the action pack tests
|
|\
| |
| | |
Use the PORT environment variable for rails server
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Cleaned up generators tests using internal assertion helper
|
| |/ |
|
|/ |
|
| |
|
| |
|
|
|
|
|
|
| |
The semantic versioning specification uses MAJOR.MINOR.PATCH – it would
make more sense to set the version to 0.1.0 for initial development
since a patch release cannot be created before a minor feature release.
|
|
|
|
| |
[Kir Shatrov & Robin Dupret]
|
|
|
|
|
|
| |
* Add missing `def` and remove useless `do` keywords.
* Move `:nodoc:` in front of the methods' definition so that methods
under these ones are correctly visible on the API.
|
|\
| |
| | |
Replace the giant comment in routes.rb with a link to the guides
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This comment not only serves no purpose, but in my experience is
actively detrimental to new developers getting started with Rails.
Expereinced developers just end up deleting this comment, and are
annoyed that they had to take this step. I also spend a lot of time
mentoring brand new developers, and a consistent theme I've seen is that
this comment just ends up intimidating them, and making them think it's
dangerous to edit this file.
One of my students just said this (due to the number of comments which
even new developers don't actually read, they just see it as a sign that
this thing is "dangerous").
> I don't edit any file that Rails generates for me, until my instructor
> says that it's OK to do so.
Realistically, this comment adds 0 value. We have very good
documentation, which we can just link to instead. If someone is truly
new enough to benefit from this info, they presumably just ran `gem
install rails`, and have an internet connection that they can use to
read the routing guide.
The choice of language here was very specific. I chose "the DSL
available" over "what is possible", because a consistent theme I've
noticed among my students is that they aren't aware that this is
actually a Ruby file, and can write any Ruby code here that they want.
This file is not the only offender, but is by far the biggest point of
pain that I've seen, and felt it was a good spot to open this
discussion.
|
|\ \
| | |
| | | |
Reload I18n.load_path in development
|
| | | |
|
|\ \ \
| | | |
| | | | |
make generated scaffold functional tests work inside API engines
|
| | | |
| | | |
| | | |
| | | |
| | | | |
* set engine's route in setup
* use fixture with engine namespace
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Using the string version of the class reference is now deprecated when
referencing middleware. This should be written as a class not as a string.
Deprecation warning that this change fixes:
```
DEPRECATION WARNING: Passing strings or symbols to the middleware
builder is deprecated, please change
them to actual class references. For example:
"ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions
```
|