| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
If the specified `skip_action_cable` option, so as not to output the
`action_cable_meta_tag` in template, gsub is unnecessary.
ref: https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt#L6..L8
|
|\
| |
| | |
Add an after_bundle callback in Rails plugin templates
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| |/
|/| |
Remove empty lines in Rails development logger
|
| |
| |
| |
| |
| |
| | |
This is causing bugs like #23215 to occur, due to the extra spaces being
inserted. Also, this is fixed upstream in the upcoming release of
Sprockets 4.
|
|\ \
| | |
| | | |
Introduce new welcome page for new projects
|
| | |
| | |
| | |
| | | |
As requested by David in 23233.
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since #23152 eliminated the EventMachine dependency, we don’t need to
explicitly mention EventMachine.
Nevertheless, I'm not 100% sure about saying "the websocket-driver loop"
driver… any suggestions, @matthewd or @pixeltrix ? :sweat_smile:
[ci skip]
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* 5-0-beta-sec:
bumping version
fix version update task to deal with .beta1.1
Eliminate instance level writers for class accessors
allow :file to be outside rails root, but anything else must be inside the rails view directory
Don't short-circuit reject_if proc
stop caching mime types globally
use secure string comparisons for basic auth username / password
|
| | | |
|
|\ \ \
| | | |
| | | | |
Be consistent in testing outputs from railties test and use /bin/rails
|
| | |/
| |/|
| | |
| | |
| | |
| | | |
everywhere(the default behaviour now) instead of mix of /bin/rake /bin/rails everywhere
[Ryo Hashimoto & Vipul A M]
|
|\ \ \
| | | |
| | | | |
Eliminate the EventMachine dependency
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We're no longer doing our work in the EM event loop, so errors are quite
unlikely, and if they do occur, they're not really our responsibility to
handle.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Using `references` or `belongs_to` in migrations will always add index
for the referenced column by default, without adding `index:true` option
to generated migration file.
- Users can opt out of this by passing `index: false`.
- Legacy migrations won't be affected by this change. They will continue
to run as they were before.
- Fixes #18146
|
|/ /
| |
| |
| |
| |
| | |
as argument
- Fixes #23137.
|
| | |
|
| |
| |
| |
| |
| | |
Because the form is not in the Rails API,
`per_form_csrf_tokens` initializer I think unnecessary.
|
|\ \
| | |
| | | |
Remove action_cable_meta_tag when skip Action Cable
|
| | | |
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
y-yagi/add_application_mailer_rb_to_mountable_engine
add application_mailer.rb to template of mountable engine
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
since 9446e38ba47c9ca3be2ad668d8a8bea0141be6fc, generated mailer inherents from ApplicationMailer,
ApplicationMailer is required in the mountable engine.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Adapterize storage for ActionCable
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Forgot to remove it, when I changed the expectations in 88881d2.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If running `bin/rails t test/models/bunny_test.rb:` we'd implicitly run all the
tests in the bunny test. I now highly doubt that people would ever put in a line
filter without a line *and* want that to mean run all tests in that file.
Instead, change regex to require a line digit after the colon, so runs without a
line at the end would fail to require the test file.
This also has the side benefit of breaking requiring a file with many colons:
`bin/rails t test/models/bunny_test.rb:::::::::::::4`
Think this means I've had enough colonoscopy to last me through the year :)
|
|\ \ \ \
| |/ / /
|/| | | |
CodeStatistic will now ignore hidden files:
|
| | | |
| | | |
| | | |
| | | | |
- Modify the default regex to not match hidden files
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix bug (#22811) that occurs when rails server is started in daemon mode
and optional path to the `server.pid` file is omitted. Store default path
in a constant instead of evaluating it multiple time using `File.expand_path`.
The bug in detail: The server startup procedure crashes, since it tries to
open a file at `/tmp/pids/server.pid` instead of
`<path to project>/tmp/pids/server.pid`. This bug was introduced in 51211a94bd
when Rack was upgraded from version 1.x to 2.x. Since version 2.x,
Rack does not memoize the options hash [1], and as a consequence
`Rails::Server#default_options` will be evaluated multiple times.
The hash returned by `Rails::Server#default_options` holds the default path
to the `server.pid` file. The path is generated with the method
`File.expand_path`. However, the return value of this method depends on the
current working directory [2], which changes once `Process.daemon` is invoked
by `Rack::Server#daemonize_app` and the process is detached from the current
shell.
Close #22811
[1]https://git.io/vzen2
[2]http://ruby-doc.org/core-2.1.5/File.html#method-c-expand_path
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
Improve generated config initializer files
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Fix grammar.
- Improve readability/understanding.
- Wrap lines at 80 characters.
[skip ci]
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
Closes #23027.
This does not restore complete backwards compatibility. It simply passes
the contets of the `TEST` env to the new runner.
|
|\ \ \
| | | |
| | | | |
remove warnings from rake test
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This removes the following warnings.
```
test/application/rake_test.rb:33: warning: ambiguous first argument; put parentheses or a space even after `/' operator
test/application/rake_test.rb:43: warning: ambiguous first argument; put parentheses or a space even after `/' operator
```
|
|\ \ \
| |/ /
|/| | |
delete only unnecessary reporter
|
| | |
| | |
| | |
| | |
| | | |
Reporter that defines its own users at the time of this process are also loaded,
to avoid them from being deleted, to delete only the specified to unnecessary reporter.
|
| | | |
|
|\ \ \
| | | |
| | | | |
rake log:clear task updated
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Avoided truncating all files if no ENV['LOGS'] specified
- Updated task to accept LOGS=all for truncating all files from log/ i.e. log/*log
- If no LOGS specified will truncates standard environment log files i.e. 'development,test,production'
- CHANGELOG & guide update added
- bin/setup test cases fixed
|
| | | |
| | | |
| | | |
| | | |
| | | | |
It might be tough for readers to know why we implement `===`, and where
the Regexp in `derive_regexp` came from.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The line filter parsing added to ActiveSupport::TestCase is only half the story
to enable line filtering. The other half, of adding the patterns to the options,
is done in the Minitest plugin that Railties has.
Thus it makes more sense to have the filter in Railties with the other half and
all the line filtering tests.
Move the filter and extend Active Support in an initializer, so that when users
or `rails/all.rb` require `rails/test_unit/railtie` we can still filter by line.
|