aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
* Replace the giant comment in routes.rb with a link to the guidesSean Griffin2015-07-241-54/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This comment not only serves no purpose, but in my experience is actively detrimental to new developers getting started with Rails. Expereinced developers just end up deleting this comment, and are annoyed that they had to take this step. I also spend a lot of time mentoring brand new developers, and a consistent theme I've seen is that this comment just ends up intimidating them, and making them think it's dangerous to edit this file. One of my students just said this (due to the number of comments which even new developers don't actually read, they just see it as a sign that this thing is "dangerous"). > I don't edit any file that Rails generates for me, until my instructor > says that it's OK to do so. Realistically, this comment adds 0 value. We have very good documentation, which we can just link to instead. If someone is truly new enough to benefit from this info, they presumably just ran `gem install rails`, and have an internet connection that they can use to read the routing guide. The choice of language here was very specific. I chose "the DSL available" over "what is possible", because a consistent theme I've noticed among my students is that they aren't aware that this is actually a Ruby file, and can write any Ruby code here that they want. This file is not the only offender, but is by far the biggest point of pain that I've seen, and felt it was a good spot to open this discussion.
* Merge pull request #20928 from matthewd/unload-interlockMatthew Draper2015-07-241-1/+1
|\ | | | | We need stricter locking before we can unload
| * We need stricter locking before we can unloadMatthew Draper2015-07-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Specifically, the "loose upgrades" behaviour that allows us to obtain an exclusive right to load things while other requests are in progress (but waiting on the exclusive lock for themselves) prevents us from treating load & unload interchangeably: new things appearing is fine, but they do *not* expect previously-present constants to vanish. We can still use loose upgrades for unloading -- once someone has decided to unload, they don't really care if someone else gets there first -- it just needs to be tracked separately.
* | Merge pull request #20926 from rsanheim/fail-fast-bin-setupRafael Mendonça França2015-07-211-5/+9
|\ \ | | | | | | add system! to fail fast in bin/setup
| * | add system! to fail fast in bin/setupRob Sanheim2015-07-181-5/+9
| |/
* | Merge pull request #20819 from y-yagi/rails_api_gemfileRafael Mendonça França2015-07-212-1/+4
|\ \ | | | | | | remove `web-console` from API app generated Gemfile
| * | remove `web-console` from API app generated Gemfileyuuji.yaginuma2015-07-092-1/+4
| | |
* | | titleizing the New LinkThiago Pinto2015-07-201-1/+1
| | |
* | | Merge pull request #20384 from kaspth/per-request-cacheDavid Heinemeier Hansson2015-07-201-0/+63
|\ \ \ | |_|/ |/| | Use digest cache in development.
| * | Make digest cache work in development.Kasper Timm Hansen2015-07-181-0/+63
| | | | | | | | | | | | | | | | | | Avoid computing the same fragment digest many times when looping over templates. The cache is cleared on every request so template changes are still picked up.
* | | [skip ci] Lookup can be a noun but it is not a verbJon Atack2015-07-171-3/+3
| | | | | | | | | | | | Various grammar corrections and wrap to 80 characters.
* | | make test runner work correctly inside engineyuuji.yaginuma2015-07-124-7/+13
| | |
* | | remove Rack::Lock for webrickAaron Patterson2015-07-101-11/+1
|/ / | | | | | | constant loading should be thread safe now, so lets remove this
* | Rely on the load interlock for non-caching reloads, tooMatthew Draper2015-07-093-24/+18
| |
* | Soften the lock requirements when eager_load is disabledMatthew Draper2015-07-092-13/+50
|/ | | | | We don't need to fully disable concurrent requests: just ensure that loads are performed in isolation.
* Merge pull request #20767 from y-yagi/remove_unnecessary_fixture_methodYves Senn2015-07-061-4/+0
|\ | | | | remove unnecessary loading fixtures from `navigation_test.rb`
| * remove unnecessary loading fixtures from `navigation_test.rb`yuuji.yaginuma2015-07-031-4/+0
| | | | | | | | | | it has been corrected in 0176aef1ebaa9f69001c7045a51727a8ea9b61b8 as for loading of fixtures in `test_helper.rb`, loading fixtures for each test is unnecessary.
* | Display a more human readable list of reserved namesRobin Dupret2015-07-014-4/+8
|/ | | | | Interpolating an array inside a String will call #inspect on it. Let's call #join to display a more human-readable error message.
* Avoid crashing when minitest-rails is loaded.Victor Costan2015-07-011-3/+3
| | | | | | | | The improvments to the test runner's integration with minitest in commit b6fc8e25a10cc4abdd03018798b180270d6c5d7f add methods to the Minitest module that refer to the Rails module. Unfortunately, when the minitest-rails gem is loaded, the reference is incorrectly resolved to the Minitest::Rails module.
* `dump_schema_after_migration` applies migration tasks other than db:migrateYves Senn2015-06-301-6/+8
| | | | | | | | | | | | | Closes #20743. The task `db:_dump` now only dumps the schema if `ActiveRecord::Base.dump_schema_after_migration` is true. This has effects: - `db:migrate:up` - `db:migrate:down` - `db:forward` - `db:rollback`
* tests, railties tests should use `bin/` executables when possible.Yves Senn2015-06-309-121/+121
| | | | | We recommend using the `bin/` executables in our docs and guides. Let's make sure that our tests execute the same code path.
* Merge pull request #20724 from y-yagi/fix_scaffold_in_full_engineYves Senn2015-06-297-3/+36
|\ | | | | | | fix NoMethodError that occurs when generating scaffold inside full mode engine
| * fix NoMethodError that occurs when generating scaffold inside full mode engineyuuji.yaginuma2015-06-287-3/+36
| |
* | Merge pull request #20712 from nhodges/dev/nh/20345Rafael Mendonça França2015-06-271-2/+1
|\ \ | |/ |/| Remove `config` options from `default_options` in `railties`
| * Remove `config` options from `default_options` in `railties`Nuri Hodges2015-06-261-2/+1
| | | | | | | | Fixes #20345.
* | Merge pull request #20714 from y-yagi/fix_file_fixture_pathRafael Mendonça França2015-06-271-1/+1
|\ \ | |/ |/| correct `file_fixture_path` in plugins `test_helper.rb`
| * correct `file_fixture_path` in plugins `test_helper.rb`yuuji.yaginuma2015-06-271-1/+1
| | | | | | | | `fixture_path` does not end with a slash
* | cherry-pick test and source doc from #20050Hirofumi Wakasugi2015-06-252-0/+12
| |
* | modify add_source in application template to take a block for gem entriesHirofumi Wakasugi2015-06-251-2/+16
|/
* do not show "Failed tests" message when a failed test is notyuuji.yaginuma2015-06-232-3/+10
|
* remove unused variable in reporter testyuuji.yaginuma2015-06-221-1/+0
|
* Merge pull request #20605 from dcrec1/assert_fileYves Senn2015-06-194-2/+15
|\ | | | | | | assert_file understands paths with special characters
| * assert_file understands paths with special charactersDiego Carrion2015-06-183-2/+10
| | | | | | fixes #20042
* | fix railties testsMehmet Emin İNAÇ2015-06-181-2/+2
| |
* | Remove ContentLength middleware from the defaults.Aaron Patterson2015-06-172-1/+5
| | | | | | | | | | ContentLength is not part of the rack SPEC since rack/rack@86ddc7a6ec68d7b6951c2dbd07947c4254e8bc0d If you want it, just add it as a middleware in your config.
* | Merge pull request #20596 from vngrs/use_single_quote_in_gemfileKasper Timm Hansen2015-06-171-1/+1
|\ \ | | | | | | Use single quote in Railties generators Gemfile [ci skip]
| * | Use single quote in Railties generators Gemfile [ci skip]Mehmet Emin İNAÇ2015-06-171-1/+1
| |/
* / Bump AMS to 0.10.0.rc2Santiago Pastorino2015-06-161-1/+1
|/
* [ci skip] Fix the Rails::Generators::NamedBase#template docRoque Pinel2015-06-151-2/+2
| | | | | Since #13612, `template` is no longer being used to generate migrations.
* make it possible to customize the executable inside rereun snippets.Yves Senn2015-06-133-1/+23
| | | | | | | | | | | | | | | | | | | In the Rails repository we use a `bin/test` executable to run our tests. However the rerun snippets still included `bin/rails test`: BEFORE: ``` Failed tests: bin/rails test test/cases/adapters/postgresql/schema_test.rb:91 ``` AFTER: ``` Failed tests: bin/test test/cases/adapters/postgresql/schema_test.rb:91 ```
* Merge pull request #20480 from senny/test_runnerYves Senn2015-06-121-4/+1
|\ | | | | use our own runner for Rails framework components `bin/test`
| * inline test runner check into `as/testing/autorun.rb`.Yves Senn2015-06-111-4/+1
| | | | | | | | | | This makes it possible to easily get the runner working with existing setups that rely on `active_support/testing/autorun.rb`.
* | Fix failing tests for Rails-APISean Griffin2015-06-111-1/+1
| | | | | | | | This looks to be just out of sync tests
* | assigns was removed from RailsRafael Mendonça França2015-06-111-1/+0
| |
* | head :no_content is implicitly calledSantiago Pastorino2015-06-111-2/+0
| |
* | Checking if controller responds to wrap_parameter is not longer requiredJorge Bejar2015-06-111-1/+1
| |
* | Enable wrap_parameter by default in rails api applicationsJorge Bejar2015-06-112-5/+1
| |
* | Add rake-cors gem (commented) in Gemfile for rails api appsJorge Bejar2015-06-113-0/+20
| |
* | Make Rails API apps return the full resource on updateSantiago Pastorino2015-06-112-2/+2
| |
* | Add CHANGELOG entries for API apps functionalitySantiago Pastorino2015-06-111-0/+7
| |
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-19 11:37:58 +0000