| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Collapse all new default initializers into a single file
|
| |
| |
| |
| |
| |
| | |
- Adjusted tests also for this new behavior.
- Based on the discussion in
https://github.com/rails/rails/pull/25184#issuecomment-222454583.
|
|/ |
|
|
|
|
|
|
| |
- These initializers are new defaults for Rails 5 and newly generated
apps do not need to change them.
- Fixes #25181
|
|
|
|
| |
Follow up to e45f388.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When changing the generated integration tests to assert redirects with
an absolute path this redirection check in `assert_redirected_to` against
the absolute response location would now pass:
https://github.com/rails/rails/blob/af245aaf3a1c447752a1b5895adddc66e5f73c00/actionpack/lib/action_dispatch/testing/assertions/response.rb#L55
Thus we'd break early instead of hitting `assert_operator` and have
2 fewer assertions per `assert_redirected_to` as `assert_operator`
is composed of 2 assertions internally:
https://github.com/seattlerb/minitest/blob/4e146b1515b19a5c474e39c174b037510f6dbc6e/lib/minitest/assertions.rb#L254-L258
Deduct 2 assertions for 2 redirects taking the expected count down by 4
in total for the two failing tests.
|
|\
| |
| | |
Remove public/ files for API apps
|
| |
| |
| |
| | |
- Fixes #25180
|
| | |
|
| |
| |
| |
| | |
second is now irrelevant with the dedicated API mode
|
|/ |
|
|\
| |
| | |
Build action_cable.js with Blade
|
| |
| |
| |
| | |
Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
|
| |
| |
| | |
Adding '$' to emulate shell syntax
|
| |
| |
| | |
[ci skip]
|
|\ \
| |/
|/| |
Use RAILS_MAX_THREADS as pool size on all adapters
|
| |
| |
| |
| |
| |
| |
| |
| | |
When RAILS_MAX_THREADS is set, the postgresql adapter uses it as the
connection pool size, so that there are always enough connections
available to serve Action Cable requests.
The same logic applies when using any other adapter.
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | | |
Un-hide helper and assets options for controller generator
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These options were hidden via 9b36cf0fa4cbdcb2e2072ef1b8179a98b13efce3,
but these options have tests written for them, and I believe that they
are supposed to be public API.
Fixes #24168.
|
| | |
| | |
| | |
| | | |
environments
|
|\ \ \
| |_|/
|/| | |
Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
javascript engine of the application
- Now we will detect what javascript engine user is using and based on
that we will generate either `.js` or `.coffee` version of the channel
file.
- This also needs a change in coffee-rails to override the `js_template`
method. Related PR https://github.com/rails/coffee-rails/pull/72.
- Currently coffee-rails gem sets
`config.app_generators.javascript_engine` to `:coffee` and using this
information we override the `js_template` to set the extension as
`.coffee` in coffee-rails gem.
- Using this approach, we can keep the `channel.js` and `channel.coffee`
files in the Rails repository itself.
- Additionally the `js_template` method can act as public interface for
coffee-rails gem to hook into and change the extension to `.coffee`
without maintaining the actual asset files.
[Prathamesh Sonpatki, Matthew Draper]
|
|/ /
| |
| |
| |
| | |
Sorry, I missed a few places in my last PR. This should be the last of
'em :grimacing:
|
| |
| |
| |
| | |
Conventionally envs are ordered development -> test -> production.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
It is related with https://github.com/rack/rack/commit/7b66d2cdb80a4d6b44fa8c61d92e25fbbda1f152
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
|\ \
| | |
| | | |
remove unnessary option setting from test runner
|
| | |
| | |
| | |
| | |
| | | |
In order to prevent `OptionParser::ParseError` when specify the rake options to
`routes` task.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If run the test over the `rake` command, because of the test patterns is passed
via `rake_run` method, do not need to be obtained from the argv.
This probably fixes #24372.
|
| | |
| | |
| | |
| | | |
`railtie` is already a string!
|
| | |
| | |
| | |
| | | |
- Followup of https://github.com/rails/rails/pull/24709.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will
preserve the timezone of the receiver when converting to an instance
of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we
need to introduce a compatibility layer so that apps that upgrade do
not break. New apps will have a config initializer file that defaults
to match the new Ruby 2.4 behavior going forward.
For information about the changes to Ruby see:
https://bugs.ruby-lang.org/issues/12189
https://bugs.ruby-lang.org/issues/12271
Fixes #24617.
|
|/ / |
|
|\ \
| | |
| | | |
using rails dev:cache instead of rake dev:cache
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
y-yagi/use_wrapper_file_to_add_rake_task_for_engines
use wrapper file to add rake task for engines
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`bundler` provides wrapper file to add rask tasks.
https://github.com/bundler/bundler/blob/master/lib/bundler/gem_tasks.rb
Instead of directly call method, by which require this file,
it can be used without updating of Rakefile if task has been added.
|
|/ / / |
|
|\| |
| | |
| | |
| | | |
Add ActiveSupport::TimeZone.country_zones helper
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Railties' `config` method instatiates a Rails::Railtie::Configuration
object. Rails::Configuration is not used in this file.
The patch does not replace the file being required with the one for
Rails::Railtie::Configuration because that one is autoloaded. See the
spot where this patch changes double quotes with single quotes.
Rails::Railtie::Configuration does depend on Rails::Configuration, and
it requires it accordingly.
|
|\ \
| | |
| | | |
Added notice when a database is successfully created or dropped.
|