| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
support minitest after_run
|
| | |
|
| |
| |
| |
| | |
see https://github.com/seattlerb/minitest/blob/f9605387e4af7d657921a83aaf0ae364f6d26a57/lib/minitest.rb#L51-L65
|
| | |
|
|\ \
| | |
| | | |
use rails command in restart task test
|
| | | |
|
|/ / |
|
|/
|
|
|
|
| |
assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message
assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
|
|\
| |
| | |
remove useless `gemfile` option
|
| |
| |
| |
| |
| |
| |
| | |
Rails application for test creates with `--skip-gemfile` option.
https://github.com/rails/rails/blob/master/railties/test/isolation/abstract_unit.rb#L333
Therefore, regardless of the option, Gemfile is not created.
|
|\ \
| | |
| | | |
Move comment about disconnecting pool close to comment about preload
|
| | |
| | |
| | |
| | | |
- These two comments are connected to each other so kept them back to back.
|
|/ /
| |
| |
| | |
Follow up to 92703a9ea5d8b96f30e0b706b801c9185ef14f0e
|
| |
| |
| |
| | |
Master based applications should be pointing to master
|
|\ \
| | |
| | | |
Disconnects all connections in the pool before forking.
|
| | |
| | |
| | |
| | | |
See discussion in https://github.com/puma/puma/issues/1001
|
| |/
|/|
| |
| | |
Lacks some proper creds to the homies who went the... distance ;)
|
| |
| |
| |
| |
| |
| |
| | |
Currently, `bin/setup` test uses Gemfile of Rails. But this Gemfile is not a
file to be used in Rails application.
Add a Gemfile to Rails application that is created for test, it has been
modified to use the Gemfile.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently mongrel is not maintained.
And it couldn't be built with any Ruby versions that
supported by Rails.
It is reasonable to remove the word "mongrel" in order to avoid
confusion from newcomer.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Recently, the Rails team made an effort to keep the source code consistent, using Ruboco
(bb1ecdcc677bf6e68e0252505509c089619b5b90 and below). Some of the case
statements were missed.
This changes the case statements' formatting and is consistent with changes
in 810dff7c9fa9b2a38eb1560ce0378d760529ee6b and db63406cb007ab3756d2a96d2e0b5d4e777f8231.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Is this usage correct? cc/ @prathamesh-sonpatki
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Adding all those `public_*` methods is a bit heavy handed, we can change the API to instead use `public_folder: true`. Change was pretty easy since it was already implemented that way.
|
| | |
|
| | |
|
|/ |
|
|\
| |
| | |
Consistent examples and template for assets#precompile
|
| |
| |
| |
| |
| |
| |
| |
| | |
Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent.
This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template.
Re-add spaces inside array parentheses.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
inherits from Rails::Application
Until Rails 4.1, `before_configuration` run as soon as the application constant
inherits from `Rails::Application`.
However, in d25fe31c40928712b5e08fe0afb567c3bc88eddf, it has been modified to
run at instantiation process.
This modify to `before_configuration` is run at same timing as to Rails 4.1.
Fixes #19880
|
| |
| |
| |
| |
| | |
Extract a common method of `Rails::CommandsTasks` and
`Rails::Engine::CommandsTasks` to the module.
|
|\ \
| | |
| | |
| | |
| | | |
y-yagi/remove_test_mailers_when_skipping_action-mailer
remove "test/mailers" directory when skipping action-mailer
|
| |/
| |
| |
| | |
Related to #26146
|
|\ \
| | |
| | | |
Drop a temporary table before end of a test case
|
| | | |
|
| |/
|/|
| |
| |
| |
| |
| |
| | |
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
|
| |
| |
| |
| | |
Closes #26145
|
|/ |
|
|
|
|
|
|
|
|
| |
Fix unsafe query generation risk.
Redo of CVE-2012-2660, CVE-2012-2694 and CVE-2013-0155
CVE-2016-6317
|
|
|
|
|
| |
In ff8035dfeed8c86594c32ef8e9204806e190cb58, require rake is deferred.
Therefore, it is necessary to require rake even `Engine::CommandsTasks.
|
|
|
|
| |
Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
|
|
|
|
|
|
|
|
|
| |
A few have been left for aesthetic reasons, but have made a pass
and removed most of them.
Note that if the method `foo` returns an array, `foo << 1`
is a regular push, nothing to do with assignments, so
no self required.
|
|
|
|
| |
Some case expressions remain, need to think about those ones.
|
| |
|