aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | Revise 'sqlite3:' URL handling for smoother upgradesMatthew Draper2014-04-032-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll change to the absolute-path interpretation in 4.2. The current "correct" spellings for in-memory, relative, and absolute URLs, respectively, are: sqlite3::memory: sqlite3:relative/path sqlite3:/full/path Substantially reverses/defers fbb79b517f3127ba620fedd01849f9628b78d6ce. Uncovered by @guilleiguaran while investigating #14495, though that sounds like a different issue.
* | Fix build with bundler 1.6Rafael Mendonça França2014-03-261-1/+1
| |
* | Fix Generation of proper migration whenKuldeep Aggarwal2014-03-251-0/+50
| | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Base.pluralize_table_names = false. Previously, generation a migration like this: rails g migration add_column_name_to_user name would not generating the correct table name. Fixes #13426.
* | Check if any sqlite files are not included in the gitignoreRafael Mendonça França2014-03-241-2/+2
| | | | | | | | | | If the sqlite file name change in future version we this regexp should catch
* | Remove sqlite3 lines from .gitignore if the application is not using sqlite3.Dmitrii Golub2014-03-241-1/+25
| |
* | test for structure:dump without schema information table. refs eafec46Yves Senn2014-03-201-0/+12
| | | | | | | | This is a test case for the fix provided in eafec4694c5b37eff9d83b1188b8e331fa6027fa
* | Remove some indirection in rake dbs testCarlos Antonio da Silva2014-03-201-34/+20
| | | | | | | | | | Just pass in the expected database as argument rather than "caching" it in a hash and using the hash in the helper methods.
* | Check if the output is empty rather than asserting for equalityCarlos Antonio da Silva2014-03-201-5/+4
| | | | | | | | Also fix indent of test block.
* | Refactor assertion of line numbers matching 4 spacesCarlos Antonio da Silva2014-03-191-16/+4
| |
* | Move booting/loading tasks setup to the rake notes helper methodCarlos Antonio da Silva2014-03-191-15/+3
| |
* | Extract rake notes command and lines scan boilerplateCarlos Antonio da Silva2014-03-191-19/+14
| | | | | | | | Refactor to a reusable method.
* | Remove extra space assertionCarlos Antonio da Silva2014-03-191-3/+2
| | | | | | | | | | No need to check that each line contains an extra space, just matching the space in the regexp is enough to ensure that.
* | Extract common setup for loading tasks in rake notes testsCarlos Antonio da Silva2014-03-191-29/+14
| |
* | Merge pull request #14379 from robertomiranda/rake-notes.configGuillermo Iguaran2014-03-172-14/+40
|\ \ | | | | | | Add Public Api for Register New Extensions for Rake Notes
| * | Rake notes should picked up new Extensions registered in the ↵robertomiranda2014-03-171-3/+19
| | | | | | | | | | | | config/application.rb file
| * | Add config.annotations, in order to register new extensions for Rake notes ↵robertomiranda2014-03-161-0/+10
| | | | | | | | | | | | at config level
| * | Fix Shadowing extensions variable in Register Annotation Exentsionsrobertomiranda2014-03-161-5/+5
| | |
| * | Supporting .ruby, .yml and .yaml Extension in Rake Notesrobertomiranda2014-03-141-1/+6
| | |
| * | Remove .scss, .sass, .less, .haml, .slim, coffee from Rake Notes. Now we ↵robertomiranda2014-03-141-13/+3
| | | | | | | | | | | | have an API for register it in the corresponding gems
| * | Add Public Api for register new extensions for Rake Notesrobertomiranda2014-03-141-0/+5
| | |
* | | Fix assertionsCarlos Antonio da Silva2014-03-161-2/+2
| | |
* | | better test error messagesschneems2014-03-141-4/+4
|/ /
* | Make the rails:template rake task load initializersRobin Dupret2014-03-081-0/+11
| | | | | | | | | | | | | | | | | | | | | | Templates could rely on irregular inflections or external libraries for instance so we should load the application's initializers when running the rails:template task. The introducing commit of this feature is f7f11361 ; the initializers have never been loaded invoking this task. Fixes #12133.
* | Introduce `Rails.gem_version`Prem Sichanugrist2014-03-051-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method return `Gem::Version.new(Rails.version)`, suggesting a more reliable way to perform version comparison. Example: Rails.version #=> "4.1.2" Rails.gem_version #=> #<Gem::Version "4.1.2"> Rails.version > "4.1.10" #=> false Rails.gem_version > Gem::Version.new("4.1.10") #=> true Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true This was originally introduced as `.version` by @charliesome in #8501 but got reverted in #10002 since it was not backward compatible. Also, updating template for `rake update_versions`.
* | Merge pull request #14195 from robin850/issue-14079Guillermo Iguaran2014-02-281-0/+12
|\ \ | | | | | | Avoid namespacing routes inside engines
| * | Avoid namespacing routes inside enginesRobin Dupret2014-02-261-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since #11544, invoking the controller generator, any generated route is namespaced according to the class_path method. Since a mountable plugin is namespaced, creating a controller inside would generate a namespaced route based on the engine's name. The controller generator now relies on regular_class_path which does not contain the class hierarchy but the given path. Fixes #14079.
* | | Merge pull request #14174 from kuldeepaggarwal/fix-resource_generator_testYves Senn2014-02-272-4/+4
|\ \ \ | | | | | | | | fix test cases
| * | | modify model generator warning message. refs [#174c9f0]Kuldeep Aggarwal2014-02-272-4/+4
| |/ /
* | | Remove inclusion of rubysl gem for rbx on generated GemfileCarlos Antonio da Silva2014-02-251-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From #14026: Specific rbx-2 to limit testing on Rubinius 2.x (since there will be other versions of Rubinius > 2.x soon). Also, as of Rubinius 2.2.5, it is no longer necessary to bundle the rubysl gem. This is what Rails master/4.1 supports, so we don't need to add rubysl to gemfiles anymore.
* | | [skip ci] Fix test name typo in app generator tests.Spencer Rogers2014-02-251-1/+1
|/ /
* | build fix. follow up to 174c9f0df39cd338a4871f82794256cc64f68a81Yves Senn2014-02-241-1/+1
| |
* | include names in model generator warning message. refs #13515.Yves Senn2014-02-241-1/+1
| | | | | | | | | | | | This is a follow up to #13515. It includes the name given and the singularized version in the warning message. This will aide the user to see wether the detected singular was right or not.
* | Merge pull request #13515 from kuldeepaggarwal/f-model-generationGodfrey Chan2014-02-222-1/+8
|\ \ | | | | | | Added warning when user tried to create model with pluralize name.
| * | Add warning when user tried to create model with pluralize name.Kuldeep Aggarwal2014-02-232-1/+8
| | | | | | | | | | | | | | | 1. Generate model with correct_name. 2. It will help new users to avoid mistakes when tried to create model with wrong name.
* | | Revert "Only lookup `config.log_level` for stdlib `::Logger`. Closes #11665."Guillermo Iguaran2014-02-211-14/+1
|/ / | | | | | | | | | | | | | | | | | | | | | | This reverts commit e0a521cfcd13e4d1f0ae8ab96004289e1c020f71. Conflicts: railties/CHANGELOG.md We expect loggers to quack like stdlib logger. If log4r needs different level= assignment, using a Logger-quacking wrapper is the way to do it. Fixes #14114.
* | remove railties changes. fixes #14054Aaron Patterson2014-02-143-100/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Squashed commit of the following: commit 96991e8e919edfb20cc4120bca4e36ed51175d57 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri Feb 14 11:29:24 2014 -0800 Revert "gems can be added or skipped from the template" This reverts commit 8beb42cfbc41753ae4dbb91e16abcd1fb7d00356. Conflicts: railties/lib/rails/generators/rails/app/app_generator.rb railties/test/generators/app_generator_test.rb commit 35599c0e657245ef14ac0f28c9189ad16acf40e6 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri Feb 14 11:26:53 2014 -0800 Revert "oops, template replay needs to happen after bundle. :orz:" This reverts commit 9104702be61253f9448ca070a22fc86bb4299555. Conflicts: railties/lib/rails/generators/rails/app/app_generator.rb commit f519c3902c313db8e906a49251c91643b8e6499e Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri Feb 14 11:25:51 2014 -0800 Revert "only ask for these ivars if the target responds to them" This reverts commit 656d412546cd97d5660c634c2a41c799d3f9e211. commit aa524a9428e3e4c45fe221f10a66a08efb827ab5 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri Feb 14 11:25:39 2014 -0800 Revert "refactor generator tests to use block form of Tempfile" This reverts commit 65251820ef0ab7f3cffb38130de3dd41af8d72be. commit 7d3740549fa4dfa62e3761f8d4bc6d6d441256e7 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri Feb 14 11:25:25 2014 -0800 Revert "add a more restricted codepath for templates fixes #13390" This reverts commit 2875b4a66e38e4333da887a4afbed33358999298. commit 525df0af1001918986cdfce59539fd2d52c4f32c Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Fri Feb 14 11:25:11 2014 -0800 Revert "add a send so `apply` can be called. Fixes #13510" This reverts commit c5034d60dba0cd31a6a8c612ee35d63b8127793a.
* | fix path shown in mailer's templatesKassio Borges2014-02-141-4/+4
| |
* | Merge pull request #13945 from rails/json_cookie_serializer_improvementsGuillermo Iguaran2014-02-131-1/+1
|\ \ | | | | | | Cookies serializer improvements
| * | Fix AppGeneratorTest: serializer option was removed from session_storeGuillermo Iguaran2014-02-111-1/+1
| | |
* | | do not crash when `config/secrets.yml` is blank.Yves Senn2014-02-121-0/+8
| | |
* | | add a send so `apply` can be called. Fixes #13510Aaron Patterson2014-02-111-0/+32
|/ / | | | | | | | | | | | | THIS IS A HUGE HACK. Thor does not allow us to define public methods without turning them in to "thor tasks". That means we cannot subclass the `apply` method and make it public, so we have to make the method private and call `send` on it.
* | Add config to disable schema dump after migrationEmil Soman2014-02-062-0/+48
| | | | | | | | | | | | | | | | | | * Add a config on Active Record named `dump_schema_after_migration` * Schema dump doesn't happen if the config is set to false * Set default value of the config to true * Set config in generated production environment file to false * Update configuration guide * Update CHANGELOG
* | Merge pull request #13612 from eval/issue-13588Rafael Mendonça França2014-01-301-0/+134
|\ \ | | | | | | Add CreateMigration action
| * | Add CreateMigration actionGert Goet2014-01-281-0/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This Thor-action isolates the logic whether to (over-)write migration and what is shown to the user. It's modelled after Thor's CreateFile-action. This solves the issue that removing a non-existing migration, tried to remove the template-path (#13588). Related issues: #12674
* | | Modify the session serializer implementationGuillermo Iguaran2014-01-301-1/+1
| | | | | | | | | | | | | | | Rename allowed options to :marshal and :json, for custom serializers only allow the use of custom classes.
* | | Allow session serializer key in config.session_storeLukasz Sarnacki2014-01-291-1/+1
|/ / | | | | | | | | | | | | | | | | | | | | | | | | MessageEncryptor has :serializer option, where any serializer object can be passed. This commit make it possible to set this serializer from configuration level. There are predefined serializers (:marshal_serializer, :json_serialzier) and custom serializer can be passed as String, Symbol (camelized and constantized in ActionDispatch::Session namepspace) or serializer object. Default :json_serializer was also added to generators to provide secure defalt.
* | Add a test-case for GH #13825Guillermo Iguaran2014-01-241-2/+8
| |
* | Use single quotes in generated filesChulki Lee2014-01-141-4/+4
| |
* | single quotes for controller generated routesCristian Mircea Messel2014-01-142-3/+3
| | | | | | | | | | | | | | | | | | | | Write routes in route.rb with single quotes get 'welcome/index' instead of get "welcome/index"
* | Favor canonical environment variables for secretsschneems2014-01-131-2/+2
| | | | | | | | | | | | | | | | | | Prefixing an environment variable with `RAILS_` should be used when there is otherwise a conflict, such as `RAILS_ENV` or if it is being used for a very Rails specific value. If we remove the prefix of `RAILS_` in the case of `RAILS_SECRET_KEY_BASE` then we can push for a pseudo standard among other frameworks that will accept a common environment key `SECRET_KEY_BASE` to keep your app secure. This is beneficial for containerized deployments such as docker, Heroku, etc. So that the container need to know one less thing about your app (it can just set it no-matter what language or framework you are using). This change also allows the defaults to be consistent with the way the secret key is accessed so `secrets.secret_key_base` is aliased to `SECRET_KEY_BASE` instead of `RAILS_SECRET_KEY_BASE`.