aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #18994 from tgxworld/run_delete_middleware_operations_lastGuillermo Iguaran2015-02-191-0/+16
|\ | | | | Allow Rack::Runtime to be deleted from middleware stack.
| * Allow Rack::Runtime to be deleted from middleware stack.Guo Xiang Tan2015-02-191-0/+16
| | | | | | | | Fixes: https://github.com/rails/rails/issues/16433.
* | Remove unused gsub_app_file method from Bukkit.Josef Šimánek2015-02-191-6/+0
| |
* | Merge pull request #18393 from y-yagi/fix_mailerRafael Mendonça França2015-02-182-16/+25
|\ \ | |/ |/| follow up to #18074
| * follow up to #18074yuuji.yaginuma2015-01-082-16/+25
| | | | | | | | | | * ignore mailer suffix when generate test files * add mailer suffix to view files
* | Dont check bundler output on plugin generator testArthur Neves2015-02-101-4/+2
| |
* | Actually fix the buildSean Griffin2015-02-101-1/+1
| | | | | | | | Like for real this time. I checked.
* | Fix the buildSean Griffin2015-02-101-1/+1
| |
* | tests, reset global to previous value.Yves Senn2015-02-091-1/+3
| | | | | | | | | | The default of the global might change. It's better to reset it to what it was than a hardcoded value.
* | Remove warning from generator named base testYuki Nishijima2015-02-081-10/+0
| | | | | | | | | | | | | | | | | | This removes the following warning: railties/test/generators/named_base_test.rb:9: warning: method redefined; discarding old pluralize_table_names activesupport/lib/active_support/core_ext/class/attribute.rb:86: warning: previous definition of pluralize_table_names was here railties/test/generators/named_base_test.rb:9: warning: method redefined; discarding old pluralize_table_names= activesupport/lib/active_support/core_ext/class/attribute.rb:83: warning: previous definition of pluralize_table_names= was here
* | README.rdoc -> README.md for newly generated applicationsXavier Noria2015-02-062-3/+3
| | | | | | | | | | | | README.rdoc was generated to support the doc:app task. Now that this task is gone we can switch to Markdown, which is nowadays a better default.
* | Remove documentation tasksXavier Noria2015-02-061-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch removes the tasks doc:app, doc:rails, and doc:guides. In our experience applications do not generate APIs using doc:app. Methods may be certainly documented for maintainers, annotated with YARD tags, etc. but that is intended to be read with the source code, not in a separate website. Then, teams also have typically selected topics written down in Markdown files, or in a GitHub wiki... that kind of thing. If a team absolutely needs to generate application documentation for internal purposes, they can still easily write their own task. Regarding doc:rails and doc:guides, we live in 2015. We are used to go to online docs all the time. If you really want access to the API offline RubyGems generates it for every Rails component unless you tell it not to, and you can checkout the Rails source code to read the guides as Markdown, or download them for a Kindle reader. All in all, maintaining this code does not seem to be worthwhile anymore. As a consequence of this, guides (+3 MB uncompressed) won't be distributed with the rails gem anymore. Of course, guides and API are going to be still part of releases, since documentation is maintained alongside code and tests. Also, time permitting, this will allow us to experiment with novel ways to generate documentation in the Rails docs server, since right now we were constrained by being able to generate them in the user's environment.
* | Merge pull request #18399 from kommen/unify-structure-file-envvar-namesRafael Mendonça França2015-02-051-1/+1
|\ \ | | | | | | | | | | | | | | | | | | Use SCHEMA instead of DB_STRUCTURE for specifiying structure file. Conflicts: activerecord/CHANGELOG.md
| * | Use `SCHEMA` instead of `DB_STRUCTURE` for specifiying structure file.Dieter Komendera2015-01-081-1/+1
| |/ | | | | | | | | `rake test:load_structure` already uses `SCHEMA` and there's no need to maintain two different env vars.
* | Merge pull request #18526 from vipulnsward/add-silence-streamRafael Mendonça França2015-02-053-71/+8
|\ \ | | | | | | Extracted silence_stream method to new module in activesupport/testing
| * | - Extracted silence_stream method to new module in activesupport/testing.Vipul A M2015-01-203-71/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Added include for the same in ActiveSupport::Test. - Removed occurrences of silence_stream being used elsewhere. - Reordered activesupport testcase requires alphabetically. - Removed require of silence stream from test_case - Moved quietly method to stream helper - Moved capture output to stream helper module and setup requires for the same elsewhere
* | | Force generated route to be insertedAndrew White2015-02-051-0/+5
| | | | | | | | | | | | | | | | | | | | | Thor isn't very discerning over whether some content is present when passed to `inject_into_file`, e.g. a commented out route is detected as being present. So to prevent people scratching their heads as to why a route hasn't appeared it's better to fall on the side of having duplicate routes.
* | | Don't remove all line endings from routes.rbAndrew White2015-02-031-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When there is a single scaffold in the routes.rb with no other lines then revoking/destroying it will create a routes.rb file with a syntax error. This is because the sentinel for the Thor `route` action didn't include the newline but the logged route code did. The fix is to add the newline to the sentinel and remove it from the the logged route code. Fixes #15913.
* | | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-035-5/+0
| | | | | | | | | | | | onwards.
* | | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846robertomiranda2015-01-311-1/+1
| | | | | | | | | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
* | | Fixed a few things from ee9e4c3Godfrey Chan2015-01-301-7/+7
| | | | | | | | | | | | | | | Mostly cosmetics, except that `isolate_namespace` should be applied to the last module in the chain.
* | | Allow hyphenated names for `rails plugin new` generator.Robin Böning2015-01-301-4/+102
| | | | | | | | | | | | | | | | | | It was not possible to create a new gem with a hyphenated name via the `rails plugin new` generator. The naming guide of rubygems clearly says dashes should be used for gems that extend other gems. http://guides.rubygems.org/name-your-gem/
* | | build fix II, adjust broken tests as a consequence of 670ac73126.Yves Senn2015-01-301-4/+4
| | |
* | | build fix.Yves Senn2015-01-301-4/+4
| | |
* | | tests, use `capture` instead of custom `redirect_stderr` helper.Yves Senn2015-01-301-12/+2
| | |
* | | Merge pull request #18705 from mrgilman/skip-testRafael Mendonça França2015-01-293-11/+11
|\ \ \ | | | | | | | | Update option to skip test in generators
| * | | Change option description and update test namesMelanie Gilman2015-01-292-2/+2
| | | |
| * | | Update option to skip test in generatorsMelanie Gilman2015-01-273-9/+9
| | | | | | | | | | | | | | | | Rails no longer generates Test::Unit files by default.
* | | | introduce `ActiveSupport::Testing::FileFixtures`.Yves Senn2015-01-281-0/+1
|/ / / | | | | | | | | | | | | | | | It's a thin layer to provide easy access to sample files throughout test-cases. This adds the directory `test/fixtures/files` to newly generated applications.
* / / Fixed test for assert_welcomePrathamesh Sonpatki2015-01-171-1/+2
|/ / | | | | | | - Test was wrongly using assert with assignment statement.
* | Add the `method_source` gem to the default GemfileSean Griffin2015-01-131-0/+7
| | | | | | | | Fixes #18473
* | Add Secure Token Generatorrobertomiranda2015-01-112-0/+35
| |
* | Use IO::NULL alwaysNobuyoshi Nakada2015-01-102-2/+2
| |
* | Merge pull request #18413 from brainopia/automatic_inverse_of_for_belongs_toDavid Heinemeier Hansson2015-01-091-24/+50
|\ \ | | | | | | Correctly count methods when using declarative `#test` in minitest
| * | Update `rake counts` to count declarative tests in minitestbrainopia2015-01-091-24/+50
| |/
* / Add _mailer suffix to i18n pathCarlos Souza2015-01-082-5/+5
|/ | | | | | For mailers created via generators Follow up to #18074
* Add mailer suffix to generated files and classesCarlos Souza2015-01-062-28/+35
| | | | | Following the same naming convention used in controllers and jobs.
* Remove debugger supportRafael Mendonça França2015-01-043-28/+0
| | | | | bebugger doesn't work with Ruby 2.2 so we don't need to support it anymore
* Remove deprecated `serve_static_assets` configurationRafael Mendonça França2015-01-041-16/+0
|
* Remove deprecation warning when log_level is not explicit set on productionRafael Mendonça França2015-01-041-30/+0
|
* Change the default `null` value for `timestamps` to `false`Rafael Mendonça França2015-01-041-1/+1
|
* Remove deprecate `*_path` helpers in email viewsRafael Mendonça França2015-01-043-55/+2
|
* Remove deprecated methods at `Kernel`.Rafael Mendonça França2015-01-042-0/+20
| | | | `silence_stderr`, `silence_stream`, `capture` and `quietly`.
* Improve the matches on the scaffold generator testsCarlos Antonio da Silva2015-01-031-9/+8
| | | | Related to #13434.
* Merge pull request #13434 from tanraya/local_variablesCarlos Antonio da Silva2015-01-031-0/+11
|\ | | | | | | | | | | | | Use local variables in _form.html.erb generated by scaffold. Conflicts: railties/CHANGELOG.md
| * Use local variables in _form.html.erb generated by scaffold generator.tanraya2014-07-261-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | It seems a good idea to use local variables in generated partials instead of using instance variables. Before <%= render 'form' %> After <%= render 'form', product: @product %>
* | Merge pull request #17227 from claudiob/explicitly-abort-callbacksRafael Mendonça França2015-01-032-10/+37
|\ \ | | | | | | | | | | | | | | | | | | Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps. Conflicts: railties/CHANGELOG.md
| * | Add config to halt callback chain on return falseclaudiob2015-01-021-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This stems from [a comment](rails#17227 (comment)) by @dhh. In summary: * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning. * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning. For this purpose, this commit introduces a Rails configuration option: ```ruby config.active_support.halt_callback_chains_on_return_false ``` For new Rails 5.0 apps, this option will be set to `false` by a new initializer `config/initializers/callback_terminator.rb`: ```ruby Rails.application.config.active_support.halt_callback_chains_on_return_false = false ``` For existing apps ported to Rails 5.0, the initializers above will not exist. Even running `rake rails:update` will not create this initializer. Since the default value of `halt_callback_chains_on_return_false` is set to `true`, these apps will still accept `return true` as a way to halt callback chains, displaying a deprecation warning. Developers will be able to switch to the new behavior (and stop the warning) by manually adding the line above to their `config/application.rb`. A gist with the suggested release notes to add to Rails 5.0 after this commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
| * | Loosen test about order of initializersclaudiob2015-01-021-10/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit modifies the code (but not the purpose) of a test that checks that > initializers are executed after application configuration initializers Currently the test hard-codes the *exact* initializers that are expected to occur before a custom one. This can cause the test to fail even if the expectation still passes. This commit loosens the test by simply checking that, in the array of initializers, the custom initializers (called `dummy_initializer` in the example) is executed after the last occurrence of `load_config_initializers`.
* | | Remove some warningsRafael Mendonça França2015-01-031-32/+32
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 14:29:35 +0000