aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
* Fix invalid asset compile assertionsJoshua Peek2012-08-071-3/+2
| | | | Logical paths to compile should require an extension
* make assertions easier to track downAaron Patterson2012-08-071-9/+17
|
* html_escape should escape single quotesSantiago Pastorino2012-08-021-2/+2
| | | | | | | | | | | | https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content Closes #7215 Conflicts: actionpack/test/template/erb_util_test.rb actionpack/test/template/form_tag_helper_test.rb actionpack/test/template/text_helper_test.rb actionpack/test/template/url_helper_test.rb activesupport/lib/active_support/core_ext/string/output_safety.rb
* Merge pull request #6690 from suginoy/fix-templates-copyRafael Mendonça França2012-06-111-0/+12
| | | | | | Fix: 'rake rails:templates:copy' doesn't work Conflicts: railties/test/application/rake_test.rb
* Don't add sqlite3 to gemspec with -O on rails plugin newPiotr Sarnacki2012-06-081-0/+8
| | | | (closes #6672)
* Merge pull request #6678 from arunagw/fix_issue_6673Rafael Mendonça França2012-06-081-0/+8
|\ | | | | Fix issue 6673
| * We should not include engine.rake file into rakeArun Agrawal2012-06-081-0/+8
| | | | | | | | | | | | | | | | | | | | if we are passing -T which is skip_test_unit See issue #6673 for more details. I saw that we are not creating dummy app even if we do skip_test_unit. Fixes #6673
* | Removed protected as we already doing it above. Arun Agrawal2012-06-081-2/+0
|/
* Revert "fix the Flash middleware loading the session on every request (very ↵Rafael Mendonça França2012-06-051-20/+0
| | | | | | | | | dangerous especially with Rack::Cache), it should only be loaded when the flash method is called" This reverts commits e3069c64b2c5ddc7a5789b55b8efd4902d9e9729 and 2b2983d76fd11efc219273036a612f47cfaa5bfa. Reason: This add a non-backward compatible change in the way that flash works now (swept in every request).
* Changed symbol platform to platforms for the commented out call to gem ↵Martin O'Connor2012-05-301-1/+1
| | | | | | | 'therubyracer'. Dependency.rb expects the symbol to be named :platforms as opposed to platform. RubyMine's inspections indicate that the symbol should be named :platforms. Updating tests.
* Remove irrelevant assertionOscar Del Ben2012-05-291-7/+0
|
* Display annotations from .coffee files in `rake notes`Bartlomiej Kozal2012-05-281-5/+16
|
* Fix railties_order when application object is passedPiotr Sarnacki2012-05-271-0/+4
| | | | | | | | | | | | | | | railites_order method, introduced in 40b19e0, had a bug that was causing loading application instance twice in initializers if railties_order already included application instance. So for example railties_order = [Foo::Engine, :main_app, Bar::Engine] would result in such railties array: [MyApp::Application, Foo::Engine, MyAppApplication, Bar::Engine] In order to fix it, we need to check for existence of application in both railties_order and railties arrays.
* Use require_dependency in generated controllersPiotr Sarnacki2012-05-221-2/+2
| | | | | | | Using require in development mode will prevent required files from reloading, even if they're changed. In order to keep namespaced application_controller reloadable, we need to use require_dependency instead of require.
* Fix generators to help with ambiguous `ApplicationController` issuePiotr Sarnacki2012-05-201-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In development mode, dependencies are loaded dynamically at runtime, using `const_missing`. Because of that, when one of the constants is already loaded and `const_missing` is not triggered, user can end up with unexpected results. Given such file in an Engine: ```ruby module Blog class PostsController < ApplicationController end end ``` If you load it first, before loading any application files, it will correctly load `Blog::ApplicationController`, because second line will hit `const_missing`. However if you load `ApplicationController` first, the constant will be loaded already, `const_missing` hook will not be fired and in result `PostsController` will inherit from `ApplicationController` instead of `Blog::ApplicationController`. Since it can't be fixed in `AS::Dependencies`, the easiest fix is to just explicitly load application controller. closes #6413
* Added test for assets:precompile for index filesDmitry Vorotilin2012-05-011-0/+9
|
* Failing test for #6034Piotr Sarnacki2012-04-301-0/+20
|
* Replace ruby-debug19 which doesnt work on 1.9.3 out of the box with a more ↵Aditya Sanghi2012-04-171-2/+2
| | | | maintained debugger gem
* "rails new -h" shows message in rails directoryask2012-04-131-0/+10
|
* log which config format AR uses to connect withTerence Lee2012-04-031-0/+19
|
* test initializer logic for DATABASE_URL env varTerence Lee2012-04-031-0/+43
|
* Usage file in generators shouldn't be fetched only based on source_rootPiotr Sarnacki2012-04-022-1/+5
| | | | | | | | In case `source_roout` is not set, `default_source_root` is used, which includes also `templates` directory. If there is no `templates` directory, `default_source_root` is not available and USAGE will not be displayed. USAGE should be also checked based on default directory excluding `templates`.
* Add arel branch to the testsRafael Mendonça França2012-03-271-1/+1
|
* Fix GH #5411. When precompiling, params method is undefined.kennyj2012-03-221-0/+12
|
* [3-2-stable] Port of #5522 'Fix adding/removing field's index when ↵Marcelo Silveira2012-03-211-0/+18
| | | | generating migration'
* [3-2-stable] Remove blank line from generated migrationMarcelo Silveira2012-03-201-0/+1
|
* Build fix for app_generator_test.rbArun Agrawal2012-03-181-1/+1
|
* Fix GH #5435. db:structure:dump should be re-enable.kennyj2012-03-181-0/+12
|
* Use Ruby 1.8 hash syntaxRafael Mendonça França2012-03-132-8/+32
|
* Use the attributes hash explicitlyRafael Mendonça França2012-03-132-6/+26
|
* Do not use the attributes hash in the scaffold functional testsRafael Mendonça França2012-03-132-2/+9
|
* Now all the models need to explicitly declare the accessible attributesRafael Mendonça França2012-03-041-0/+1
|
* Only add the whitelist_attributes option if ActiveRecord is presentRafael Mendonça França2012-03-042-1/+7
| | | | | | | Conflicts: railties/test/generators/app_generator_test.rb railties/test/isolation/abstract_unit.rb
* Whitelist all attribute assignment by default.Michael Koziarski2012-03-051-0/+10
| | | | Change the default for newly generated applications to whitelist all attribute assignment. Also update the generated model classes so users are reminded of the importance of attr_accessible.
* --edge option should generate app with rails 3-2-stableGuillermo Iguaran2012-02-072-3/+3
|
* Fix plugin_new test failure from c8c84397Prem Sichanugrist2012-02-012-3/+7
| | | | | `plugin_new` generator doesn't generate `sass-rails` in the Gemfile, so you can't check for that.
* Fix GH #4749. Remove branch options, because edge is not 3-2-stable.kennyj2012-02-011-0/+5
|
* fix assets testSergey Nartimov2012-01-311-1/+1
|
* Support decimal{1,2} and decimal{1-2} and decimal{1.2} so it works fine with ↵José Valim2012-01-221-3/+3
| | | | bash, zsh, etc, closes #4602
* Add default charset config to ActionDispatchCarlos Antonio da Silva2012-01-171-0/+8
|
* Don't hardcode assets route skipped in route inspectorGuillermo Iguaran2012-01-151-0/+15
| | | | | | Conflicts: railties/lib/rails/application/route_inspector.rb
* No AS::TestCase here.José Valim2012-01-131-1/+1
|
* config.force_ssl should mark the session as secure.José Valim2012-01-131-0/+30
|
* Merge pull request #4451 from guilleiguaran/add-therubyracer-commentedJosé Valim2012-01-131-4/+2
|
* Remove duplicated test line which was causing Ci failures on 1.8.7.José Valim2012-01-101-1/+0
|
* Remove dead codeSantiago Pastorino2012-01-101-4/+0
|
* Rails initialization with initialize_on_precompile = false should set assets_dirSantiago Pastorino2012-01-101-0/+6
|
* Add ORIGINAL_FULLPATH to envPiotr Sarnacki2012-01-102-1/+37
| | | | | | | | | | | This behaves similarly to REQUEST_URI, but we need to implement it on our own because REQUEST_URI is not reliable. Note that since PATH_INFO does not contain information about trailing question mark, this is not 100% accurate, for example `/foo?` will result in `/foo` in ORIGINAL_FULLPATH
* Correctly display rack apps with dynamic constraints in RoutesInspectorPiotr Sarnacki2011-12-261-0/+17
| | | | | | | | | | | | | If you used dynamic constraint like that: scope :constraint => MyConstraint.new do mount RackApp => "/foo" end routes were not displayed correctly when using `rake routes`. This commit fixes it. If you want nice display of dynamic constraints in `rake routes` output, please just override to_s method in your constraint's class.
* Last attempt to fix 1.8.7 tests.José Valim2011-12-242-7/+14
|