aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #22756 from lucasmazza/lm-test-reporter-colored-outputKasper Timm Hansen2015-12-231-3/+35
|\ | | | | Add colored output to the new test reporter.
| * Add colored output to the new test reporter.Lucas Mazza2015-12-221-3/+35
| |
* | remove cors initializer from rails appyuuji.yaginuma2015-12-221-0/+6
|/ | | | | `rack-cors` gem is defined in Gemfile by default only if the api, not defined by default in rails app.
* Merge pull request #22685 from jeyb/remove_cable_files_for_skip_action_cableRafael França2015-12-211-0/+3
|\ | | | | Ensure Action Cable files are removed when `skip_action_cable` is set.
| * Ensure Action Cable files are removed when `skip_action_cable` is set.Jey Balachandran2015-12-211-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | The Action Cable generators creates four files which need to be removed if `skip_action_cable` is set. 1. `app/assets/javascripts/cable.coffee` 2. `app/channels/application_cable/channel.rb` 3. `app/channels/application_cable/connection.rb` 4. `config/redis/cable.yml` Fixes #22669.
* | Use the generators options to not generate channel assetsRafael Mendonça França2015-12-211-6/+2
| |
* | Merge pull request #22727 from prathamesh-sonpatki/fix-masterKasper Timm Hansen2015-12-211-1/+4
|\ \ | | | | | | Ensure that assets are enabled back after the test that tests assets are disabled
| * | Ensure that assets are enabled back after the test that tests assets are ↵Prathamesh Sonpatki2015-12-211-1/+4
| | | | | | | | | | | | disabled
* | | Merge pull request #22684 from ↵Yves Senn2015-12-211-0/+9
|\ \ \ | |/ / |/| | | | | | | | teknofire/fix-using-add_resource-with-a-block-after-gem-call Fix using add_resource with a block after gem in custom generators
| * | Fixes using `add_source` with a block after using `gem` in a custom railsWill Fisher2015-12-211-0/+9
| |/ | | | | | | generator template.
* | Merge pull request #22692 from ryohashimoto/22669_api_generatorDavid Heinemeier Hansson2015-12-211-0/+30
|\ \ | | | | | | Action Cable channel generator doesn't create JS assets if options[:rails][:assets] is false
| * | Action Cable channel generator should not create JS assets in --api modeRyo Hashimoto2015-12-191-0/+30
| |/
* / display detailed information in inline reportingyuuji.yaginuma2015-12-214-6/+12
|/ | | | | | | | | | | | | | | | | | | | | The errors message only was not displayed, as if it did not use the inline reporting, modified to also information the method name and the like in error are displayed. ``` # before Failed assertion, no message given. bin/rails test test/models/user_test.rb:5 ``` ``` # after Failure: UserTest#test_the_truth: Failed assertion, no message given. bin/rails test test/models/user_test.rb:5 ```
* Do not check the version anymoreRafael Mendonça França2015-12-181-2/+2
| | | | | Our logic is complex now and we don't need to check the version to asset the behavior so I'm removing the checking here.
* Allow normal version updates within a release seriesMatthew Draper2015-12-181-0/+15
| | | | | | | | | | | | | | | | | | | We originally chose to apply very strict versioning on the `rails` entry in the Gemfile, because our future versioning policy was not strongly defined. Now it is, and our policy is very much designed on the expectation that people will regularly update to the latest patch level in their release series... so we should encourage that. Of course, Gemfile.lock will do its job and prevent unplanned updates, just as it does for every other gem in the bundle... but if you run `bundle update`, we want to get you the latest bug/security fixes without requiring a manual edit of the Gemfile entry. Our current version could be a few different shapes, so it takes a bit of work to find the right specifier, but in principle, we match anything of the form x.y.*, where x.y matches our current release series.
* Merge pull request #22642 from seuros/remove-mysql-adapterMatthew Draper2015-12-181-3/+3
|\ | | | | | | Remove legacy mysql adapter
| * Remove legacy mysql adapterAbdelkader Boudih2015-12-171-3/+3
| |
* | ApplicationMailer should be generated by default just like every other ↵David Heinemeier Hansson2015-12-175-27/+3
| | | | | | | | Application* parent
* | Fix warningRafael Mendonça França2015-12-171-1/+1
|/
* README.rdoc -> README.md for newly generated pluginsyuuji.yaginuma2015-12-171-3/+3
| | | | I think Markdown is nowadays a better default.
* Fix testsDavid Heinemeier Hansson2015-12-171-2/+0
|
* No longer uses keep now that we have ApplicationRecordDavid Heinemeier Hansson2015-12-161-1/+0
|
* Fix testDavid Heinemeier Hansson2015-12-161-1/+10
|
* Fix test now that cable is in there by default tooDavid Heinemeier Hansson2015-12-161-1/+1
|
* Merge branch 'master' into merge-action-cableRafael Mendonça França2015-12-1611-36/+49
|\
| * Use sprockets 3 in the Rails 5 releaseRafael Mendonça França2015-12-162-6/+7
| |
| * Merge pull request #22567 from gsamokovarov/introduce-application-recordRafael França2015-12-164-1/+14
| |\ | | | | | | Introduce ApplicationRecord, an Active Record layer supertype
| | * Introduce ApplicationRecord, an Active Record layer supertypeGenadi Samokovarov2015-12-164-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's pretty common for folks to monkey patch `ActiveRecord::Base` to work around an issue or introduce extra functionality. Instead of shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can hold all those custom work the apps may need. Now, we don't wanna encourage all of the application models to inherit from `ActiveRecord::Base`, but we can encourage all the models that do, to inherit from `ApplicationRecord`. Newly generated applications have `app/models/application_record.rb` present by default. The model generators are smart enough to recognize that newly generated models have to inherit from `ApplicationRecord`, but only if it's present.
| * | Run railties generated app tests in test enveileencodes2015-12-151-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Running railties generated app tests in development env can cause unintended consequences. The environments are different and tests aren't meant to be run in development mode. The changes to the generator exposed this issue where the random test order in the generated apps could cause problems when those tests are run in development mode. Particularly we saw failures in `railties/test/application/rake_test.rb` generated apps that used the scaffold to create applications and then run the migration and immediately run the tests. The error we saw was `ActiveRecord::RecordNotFound: Couldn't find User with 'id'=980190962` and seemed to only occur if the destroy test ran first. I'm not entirely sure _why_ this causes that error to be thrown but I believe it is related to the environments being different.
| * | Update test generators to use ActionDispatch::IntegrationTestAbdelkader Boudih2015-12-154-24/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Rails 5.1 `ActionController::TestCase` will be moved out of Rails into it's own gem. Please use `ActionDispatch::IntegrationTest` going forward. This changes the generators to use `ActionDispatch::IntegrationTest` and the required URL setup (rather than symbols) for each of the controller actions. Updated fix to #22076.
| * | Do not default to any SerializerSantiago Pastorino2015-12-151-2/+1
| |/ | | | | | | We will wait until 5.1 to make a decision
* | Accept a Pathname in Application#config_forRafael Mendonça França2015-12-151-0/+15
| | | | | | | | That would make possible to use it with action cable configuration.
* | Merge remote-tracking branch 'origin/master' into merge-action-cableRafael Mendonça França2015-12-157-29/+29
|\|
| * Internal test migrations use the private 'Current' versionMatthew Draper2015-12-154-15/+15
| | | | | | | | | | | | | | | | Apart from specific versioning support, our tests should focus on the behaviour of whatever version they're accompanying, regardless of when they were written. Application code should *not* do this.
| * Ensure generated migrations include a version numberMatthew Draper2015-12-153-14/+14
| |
* | Add option to skip Action CableRafael Mendonça França2015-12-141-0/+5
|/
* Revert "Merge pull request #22569 from seuros/remove-test-case"eileencodes2015-12-136-14/+14
| | | | | | | | | This reverts commit 9712a7a12b7f9e4dcef751ceda8a73c3f4beb11f, reversing changes made to 3e65c3d3886336e9145438cdeacaf4ebec6a48b8. Reverting because this caused test failures and while we have a followup branch there is still one failure that happens randomly and isn't straight forward to fix.
* Merge pull request #22569 from seuros/remove-test-caseEileen M. Uchitelle2015-12-136-14/+14
|\ | | | | Controller generators should be creating IntegrationTest stubs instea…
| * Controller generators should be creating IntegrationTest stubs instead of ↵Abdelkader Boudih2015-12-136-14/+14
| | | | | | | | ControllerTest
* | Merge pull request #22574 from gsamokovarov/scaffold-500Kasper Timm Hansen2015-12-131-1/+1
|\ \ | | | | | | Prevent a 500 in the default controller scaffold
| * | Prevent a 500 in the default controller scaffoldGenadi Samokovarov2015-12-131-1/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you update a record with no attributes, you'll hit a 500 from a guard in `assign_attributes` raising: ```ruby ArgumentError: When assigning attributes, you must pass a hash as an argument. app/controllers/users_controller.rb:44:in `block in update' app/controllers/users_controller.rb:43:in `update' test/controllers/users_controller_test.rb:37:in `block in <class:UsersControllerTest>' ``` Not a biggie, but may be quite confusing for the folks new to the framework.
* / Update web-console to 3.0.0Genadi Samokovarov2015-12-131-2/+2
|/ | | | | Web Console 3.0.0 is compatible with Rails 5, while the 2.x.x releases aren't.
* show relative path the rerun snippet of test runner in rails engineyuuji.yaginuma2015-12-103-22/+58
| | | | | | | | | | | | | Since the absolute path is not required to re-run the test, modified so that unnecessary information is not displayed. ```ruby # before bin/rails test /path/to/blorgh/test/integration/navigation_test.rb:5 # after bin/rails test test/integration/navigation_test.rb:5 ```
* Remove duplicated assertion from api_app_generator testsJorge Bejar2015-12-091-2/+0
|
* We don't need to set config.debug_exception_response_format given that :api ↵Jorge Bejar2015-12-091-4/+0
| | | | is the default value for only API apps
* Make debug_exception_response_format config depends on api_only when is not setJorge Bejar2015-12-091-0/+25
|
* Add tests for api_only configuration settingJorge Bejar2015-12-091-0/+15
|
* Add debug_exception_response_format config to configure DebugExceptionJorge Bejar2015-12-091-0/+4
| | | | behavior
* Do not include web-console in Rails API appsJorge Bejar2015-12-091-0/+2
|
* Clarify the need to run command twice.Kasper Timm Hansen2015-12-071-2/+2
| | | | | We had 2 pull requests erronously trying to remove the first command. Add some comments for clarity.