aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | cleanup up constant in test suiteXavier Noria2019-04-091-0/+1
| | |
* | | depend on Zeitwerk 2.1.0Xavier Noria2019-04-091-9/+61
|/ /
* | depend on Zeitwerk 2Xavier Noria2019-04-071-0/+14
| |
* | Output junit format test reportFumiaki MATSUSHIMA2019-04-041-0/+2
| |
* | Remove redundant begin blockRyuta Kamizono2019-04-041-10/+9
| | | | | | | | | | We have `Style/RedundantBegin` cop (#34764) but it could not correct in this case.
* | Use `execute_batch2` rather than `execute_batch` to fix performance ↵Ryuta Kamizono2019-04-042-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | regression for fixture loading d8d6bd5 makes fixture loading to bulk statements by using `execute_batch` for sqlite3 adapter. But `execute_batch` is slower and it caused the performance regression for fixture loading. In sqlite3 1.4.0, it have new batch method `execute_batch2`. I've confirmed `execute_batch2` is extremely faster than `execute_batch`. So I think it is worth to upgrade sqlite3 to 1.4.0 to use that method. Before: ``` % ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids Using sqlite3 Run options: -n test_eager_loading_too_may_ids --seed 35790 # Running: . Finished in 202.437406s, 0.0049 runs/s, 0.0049 assertions/s. 1 runs, 1 assertions, 0 failures, 0 errors, 0 skips ARCONN=sqlite3 bundle exec ruby -w -Itest -n test_eager_loading_too_may_ids 142.57s user 60.83s system 98% cpu 3:27.08 total ``` After: ``` % ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids Using sqlite3 Run options: -n test_eager_loading_too_may_ids --seed 16649 # Running: . Finished in 8.471032s, 0.1180 runs/s, 0.1180 assertions/s. 1 runs, 1 assertions, 0 failures, 0 errors, 0 skips ARCONN=sqlite3 bundle exec ruby -w -Itest -n test_eager_loading_too_may_ids 10.71s user 1.36s system 95% cpu 12.672 total ```
* | Add test that the listen gem is included when RUBY_ENGINE is not 'ruby'Benoit Daloze2019-04-031-0/+16
| | | | | | | | | | * The fix is already in master since https://github.com/rails/rails/pull/34243 * See https://github.com/rails/rails/pull/35482 for the fix in Rails 5.2
* | Auto-correct rubocop offencesRyuta Kamizono2019-04-031-2/+2
| |
* | Merge pull request #35805 from excid3/attachments-field-generatorsRafael França2019-04-025-5/+73
|\ \ | | | | | | Add attachment and attachments field generators
| * | Add attachment and attachments field generatorsChris Oliver2019-03-305-5/+73
| | |
* | | Merge pull request #35768 from robertomiranda/r/rake-db-prepareEileen M. Uchitelle2019-04-022-0/+36
|\ \ \ | | | | | | | | Add db:prepare rake task.
| * | | Add migration in case of db:drop assertionRoberto Miranda2019-04-021-0/+7
| | | |
| * | | 💇Roberto Miranda2019-04-022-2/+1
| | | |
| * | | Add test cases for rake db:prepareRoberto Miranda2019-04-022-0/+30
| | | |
* | | | Rename `connection` option to `database` in `dbconsole` commandyuuji.yaginuma2019-04-021-6/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We introduced `connection` option for specifying spec with 1acd9a6464668d4d54ab30d016829f60b70dbbeb. But now we are using the `database` to specify the same value in other commands. * https://github.com/rails/rails/blob/0a0f115031b64b5335fa88543c40df4194dfb428/activerecord/lib/rails/generators/active_record/migration/migration_generator.rb#L11 * https://github.com/rails/rails/blob/0a0f115031b64b5335fa88543c40df4194dfb428/activerecord/lib/rails/generators/active_record/model/model_generator.rb#L17 The options provided to the users should be uniform. Since the term "database" is used in rake task etc, So I want to be able to use it in `dbconsole` command. Also I deprecated the `connection` option because I think that it would be confusing if there are multiple options to specify a same value.
* | | | Merge pull request #35820 from sharang-d/url-to-URL-except-actionpackRyuta Kamizono2019-04-025-8/+8
|\ \ \ \ | | | | | | | | | | url -> URL where apt except inside actionpack/
| * | | | url -> URL where apt except inside actionpack/Sharang Dashputre2019-04-015-8/+8
| | | | |
* | | | | Include final newline in generated .ruby-versionOrhan Toy2019-04-011-0/+2
|/ / / /
* | | | [ci skip] Fix typo directores -> directoriesAbhay Nikam2019-03-301-1/+1
| | | |
* | | | optimizes eager loading in :zeitwerk modeXavier Noria2019-03-301-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During initialization, the eager load paths of engines are unshifted into AS::Dependencies.autoload_paths. After that, the collection is frozen. (See the initializers in railties/lib/rails/engine.rb.) Hence, there is no eager load path that is not an autoload path too, and so the array difference in the deleted code is always an empty array. Just do nothing.
* | | | fixes eager loading edge case in :zeitwerk modeXavier Noria2019-03-301-0/+28
| |/ / |/| |
* | | Add rich_text field to model generatorsChris Oliver2019-03-283-1/+54
|/ /
* | Reword test names in credentials_test.rbSharang Dashputre2019-03-251-4/+4
| |
* | Merge pull request #35732 from rails/webdriversGuillermo Iguaran2019-03-241-2/+2
|\ \ | | | | | | Replace chromedriver-helper with webdrivers
| * | Use webdrivers instead of chromedriver-helper in new appsGuillermo Iguaran2019-03-241-2/+2
| | |
* | | Merge pull request #35723 from sikachu/disable-sandbox-flagGuillermo Iguaran2019-03-243-4/+35
|\ \ \ | |/ / |/| | Add config.disable_sandbox option to Rails console
| * | Add config.disable_sandbox option to Rails consolePrem Sichanugrist2019-03-233-4/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A long-running `rails console --sandbox` could cause a database server to become out-of-memory as it's holding on to changes that happen on the database. Given that it's common for Ruby on Rails application with huge traffic to have separate write database and read database, we should allow the developers to disable this sandbox option to prevent someone from accidentally causing the Denial-of-Service on their server.
* | | Add `secret_key_base` when creating new credential fileyuuji.yaginuma2019-03-231-1/+12
|/ / | | | | | | | | | | | | | | Since `secret_key_base` is expected to be included in credential file, `secret_key_base` should be included even if re-create the file. This is the same behavior as creating a new app. When env is specified, it may be unnecessary, so I added it only when not specifying env.
* | Fix server restart test on Puma 3.12.1yuuji.yaginuma2019-03-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | Since https://github.com/puma/puma/pull/1700, the default host is correctly used. So `localhost` is used instead of `0.0.0.0`. As a result, the log output on restart is changed, and the restart test fails on Puma 3.12.1. https://travis-ci.org/rails/rails/jobs/509239592#L2303-L2305 Specify binding explicitly to avoid being affected by Puma changes.
* | Make aliases of `database` option in generators workyuuji.yaginuma2019-03-203-0/+30
| | | | | | | | | | | | | | | | | | | | | | Thor automatically adds `-` if aliases do not start with `-`. https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L53 But Thor follows a convention of one-dash-one-letter options. So, even if `-` is added to `db`, it does not work. https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L4 Follow up #34021.
* | Fix database configuration when adding another config leveleileencodes2019-03-181-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is kind of hard to explain but if you have a database config with another level like this: ``` development: primary: database: "my db" variables: statement_timeout: 1000 ``` the database configurations code would chooke on the `variables` level because it didn't know what to do with it. We'd see the following error: ``` lib/active_record/database_configurations.rb:72:in `block in find_db_config': undefined method `env_name' for [nil]:Array (NoMethodError) ``` The problem here is that Rails does correctly identify this as not a real configuration but returns `[nil]` along with the others. We need to make sure to flatten the array and remove all the `nil`'s before returning the `configurations` objects. Fixes #35646
* | Add -e/--environment option to `rails initializers`yuuji.yaginuma2019-03-161-2/+18
| | | | | | | | This allows specifying the environment as would any other rails commands.
* | Engines are reloaded in Zeitwerk mode [closes #35618]Xavier Noria2019-03-151-14/+19
| |
* | Properly expand the environment's name in all commandsyuuji.yaginuma2019-03-153-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | Since 3777701f1380f3814bd5313b225586dec64d4104, the environment's name is automatically expanded in console and dbconsole commands. In order to match the behavior between the commands, fixes it to have the same behavior of all the commands. This behavior is defined in `EnvironmentArgument`. Since `EnvironmentArgument` also defines the environment option, it is reused. However, since desc was not content that can be used in all comments, fixed desc to be defined for each command.
* | Make application work without tmp directoryyuuji.yaginuma2019-03-141-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | The tmp directory is added to version control in the newly created application. This was added in Rails 5.0.0(https://github.com/rails/rails/commit/f06ce4c12a396795a3b2c1812951d9277bcb3a82). However, applications created before that are not guaranteed to have the tmp directory. If the tmp directory does not exist, writing to the key file raise error. This is a bit incompatible. So I fixed that create the directory before writing a key.
* | Fix secret_key_base for Railtieseileencodes2019-03-132-0/+2
| | | | | | | | | | | | This was missed in the security fix for local dev. CI doesn't have a tmp directory in the apps built for testing so these end up failing. This adds the secret_key_base so we don't need to generate one.
* | Merge tag 'v6.0.0.beta3'eileencodes2019-03-132-1/+22
|\ \ | | | | | | | | | v6.0.0.beta3 release
| * | Fix possible dev mode RCEAaron Patterson2019-03-102-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the secret_key_base is nil in dev or test generate a key from random bytes and store it in a tmp file. This prevents the app developers from having to share / checkin the secret key for dev / test but also maintains a key between app restarts in dev/test. [CVE-2019-5420] Co-Authored-By: eileencodes <eileencodes@gmail.com> Co-Authored-By: John Hawthorn <john@hawthorn.email>
* | | Add test for runner command with `environment` optionyuuji.yaginuma2019-03-131-0/+4
| | |
* | | Add additional ERB DummyCompiler testsCliff Pruitt2019-03-121-0/+54
| | | | | | | | | | | | This adds a few additional tests to the commits by eileencodes (https://github.com/rails/rails/pull/35497) and rafaelfranca (https://github.com/rails/rails/commit/cfa22f1a4b5e8b95ee01a432168de2f831b3f788). The additional tests cover several more ERB tag formatting cases such as multiline tags, conditional statements that result in duplicate keys, and multiple erb statements on a single line.
* | | Do not generate dummy string when the tag used is not the <%=Rafael Mendonça França2019-03-111-0/+1
| | |
* | | [ci skip] Minor documentation fixes for consistencyShailesh Kalamkar2019-03-091-1/+1
| | |
* | | Fix "DEPRECATION WARNING: ActionView::Template#initialize requires a locals ↵yuuji.yaginuma2019-03-091-1/+1
| | | | | | | | | | | | | | | | | | parameter" Ref: #35411
* | | Minor text changes to the db:seed:replant testsSharang Dashputre2019-03-091-2/+2
| | |
* | | Allow autoloader inflectors to be swaped outJean Boussier2019-03-081-0/+4
| | |
* | | Merge pull request #35522 from gmcgibbon/rails_db_system_change_versioningKasper Timm Hansen2019-03-081-3/+18
|\ \ \ | | | | | | | | Add version awareness to rails db:system:change
| * | | Add version awareness to rails db:system:changeGannon McGibbon2019-03-081-3/+18
| | | |
* | | | Build assets automatically if necessaryyuuji.yaginuma2019-03-081-0/+7
|/ / / | | | | | | | | | | | | | | | In CI, these are unnecessary because done by preprocessing. To test locally, you need to do it manually. If assets not exist, it will fail when a run specific test, so force to build those only when necessary.
* | | Load YAML for rake tasks without parsing ERBeileencodes2019-03-061-12/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds a new method that loads the YAML for the database config without parsing the ERB. This may seem odd but bear with me: When we added the ability to have rake tasks for multiple databases we started looping through the configurations to collect the namespaces so we could do `rake db:create:my_second_db`. See #32274. This caused a problem where if you had `Rails.config.max_threads` set in your database.yml it will blow up because the environment that defines `max_threads` isn't loaded during `rake -T`. See #35468. We tried to fix this by adding the ability to just load the YAML and ignore ERB all together but that caused a bug in GitHub's YAML loading where if you used multi-line ERB the YAML was invalid. That led us to reverting some changes in #33748. After trying to resolve this a bunch of ways `@tenderlove` came up with replacing the ERB values so that we don't need to load the environment but we also can load the YAML. This change adds a DummyCompiler for ERB that will replace all the values so we can load the database yaml and create the rake tasks. Nothing else uses this method so it's "safe". DO NOT use this method in your application. Fixes #35468
* | | Allow `truncate` for SQLite3 adapter and add `rails db:seed:replant` (#34779)Bogdan2019-03-041-1/+121
|/ / | | | | | | | | | | | | | | | | | | | | | | | | * Add `ActiveRecord::Base.connection.truncate` for SQLite3 adapter. SQLite doesn't support `TRUNCATE TABLE`, but SQLite3 adapter can support `ActiveRecord::Base.connection.truncate` by using `DELETE FROM`. `DELETE` without `WHERE` uses "The Truncate Optimization", see https://www.sqlite.org/lang_delete.html. * Add `rails db:seed:replant` that truncates database tables and loads the seeds Closes #34765
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 02:09:59 +0000