Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Run in-app rails commands via fork+load where possible | Matthew Draper | 2017-09-04 | 20 | -288/+333 | |
| | | | | | | | | | | While this avoids shell argument parsing, we still pass through everything in our stack. | |||||
* | | Explicitly require `test_unit/reporter` in test helper | yuuji.yaginuma | 2017-09-04 | 1 | -0/+6 | |
|/ | | | | | | | | | | | If the user used the `bin/test` to execute the test, this file is automatically loaded, so require is unnecessary. https://github.com/rails/rails/blob/acea68de026ba657cb65c4dd0fc1f24ba67e1cf8/railties/lib/rails/plugin/test.rb#L4 However, when using `rake test`, an explicit require is required because the above file is not loaded. Fixes #30516 | |||||
* | Don't need the layout here | Matthew Draper | 2017-09-04 | 1 | -0/+2 | |
| | ||||||
* | Preload some additional specific files | Matthew Draper | 2017-09-04 | 1 | -0/+3 | |
| | ||||||
* | Preload Rails component gems in railties tests | Matthew Draper | 2017-09-04 | 4 | -2/+22 | |
| | ||||||
* | Remove needless `silence_warnings` | yuuji.yaginuma | 2017-09-01 | 1 | -4/+1 | |
| | | | | Since ff30db1, warning is not show. | |||||
* | Merge pull request #30323 from yhirano55/support_multiple_version_for_gem_method | Matthew Draper | 2017-08-31 | 1 | -4/+11 | |
|\ | | | | | Support multiple versions arguments for `gem` method of Generators | |||||
| * | Support multiple versions arguments for `gem` method of Generators | Yoshiyuki Hirano | 2017-08-19 | 1 | -4/+11 | |
| | | ||||||
* | | Fix `can't modify frozen String` error in `DBConsole` | yuuji.yaginuma | 2017-08-29 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | Without this, `dbconsole` raises an error as follwing: ``` RuntimeError: can't modify frozen String railties/lib/rails/commands/dbconsole/dbconsole_command.rb:79:in `start' ``` | |||||
* | | Merge pull request #30370 from ↵ | Kasper Timm Hansen | 2017-08-28 | 2 | -4/+4 | |
|\ \ | | | | | | | | | | | | | yhirano55/fix_indentation_in_secrets_yaml_template Fix indentation in the template for secrets | |||||
| * | | Fix indentation in the template for secrets | Yoshiyuki Hirano | 2017-08-23 | 2 | -4/+4 | |
| | | | ||||||
* | | | Remove frozen_string_literal magic comment from templates | Koichi ITO | 2017-08-22 | 1 | -2/+0 | |
|/ / | ||||||
* / | Make `restart` and `dev:cache` tasks work when customizing pid file path | yuuji.yaginuma | 2017-08-21 | 4 | -14/+37 | |
|/ | | | | | | | | | | Originally, it hard-coded pid file path. It can not be removed when customizing pid file path. But rake task can not get pid file path. Therefore, do not remove file in rake task, makes it possible to judge whether it is restart from the argument of the command and removes the file in server command. Fixes #29306 | |||||
* | Move common tests from `AppGeneratorTest` and `PluginGeneratorTest` to ↵ | bogdanvlviv | 2017-08-17 | 3 | -200/+114 | |
| | | | | `SharedGeneratorTests` | |||||
* | Fix RuboCop offenses | Koichi ITO | 2017-08-16 | 10 | -29/+29 | |
| | | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop. | |||||
* | Add test case to make sure Parameters configuration are executed once | Rafael Mendonça França | 2017-08-15 | 1 | -0/+10 | |
| | | | | Test case for #30045 | |||||
* | Add --skip-yarn option to the plugin generator | bogdanvlviv | 2017-08-15 | 3 | -26/+34 | |
| | | | | | Add SharedGeneratorTests#application_path This method will help to DRY in files app_generator_test.rb, plugin_generator_test.rb | |||||
* | Fix typo for api_app_generator_test | Yoshiyuki Hirano | 2017-08-15 | 1 | -1/+1 | |
| | ||||||
* | Merge pull request #30219 from yhirano55/fix_app_generator_api_options | Rafael França | 2017-08-14 | 2 | -22/+41 | |
|\ | | | | | Refactor `--api` option of the app generator | |||||
| * | Refactor `--api` option of the app generator | Yoshiyuki Hirano | 2017-08-13 | 2 | -22/+41 | |
| | | | | | | | | | | It can't use JavaScript in api mode. Action cable should be disabled by default. | |||||
* | | Merge pull request #30241 from yhirano55/optimize_routes_indentation | Rafael Mendonça França | 2017-08-14 | 1 | -0/+7 | |
|\ \ | | | | | | | | | | Optimize routes indentation | |||||
| * | | Optimize routes indentation | Yoshiyuki Hirano | 2017-08-14 | 1 | -0/+7 | |
| |/ | ||||||
* | | Allow for frozen string pragma in generated files. | Pat Allan | 2017-08-14 | 1 | -2/+2 | |
| | | ||||||
* | | Add frozen string pragma to expected routes files. | Pat Allan | 2017-08-14 | 1 | -0/+2 | |
| | | ||||||
* | | Adding frozen_string_literal pragma to Railties. | Pat Allan | 2017-08-14 | 121 | -0/+242 | |
| | | ||||||
* | | Railties updates for frozen string literals. | Pat Allan | 2017-08-14 | 7 | -8/+9 | |
|/ | ||||||
* | Merge pull request #30166 from yhirano55/fix_generator_method_environment | Rafael Mendonça França | 2017-08-11 | 1 | -6/+66 | |
|\ | | | | | | | Optimize indentation for generator actions | |||||
| * | Optimize indentation for generator actions | Yoshiyuki Hirano | 2017-08-11 | 1 | -6/+66 | |
| | | ||||||
* | | Merge pull request #29559 from kirs/eager-load-controller-actions | Rafael França | 2017-08-11 | 1 | -0/+60 | |
|\ \ | | | | | | | Eager load controller actions to reduce response time of the first request | |||||
| * | | Eager load controller and mailer actions | Kir Shatrov | 2017-07-29 | 1 | -0/+60 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On the first request, ActionController::Base#action_methods computes and memoized the list of available actions [1]. With this PR we move this expensive operation into eager load step to reduce response time of the first request served in production. This also reduces the memory footprint when running on forking server like Unicorn. [1] https://github.com/rails/rails/blob/a3813dce9a0c950a4af7909111fa730a2622b1db/actionpack/lib/abstract_controller/base.rb#L66-L77 | |||||
* | | | Merge pull request #30116 from ↵ | Rafael Mendonça França | 2017-08-11 | 1 | -1/+13 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | yhirano55/skip_unused_components_when_running_rails_command_in_plugin Skip unused components when running `bin/rails` in Rails plugin | |||||
| * | | | Skip unused components when running in Rails plugin | Yoshiyuki Hirano | 2017-08-09 | 1 | -1/+13 | |
| | | | | ||||||
* | | | | Merge pull request #30105 from bogdanvlviv/remove-sorted-test_order | Rafael França | 2017-08-11 | 1 | -2/+0 | |
|\ \ \ \ | | | | | | | | | | | Remove :sorted test order for isolated tests | |||||
| * | | | | Remove :sorted test order for isolated tests | bogdanvlviv | 2017-08-07 | 1 | -2/+0 | |
| | | | | | ||||||
* | | | | | Merge pull request #30110 from yhirano55/add_git_source | Rafael Mendonça França | 2017-08-11 | 1 | -0/+5 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | Add git_source to Gemfile for plugin generator | |||||
| * | | | | | Add git_source to Gemfile for plugin generator | Yoshiyuki Hirano | 2017-08-09 | 1 | -0/+5 | |
| | |/ / / | |/| | | | ||||||
* | | | | | Refactor app_generator_test (#30192) | yhirano55 | 2017-08-11 | 1 | -1/+8 | |
| |_|_|/ |/| | | | ||||||
* | | | | `--skip-action-cable` pass throughs `rails plugin new` | bogdanvlviv | 2017-08-10 | 1 | -0/+6 | |
| | | | | ||||||
* | | | | Improve plugin generator tests. Related to #30123. | bogdanvlviv | 2017-08-10 | 2 | -44/+74 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve app generator tests. Ensure that generation `config/application.rb` is correct. Ensure that generation `config/application.rb` is correct. | |||||
* | | | | Merge pull request #30091 from yhirano55/fix_engine_command | Rafael França | 2017-08-08 | 1 | -0/+4 | |
|\ \ \ \ | | | | | | | | | | | Fix engine command | |||||
| * | | | | Fix engine command | Yoshiyuki Hirano | 2017-08-06 | 1 | -0/+4 | |
| | | | | | ||||||
* | | | | | Merge pull request #30090 from yhirano55/fix_escaped_character | Rafael França | 2017-08-08 | 1 | -1/+1 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | Fix non escaped character | |||||
| * | | | | Fix escaped character | Yoshiyuki Hirano | 2017-08-06 | 1 | -1/+1 | |
| |/ / / | ||||||
* | | | | Merge pull request #30127 from y-yagi/deprecate_support_of_older_config_ru | Rafael França | 2017-08-08 | 1 | -0/+31 | |
|\ \ \ \ | | | | | | | | | | | Deprecate support of older `config.ru` | |||||
| * | | | | Deprecate support of older `config.ru` | yuuji.yaginuma | 2017-08-08 | 1 | -0/+31 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Rails 4.0, `config.ru` generated by default uses instances of `Rails.application`. Therefore, I think that it is good to deprecate the old behavior. Related: #9669 | |||||
* / / / | ActiveStorage:Add migrations per rails engine conventions (#30111) | Dino Maric | 2017-08-08 | 1 | -2/+2 | |
|/ / / | | | | | | | | | | | | | | | | * Add migrations per rails engine conventions * Fix failing tests | |||||
* / / | Check for `app.secrets.secret_key_base`, not `app.config.secret_key_base` | George Claghorn | 2017-08-05 | 1 | -3/+1 | |
|/ / | | | | | | | By default, apps only have the former set. | |||||
* | | Merge pull request #30020 from rails/active-storage-import | David Heinemeier Hansson | 2017-08-04 | 6 | -16/+56 | |
|\ \ | | | | | | | Add Active Storage to Rails | |||||
| * | | Make sure the test fails if the code chages | Rafael Mendonça França | 2017-08-04 | 1 | -8/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | The test was passing before because it was not being testes correctly. Now we create a different engine that is loaded before the already exising and we make sure that the first call for isolate_namespace is what takes effect. | |||||
| * | | Do not call isolate_namespace on the application | Rafael Mendonça França | 2017-08-04 | 1 | -1/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | What we want to test is that two different calls to isolate_namespace with the same module doesn't change the original railtie. We can do that defining two different railties. We can't call in the application because this method is not supposed to be called in an Application class. |