aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix / improve some assertionsCarlos Antonio da Silva2014-07-301-6/+4
|
* Remove some globals from configuration testsCarlos Antonio da Silva2014-07-301-20/+20
|
* Deprecate `*_path` methods in mailers@schneems and @sgrif2014-07-302-2/+54
| | | | | | | | | | | Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems
* Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require"Santiago Pastorino2014-07-302-2/+2
| | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343
* Remove mocha usageRafael Mendonça França2014-07-231-2/+5
|
* Merge pull request #16267 from robin850/rbx-yamlRafael Mendonça França2014-07-231-0/+13
|\ | | | | Set Psych as the YAML engine for Rubinius
| * Set Psych as the YAML engine for RubiniusRobin Dupret2014-07-231-0/+13
| | | | | | | | | | | | | | | | | | | | Since the rubysl-yaml gem doesn't ship with Psych by default because of its dependency on libyaml, on Rubinius, the default engine is Syck. However, if we want to be able to run the application safely on different rubies, we need to make people using Rubinius rely on Psych. See http://git.io/uuLVag for further information.
* | Do not set enforce_available_locales to i18n 0.7Rafael Mendonça França2014-07-231-18/+2
|/ | | | | | Now the default is always true. Users still can set it using config.i18n.enforce_available_locales.
* Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-1912-77/+166
|\ | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| * Stop requiring mocha automaticallyRafael Mendonça França2014-07-197-0/+7
| | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
| * Stop using mocha on dbconsole_testRafael Mendonça França2014-07-151-44/+68
| |
| * Stop using mocha on console_testRafael Mendonça França2014-07-071-15/+40
| |
| * Set the application logger using configurationRafael Mendonça França2014-07-071-3/+5
| |
| * Stop using mocha on configuration_testRafael Mendonça França2014-07-071-7/+23
| |
| * Stop using mocha on app_rails_loader_testRafael Mendonça França2014-07-071-8/+23
| |
* | Keep quietly and capture undeprecated on your suiteRafael Mendonça França2014-07-155-2/+60
| |
* | Add Rails::Application#config_forRafael Mendonça França2014-07-151-0/+84
| | | | | | | | | | This is a convenience for loading configuration for the current Rails environment.
* | Fix incorrect unsubscription.Guo Xiang Tan2014-07-111-2/+2
|/
* Display notice in index.html pages in scaffolded generated viewsArun Agrawal2014-07-042-1/+9
| | | | | | | | | As we are setting notice in destroy action we should display that For more information see https://github.com/rails/rails/pull/14044 And https://github.com/rails/jbuilder/pull/191 closes #14044
* Revert "Merge pull request #15394 from ↵Rafael Mendonça França2014-07-021-90/+1
| | | | | | | | | | morgoth/fix-automatic-maintaining-test-schema-for-sql-format" This reverts commit 46139d33c06715e74ad450428ece3ee84da98579, reversing changes made to 8f247871bb18b2e3036a05df5f62cbfe3b402586. Conflicts: activerecord/CHANGELOG.md
* Rename preview_enabled option to show_previewsRafael Mendonça França2014-07-012-10/+10
|
* Add configuration to enable mail previewsLeonard Garvey2014-07-012-0/+38
| | | | | | | | | | | | | | | | | | Adds `config.action_mailer.preview_enabled` This allows mail previewing to be enabled easily in non-development environments such as staging. The default is set to true for development so no changes should be required to existing Rails applications. The mail preview path can still be configured using the existing `config.action_mailer.preview_path` configuration option. Adding this avoids devs from having to do stuff like: https://gist.github.com/lengarvey/fa2c9bd6cdbeba96526a Update actionmailer/CHANGELOG with new configuration. Update configuring guide with new configuratation. Add `config.action_mailer.preview_path` to configuring guide.
* Merge pull request #15933 from rafael/masterRafael Mendonça França2014-06-271-0/+38
|\ | | | | | | | | | | Add always permitted parameters as a configurable option. [Rafael Mendonça França + Gary S. Weaver]
| * Improvements per code review.Rafael Chacón2014-06-271-0/+25
| | | | | | | | | | | | * General style fixes. * Add changes to configuration guide. * Add missing tests.
| * Add always_permitted_parameters as an option.Rafael Chacón2014-06-261-0/+13
| | | | | | | | | | | | | | | | | | * This commit adds back the always_permitted_parameters configuration option to strong paramaters. * The initial pull requests where this feature was added are the following: - https://github.com/rails/rails/pull/12682 - https://github.com/rails/strong_parameters/pull/174
* | Add a test for db:migrate:status to check missing file scenarioViktar Basharymau2014-06-271-0/+15
| |
* | Add a '--skip-routes' flag for the Controller generator.Lucas Mazza2014-06-241-0/+7
| | | | | | | | | | This way it is possible to skip the addition of the 'get "foo/bar"' routes when generating a controller.
* | initialize the right variableRafael Mendonça França2014-06-171-1/+1
| |
* | Add a generic --skip-gems options to generatorRafael Mendonça França2014-06-171-2/+3
| | | | | | | | | | | | | | | | | | | | Also remove --skip-turbolinks. This option is useful if users want to remove some gems like jbuilder, turbolinks, coffee-rails, etc that don't have specific options on the generator. rails new my_app --skip-gems turbolinks coffee-rails
* | Merge pull request #15716 from schuetzm/skip-turbolinksRafael Mendonça França2014-06-171-0/+14
|\ \ | | | | | | Add an option to skip installation of Turbolinks
| * | Add an option to skip installation of TurbolinksMarc Schütz2014-06-141-0/+14
| | |
* | | allow preview interceptors to be registered through `config.action_mailer`.Yves Senn2014-06-151-0/+32
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was partially broken because `preview_interceptors=` just assigned the raw values, whithout going through `register_preview_interceptor`. Now the Action Mailer railtie takes care of the `preview_interceptors` option. This commit is a partial revert of: Revert "Merge pull request #15739 from y-yagi/correct_doc_for_action_mailer_base" This reverts commit a15704d7f35f17d34d0118546799141d6f853656, reversing changes made to 1bd12a8609d275ad75fcc4b622ca4f5b32dc76be. /cc @kuldeepaggarwal @y-yagi
* | Merge pull request #15394 from ↵Yves Senn2014-06-121-1/+90
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | morgoth/fix-automatic-maintaining-test-schema-for-sql-format ActiveRecord::Migration.maintain_test_schema! doesn't work with structure.sql Conflicts: activerecord/CHANGELOG.md
| * | Fixed automatic maintaining test schema to properly handle sql structure ↵Wojciech Wnętrzak2014-06-121-2/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | schema format. Additionally: * It changes `purge` task on `sqlite3` adapter to recreate database file, to be consistent with other adapters. * Adds `purge` step when loading from `schema.rb`
| * | Added missing test case for migrations when using sql structureWojciech Wnętrzak2014-06-011-1/+40
| | |
* | | remove unnused method from testFabian Rodriguez2014-06-111-10/+0
| | |
* | | Emit suggested generator names when not foundschneems2014-06-041-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When someone types in a generator command it currently outputs all generators. Instead we can attempt to find a subtle mis-spelling by running all generator names through a levenshtein_distance algorithm provided by rubygems. So now a failure looks like this: ```ruby $ rails generate migratioooons Could not find generator 'migratioooons'. Maybe you meant 'migration' or 'integration_test' or 'generator' Run `rails generate --help` for more options. ``` If the suggestions are bad we leave the user with the hint to run `rails generate --help` to see all commands.
* | | Merge pull request #14881 from robin850/patch-19Yves Senn2014-06-011-5/+8
|\ \ \ | |/ / |/| | Swallow bundler exceptions when running tests
| * | Swallow bundler exceptions when running testsRobin Dupret2014-04-271-5/+8
| | | | | | | | | | | | Let's avoid useless output when testing stuff related to Bundler.
* | | `bin/setup` script to bootstrap applications.Yves Senn2014-05-301-0/+1
| | |
* | | Merge pull request #15269 from arunagw/aa-fixes-8930Rafael Mendonça França2014-05-271-0/+32
|\ \ \ | | | | | | | | rake railties:install:migrations respects the order of railties
| * | | rake railties:install:migrations respects the order of railtiesArun Agrawal2014-05-271-0/+32
| | | | | | | | | | | | | | | | This PR fixes #8930 and some stuff from #8985
* | | | Merge pull request #15327 from alexbel/replace_double_quotes_with_single_quotesYves Senn2014-05-271-7/+15
|\ \ \ \ | | | | | | | | | | | | | | | Replace double quotes with single quotes while adding an entry into Gemfile
| * | | | Replace double quotes with single quotes while adding an entry into Gemfilealexbel2014-05-261-7/+7
|/ / / /
* | | | Merge pull request #15294 from schneems/schneems/generator-output-in-error2Rafael Mendonça França2014-05-261-2/+4
|\ \ \ \ | | | | | | | | | | print generators on failed generate
| * | | | print generators on failed generateschneems2014-05-261-2/+4
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Let's say we just ran: ``` $ rails g migrate add_click_to_issue_assignment ``` We will get an error that looks like: ``` Could not find generator migrate. ``` This patch adds all existing migrations to the output to make it easier for a developer to find a valid migration. ``` Could not find generator "migrate". Please select a valid generator: Rails: assets controller generator helper integration_test mailer migration model resource scaffold scaffold_controller task ``` It would be nice to do some spelling detection and suggest alternatives, but for now this should help.
* / / / Remove unnecessary require of Minitest.Guo Xiang Tan2014-05-242-2/+2
|/ / / | | | | | | | | | Minitest has already been required when calling Minitest.autorun.
* | | Default config.assets.digests to true in developmentDan Kang2014-05-172-14/+13
| | |
* | | New applications should be created with json serializerRafael Mendonça França2014-05-171-0/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fix introduced at 75ba7425f6d235f254c00a45a58f42e88f80301a were missing this case. To fix the original issue mentioned at that commit the correct is to remove update_config_files from the command list since we should not run both config_files command when creating a new application. Tests were added to make sure everything is working fine.
* | | Fix app generator test hanging.Christian Wesselhoeft2014-05-171-2/+2
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-17 18:04:31 +0000