aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge pull request #26515 from grosser/grosser/after_runArthur Nogueira Neves2016-09-231-1/+33
|\ | | | | support minitest after_run
| * support minitest after_run for parity to regular minitestMichael Grosser2016-09-161-0/+18
| | | | | | | | see https://github.com/seattlerb/minitest/blob/f9605387e4af7d657921a83aaf0ae364f6d26a57/lib/minitest.rb#L51-L65
| * improve test coverageMichael Grosser2016-09-161-2/+16
| |
* | use rails command in restart task testyuuji.yaginuma2016-09-191-7/+7
| |
* | improve error message when include assertions failMichael Grosser2016-09-1613-50/+50
|/ | | | | | assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
* Merge pull request #26469 from y-yagi/remove_useless_optionRafael França2016-09-141-5/+0
|\ | | | | remove useless `gemfile` option
| * remove useless `gemfile` optionyuuji.yaginuma2016-09-121-5/+0
| | | | | | | | | | | | | | Rails application for test creates with `--skip-gemfile` option. https://github.com/rails/rails/blob/master/railties/test/isolation/abstract_unit.rb#L333 Therefore, regardless of the option, Gemfile is not created.
* | fix broken generators testyuuji.yaginuma2016-09-142-2/+2
|/ | | | Follow up to 92703a9ea5d8b96f30e0b706b801c9185ef14f0e
* use correct Gemfile in `bin/setup` testyuuji.yaginuma2016-09-111-0/+18
| | | | | | | Currently, `bin/setup` test uses Gemfile of Rails. But this Gemfile is not a file to be used in Rails application. Add a Gemfile to Rails application that is created for test, it has been modified to use the Gemfile.
* fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-011-8/+8
|
* Fix styleschneems2016-08-301-26/+26
|
* Address comment via @dhh, better option namingschneems2016-08-301-4/+4
|
* Thanks rubocopschneems2016-08-291-1/+1
|
* Favor `public_folder: true` over `public_*`schneems2016-08-291-25/+44
| | | | Adding all those `public_*` methods is a bit heavy handed, we can change the API to instead use `public_folder: true`. Change was pretty easy since it was already implemented that way.
* Fix formattingschneems2016-08-291-3/+3
|
* Add `public_*` helpers to all the `_tag` methods.schneems2016-08-291-9/+15
|
* Test `public_` methods.schneems2016-08-291-0/+72
|
* run `before_configuration` callbacks as soon as application constant ↵yuuji.yaginuma2016-08-191-0/+7
| | | | | | | | | | | | | inherits from Rails::Application Until Rails 4.1, `before_configuration` run as soon as the application constant inherits from `Rails::Application`. However, in d25fe31c40928712b5e08fe0afb567c3bc88eddf, it has been modified to run at instantiation process. This modify to `before_configuration` is run at same timing as to Rails 4.1. Fixes #19880
* Merge pull request #26157 from ↵Rafael França2016-08-161-0/+1
|\ | | | | | | | | y-yagi/remove_test_mailers_when_skipping_action-mailer remove "test/mailers" directory when skipping action-mailer
| * remove "test/mailers" directory when skipping action-maileryuuji.yaginuma2016-08-141-0/+1
| | | | | | | | Related to #26146
* | Merge pull request #26130 from yui-knk/drop_tableRafael França2016-08-161-1/+3
|\ \ | | | | | | Drop a temporary table before end of a test case
| * | Drop a temporary table before end of a test caseyui-knk2016-08-141-1/+3
| | |
* | | Add three new rubocop rulesRafael Mendonça França2016-08-1626-86/+86
| |/ |/| | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* | Ensure app/mailers is removed when skipping action-mailerBrian Cardarella2016-08-121-0/+1
|/ | | | Closes #26145
* Integration test to prevent regression for the 5th timeAaron Patterson2016-08-111-0/+47
| | | | | | | | Fix unsafe query generation risk. Redo of CVE-2012-2660, CVE-2012-2694 and CVE-2013-0155 CVE-2016-6317
* add missing require rakeyuuji.yaginuma2016-08-111-0/+24
| | | | | In ff8035dfeed8c86594c32ef8e9204806e190cb58, require rake is deferred. Therefore, it is necessary to require rake even `Engine::CommandsTasks.
* code gardening: removes redundant selfsXavier Noria2016-08-081-1/+1
| | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
* applies project convention for string literalsXavier Noria2016-08-071-1/+1
|
* Merge pull request #24260 from ↵Kasper Timm Hansen2016-08-071-4/+6
|\ | | | | | | | | y-yagi/show_error_message_when_error_raised_in_rails_runner show error message when error raised in rails runner
| * show error message when error raised in rails runneryuuji.yaginuma2016-08-031-4/+6
| |
* | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-075-7/+0
| |
* | applies remaining conventions across the projectXavier Noria2016-08-067-9/+1
| |
* | normalizes indentation and whitespace across the projectXavier Noria2016-08-0617-231/+231
| |
* | remove redundant curlies from hash argumentsXavier Noria2016-08-066-20/+20
| |
* | modernizes hash syntax in railtiesXavier Noria2016-08-064-9/+9
| |
* | applies new string literal convention in railties/testXavier Noria2016-08-0695-1595/+1595
|/ | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* remove unnecessary require and extendyuuji.yaginuma2016-07-311-8/+0
| | | | | | | | `rack/test` is require at the top of file. https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L3 In addtion, `Rack::Test::Methods` is include in class, extend is unnecessary. https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L9
* There are some cases where @@app is not definedSantiago Pastorino2016-07-261-0/+28
|
* A generated app should not include Uglifier with `--skip-javascript` option.Ben Pickles2016-07-261-0/+5
|
* Enforce minimal web-console version for Rails 5Genadi Samokovarov2016-07-211-2/+2
| | | | | | | | | | | | | | | I dropped the version constraint in web-console with the idea it will be easier to upgrade the console between Rails releases. However, issues like #25899 started popping up. I'm reintroducing the constraint, but this time, I don't set an upper limit to the major version. This will keep the web-console in a version that always works for the current Rails version and can be easily upgraded to the last one with `bundle update`. We may need to backport this for Rails 5.0.1. Fixes #25899.
* Merge pull request #25438 from prathamesh-sonpatki/rm-session-store-initializerRafael Mendonça França2016-07-203-11/+16
|\ | | | | | | Setup default session store internally, no longer through an initializer
| * Setup default session store internally, no longer through an application ↵Prathamesh Sonpatki2016-07-173-11/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | initializer - By default the session store will be set to cookie store with application name as session key. - Older apps are not affected as they will have the session store initializer generated by Rails in older versions, and Rails will not overwrite the session store if it is already set or disabled. - But new apps will not have the initializer, instead the session store will be set to cookie store by default. - Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
* | Fix typo in mailer previews test description [ci skip]Gale Shafer2016-07-141-1/+1
| | | | | | | | | | A mailer preview test description misspelled the word configuration. This commit updates the test description to spell the word correctly.
* | rails -> Rails [ci skip]Santosh Wadghule2016-07-122-2/+2
| |
* | remove unnecessary sendyuuji.yaginuma2016-07-101-5/+5
|/ | | | | `class_variable_get` is public from Ruby 1.9. Ref: http://ruby-doc.org/core-2.2.0/Module.html#method-i-class_variable_get
* Merge pull request #25652 from prathamesh-sonpatki/rm-boot-railsGuillermo Iguaran2016-07-0838-46/+3
|\ | | | | Remove unused boot_rails method and it's usage
| * Remove unused boot_rails method and it's usagePrathamesh Sonpatki2016-07-0438-46/+3
| | | | | | | | | | - The `boot_rails` method from abstract_unit.rb is empty after 2abcdfd978fdcd491576a237e8c6b. - So let's remove it and its usage.
* | Merge pull request #25688 from mahnunchik/host-env-varGuillermo Iguaran2016-07-081-0/+7
|\ \ | | | | | | Use the HOST environment variable for rails server #25677
| * | Use the HOST environment variable for rails server #25677Evgeny Vlasenko2016-07-051-0/+7
| |/
* | Merge pull request #25730 from prathamesh-sonpatki/rm-cookie-onlyRafael França2016-07-071-0/+6
|\ \ | | | | | | No need to set `cookie_only` option from Rails
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 17:39:58 +0000