aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | Add key rotation message Encryptor and VerifierMichael Coyne2017-09-231-0/+143
| | | | | | | | | | | | Both classes now have a rotate method where new instances are added for each call. When decryption or verification fails the next rotation instance is tried.
* | Use `TOPLEVEL_BINDING` in rails runner commandyuuji.yaginuma2017-09-221-0/+12
| | | | | | | | | | | | | | | | | | Binding to capture the local scope. This means that if a constant with same name as constant specified by the user exists in local scope, constant defined in local will use. This is different from what the user expects. Therefore, fixed to use top-level binding instead of local scope. Fixes #30644
* | Merge pull request #30609 from y-yagi/add_tests_for_credentials_commandKasper Timm Hansen2017-09-171-0/+19
|\ \ | | | | | | Add tests for credentials command
| * | Add tests for credentials commandyuuji.yaginuma2017-09-151-0/+19
| | |
* | | Don't expose Active Storage routesyuuji.yaginuma2017-09-161-28/+13
|/ / | | | | | | | | | | | | These routes are only used internally in Active Storage, and it seems that there is no need for the user to directly use them. Therefore, I think that routes should not be exposed to users.
* | Merge pull request #30581 from y-yagi/do_not_add_master_key_twice_to_gitignoreKasper Timm Hansen2017-09-141-0/+30
|\ \ | | | | | | Make master key added to gitignore the same value as when creating appplication
| * | Make master key added to gitignore the same value as when creating appplicationyuuji.yaginuma2017-09-141-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | For gitignore generated by `rails new`, key with a leading slash is specified. https://github.com/rails/rails/blob/69f976b859cae7f9d050152103da018b7f5dda6d/railties/lib/rails/generators/rails/app/templates/gitignore#L11 Therefore, when executing `credentials:edit`, also need leading slack. In order to avoid such a difference, fixed to use same method for `rails new` and `credentials:edit`.
* | | Use escaped character in regexpyhirano552017-09-111-1/+1
|/ /
* | Add credentials using a generic EncryptedConfiguration class (#30067)David Heinemeier Hansson2017-09-1111-93/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * WIP: Add credentials using a generic EncryptedConfiguration class This is sketch code so far. * Flesh out EncryptedConfiguration and test it * Better name * Add command and generator for credentials * Use the Pathnames * Extract EncryptedFile from EncryptedConfiguration and add serializers * Test EncryptedFile * Extract serializer validation * Stress the point about losing comments * Allow encrypted configuration to be read without parsing for display * Use credentials by default and base them on the master key * Derive secret_key_base in test/dev, source it from credentials in other envs And document the usage. * Document the new credentials setup * Stop generating the secrets.yml file now that we have credentials * Document what we should have instead Still need to make it happen, tho. * [ci skip] Keep wording to `key base`; prefer defaults. Usually we say we change defaults, not "spec" out a release. Can't use backticks in our sdoc generated documentation either. * Abstract away OpenSSL; prefer MessageEncryptor. * Spare needless new when raising. * Encrypted file test shouldn't depend on subclass. * [ci skip] Some woordings. * Ditch serializer future coding. * I said flip it. Flip it good. * [ci skip] Move require_master_key to the real production.rb. * Add require_master_key to abort the boot process. In case the master key is required in a certain environment we should inspect that the key is there and abort if it isn't. * Print missing key message and exit immediately. Spares us a lengthy backtrace and prevents further execution. I've verified the behavior in a test app, but couldn't figure the test out as loading the app just exits immediately with: ``` /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `load': marshal data too short (ArgumentError) from /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `run' from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest.rb:830:in `run_one_method' from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest/parallel.rb:32:in `block (2 levels) in start' ``` It's likely we need to capture and prevent the exit somehow. Kernel.stub(:exit) didn't work. Leaving it for tomorrow. * Fix require_master_key config test. Loading the app would trigger the `exit 1` per require_master_key's semantics, which then aborted the test. Fork and wait for the child process to finish, then inspect the exit status. Also check we aborted because of a missing master key, so something else didn't just abort the boot. Much <3 to @tenderlove for the tip. * Support reading/writing configs via methods. * Skip needless deep symbolizing. * Remove save; test config reader elsewhere. * Move secret_key_base check to when we're reading it. Otherwise we'll abort too soon since we don't assign the secret_key_base to secrets anymore. * Add missing string literal comments; require unneeded yaml require. * ya ya ya, rubocop. * Add master_key/credentials after bundle. Then we can reuse the existing message on `rails new bc4`. It'll look like: ``` Using web-console 3.5.1 from https://github.com/rails/web-console.git (at master@ce985eb) Using rails 5.2.0.alpha from source at `/Users/kasperhansen/Documents/code/rails` Using sass-rails 5.0.6 Bundle complete! 16 Gemfile dependencies, 72 gems now installed. Use `bundle info [gemname]` to see where a bundled gem is installed. Adding config/master.key to store the master encryption key: 97070158c44b4675b876373a6bc9d5a0 Save this in a password manager your team can access. If you lose the key, no one, including you, can access anything encrypted with it. create config/master.key ``` And that'll be executed even if `--skip-bundle` was passed. * Ensure test app has secret_key_base. * Assign secret_key_base to app or omit. * Merge noise * Split options for dynamic delegation into its own method and use deep symbols to make it work * Update error to point to credentials instead * Appease Rubocop * Validate secret_key_base when reading it. Instead of relying on the validation in key_generator move that into secret_key_base itself. * Fix generator and secrets test. Manually add config.read_encrypted_secrets since it's not there by default anymore. Move mentions of config/secrets.yml to config/credentials.yml.enc. * Remove files I have no idea how they got here. * [ci skip] swap secrets for credentials. * [ci skip] And now, changelogs are coming.
* | Remove needless `silence_warnings`yuuji.yaginuma2017-09-093-17/+3
| | | | | | | | Since ff30db1, warning is not shown.
* | Remove unused `fork` arg for `rails`yuuji.yaginuma2017-09-081-4/+2
| |
* | Reorganize secrets test to use only `isolation/abstract_unit`yuuji.yaginuma2017-09-071-14/+18
| | | | | | | | | | | | | | | | Currently, secrets test uses `abstract_unit` and `isolation/abstract_unit`. This is a bit odd. Therefore, reorganize it so that use only `isolation/abstract_unit`. Context: https://github.com/rails/rails/pull/30520#issuecomment-327409586
* | Merge pull request #30520 from rails/railties-rails-commandMatthew Draper2017-09-0520-288/+333
|\ \ | | | | | | Run in-app rails commands via fork+load where possible
| * | Run in-app rails commands via fork+load where possibleMatthew Draper2017-09-0420-288/+333
| | | | | | | | | | | | | | | While this avoids shell argument parsing, we still pass through everything in our stack.
* | | Explicitly require `test_unit/reporter` in test helperyuuji.yaginuma2017-09-041-0/+6
|/ / | | | | | | | | | | | | | | | | | | | | If the user used the `bin/test` to execute the test, this file is automatically loaded, so require is unnecessary. https://github.com/rails/rails/blob/acea68de026ba657cb65c4dd0fc1f24ba67e1cf8/railties/lib/rails/plugin/test.rb#L4 However, when using `rake test`, an explicit require is required because the above file is not loaded. Fixes #30516
* | Don't need the layout hereMatthew Draper2017-09-041-0/+2
| |
* | Preload some additional specific filesMatthew Draper2017-09-041-0/+3
| |
* | Preload Rails component gems in railties testsMatthew Draper2017-09-044-2/+22
| |
* | Remove needless `silence_warnings`yuuji.yaginuma2017-09-011-4/+1
| | | | | | | | Since ff30db1, warning is not show.
* | Merge pull request #30323 from yhirano55/support_multiple_version_for_gem_methodMatthew Draper2017-08-311-4/+11
|\ \ | | | | | | Support multiple versions arguments for `gem` method of Generators
| * | Support multiple versions arguments for `gem` method of GeneratorsYoshiyuki Hirano2017-08-191-4/+11
| | |
* | | Fix `can't modify frozen String` error in `DBConsole`yuuji.yaginuma2017-08-291-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | Without this, `dbconsole` raises an error as follwing: ``` RuntimeError: can't modify frozen String railties/lib/rails/commands/dbconsole/dbconsole_command.rb:79:in `start' ```
* | | Merge pull request #30370 from ↵Kasper Timm Hansen2017-08-282-4/+4
|\ \ \ | | | | | | | | | | | | | | | | yhirano55/fix_indentation_in_secrets_yaml_template Fix indentation in the template for secrets
| * | | Fix indentation in the template for secretsYoshiyuki Hirano2017-08-232-4/+4
| | | |
* | | | Remove frozen_string_literal magic comment from templatesKoichi ITO2017-08-221-2/+0
|/ / /
* / / Make `restart` and `dev:cache` tasks work when customizing pid file pathyuuji.yaginuma2017-08-214-14/+37
|/ / | | | | | | | | | | | | | | | | | | Originally, it hard-coded pid file path. It can not be removed when customizing pid file path. But rake task can not get pid file path. Therefore, do not remove file in rake task, makes it possible to judge whether it is restart from the argument of the command and removes the file in server command. Fixes #29306
* | Move common tests from `AppGeneratorTest` and `PluginGeneratorTest` to ↵bogdanvlviv2017-08-173-200/+114
| | | | | | | | `SharedGeneratorTests`
* | Fix RuboCop offensesKoichi ITO2017-08-1610-29/+29
| | | | | | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* | Add test case to make sure Parameters configuration are executed onceRafael Mendonça França2017-08-151-0/+10
| | | | | | | | Test case for #30045
* | Add --skip-yarn option to the plugin generatorbogdanvlviv2017-08-153-26/+34
| | | | | | | | | | Add SharedGeneratorTests#application_path This method will help to DRY in files app_generator_test.rb, plugin_generator_test.rb
* | Fix typo for api_app_generator_testYoshiyuki Hirano2017-08-151-1/+1
| |
* | Merge pull request #30219 from yhirano55/fix_app_generator_api_optionsRafael França2017-08-142-22/+41
|\ \ | | | | | | Refactor `--api` option of the app generator
| * | Refactor `--api` option of the app generatorYoshiyuki Hirano2017-08-132-22/+41
| | | | | | | | | | | | | | | It can't use JavaScript in api mode. Action cable should be disabled by default.
* | | Merge pull request #30241 from yhirano55/optimize_routes_indentationRafael Mendonça França2017-08-141-0/+7
|\ \ \ | | | | | | | | | | | | Optimize routes indentation
| * | | Optimize routes indentationYoshiyuki Hirano2017-08-141-0/+7
| |/ /
* | | Allow for frozen string pragma in generated files.Pat Allan2017-08-141-2/+2
| | |
* | | Add frozen string pragma to expected routes files.Pat Allan2017-08-141-0/+2
| | |
* | | Adding frozen_string_literal pragma to Railties.Pat Allan2017-08-14121-0/+242
| | |
* | | Railties updates for frozen string literals.Pat Allan2017-08-147-8/+9
|/ /
* | Merge pull request #30166 from yhirano55/fix_generator_method_environmentRafael Mendonça França2017-08-111-6/+66
|\ \ | | | | | | | | | Optimize indentation for generator actions
| * | Optimize indentation for generator actionsYoshiyuki Hirano2017-08-111-6/+66
| | |
* | | Merge pull request #29559 from kirs/eager-load-controller-actionsRafael França2017-08-111-0/+60
|\ \ \ | | | | | | | | Eager load controller actions to reduce response time of the first request
| * | | Eager load controller and mailer actionsKir Shatrov2017-07-291-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On the first request, ActionController::Base#action_methods computes and memoized the list of available actions [1]. With this PR we move this expensive operation into eager load step to reduce response time of the first request served in production. This also reduces the memory footprint when running on forking server like Unicorn. [1] https://github.com/rails/rails/blob/a3813dce9a0c950a4af7909111fa730a2622b1db/actionpack/lib/abstract_controller/base.rb#L66-L77
* | | | Merge pull request #30116 from ↵Rafael Mendonça França2017-08-111-1/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | yhirano55/skip_unused_components_when_running_rails_command_in_plugin Skip unused components when running `bin/rails` in Rails plugin
| * | | | Skip unused components when running in Rails pluginYoshiyuki Hirano2017-08-091-1/+13
| | | | |
* | | | | Merge pull request #30105 from bogdanvlviv/remove-sorted-test_orderRafael França2017-08-111-2/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove :sorted test order for isolated tests
| * | | | | Remove :sorted test order for isolated testsbogdanvlviv2017-08-071-2/+0
| | | | | |
* | | | | | Merge pull request #30110 from yhirano55/add_git_sourceRafael Mendonça França2017-08-111-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Add git_source to Gemfile for plugin generator
| * | | | | | Add git_source to Gemfile for plugin generatorYoshiyuki Hirano2017-08-091-0/+5
| | |/ / / / | |/| | | |
* | | | | | Refactor app_generator_test (#30192)yhirano552017-08-111-1/+8
| |_|_|/ / |/| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 12:21:10 +0000