aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #27605 from ↵Godfrey Chan2017-02-141-0/+20
|\ | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine-take-2 Fix generator command for nested (namespaced) rails engine (take 2)
| * Fix generator command for nested (namespaced) rails engine (take 2)Fumiaki MATSUSHIMA2017-01-071-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rewrite https://github.com/rails/rails/pull/27550 085546df45 was reverted (b6ffb5efcb) because it change the return of `namespaced_path` from String to Array. ---------------- If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
* | Remove unused requireRyuta Kamizono2017-02-122-2/+0
| | | | | | | | | | | | These files are not using `strip_heredoc`. Closes #27976
* | remove `ActiveSupport.halt_callback_chains_on_return_false` from everywhereyuuji.yaginuma2017-02-081-1/+0
| |
* | Correct spellingBenjamin Fleischer2017-02-051-2/+2
| | | | | | | | | | | | | | ``` go get -u github.com/client9/misspell/cmd/misspell misspell -w -error -source=text . ```
* | Merge pull request #27802 from domcleal/27801-multiple-rake-testsKasper Timm Hansen2017-02-051-0/+15
|\ \ | | | | | | Collect all file patterns when running multiple rake test tasks
| * | Collect all file patterns when running multiple rake test tasksDominic Cleal2017-02-041-0/+15
| | | | | | | | | | | | | | | | | | | | | Replaces the rake_patterns instance variable with simple require, as `autorun` will run tests from all eagerly required test files. Fixes #27801
* | | Ignore yarn error log fileyuuji.yaginuma2017-02-031-0/+5
|/ /
* | Don't mutate raw_source in mailer preview interceptorEugene Kenny2017-01-301-0/+34
| | | | | | | | | | | | | | | | The raw_source method is documented as returning the exact value that was used to create the body; mutating it breaks that contract. Additionally, if the value used to create the body is blank, raw_source returns a frozen string which causes the interceptor to raise an error.
* | Merge pull request #27797 from y-yagi/correctly_check_error_messageArthur Nogueira Neves2017-01-301-2/+4
|\ \ | | | | | | correctly check error message
| * | correctly check error messageyuuji.yaginuma2017-01-251-2/+4
| | | | | | | | | | | | | | | | | | | | | `assert_raise` does not check error message. However, in some tests, it seems like expecting error message checking with `assert_raise`. Instead of specifying an error message in `assert_raise`, modify to use another assert to check the error message.
* | | Merge pull request #27784 from y-yagi/add_warnings_option_to_test_runnerRafael França2017-01-302-0/+22
|\ \ \ | | | | | | | | add warnings option to test runner
| * | | add warnings option to test runneryuuji.yaginuma2017-01-242-0/+22
| | | |
* | | | remove warning from `bin/setup` testyuuji.yaginuma2017-01-261-1/+1
| |/ / |/| | | | | | | | | | | | | | | | | | | | This removes the following warnings. ``` test/application/bin_setup_test.rb:43: warning: ambiguous first argument; put parentheses or a space even after `/' operator ```
* | | Bundler 1.14 compatMatthew Draper2017-01-231-1/+4
| | |
* | | do not run `git init` when specify the `pretend` optionyuuji.yaginuma2017-01-231-0/+1
|/ / | | | | | | | | When specifying the `pretend` option, expect that no processing will be done, so do not execute `git init` as well.
* | Merge two tests that needs to initialize Rails before accessing `Rails`Akira Matsuda2017-01-231-16/+1
| | | | | | | | | | Fixes "NameError: uninitialized constant ApplicationTests::ConfigurationTests::CustomTest::Rails" when run individually
* | update CREATE TABLE statements generated by `sqlite3` commandyuuji.yaginuma2017-01-191-2/+2
| | | | | | | | | | | | | | From SQLite 3.16.0, `IF NOT EXISTS` set to CREATE TABLE statements. Ref: https://www.sqlite.org/src/info/c7021960f5c070fb Fixes #27635.
* | Merge pull request #27632 from dixpac/repo_initializeRafael Mendonça França2017-01-182-2/+8
|\ \ | | | | | | | | | Initalize git repo when creatin new rails app
| * | Initalize git repo when creatin new rails appdixpac2017-01-122-2/+8
| | | | | | | | | | | | | | | * If `--skip-git` is not specified initalize git repo when creating new rails app
* | | Move config reset to ensure blockAndrew White2017-01-171-1/+2
| | | | | | | | | | | | We don't want to leak the extra migration path to other railties tests.
* | | Move config reset to ensure blockAndrew White2017-01-171-1/+2
| | | | | | | | | | | | We don't want to leak the extra migration path to other railties tests.
* | | Merge pull request #27674 from kjg/migration_generator_honor_path_configAndrew White2017-01-172-0/+20
|\ \ \ | | | | | | | | Generate migrations at path set by `config.paths["db/migrate"]`
| * | | Generate migrations at path set by `config.paths["db/migrate"]`Kevin Glowacz2017-01-162-0/+20
| | | |
* | | | Don't pollute Object with rubinius_skip and jruby_skipAkira Matsuda2017-01-171-9/+9
|/ / / | | | | | | | | | we call them only in the tests
* | | Merge pull request #27601 from y-yagi/make_work_all_commands_from_engineKasper Timm Hansen2017-01-154-27/+100
|\ \ \ | | | | | | | | Make all rails commands work in engine
| * | | improve server default options testyuuji.yaginuma2017-01-091-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This test was added in 221b4ae. 221b4ae modified to return the same result even if `Rails::Server#default_options` is called more than once. Therefore, also use `Rails::Server#default_options` instead of `ServerCommand#default_options` in test.
| * | | make all rails commands work in engineyuuji.yaginuma2017-01-093-24/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, all rails commands can be executed in engine, but `server`, `console`, `dbconsole` and `runner` do not work. This make all rails commands work in engine. Related to #22588
* | | | class Foo < Struct.new(:x) creates an extra unneeded anonymous classAkira Matsuda2017-01-131-1/+1
| |/ / |/| | | | | | | | because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
* | | Revert "Merge pull request #27619 from dixpac/add_missing_generator_test"yuuji.yaginuma2017-01-101-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8cb3cdffdb70f3575518d24ea96ec891e40d21d0, reversing changes made to 3bc747bd8676dc940b531067e2861dcd4ac28efc. Reason: This test already exists in `SharedGeneratorTests`. Ref: https://github.com/rails/rails/blob/master/railties/test/generators/shared_generator_tests.rb#L109..L112 https://github.com/rails/rails/blob/master/railties/test/generators/app_generator_test.rb#L55..L56
* | | Test `--skip-git` generator optiondixpac2017-01-091-0/+5
|/ /
* / Don't generate HTML/ERB templates for scaffold controller with --api flagPrathamesh Sonpatki2017-01-071-0/+6
|/ | | | - Fixes #27591.
* Fix style guide violationsRafael Mendonça França2017-01-051-1/+0
|
* Merge pull request #27399 from sinogermany/rails-env-for-empty-string-env-varsRafael Mendonça França2017-01-031-0/+12
|\ | | | | | | Rails env for empty string env vars
| * Rails.env falls back to dev mode when env var is emptyDaniel Deng2017-01-041-0/+12
| |
* | Fix configuration test now that Metal#env was removedRafael Mendonça França2017-01-031-1/+1
| |
* | Revert "Merge pull request #27550 from ↵Rafael Mendonça França2017-01-031-20/+0
| | | | | | | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine" This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1. Reason: It breaks the public API
* | Merge pull request #27550 from ↵Rafael França2017-01-031-0/+20
|\ \ | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine Fix generator command for nested (namespaced) rails engine
| * | Fix generator command for nested (namespaced) rails engineFumiaki MATSUSHIMA2017-01-031-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
* | | Remove test to the db:test:cloneRafael Mendonça França2017-01-031-10/+0
| | |
* | | Remove deprecated CONTROLLER environment variable for routes taskRafael Mendonça França2017-01-031-42/+25
| | |
* | | Remove deprecated config.serve_static_filesRafael Mendonça França2017-01-031-10/+0
| | |
* | | Remove deprecated `config.static_cache_control`Rafael Mendonça França2017-01-031-10/+0
|/ /
* | Remove bin/yarn if yarn is skipped, tidy up testsPrathamesh Sonpatki2017-01-011-0/+7
| | | | | | | | | | | | - No need to remove bin/yarn separately for API only apps because :skip_yarn is set to true for API only apps. - Added a test for :skip_yarn config.
* | Enforce middleware ordering with a test, instead of commentsMatthew Draper2016-12-311-3/+34
| | | | | | | | | | | | | | | | | | We want the actual order to be very predictable, so it's rightly defined in code -- not with an on-the-fly tsort. But we can do the tsort here, and then verify that it matches the implemented ordering. This way we don't leave future readers guessing which parts of the ordering are deliberate and which are arbitrary.
* | Merge pull request #27515 from ↵Matthew Draper2016-12-311-2/+2
|\ \ | | | | | | | | | | | | | | | kbrock/fix_log_remote_ip_before_dispatcher_ips_settings Allow log remote ip addres when config.action_dispatch.trusted_proxie…
| * | Allow log remote ip addres when config.action_dispatch.trusted_proxies passedLeonid Batizhevsky2016-12-301-1/+1
|/ /
* | `#tables` and `#table_exists?` and returns only tables and not viewsRafael Mendonça França2016-12-291-5/+3
| |
* | Remove deprecated support to passing a column to #quoteRafael Mendonça França2016-12-291-18/+1
| |
* | Merge branch 'master' into fix_26964Kasper Timm Hansen2016-12-2918-48/+84
|\ \
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 17:53:22 +0000