| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
|
|/ / |
|
|\ \
| | |
| | |
| | | |
Optimize indentation for generator actions
|
| | | |
|
|\ \ \
| | | |
| | | | |
Eager load controller actions to reduce response time of the first request
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
On the first request, ActionController::Base#action_methods computes
and memoized the list of available actions [1]. With this PR we move
this expensive operation into eager load step to reduce response time
of the first request served in production.
This also reduces the memory footprint when running on forking server
like Unicorn.
[1] https://github.com/rails/rails/blob/a3813dce9a0c950a4af7909111fa730a2622b1db/actionpack/lib/abstract_controller/base.rb#L66-L77
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
yhirano55/skip_unused_components_when_running_rails_command_in_plugin
Skip unused components when running `bin/rails` in Rails plugin
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove :sorted test order for isolated tests
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Add git_source to Gemfile for plugin generator
|
| | |/ / / /
| |/| | | | |
|
| |_|_|/ /
|/| | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Improve app generator tests.
Ensure that generation `config/application.rb` is correct.
Ensure that generation `config/application.rb` is correct.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix engine command
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Fix non escaped character
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Deprecate support of older `config.ru`
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since Rails 4.0, `config.ru` generated by default uses instances of
`Rails.application`. Therefore, I think that it is good to deprecate
the old behavior.
Related: #9669
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
* Add migrations per rails engine conventions
* Fix failing tests
|
|/ / /
| | |
| | |
| | | |
By default, apps only have the former set.
|
|\ \ \
| | | |
| | | | |
Add Active Storage to Rails
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The test was passing before because it was not being testes correctly.
Now we create a different engine that is loaded before the already
exising and we make sure that the first call for isolate_namespace is
what takes effect.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
What we want to test is that two different calls to isolate_namespace
with the same module doesn't change the original railtie. We can do that
defining two different railties.
We can't call in the application because this method is not supposed to
be called in an Application class.
|
| | | |
| | | |
| | | |
| | | | |
And deal with a temporary test fix until we allow you to skip active storage.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
|
| | | |
| | | |
| | | |
| | | | |
It's worth considering whether we should hide these by default, but I'm kinda thinking no. It's very reasonable that someone would want to call these directly, so they should be documented.
|
| | | |
| | | |
| | | |
| | | | |
cc @rafaelfranca
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \ |
|
| |\ \ \ \ |
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
Handling add/remove to/from migration edge cases
|
| | |_|_|/
| |/| | |
| | | | |
| | | | | |
Making sure the table name is parsed correctly when an add/remove column migration have 'from'/'to' in the table name.
|
|\ \ \ \ \
| | |_|/ /
| |/| | | |
|
| |\ \ \ \
| | | | | |
| | | | | | |
Use duktape gem as default JS engine on Windows-MINGW
|
| | |/ / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The fallback javascript engine on Windows is Windows Script Host (JScript).
However this engine isn't able to process the default assets, because it supports
ES3 only but the coffeescript compiler requires ES5.
Fixes #30014
|
| | |/ /
| |/| |
| | | |
| | | | |
Since 553b695, `doc` directory is not created in application.
|
| |/ / |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes the following warning:
```
/tmp/d20170727-7039-kmdtb1/app/app/models/user.rb:5: warning: method redefined; discarding old model_name
rails/activemodel/lib/active_model/naming.rb:222: warning: previous definition of model_name was here
```
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Solves #29923
This regression was caused due to a wrong regex to filter out
paths, introduced in commit 796a1cf0e
The regex was /^\w+\// which did not accept paths with a leading
slash and hence all absolute paths were filtered out.
This change introduces a change in regex which allows for a leading
slash and acts on the matched term accordingly.
While cascading through the case block, the paths are checked for
line number specification, existence of a directory at that path
and if none of those match, then it is considered to be a path to the
file. The regex matchers specified are filtered out via the call
to `Array#compact` since they do not match any of these conditions.
|
| |\ \
| | |/
| |/|
| | |
| | | |
y-yagi/extract_assert_output_and_available_pty_to_module
Extract `assert_output` and `available_pty?` into `ConsoleHelpers` module
|