Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Don't put db:migrate and db:setup in binfiles if activerecord is excluded | Bouke van der Bijl | 2016-11-01 | 1 | -0/+6 | |
| | | ||||||
* | | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 16 | -41/+41 | |
| | | ||||||
* | | remove assets config from `new_framework_defaults` if `--skip-sprockets` is true | yuuji.yaginuma | 2016-10-25 | 1 | -0/+3 | |
| | | | | | | | | If `sprockets` is not loaded, `Rails.application.config.assets` is not defined. | |||||
* | | Prevent the test framework from being loaded in production mode | Aaron Patterson | 2016-10-21 | 1 | -0/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | The test framework should not be autoloaded in production mode. Before this commit, the testing railtie would extend AS::TestCase. This caused AS::TestCase to be preloaded regardless of the environment in which we were running. This commit just moves the code that adds line filtering support in to the test command where we actually execute the test runner. That allows us to maintain the line runner feature but only load the minimal amount of code we need. | |||||
* | | don't create db directory when skip active_record | José Gomes Júnior | 2016-10-21 | 1 | -0/+1 | |
|/ | ||||||
* | Remove deprecated code in ssl middleware | Rafael Mendonça França | 2016-10-10 | 1 | -2/+2 | |
| | ||||||
* | Remove deprecated support to :text in render | Rafael Mendonça França | 2016-10-10 | 10 | -69/+69 | |
| | ||||||
* | use `active_support/testing/autorun` in `bin/test` script | yuuji.yaginuma | 2016-09-27 | 1 | -0/+6 | |
| | | | | | | | 29f0fbd5db643b885665e4a14c7de3bf6c0d9c96 has changed that always call `Minitest.autorun` in `active_support/testing/autorun`. Therefore, when used directly `Minitest.run`, tests are performed twice. | |||||
* | Fix server command tests. | Kasper Timm Hansen | 2016-09-25 | 1 | -1/+2 | |
| | ||||||
* | Fix dbconsole tests. | Kasper Timm Hansen | 2016-09-25 | 1 | -22/+55 | |
| | ||||||
* | Fix console tests. | Kasper Timm Hansen | 2016-09-25 | 1 | -6/+30 | |
| | ||||||
* | Initial command structure. | Kasper Timm Hansen | 2016-09-25 | 1 | -1/+1 | |
| | ||||||
* | Merge pull request #26515 from grosser/grosser/after_run | Arthur Nogueira Neves | 2016-09-23 | 1 | -1/+33 | |
|\ | | | | | support minitest after_run | |||||
| * | support minitest after_run for parity to regular minitest | Michael Grosser | 2016-09-16 | 1 | -0/+18 | |
| | | | | | | | | see https://github.com/seattlerb/minitest/blob/f9605387e4af7d657921a83aaf0ae364f6d26a57/lib/minitest.rb#L51-L65 | |||||
| * | improve test coverage | Michael Grosser | 2016-09-16 | 1 | -2/+16 | |
| | | ||||||
* | | use rails command in restart task test | yuuji.yaginuma | 2016-09-19 | 1 | -7/+7 | |
| | | ||||||
* | | improve error message when include assertions fail | Michael Grosser | 2016-09-16 | 13 | -50/+50 | |
|/ | | | | | | assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong | |||||
* | Merge pull request #26469 from y-yagi/remove_useless_option | Rafael França | 2016-09-14 | 1 | -5/+0 | |
|\ | | | | | remove useless `gemfile` option | |||||
| * | remove useless `gemfile` option | yuuji.yaginuma | 2016-09-12 | 1 | -5/+0 | |
| | | | | | | | | | | | | | | Rails application for test creates with `--skip-gemfile` option. https://github.com/rails/rails/blob/master/railties/test/isolation/abstract_unit.rb#L333 Therefore, regardless of the option, Gemfile is not created. | |||||
* | | fix broken generators test | yuuji.yaginuma | 2016-09-14 | 2 | -2/+2 | |
|/ | | | | Follow up to 92703a9ea5d8b96f30e0b706b801c9185ef14f0e | |||||
* | use correct Gemfile in `bin/setup` test | yuuji.yaginuma | 2016-09-11 | 1 | -0/+18 | |
| | | | | | | | Currently, `bin/setup` test uses Gemfile of Rails. But this Gemfile is not a file to be used in Rails application. Add a Gemfile to Rails application that is created for test, it has been modified to use the Gemfile. | |||||
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 1 | -8/+8 | |
| | ||||||
* | Fix style | schneems | 2016-08-30 | 1 | -26/+26 | |
| | ||||||
* | Address comment via @dhh, better option naming | schneems | 2016-08-30 | 1 | -4/+4 | |
| | ||||||
* | Thanks rubocop | schneems | 2016-08-29 | 1 | -1/+1 | |
| | ||||||
* | Favor `public_folder: true` over `public_*` | schneems | 2016-08-29 | 1 | -25/+44 | |
| | | | | Adding all those `public_*` methods is a bit heavy handed, we can change the API to instead use `public_folder: true`. Change was pretty easy since it was already implemented that way. | |||||
* | Fix formatting | schneems | 2016-08-29 | 1 | -3/+3 | |
| | ||||||
* | Add `public_*` helpers to all the `_tag` methods. | schneems | 2016-08-29 | 1 | -9/+15 | |
| | ||||||
* | Test `public_` methods. | schneems | 2016-08-29 | 1 | -0/+72 | |
| | ||||||
* | run `before_configuration` callbacks as soon as application constant ↵ | yuuji.yaginuma | 2016-08-19 | 1 | -0/+7 | |
| | | | | | | | | | | | | | inherits from Rails::Application Until Rails 4.1, `before_configuration` run as soon as the application constant inherits from `Rails::Application`. However, in d25fe31c40928712b5e08fe0afb567c3bc88eddf, it has been modified to run at instantiation process. This modify to `before_configuration` is run at same timing as to Rails 4.1. Fixes #19880 | |||||
* | Merge pull request #26157 from ↵ | Rafael França | 2016-08-16 | 1 | -0/+1 | |
|\ | | | | | | | | | y-yagi/remove_test_mailers_when_skipping_action-mailer remove "test/mailers" directory when skipping action-mailer | |||||
| * | remove "test/mailers" directory when skipping action-mailer | yuuji.yaginuma | 2016-08-14 | 1 | -0/+1 | |
| | | | | | | | | Related to #26146 | |||||
* | | Merge pull request #26130 from yui-knk/drop_table | Rafael França | 2016-08-16 | 1 | -1/+3 | |
|\ \ | | | | | | | Drop a temporary table before end of a test case | |||||
| * | | Drop a temporary table before end of a test case | yui-knk | 2016-08-14 | 1 | -1/+3 | |
| | | | ||||||
* | | | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 26 | -86/+86 | |
| |/ |/| | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | |||||
* | | Ensure app/mailers is removed when skipping action-mailer | Brian Cardarella | 2016-08-12 | 1 | -0/+1 | |
|/ | | | | Closes #26145 | |||||
* | Integration test to prevent regression for the 5th time | Aaron Patterson | 2016-08-11 | 1 | -0/+47 | |
| | | | | | | | | Fix unsafe query generation risk. Redo of CVE-2012-2660, CVE-2012-2694 and CVE-2013-0155 CVE-2016-6317 | |||||
* | add missing require rake | yuuji.yaginuma | 2016-08-11 | 1 | -0/+24 | |
| | | | | | In ff8035dfeed8c86594c32ef8e9204806e190cb58, require rake is deferred. Therefore, it is necessary to require rake even `Engine::CommandsTasks. | |||||
* | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 1 | -1/+1 | |
| | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | |||||
* | applies project convention for string literals | Xavier Noria | 2016-08-07 | 1 | -1/+1 | |
| | ||||||
* | Merge pull request #24260 from ↵ | Kasper Timm Hansen | 2016-08-07 | 1 | -4/+6 | |
|\ | | | | | | | | | y-yagi/show_error_message_when_error_raised_in_rails_runner show error message when error raised in rails runner | |||||
| * | show error message when error raised in rails runner | yuuji.yaginuma | 2016-08-03 | 1 | -4/+6 | |
| | | ||||||
* | | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty lines | Ryuta Kamizono | 2016-08-07 | 5 | -7/+0 | |
| | | ||||||
* | | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 7 | -9/+1 | |
| | | ||||||
* | | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 17 | -231/+231 | |
| | | ||||||
* | | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 6 | -20/+20 | |
| | | ||||||
* | | modernizes hash syntax in railties | Xavier Noria | 2016-08-06 | 4 | -9/+9 | |
| | | ||||||
* | | applies new string literal convention in railties/test | Xavier Noria | 2016-08-06 | 95 | -1595/+1595 | |
|/ | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | |||||
* | remove unnecessary require and extend | yuuji.yaginuma | 2016-07-31 | 1 | -8/+0 | |
| | | | | | | | | `rack/test` is require at the top of file. https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L3 In addtion, `Rack::Test::Methods` is include in class, extend is unnecessary. https://github.com/rails/rails/blob/master/railties/test/railties/engine_test.rb#L9 | |||||
* | There are some cases where @@app is not defined | Santiago Pastorino | 2016-07-26 | 1 | -0/+28 | |
| |