| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
_form view [Fixes #11573]
|
| |
| |
| |
| |
| | |
assert_file already gives this functionality for free by passing
multiple contents.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Showing welcome page in production can expose information, which should
not be visible on production if people don't override the default root
route.
This reverts commit b0caea29c2da9f4c8bb958019813482da297067d.
|
|\ \
| | |
| | | |
Match Dev/Prod parity for Index Page
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
With Rails 4 the default index page was moved from a static file `index.html` inside the `public/` folder to an internal controller/view inside of the railties gem. This was to allow use of erb in the default index page and to remove the requirement that new apps must delete a static file to make their index pages work. While this was a good change, the functionality was unexpected to developers who wish to get their apps running in production ASAP. They will create a new app `rails new my app`, start a server to verify it works, then immediately deploy the app to verify that it can start working in production. Unfortunately locally they see a page when they visit `localhost:3000` when they visit their production app they get an error page.
We initially anticipated this problem in the original pull request, but did not properly anticipate the severity or quantity of people who would like this functionality. Having a default index page serves as an excellent litmus test for a passed deploy on default apps, and it is very unexpected to have a page work locally, but not on production.
This change makes the default index page available in production if the developer has not over-written it by defining their own `root` path inside of routes.
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Fix an issue where Journey was failing to clear the named routes hash when the
routes were reloaded and since it doesn't overwrite existing routes then if a
route changed but wasn't renamed it kept the old definition. This was being
masked by the optimised url helpers so it only became apparent when passing an
options hash to the url helper.
|
| |
| |
| |
| | |
rake task included in test:all rake task.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As this middleware comes by default in a new
rails app
Added test to check omit for CheckPending when
Active Record is not included.
|
| |
| |
| |
| | |
Rack::Sendfile is loaded by default now
|
| |
| |
| |
| | |
reflect that
|
| |
| |
| |
| | |
Closes #11381
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
s/plugin_new/plugin
|
| | |
| | |
| | |
| | |
| | | |
There are historical reasons that the `plugin` command was `plugin_new`, now those are no longer applicable, we should remove the naming edge case from the project. This PR is based off of comments from #11176
ATP Railties
|
|/ /
| |
| |
| |
| | |
This change provides the ability to create a new application with a
configuration which can be specified.
|
| | |
|
| |
| |
| |
| |
| | |
The `rake test:recent` and `rake test:uncommitted` tasks were
deprecated and are now being removed.
|
|\ \
| | |
| | |
| | |
| | | |
jetthoughts/10428_bug_with_config_assets_precompile
#10428: Added tests for config.assets.precompile
|
| | |
| | |
| | |
| | |
| | |
| | | |
Tests for bug in sprocket-rails:
do not use value of configuration options
which changed after environment loaded
|
|/ / |
|
|\ \
| | |
| | | |
Calls to the application constant have been refactored
|
| | |
| | |
| | |
| | |
| | | |
Rails.application when drawing routes and creating other configurations
on the application.
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| | |
Conflicts:
railties/test/application/loading_test.rb
|
|/ |
|
|
|
|
|
| |
more agnostic Rails.application syntax. This means tests will be more
portable, and won't rely on the existence of a particular subclass.
|
|
|
|
| |
particular controller to search for in rake routes.
|
|
|
|
| |
environment works correctly.
|
|\
| |
| | |
Squishy minitest5
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
+ Namespace changes, overhaul of runners.
+ Internal ivar name changes
- Removed a logger globally applied to tests that spew everywhere?!?
+ Override Minitest#__run to sort tests by name.
+ Reworked testing isolation to work with the new cleaner architecture.
- Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago.
- Minor report output differences.
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- f1805a697831 Redefined 'test_scaffold_generator_no_assets' twice.
- Only the last instance of these three definitions of the same method
was getting called when the tests were actually running.
- This commit changes names of this method so that all three
definitions will be called
- scaffold.css is not generated by --assets=false switch.
- Test was expecting the presence of the file with --assets=false
- This issue was not discovered in f1805a697831b because it was
redefining the same method twice
|
|
|
|
|
|
| |
Scaffold generator with --assets=false option
outputs an error
See #9525
|
|\
| |
| | |
generate 'app/assets/images' directory when creating new rails app. Fixes #10434
|
| | |
|
| |
| |
| |
| | |
https://github.com/rails/rails/commit/558d402472b49c4c99bf6753d341d7aef2e25dd4
|
|/
|
|
|
|
|
|
|
|
|
|
| |
A regression was introduced in 5b3bb6, generating route from within an
engine to an another engine resulted in prefixing a path with the
SCRIPT_NAME value.
The regression was caused by the fact that SCRIPT_NAME should be
appended only if it's the SCRIPT_NAME for the application, not if it's
SCRIPT_NAME from the current engine.
closes #10409
|
| |
|
|
|
|
|
| |
syntax. This helps removing the class level abstraction of an
application.
|
|
|
|
|
| |
Railtie itself abstract. This stops the weird behavior of forcing
subclasses of Railtie to include the Configurable module.
|
| |
|
| |
|
|
|
|
| |
tasks if `eager_load` is `true`
|
|
|
|
| |
Simpler, thanks to @rubys for the hint.
|
|\
| |
| | |
initialize instead of assert to fix warning
|