aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge pull request #29559 from kirs/eager-load-controller-actionsRafael França2017-08-111-0/+60
|\ \ \ | | | | | | | | Eager load controller actions to reduce response time of the first request
| * | | Eager load controller and mailer actionsKir Shatrov2017-07-291-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On the first request, ActionController::Base#action_methods computes and memoized the list of available actions [1]. With this PR we move this expensive operation into eager load step to reduce response time of the first request served in production. This also reduces the memory footprint when running on forking server like Unicorn. [1] https://github.com/rails/rails/blob/a3813dce9a0c950a4af7909111fa730a2622b1db/actionpack/lib/abstract_controller/base.rb#L66-L77
* | | | Merge pull request #30116 from ↵Rafael Mendonça França2017-08-111-1/+13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | yhirano55/skip_unused_components_when_running_rails_command_in_plugin Skip unused components when running `bin/rails` in Rails plugin
| * | | | Skip unused components when running in Rails pluginYoshiyuki Hirano2017-08-091-1/+13
| | | | |
* | | | | Merge pull request #30105 from bogdanvlviv/remove-sorted-test_orderRafael França2017-08-111-2/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove :sorted test order for isolated tests
| * | | | | Remove :sorted test order for isolated testsbogdanvlviv2017-08-071-2/+0
| | | | | |
* | | | | | Merge pull request #30110 from yhirano55/add_git_sourceRafael Mendonça França2017-08-111-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Add git_source to Gemfile for plugin generator
| * | | | | | Add git_source to Gemfile for plugin generatorYoshiyuki Hirano2017-08-091-0/+5
| | |/ / / / | |/| | | |
* | | | | | Refactor app_generator_test (#30192)yhirano552017-08-111-1/+8
| |_|_|/ / |/| | | |
* | | | | `--skip-action-cable` pass throughs `rails plugin new`bogdanvlviv2017-08-101-0/+6
| | | | |
* | | | | Improve plugin generator tests. Related to #30123.bogdanvlviv2017-08-102-44/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve app generator tests. Ensure that generation `config/application.rb` is correct. Ensure that generation `config/application.rb` is correct.
* | | | | Merge pull request #30091 from yhirano55/fix_engine_commandRafael França2017-08-081-0/+4
|\ \ \ \ \ | | | | | | | | | | | | Fix engine command
| * | | | | Fix engine commandYoshiyuki Hirano2017-08-061-0/+4
| | | | | |
* | | | | | Merge pull request #30090 from yhirano55/fix_escaped_characterRafael França2017-08-081-1/+1
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Fix non escaped character
| * | | | | Fix escaped characterYoshiyuki Hirano2017-08-061-1/+1
| |/ / / /
* | | | | Merge pull request #30127 from y-yagi/deprecate_support_of_older_config_ruRafael França2017-08-081-0/+31
|\ \ \ \ \ | | | | | | | | | | | | Deprecate support of older `config.ru`
| * | | | | Deprecate support of older `config.ru`yuuji.yaginuma2017-08-081-0/+31
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Rails 4.0, `config.ru` generated by default uses instances of `Rails.application`. Therefore, I think that it is good to deprecate the old behavior. Related: #9669
* / / / / ActiveStorage:Add migrations per rails engine conventions (#30111)Dino Maric2017-08-081-2/+2
|/ / / / | | | | | | | | | | | | | | | | | | | | * Add migrations per rails engine conventions * Fix failing tests
* / / / Check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`George Claghorn2017-08-051-3/+1
|/ / / | | | | | | | | | By default, apps only have the former set.
* | | Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-046-16/+56
|\ \ \ | | | | | | | | Add Active Storage to Rails
| * | | Make sure the test fails if the code chagesRafael Mendonça França2017-08-041-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test was passing before because it was not being testes correctly. Now we create a different engine that is loaded before the already exising and we make sure that the first call for isolate_namespace is what takes effect.
| * | | Do not call isolate_namespace on the applicationRafael Mendonça França2017-08-041-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | What we want to test is that two different calls to isolate_namespace with the same module doesn't change the original railtie. We can do that defining two different railties. We can't call in the application because this method is not supposed to be called in an Application class.
| * | | Include active_storage in all generated application.rb filesDavid Heinemeier Hansson2017-08-041-1/+2
| | | | | | | | | | | | | | | | And deal with a temporary test fix until we allow you to skip active storage.
| * | | Convert to strings so array can be sorted deterministicallyDavid Heinemeier Hansson2017-08-041-3/+3
| | | |
| * | | Deterministic comparisons pleaseDavid Heinemeier Hansson2017-08-031-3/+3
| | | |
| * | | Do not eager load ActiveRecord::BaseRafael Mendonça França2017-08-032-10/+6
| | | | | | | | | | | | | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
| * | | Active Storage routes are now part of the default routesDavid Heinemeier Hansson2017-08-031-9/+37
| | | | | | | | | | | | | | | | It's worth considering whether we should hide these by default, but I'm kinda thinking no. It's very reasonable that someone would want to call these directly, so they should be documented.
| * | | Same issue from AR getting loaded earlierDavid Heinemeier Hansson2017-08-031-3/+3
| | | | | | | | | | | | | | | | cc @rafaelfranca
| * | | Including new default classes in loading testDavid Heinemeier Hansson2017-08-031-3/+3
| | | |
| * | | Active Storage loads AR earlier to extend it so require env laterDavid Heinemeier Hansson2017-08-031-3/+7
| | | |
| * | | Generating the app is where the exception is now raisedDavid Heinemeier Hansson2017-08-031-1/+1
| | | |
| * | | Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-023-3/+3
| |\ \ \
| * \ \ \ Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-012-1/+2
| |\ \ \ \
| * | | | | Use config/storage.yml as part of the skeleton and loadingDavid Heinemeier Hansson2017-07-311-1/+1
| | | | | |
| * | | | | Include default storage configurationDavid Heinemeier Hansson2017-07-311-0/+1
| | | | | |
* | | | | | Merge pull request #30011 from guilherme/fix-migration-generator-special-casesSean Griffin2017-08-031-0/+22
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Handling add/remove to/from migration edge cases
| * | | | | Handling add/remove to/from migration edge casesGuilherme Reis Campos2017-08-031-0/+22
| | |_|_|/ | |/| | | | | | | | | | | | | Making sure the table name is parsed correctly when an add/remove column migration have 'from'/'to' in the table name.
* | | | | Merge remote-tracking branch 'origin/master' into unlock-minitestRafael Mendonça França2017-08-0122-141/+368
|\ \ \ \ \ | | |_|/ / | |/| | |
| * | | | Merge pull request #30015 from larskanis/use-duktake-on-mingwGuillermo Iguaran2017-08-011-0/+2
| |\ \ \ \ | | | | | | | | | | | | Use duktape gem as default JS engine on Windows-MINGW
| | * | | | Use duktape gem as default JS engine on Windows-MINGW and MS-Visual-C buildsLars Kanis2017-08-011-0/+2
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fallback javascript engine on Windows is Windows Script Host (JScript). However this engine isn't able to process the default assets, because it supports ES3 only but the coffeescript compiler requires ES5. Fixes #30014
| * | / / Remove unnecessary `doc` directory deletionyuuji.yaginuma2017-08-011-1/+0
| | |/ / | |/| | | | | | | | | | Since 553b695, `doc` directory is not created in application.
| * | | Set Ruby version in Gemfile and .ruby-version by defaultAlberto Almagro2017-07-311-0/+12
| |/ /
| * / Fix `warning: method redefined;`yuuji.yaginuma2017-07-281-3/+3
| |/ | | | | | | | | | | | | | | | | This fixes the following warning: ``` /tmp/d20170727-7039-kmdtb1/app/app/models/user.rb:5: warning: method redefined; discarding old model_name rails/activemodel/lib/active_model/naming.rb:222: warning: previous definition of model_name was here ```
| * Merge pull request #29926 from pawandubey:fix-test-with-absolute-pathsKasper Timm Hansen2017-07-251-0/+26
| |\
| | * Allow bin/rails test task to take absolute paths as argumentsPawan Dubey2017-07-251-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Solves #29923 This regression was caused due to a wrong regex to filter out paths, introduced in commit 796a1cf0e The regex was /^\w+\// which did not accept paths with a leading slash and hence all absolute paths were filtered out. This change introduces a change in regex which allows for a leading slash and acts on the matched term accordingly. While cascading through the case block, the paths are checked for line number specification, existence of a directory at that path and if none of those match, then it is considered to be a path to the file. The regex matchers specified are filtered out via the call to `Array#compact` since they do not match any of these conditions.
| * | Merge pull request #29931 from ↵Sean Griffin2017-07-254-65/+36
| |\ \ | | |/ | |/| | | | | | | y-yagi/extract_assert_output_and_available_pty_to_module Extract `assert_output` and `available_pty?` into `ConsoleHelpers` module
| | * Extract `assert_output` and `available_pty?` into `ConsoleHelpers` moduleyuuji.yaginuma2017-07-254-65/+36
| | | | | | | | | | | | | | | We define almost the same method with multiple tests. Therefore, it extract into module.
| * | Fix `dbconsole` test when tempdir is a long pathSean Griffin2017-07-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | The output of `.databases` in SQLite will truncate to a certain size. This causes the test to fail when run locally from a mac, or anything which has a tempdir with more than a few characters. This pragma has the same output, but presented as a normal query, meaning no truncation will occur.
| * | Merge pull request #29916 from lugray/stop_generating_application_recordEileen M. Uchitelle2017-07-255-34/+26
| |\ \ | | |/ | |/| Stop creating ApplicationRecord on model generation
| | * Stop creating ApplicationRecord on model generationLisa Ugray2017-07-245-34/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When generating models, we created ApplicationRecord in the default location if no file existed there. That was annoying for people who moved it to somewhere else in the autoload path. At this point, the vast majority of apps should have either run the upgrade script or generated a model since upgrading. For those that haven't the error message after generating a new model should be helpful: NameError: uninitialized constant ApplicationRecord To ease friction in that case, this also adds a generator for ApplicationRecord.