Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Partial fix of database url tests | schneems | 2013-12-25 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | | Prior to #13463 when `DATABASE_URL` was set, Rails automagically used that value instead of the database.yml. There are tests in dbs_test that expect this to still be true. After that PR, `RAILS_DATABASE_URL` is expected to be read into the YAML file via ERB, this PR fixes that behavior. Note: this does not entirely fix the tests. It seems that `ActiveRecord::Tasks::DatabaseTasks.current_config` does not process the url string correctly (convert it into a hash), and ` ActiveRecord::Tasks::DatabaseTasks.structure_load(current_config, filename)` as well as other methods in `DatabaseTasks` expect a hash. It seems like we should involve the resolver somewhere in this process to correctly convert the database url, I do not know the best place for that /cc @josevalim | |||||
* | | Fix tests names: tokens.yml => secrets.yml | Guillermo Iguaran | 2013-12-25 | 1 | -2/+2 | |
| | | ||||||
* | | using symbol instead of string in establish_connection | Kuldeep Aggarwal | 2013-12-25 | 1 | -1/+1 | |
| | | ||||||
* | | Revert "Ensure secret_key_base is set for all environments" | José Valim | 2013-12-24 | 1 | -2/+1 | |
| | | | | | | | | | | | | A better solution has been pushed to master. This reverts commit 959cfcef7255bba720ce3f15323056533ea7b50a. | |||||
* | | Fix railties tests in master | schneems | 2013-12-24 | 1 | -1/+2 | |
| | | | | | | | | | | Tests are failing due to missing env var on master https://travis-ci.org/rails/rails/jobs/15930622#L641 This adds an environment variable `ENV['RAILS_SECRET_KEY_BASE']` so these tests will pass. | |||||
* | | Ensure secret_key_base is set for all environments | José Valim | 2013-12-24 | 1 | -1/+2 | |
| | | ||||||
* | | Fix build failures related to the new ENV options in yml | José Valim | 2013-12-24 | 1 | -0/+18 | |
| | | ||||||
* | | Add comments with urls for email previews | Andrew White | 2013-12-22 | 1 | -6/+11 | |
| | | ||||||
* | | Use Full path to sqlite database in tests | schneems | 2013-12-22 | 2 | -4/+4 | |
| | | ||||||
* | | Fix DB Console tests | schneems | 2013-12-21 | 1 | -20/+22 | |
| | | | | | | | | | | | | | | | | | | | | | | The build is broken: https://travis-ci.org/rails/rails/builds/15824530 This commit fixes it. The problem: Sqlite expects the `database` part to be an absolute path. That prompted this change to be committed to master: https://github.com/rails/rails/commit/fbb79b517f3127ba620fedd01849f9628b78d6ce This change provides correct behavior. Unfortunately tests were introduced in https://github.com/rails/rails/commit/971d5107cd4cd08c22a85d34546f4ba03ed5c925 that were relying on the incorrect behavior. We can avoid the fix by changing to another database url such as `mysql` or `postgresql` In addition to fixing the failure, the assertions are changed so that the "expected" value comes before "actual" value. | |||||
* | | `html` and `text` templates for mailers by default | Kassio Borges | 2013-12-20 | 1 | -1/+15 | |
| | | ||||||
* | | Make possible to use symbol as the verifier name | Rafael Mendonça França | 2013-12-19 | 1 | -6/+6 | |
| | | ||||||
* | | Change all `MiniTest` to `Minitest` since, `MiniTest` namespace has been ↵ | Vipul A M | 2013-12-18 | 1 | -2/+2 | |
| | | | | | | | | | | | | renamed to `Minitest` Ref: https://github.com/seattlerb/minitest/blob/master/History.txt | |||||
* | | Default I18n.enforce_available_locales to true | Carlos Antonio da Silva | 2013-12-17 | 1 | -4/+38 | |
| | | | | | | | | | | | | | | | | | | | | | | | | We will default this option to true from now on to ensure users properly handle their list of available locales whenever necessary. This option was added as a security measure and thus Rails will follow it defaulting to secure option. Also improve the handling of I18n config options in its railtie, taking the new enforce_available_locales option into account, by setting it as the last one in the process. This ensures no other configuration will trigger a deprecation warning due to that setting. | |||||
* | | Add mailer previews feature based on mail_view gem | Andrew White | 2013-12-17 | 2 | -3/+421 | |
| | | ||||||
* | | Fix method redefinition warning | Andrew White | 2013-12-17 | 1 | -2/+6 | |
| | | ||||||
* | | Merge pull request #13328 from teohm/dbconsole_support_database_url | Yves Senn | 2013-12-16 | 1 | -27/+67 | |
|\ \ | | | | | | | Fixed rails dbconsole to support DATABASE_URL | |||||
| * | | fixed rails dbconsole to support ENV['DATABASE_URL']. | Huiming Teo | 2013-12-16 | 1 | -27/+67 | |
| | | | ||||||
* | | | Regression test for load_structure and clone_structure | Arthur Neves | 2013-12-14 | 1 | -2/+4 | |
|/ / | ||||||
* | | Rename tokens.yml to secrets.yml | Guillermo Iguaran | 2013-12-12 | 1 | -3/+3 | |
| | | ||||||
* | | Add test for custom tokens stored in config/tokens.yml | Guillermo Iguaran | 2013-12-12 | 1 | -0/+13 | |
| | | ||||||
* | | Replace config.secret_key_base with secrets.secret_key_base in test | Guillermo Iguaran | 2013-12-12 | 1 | -1/+1 | |
| | | ||||||
* | | Load secret_key_base from tokens.yml, fallback to config.secret_key_base | Guillermo Iguaran | 2013-12-12 | 3 | -6/+25 | |
| | | ||||||
* | | Skipping debugger from plugin Gemfile for JRuby | Arun Agrawal | 2013-12-06 | 1 | -0/+11 | |
| | | ||||||
* | | Merge branch 'av-loading-order' | Rafael Mendonça França | 2013-12-05 | 1 | -4/+18 | |
|\ \ | ||||||
| * | | Assert the singleton instead of to truthy/falsy | Rafael Mendonça França | 2013-12-05 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | This will avoid false positives where caching? is nil and should be false | |||||
| * | | Add tests to cache_template_loading when an engine loaded Action View | Rafael Mendonça França | 2013-12-05 | 1 | -0/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | before the application This test is a regression test to b068e20b35797aa6deaa377a48c990759734f515 that changed the load order of Action View initializers. | |||||
* | | | Make sure that spring is loaded in development only | Arun Agrawal | 2013-12-05 | 1 | -1/+1 | |
|/ / | ||||||
* | | Merge pull request #13189 from strzalek/retain-ap-av-dep | Jeremy Kemper | 2013-12-05 | 1 | -2/+0 | |
|\ \ | | | | | | | Retain ActionPack dependency on ActionView. Fixes #12979. | |||||
| * | | Remove missing integration points of AV extraction | Carlos Antonio da Silva | 2013-12-05 | 1 | -2/+0 | |
| | | | ||||||
* | | | set `i18n.enforce_available_locales` before `i18n.default_locale`. | Yves Senn | 2013-12-05 | 1 | -0/+11 | |
| | | | ||||||
* | | | Make salt argument required for message verifier | Rafael Mendonça França | 2013-12-04 | 1 | -5/+5 | |
| | | | ||||||
* | | | Test if two different verifiers don't share the same secret | Rafael Mendonça França | 2013-12-04 | 1 | -2/+12 | |
| | | | ||||||
* | | | Don't need to use a controller to test the verifier | Rafael Mendonça França | 2013-12-04 | 1 | -9/+3 | |
| | | | ||||||
* | | | No need to configure salts | Rafael Mendonça França | 2013-12-04 | 1 | -21/+1 | |
| | | | ||||||
* | | | Make possibile to get different message verifiers | Rafael Mendonça França | 2013-12-04 | 1 | -0/+10 | |
| | | | ||||||
* | | | Rename verifier to message_verifier | Rafael Mendonça França | 2013-12-04 | 1 | -3/+3 | |
| | | | ||||||
* | | | Add application verifier | Rafael Mendonça França | 2013-12-04 | 1 | -0/+41 | |
| | | | | | | | | | | | | | | | | | | | | | | | | It is an application global verifier that can be used to generate and verify signed messages. See the documentation of ActiveSupport::MessageVerifier for more information. | |||||
* | | | Install Spring preloader when generating new applications | Jon Leighton | 2013-12-03 | 2 | -6/+38 | |
|/ / | ||||||
* | | Merge pull request #13117 from akshay-vishnoi/typo | Xavier Noria | 2013-12-02 | 1 | -2/+2 | |
|\ \ | | | | | | | Typo and grammatical fixes [ci skip] | |||||
| * | | Typo and grammatical fixes [ci skip] | Akshay Vishnoi | 2013-12-02 | 1 | -2/+2 | |
| | | | ||||||
* | | | Merge pull request #12365 from jbaudanza/reorder | Guillermo Iguaran | 2013-12-01 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Move Rack::Cache after ActionDispatch::Static in the middleware stack | |||||
| * | | | Move Rack::Cache after AD::Static in the stack | Jonathan Baudanza | 2013-09-25 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | config.assets.enabled isn't used anymore to disable Rails asset pipeline | Guillermo Iguaran | 2013-12-01 | 1 | -1/+0 | |
| | | | | ||||||
* | | | | Merge pull request #13111 from akshay-vishnoi/typo | Carlos Antonio da Silva | 2013-11-30 | 1 | -1/+1 | |
|\ \ \ \ | | |/ / | |/| | | Typo fixes [ci skip] | |||||
| * | | | Typo fixes [ci skip] | Akshay Vishnoi | 2013-11-30 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Fixes failing test for JRuby | Arun Agrawal | 2013-11-29 | 1 | -0/+3 | |
| | | | | | | | | | | | | | | | | | | | | in JRuby FileUtils do not change current dir when moving files | |||||
* | | | | Checking no debugger on JRuby | Arun Agrawal | 2013-11-29 | 1 | -1/+7 | |
|/ / / | | | | | | | | | | fixes tests for JRuby | |||||
* | | | Test for when controller with skip-assets | Arun Agrawal | 2013-11-23 | 1 | -0/+6 | |
| | | | ||||||
* | | | Added test when task generator called on revoke | Arun Agrawal | 2013-11-23 | 1 | -1/+13 | |
| | | |