aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/rack_logger_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Fix test added in #32444bogdanvlviv2018-04-061-2/+4
| | | | | | | Currently test `#test_logger_does_not_mutate_app_return` doesn't test mutation of response and the test passes with and without changes added in #32444. `#freeze` response in the test in order to test mutation.
* Merge pull request #32444 from matrinox/fix-return-response-mutation-rack-loggerRafael Mendonça França2018-04-041-2/+18
|\ | | | | | | Stop mutating body response
| * Stop mutating body responseGeoff Lee2018-04-031-2/+18
|/ | | | | | If @app.call returns an object that is saved (for e.g., in a constant), the mutation results in a continuing cycle of wrapping the body in Rack::BodyProxy, eventually leading to SystemStackError ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ On branch fix-return-response-mutation-rack-logger - Tue 3 Apr 2018 19:54:28 PDT by Geoff Lee <geoff.lee@lendesk.com>
* Adding frozen_string_literal pragma to Railties.Pat Allan2017-08-141-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* class Foo < Struct.new(:x) creates an extra unneeded anonymous classAkira Matsuda2017-01-131-1/+1
| | | | because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
* Add three new rubocop rulesRafael Mendonça França2016-08-161-1/+1
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* applies new string literal convention in railties/testXavier Noria2016-08-061-12/+12
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Fix incorrect unsubscription.Guo Xiang Tan2014-07-111-2/+2
|
* "Naked" rescue clauses only catch StandardError subclasses.thedarkone2013-08-061-2/+5
| | | | Similar to #11497.
* Add a missing require.thedarkone2013-08-061-0/+1
| | | | This makes the rack_logger_test.rb runnable by itself (outside of the `rake test` suite).
* Use the right instrumentation nameRafael Mendonça França2013-08-051-1/+1
| | | | | | | | | The pattern is event.component Closes #11769 Conflicts: railties/CHANGELOG.md
* fire a notification when the request stops / startsAaron Patterson2013-01-091-0/+71
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 18:44:54 +0000