| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
- Before this, while generating a channel, we were not creating
`cable.js` if it does not already exist.
- We have similar code for application mailer here -
https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4.
- Based on the comment -
https://github.com/rails/rails/issues/24418#issuecomment-205421995.
|
|\
| |
| | |
generate ApplicationJob if it does not already exist
|
| |
| |
| |
| |
| |
| | |
ActiveJob jobs now inherit from ApplicationJob by default.
However, when updating to Rails 5 from the old Rails,
since there is a possibility that ApplicationJob does not exist.
|
|/
|
|
|
|
| |
* Updated syntax
* Updated tests to match syntax
|
|\
| |
| | |
Correctly generate application_mailer.rb in mountable engines
|
| |
| |
| |
| | |
- Followup of https://github.com/rails/rails/pull/24161.
|
|\ \
| | |
| | |
| | | |
Comment out config.file_watcher during Rails upgrade process
|
| |/
| |
| |
| | |
[related #24243]
|
|/ |
|
| |
|
|\
| |
| | |
Remove passing `with_dispatchers` to AppGenerator
|
| |
| |
| |
| |
| |
| |
| | |
- While working on https://github.com/rails/rails/pull/22790 I found out
that we pass `with_dispatchers: true` but it's not used at all by Rails.
- We were passing `with_dispatchers: true` in few tests too but again
it's not used by Rails.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit comes from the comments made by @matthewd at https://github.com/rails/rails/pull/23795/files#r54469637
and by @rafaelfranca at https://github.com/rails/rails/pull/23795/files#r54609364
The idea is that if you type (for example) "rake db:migrate" in an AppGenerator,
then this should actually invoke `rake db:migrate` on the command line, whereas
if you type "rails_command db:migrate", this should invoke `rails db:migrate`.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Between major versions 2 and 3, we hit a bug. It's fixed in version 3,
however, the explicit 2.x requirement of `~> '2.0'` will prevent people
from getting the fix with `bundle update` and they would have to
explicitly set the constraint to `~> '3.0'`.
For more information see: rails/web-console#178.
I propose we drop the explicit version constraints in the Gemfile. Web
Console has been relatively stable for the past couple of years, and I
don't anticipate any major alterations, like we saw between major
versions 1 and 2.
|
|\ \
| | |
| | | |
Fix description in cookies_serializer.rb being corrupted by gsub when updating
|
| | | |
|
|/ / |
|
|\ \
| | |
| | | |
convert cable.coffee to cable.js
|
| |/
| |
| |
| | |
In order to eliminate the dependecy of CoffeeScript.
|
| | |
|
| | |
|
| |
| |
| |
| | |
Changed description with tests related to rails_command.
|
| | |
|
|/
|
|
|
| |
- Ambiguous first argument
- Mismatched indentation
|
|
|
|
| |
Rack cors initializer is only necessary to API-only applications, for when the update is unnecessary.
|
|
|
|
|
| |
Puma 3.0 and up introduced compatibility to read from `config/puma.rb` when booting from the command `$ rails server`https://github.com/puma/puma/pull/856.
|
|\
| |
| | |
Enable HSTS with IncludeSubdomains header by default for new apps
|
| |
| |
| |
| |
| | |
- We will remove the initializer for old apps which are migrated to
Rails 5 so that they are not affected by this breaking change.
|
|\ \
| |/
|/|
| |
| | |
y-yagi/correctly_check_ApplicationRecord_in_mountable_engine
correctly check `ApplicationRecord` is exist in moutable engine
|
| |
| |
| |
| | |
Follow up to 1813b29fc7632959800252f36e4b2e6ed4ac7266
|
| |
| |
| |
| | |
This also marks Action Cable routes as internal to Rails.
|
|\ \
| | |
| | | |
AppGenerator: Replace 'rake' with 'rails_command'
|
| | |
| | |
| | |
| | |
| | | |
Follows the convention from Rails 5 of invoking tasks on the command-line
with `rails …` rather than `rake …`.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since Rails 5.0 is switching the Rails command line from 'rake …'
to 'rails …', it makes sense to also replace the `rake` method in
the Rails templates API.
Based on feedback from @matthewd and @kaspth, I chose to replace
`rake` with `rails_command`, which is less confusing than
the alternatives `rails` or `command` or `rails_run` and is not
Thor-reserved word like `task`.
|
| |/
|/| |
|
| | |
|
|/ |
|
|
|
|
|
|
| |
If you want to use `EventedFileUpdateChecker`, need to specify `listen` to plugin's gemspec.
However, the default is not specified `listen` to plugin's gemspec,
`EventedFileUpdateChecker` should be disabled.
|
| |
|
| |
|
| |
|
|\
| |
| | |
generate mailer views in Rails API
|
| |
| |
| |
| |
| | |
View files is necessary to send mail, it should be generated even Rails API.
Fixes #23617
|
|/
|
|
|
|
| |
3f70e8bd2 set a new bar for tests, but they weren't updated.
Update their expectation.
|
|\
| |
| | |
set association name to generated fixtures if attribute is reference
|
| |
| |
| |
| |
| |
| |
| | |
It has been changed to require `belongs_to` by default in Rails 5.
Therefore in order to pass the controller test, have association of set to fixtures.
Fixes #23384
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
| |
on sprockets environment
- Remove jquery-rails if --skip-sprockets is true
Fixes #23431
|