| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Application* parent
|
|
|
|
| |
I think Markdown is nowadays a better default.
|
| |
|
| |
|
| |
|
|\ |
|
| |\
| | |
| | | |
Introduce ApplicationRecord, an Active Record layer supertype
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It's pretty common for folks to monkey patch `ActiveRecord::Base` to
work around an issue or introduce extra functionality. Instead of
shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can
hold all those custom work the apps may need.
Now, we don't wanna encourage all of the application models to inherit
from `ActiveRecord::Base`, but we can encourage all the models that do,
to inherit from `ApplicationRecord`.
Newly generated applications have `app/models/application_record.rb`
present by default. The model generators are smart enough to recognize
that newly generated models have to inherit from `ApplicationRecord`,
but only if it's present.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In Rails 5.1 `ActionController::TestCase` will be moved out of Rails
into it's own gem. Please use `ActionDispatch::IntegrationTest` going
forward.
This changes the generators to use `ActionDispatch::IntegrationTest` and
the required URL setup (rather than symbols) for each of the controller
actions.
Updated fix to #22076.
|
| |/
| |
| |
| | |
We will wait until 5.1 to make a decision
|
|\| |
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9712a7a12b7f9e4dcef751ceda8a73c3f4beb11f, reversing
changes made to 3e65c3d3886336e9145438cdeacaf4ebec6a48b8.
Reverting because this caused test failures and while we have a followup
branch there is still one failure that happens randomly and isn't
straight forward to fix.
|
|\
| |
| | |
Controller generators should be creating IntegrationTest stubs instea…
|
| |
| |
| |
| | |
ControllerTest
|
|\ \
| | |
| | | |
Prevent a 500 in the default controller scaffold
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If you update a record with no attributes, you'll hit a 500 from a guard
in `assign_attributes` raising:
```ruby
ArgumentError: When assigning attributes, you must pass a hash as an argument.
app/controllers/users_controller.rb:44:in `block in update'
app/controllers/users_controller.rb:43:in `update'
test/controllers/users_controller_test.rb:37:in `block in <class:UsersControllerTest>'
```
Not a biggie, but may be quite confusing for the folks new to the
framework.
|
|/
|
|
|
| |
Web Console 3.0.0 is compatible with Rails 5, while the 2.x.x releases
aren't.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the absolute path is not required to re-run the test,
modified so that unnecessary information is not displayed.
```ruby
# before
bin/rails test /path/to/blorgh/test/integration/navigation_test.rb:5
# after
bin/rails test test/integration/navigation_test.rb:5
```
|
|\
| |
| |
| |
| | |
y-yagi/remove_request_forgery_protection_from_rails_api
remove `request_forgery_protection` initializer from rails api
|
| |
| |
| |
| |
| | |
In rails api, since default is so as not to use the `protect_from_forgery`,
`request_forgery_protection` initializer I think that's unnecessary
|
| |
| |
| |
| | |
Related with e62ddac05b7d827ae870898d7cd9eaf76e0730aa
|
|/
|
|
| |
Related with 668c006cf33a63ac3f8a8f064c772a339341e70c.
|
| |
|
|
|
|
|
|
|
|
|
| |
generator
In the app generator, regardless of the namespace, it is adapted to read the same `application_controller.rb`,
modified to api generator also be the same behavior.
ref 686966a1861e6761021d45f6795de753e8a62216, 06ac63b4c602e4b26cb3bfbf0dfd2bed8b00e786
|
| |
|
|
|
|
|
|
| |
We are using the same version constraint in the database adapters so
when a new version of the adapter that doesn't work with the version of
rails is released we don't break new applications.
|
|
|
|
| |
Also move the method to the right class
|
| |
|
|
|
|
| |
`README` it is changed to `README.rdoc` in 6b126e2, it has been changed to` README.md` further 89a12c9.
|
| |
|
|\
| |
| | |
add application_job.rb to template of mountable engine
|
| |
| |
| |
| |
| | |
since cb012467214f6e4bb1ac3987554bb75020b4796b, generated job inherents from ApplicationJob,
ApplicationJob is required in the mountable engine.
|
| |
| |
| |
| | |
Since the plugin generator do not generate assets, I think manifest.js also that it unnecessary.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
generator
This is follow up to #6643.
In #6643, the controller generator only had been fixed, in this commit to fix the scaffold generator.
|
| |
| |
| |
| | |
method_call_assertions
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
* set engine's route in setup
* use fixture with engine namespace
|
|\ \
| | |
| | |
| | |
| | | |
y-yagi/loading_fixtures_in_engine_integration_tests
set the correct path to `ActionDispatch::IntegrationTest.fixture_path`
|
| | |
| | |
| | |
| | |
| | | |
`ActionDispatch::IntegrationTest.fixture_path` set by `test_help.rb`, but if the engine,
path under the dummy is will be set, fixtures under test was not loaded.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This way, running a generator inside the plugin's directory, files that
are not relevant won't be generated (e.g. views or assets).
This won't interfere with the application's generators configuration.
|
| | | |
|
| | | |
|
|/ / |
|
|\ \
| |/
|/| |
remove `web-console` from API app generated Gemfile
|