aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/generators
Commit message (Collapse)AuthorAgeFilesLines
...
* | enables the evented monitor in new applicationsXavier Noria2016-02-101-0/+22
|/
* - app generate option --skip-sprockets leaves jquery-rails gem, which relies ↵Vipul A M2016-02-041-1/+2
| | | | | | | | on sprockets environment - Remove jquery-rails if --skip-sprockets is true Fixes #23431
* Update assertion on redis in generated GemfilePrem Sichanugrist2016-02-041-1/+1
| | | | | | | | Redis now included in Gemfile but commented out. This change was made in 91864439c7aebb6ca710831aac6781903a433904 and is causing the test failure. See https://travis-ci.org/rails/rails/jobs/106994913#L1025
* Merge pull request #23420 from y-yagi/move_api_test_to_appropriate_fileRafael França2016-02-022-11/+10
|\ | | | | move `test_generator_if_skip_action_cable_is_given_for_an_api_app` to the appropriate file
| * move `test_generator_if_skip_action_cable_is_given_for_an_api_app` to the ↵yuuji.yaginuma2016-02-022-11/+10
| | | | | | | | | | | | appropriate file Test of Rails API should be in `api_app_generator_test.rb`.
* | Generated engines should protect from forgeryAaron Patterson2016-02-011-3/+3
|/ | | | | | Generated engines should call `protect_from_forgery`. If this method isn't called, then the Engine could be susceptible to XSS attacks. Thanks @tomekr for reporting this to us!
* Merge pull request #23057 from schneems/schneems/default-puma-configRichard Schneeman2016-02-011-0/+9
|\ | | | | Add Default Puma Config
| * Add Default Puma Configschneems2016-01-291-0/+9
| | | | | | | | | | | | | | | | | | | | | | When the `puma` command is run without any configuration options it will detect presence of a `config/puma.rb` file and use that. Currently there is discrepancy between `puma` command and `rails server` but Evan said it would be reasonable to add in reading in config from the default location. I am working on that right now as a feature in puma/puma. Why do we need this? By default Puma uses 16 threads, and by default ActiveRecord only has 5 threads. Due to the architecture of AR it is guaranteed that if you're running with fewer DB connections than your server has threads you will hit `ActiveRecord::ConnectionTimeoutError ` eventually if your app gets modest amounts of traffic. Since we are providing a default webserver, we should provide reasonable configuration for that webserver. This PR does a few things, first it sets the default Puma thread count to 5 to mach ActiveRecord's default. It sets the default environment to `"development"` and the default port to 300 so that booting the server with `$ puma` will give you the same default port as `rails server`. It is worth mentioning that by reading in from `PORT` environment variable this config can work with containerized deployments, such as on Heroku. We are not using worker processes by default, that way JRuby and windows devs can use this configuration without modification. I went ahead and included a default `on_worker_boot`. It won't be used unless a worker count is specified, that means this config will not use it. Even though it's not being used now It will make someone who wants to try modifying their config to run extra workers easier. cc/ @pixeltrix
* | Merge pull request #23381 from matthewd/uneventful-redisMatthew Draper2016-02-021-3/+0
|\ \ | | | | | | Redis sans EventMachine
| * | Switch the default redis adapter to a single-stream modelMatthew Draper2016-02-011-3/+0
| | | | | | | | | | | | | | | | | | This new adapter does get a little more intimate with the redis-rb gem's implementation than I would like, but it's the least bad of the approaches I've come up with.
* | | make rake proxy work in rails enginesyuuji.yaginuma2016-01-312-5/+5
|/ /
* | Add an after_bundle callback in Rails plugin templatesRyan Manuel2016-01-282-2/+31
| |
* | Pare back default `index` option for the migration generatorPrathamesh Sonpatki2016-01-243-30/+10
| | | | | | | | | | | | | | | | | | | | - Using `references` or `belongs_to` in migrations will always add index for the referenced column by default, without adding `index:true` option to generated migration file. - Users can opt out of this by passing `index: false`. - Legacy migrations won't be affected by this change. They will continue to run as they were before. - Fixes #18146
* | Rails::Generators::Actions#gem should work even if frozen string is passed ↵Prathamesh Sonpatki2016-01-241-0/+8
| | | | | | | | | | | | as argument - Fixes #23137.
* | prevent --skip-action-cable from erroring when --api option is usedDave Riddle2016-01-221-0/+12
|/
* remove `per_form_csrf_tokens` initializer from Rails APIyuuji.yaginuma2016-01-221-0/+1
| | | | | Because the form is not in the Rails API, `per_form_csrf_tokens` initializer I think unnecessary.
* Merge pull request #23174 from JuanitoFatas/followup-skip-action-cableKasper Timm Hansen2016-01-221-0/+3
|\ | | | | Remove action_cable_meta_tag when skip Action Cable
| * Remove action_cable_meta_tag when skip action_cableJuanitoFatas2016-01-221-0/+3
| |
* | Add `config/cable.yml` to list of default files in Rails generatorJon Moss2016-01-211-0/+1
|/
* Merge pull request #23078 from ↵Rafael França2016-01-211-0/+4
|\ | | | | | | | | y-yagi/add_application_mailer_rb_to_mountable_engine add application_mailer.rb to template of mountable engine
| * allow symbol to end of string in `wrap_in_modules`yuuji.yaginuma2016-01-161-4/+4
| |
| * add application_mailer.rb to template of mountable engineyuuji.yaginuma2016-01-151-0/+4
| | | | | | | | | | since 9446e38ba47c9ca3be2ad668d8a8bea0141be6fc, generated mailer inherents from ApplicationMailer, ApplicationMailer is required in the mountable engine.
* | Merge pull request #22950 from maclover7/adapterize-storage-actioncableMatthew Draper2016-01-201-1/+11
|\ \ | | | | | | | | | Adapterize storage for ActionCable
| * | Add em-hiredis and redis as default Gems for new applicationsJon Moss2016-01-181-0/+10
| | |
| * | Adapterize ActionCable storage and extract behaviorJon Moss2016-01-181-1/+1
| |/
* / Remove incomplete filter runs all tests in plugins.Kasper Timm Hansen2016-01-181-8/+0
|/ | | | Forgot to remove it, when I changed the expectations in 88881d2.
* correctly presence check of `application_record.rb` in pluginyuuji.yaginuma2016-01-021-0/+9
|
* add test of that `application_record.rb` is generated in pluginyuuji.yaginuma2016-01-021-3/+7
|
* Add sass-rails back to the default GemfileRafael Mendonça França2015-12-301-0/+7
| | | | It was removed by mistake at 877a411d0c16baa4e670dae9a28f5cfcc201adc1
* remove cors initializer from rails appyuuji.yaginuma2015-12-221-0/+6
| | | | | `rack-cors` gem is defined in Gemfile by default only if the api, not defined by default in rails app.
* Merge pull request #22685 from jeyb/remove_cable_files_for_skip_action_cableRafael França2015-12-211-0/+3
|\ | | | | Ensure Action Cable files are removed when `skip_action_cable` is set.
| * Ensure Action Cable files are removed when `skip_action_cable` is set.Jey Balachandran2015-12-211-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | The Action Cable generators creates four files which need to be removed if `skip_action_cable` is set. 1. `app/assets/javascripts/cable.coffee` 2. `app/channels/application_cable/channel.rb` 3. `app/channels/application_cable/connection.rb` 4. `config/redis/cable.yml` Fixes #22669.
* | Use the generators options to not generate channel assetsRafael Mendonça França2015-12-211-6/+2
| |
* | Merge pull request #22727 from prathamesh-sonpatki/fix-masterKasper Timm Hansen2015-12-211-1/+4
|\ \ | | | | | | Ensure that assets are enabled back after the test that tests assets are disabled
| * | Ensure that assets are enabled back after the test that tests assets are ↵Prathamesh Sonpatki2015-12-211-1/+4
| | | | | | | | | | | | disabled
* | | Merge pull request #22684 from ↵Yves Senn2015-12-211-0/+9
|\ \ \ | |/ / |/| | | | | | | | teknofire/fix-using-add_resource-with-a-block-after-gem-call Fix using add_resource with a block after gem in custom generators
| * | Fixes using `add_source` with a block after using `gem` in a custom railsWill Fisher2015-12-211-0/+9
| |/ | | | | | | generator template.
* | Merge pull request #22692 from ryohashimoto/22669_api_generatorDavid Heinemeier Hansson2015-12-211-0/+30
|\ \ | | | | | | Action Cable channel generator doesn't create JS assets if options[:rails][:assets] is false
| * | Action Cable channel generator should not create JS assets in --api modeRyo Hashimoto2015-12-191-0/+30
| |/
* / display detailed information in inline reportingyuuji.yaginuma2015-12-212-2/+4
|/ | | | | | | | | | | | | | | | | | | | | The errors message only was not displayed, as if it did not use the inline reporting, modified to also information the method name and the like in error are displayed. ``` # before Failed assertion, no message given. bin/rails test test/models/user_test.rb:5 ``` ``` # after Failure: UserTest#test_the_truth: Failed assertion, no message given. bin/rails test test/models/user_test.rb:5 ```
* Do not check the version anymoreRafael Mendonça França2015-12-181-2/+2
| | | | | Our logic is complex now and we don't need to check the version to asset the behavior so I'm removing the checking here.
* Allow normal version updates within a release seriesMatthew Draper2015-12-181-0/+15
| | | | | | | | | | | | | | | | | | | We originally chose to apply very strict versioning on the `rails` entry in the Gemfile, because our future versioning policy was not strongly defined. Now it is, and our policy is very much designed on the expectation that people will regularly update to the latest patch level in their release series... so we should encourage that. Of course, Gemfile.lock will do its job and prevent unplanned updates, just as it does for every other gem in the bundle... but if you run `bundle update`, we want to get you the latest bug/security fixes without requiring a manual edit of the Gemfile entry. Our current version could be a few different shapes, so it takes a bit of work to find the right specifier, but in principle, we match anything of the form x.y.*, where x.y matches our current release series.
* ApplicationMailer should be generated by default just like every other ↵David Heinemeier Hansson2015-12-173-26/+1
| | | | Application* parent
* README.rdoc -> README.md for newly generated pluginsyuuji.yaginuma2015-12-171-3/+3
| | | | I think Markdown is nowadays a better default.
* Fix testsDavid Heinemeier Hansson2015-12-171-2/+0
|
* No longer uses keep now that we have ApplicationRecordDavid Heinemeier Hansson2015-12-161-1/+0
|
* Fix testDavid Heinemeier Hansson2015-12-161-1/+10
|
* Merge branch 'master' into merge-action-cableRafael Mendonça França2015-12-167-26/+37
|\
| * Merge pull request #22567 from gsamokovarov/introduce-application-recordRafael França2015-12-162-0/+12
| |\ | | | | | | Introduce ApplicationRecord, an Active Record layer supertype
| | * Introduce ApplicationRecord, an Active Record layer supertypeGenadi Samokovarov2015-12-162-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's pretty common for folks to monkey patch `ActiveRecord::Base` to work around an issue or introduce extra functionality. Instead of shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can hold all those custom work the apps may need. Now, we don't wanna encourage all of the application models to inherit from `ActiveRecord::Base`, but we can encourage all the models that do, to inherit from `ApplicationRecord`. Newly generated applications have `app/models/application_record.rb` present by default. The model generators are smart enough to recognize that newly generated models have to inherit from `ApplicationRecord`, but only if it's present.