aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/generators
Commit message (Collapse)AuthorAgeFilesLines
* Use escaped character in regexpyhirano552017-09-111-1/+1
|
* Add credentials using a generic EncryptedConfiguration class (#30067)David Heinemeier Hansson2017-09-113-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * WIP: Add credentials using a generic EncryptedConfiguration class This is sketch code so far. * Flesh out EncryptedConfiguration and test it * Better name * Add command and generator for credentials * Use the Pathnames * Extract EncryptedFile from EncryptedConfiguration and add serializers * Test EncryptedFile * Extract serializer validation * Stress the point about losing comments * Allow encrypted configuration to be read without parsing for display * Use credentials by default and base them on the master key * Derive secret_key_base in test/dev, source it from credentials in other envs And document the usage. * Document the new credentials setup * Stop generating the secrets.yml file now that we have credentials * Document what we should have instead Still need to make it happen, tho. * [ci skip] Keep wording to `key base`; prefer defaults. Usually we say we change defaults, not "spec" out a release. Can't use backticks in our sdoc generated documentation either. * Abstract away OpenSSL; prefer MessageEncryptor. * Spare needless new when raising. * Encrypted file test shouldn't depend on subclass. * [ci skip] Some woordings. * Ditch serializer future coding. * I said flip it. Flip it good. * [ci skip] Move require_master_key to the real production.rb. * Add require_master_key to abort the boot process. In case the master key is required in a certain environment we should inspect that the key is there and abort if it isn't. * Print missing key message and exit immediately. Spares us a lengthy backtrace and prevents further execution. I've verified the behavior in a test app, but couldn't figure the test out as loading the app just exits immediately with: ``` /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `load': marshal data too short (ArgumentError) from /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `run' from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest.rb:830:in `run_one_method' from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest/parallel.rb:32:in `block (2 levels) in start' ``` It's likely we need to capture and prevent the exit somehow. Kernel.stub(:exit) didn't work. Leaving it for tomorrow. * Fix require_master_key config test. Loading the app would trigger the `exit 1` per require_master_key's semantics, which then aborted the test. Fork and wait for the child process to finish, then inspect the exit status. Also check we aborted because of a missing master key, so something else didn't just abort the boot. Much <3 to @tenderlove for the tip. * Support reading/writing configs via methods. * Skip needless deep symbolizing. * Remove save; test config reader elsewhere. * Move secret_key_base check to when we're reading it. Otherwise we'll abort too soon since we don't assign the secret_key_base to secrets anymore. * Add missing string literal comments; require unneeded yaml require. * ya ya ya, rubocop. * Add master_key/credentials after bundle. Then we can reuse the existing message on `rails new bc4`. It'll look like: ``` Using web-console 3.5.1 from https://github.com/rails/web-console.git (at master@ce985eb) Using rails 5.2.0.alpha from source at `/Users/kasperhansen/Documents/code/rails` Using sass-rails 5.0.6 Bundle complete! 16 Gemfile dependencies, 72 gems now installed. Use `bundle info [gemname]` to see where a bundled gem is installed. Adding config/master.key to store the master encryption key: 97070158c44b4675b876373a6bc9d5a0 Save this in a password manager your team can access. If you lose the key, no one, including you, can access anything encrypted with it. create config/master.key ``` And that'll be executed even if `--skip-bundle` was passed. * Ensure test app has secret_key_base. * Assign secret_key_base to app or omit. * Merge noise * Split options for dynamic delegation into its own method and use deep symbols to make it work * Update error to point to credentials instead * Appease Rubocop * Validate secret_key_base when reading it. Instead of relying on the validation in key_generator move that into secret_key_base itself. * Fix generator and secrets test. Manually add config.read_encrypted_secrets since it's not there by default anymore. Move mentions of config/secrets.yml to config/credentials.yml.enc. * Remove files I have no idea how they got here. * [ci skip] swap secrets for credentials. * [ci skip] And now, changelogs are coming.
* Explicitly require `test_unit/reporter` in test helperyuuji.yaginuma2017-09-041-0/+6
| | | | | | | | | | | If the user used the `bin/test` to execute the test, this file is automatically loaded, so require is unnecessary. https://github.com/rails/rails/blob/acea68de026ba657cb65c4dd0fc1f24ba67e1cf8/railties/lib/rails/plugin/test.rb#L4 However, when using `rake test`, an explicit require is required because the above file is not loaded. Fixes #30516
* Merge pull request #30323 from yhirano55/support_multiple_version_for_gem_methodMatthew Draper2017-08-311-4/+11
|\ | | | | Support multiple versions arguments for `gem` method of Generators
| * Support multiple versions arguments for `gem` method of GeneratorsYoshiyuki Hirano2017-08-191-4/+11
| |
* | Merge pull request #30370 from ↵Kasper Timm Hansen2017-08-281-2/+2
|\ \ | | | | | | | | | | | | yhirano55/fix_indentation_in_secrets_yaml_template Fix indentation in the template for secrets
| * | Fix indentation in the template for secretsYoshiyuki Hirano2017-08-231-2/+2
| |/
* / Remove frozen_string_literal magic comment from templatesKoichi ITO2017-08-221-2/+0
|/
* Move common tests from `AppGeneratorTest` and `PluginGeneratorTest` to ↵bogdanvlviv2017-08-173-200/+114
| | | | `SharedGeneratorTests`
* Fix RuboCop offensesKoichi ITO2017-08-163-7/+7
| | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* Add --skip-yarn option to the plugin generatorbogdanvlviv2017-08-153-26/+34
| | | | | Add SharedGeneratorTests#application_path This method will help to DRY in files app_generator_test.rb, plugin_generator_test.rb
* Fix typo for api_app_generator_testYoshiyuki Hirano2017-08-151-1/+1
|
* Merge pull request #30219 from yhirano55/fix_app_generator_api_optionsRafael França2017-08-142-22/+41
|\ | | | | Refactor `--api` option of the app generator
| * Refactor `--api` option of the app generatorYoshiyuki Hirano2017-08-132-22/+41
| | | | | | | | | | It can't use JavaScript in api mode. Action cable should be disabled by default.
* | Merge pull request #30241 from yhirano55/optimize_routes_indentationRafael Mendonça França2017-08-141-0/+7
|\ \ | | | | | | | | | Optimize routes indentation
| * | Optimize routes indentationYoshiyuki Hirano2017-08-141-0/+7
| |/
* | Add frozen string pragma to expected routes files.Pat Allan2017-08-141-0/+2
| |
* | Adding frozen_string_literal pragma to Railties.Pat Allan2017-08-1433-0/+66
| |
* | Railties updates for frozen string literals.Pat Allan2017-08-142-2/+2
|/
* Merge pull request #30166 from yhirano55/fix_generator_method_environmentRafael Mendonça França2017-08-111-6/+66
|\ | | | | | | Optimize indentation for generator actions
| * Optimize indentation for generator actionsYoshiyuki Hirano2017-08-111-6/+66
| |
* | Merge pull request #30116 from ↵Rafael Mendonça França2017-08-111-1/+13
|\ \ | | | | | | | | | | | | | | | yhirano55/skip_unused_components_when_running_rails_command_in_plugin Skip unused components when running `bin/rails` in Rails plugin
| * | Skip unused components when running in Rails pluginYoshiyuki Hirano2017-08-091-1/+13
| | |
* | | Merge pull request #30110 from yhirano55/add_git_sourceRafael Mendonça França2017-08-111-0/+5
|\ \ \ | | | | | | | | | | | | Add git_source to Gemfile for plugin generator
| * | | Add git_source to Gemfile for plugin generatorYoshiyuki Hirano2017-08-091-0/+5
| |/ /
* | / Refactor app_generator_test (#30192)yhirano552017-08-111-1/+8
| |/ |/|
* | `--skip-action-cable` pass throughs `rails plugin new`bogdanvlviv2017-08-101-0/+6
| |
* | Improve plugin generator tests. Related to #30123.bogdanvlviv2017-08-102-44/+74
| | | | | | | | | | | | | | | | Improve app generator tests. Ensure that generation `config/application.rb` is correct. Ensure that generation `config/application.rb` is correct.
* | Merge pull request #30091 from yhirano55/fix_engine_commandRafael França2017-08-081-0/+4
|\ \ | | | | | | Fix engine command
| * | Fix engine commandYoshiyuki Hirano2017-08-061-0/+4
| |/
* / Fix escaped characterYoshiyuki Hirano2017-08-061-1/+1
|/
* Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-042-1/+3
|\ | | | | Add Active Storage to Rails
| * Include active_storage in all generated application.rb filesDavid Heinemeier Hansson2017-08-041-1/+2
| | | | | | | | And deal with a temporary test fix until we allow you to skip active storage.
| * Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-021-1/+1
| |\
| * \ Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-012-1/+2
| |\ \
| * | | Use config/storage.yml as part of the skeleton and loadingDavid Heinemeier Hansson2017-07-311-1/+1
| | | |
| * | | Include default storage configurationDavid Heinemeier Hansson2017-07-311-0/+1
| | | |
* | | | Merge pull request #30011 from guilherme/fix-migration-generator-special-casesSean Griffin2017-08-031-0/+22
|\ \ \ \ | |_|_|/ |/| | | Handling add/remove to/from migration edge cases
| * | | Handling add/remove to/from migration edge casesGuilherme Reis Campos2017-08-031-0/+22
| | | | | | | | | | | | | | | | Making sure the table name is parsed correctly when an add/remove column migration have 'from'/'to' in the table name.
* | | | Merge remote-tracking branch 'origin/master' into unlock-minitestRafael Mendonça França2017-08-015-34/+55
|\ \ \ \ | | |_|/ | |/| |
| * | | Merge pull request #30015 from larskanis/use-duktake-on-mingwGuillermo Iguaran2017-08-011-0/+2
| |\ \ \ | | | | | | | | | | Use duktape gem as default JS engine on Windows-MINGW
| | * | | Use duktape gem as default JS engine on Windows-MINGW and MS-Visual-C buildsLars Kanis2017-08-011-0/+2
| | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fallback javascript engine on Windows is Windows Script Host (JScript). However this engine isn't able to process the default assets, because it supports ES3 only but the coffeescript compiler requires ES5. Fixes #30014
| * | / Remove unnecessary `doc` directory deletionyuuji.yaginuma2017-08-011-1/+0
| | |/ | |/| | | | | | | Since 553b695, `doc` directory is not created in application.
| * | Set Ruby version in Gemfile and .ruby-version by defaultAlberto Almagro2017-07-311-0/+12
| |/
| * Stop creating ApplicationRecord on model generationLisa Ugray2017-07-244-33/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When generating models, we created ApplicationRecord in the default location if no file existed there. That was annoying for people who moved it to somewhere else in the autoload path. At this point, the vast majority of apps should have either run the upgrade script or generated a model since upgrading. For those that haven't the error message after generating a new model should be helpful: NameError: uninitialized constant ApplicationRecord To ease friction in that case, this also adds a generator for ApplicationRecord.
| * Do not generate unused components contents in `app:update` taskyuuji.yaginuma2017-07-161-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | Currently, `app:update` generates all contents regardless of the component using in application. For example, even if not using Action Cable, `app:update` will generate a contents related to Action Cable. This is a little inconvenient. This PR checks the existence of the component and does not generate unnecessary contents. Can not check all options in this way. However, it will be able to prevent the generation of unnecessary files.
* | Fix test runner's outputyuuji.yaginuma2017-07-301-1/+1
|/ | | | | | | | Output changed due to specification change of `SummaryReporter#aggregated_results` in minitest 5.10.2. In my opinion, that should fix rails's test runner(proceeding with #29354). However, we still need discussion and the fix itself is minor, so I think that we can fix only the test first.
* Update default app files in app_generator_testKoichi ITO2017-07-061-2/+40
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-0232-32/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-0232-0/+32
|\ | | | | | | Enforce frozen string in Rubocop
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 09:34:11 +0000