| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| | |
add warnings option to test runner
|
| | |
|
|/
|
|
|
| |
When specifying the `pretend` option, expect that no processing will be
done, so do not execute `git init` as well.
|
|\
| |
| |
| | |
Initalize git repo when creatin new rails app
|
| |
| |
| |
| |
| | |
* If `--skip-git` is not specified initalize git repo
when creating new rails app
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 8cb3cdffdb70f3575518d24ea96ec891e40d21d0, reversing
changes made to 3bc747bd8676dc940b531067e2861dcd4ac28efc.
Reason: This test already exists in `SharedGeneratorTests`.
Ref:
https://github.com/rails/rails/blob/master/railties/test/generators/shared_generator_tests.rb#L109..L112
https://github.com/rails/rails/blob/master/railties/test/generators/app_generator_test.rb#L55..L56
|
| | |
|
| |
| |
| |
| | |
We don't want to leak the extra migration path to other railties tests.
|
| |
| |
| |
| | |
We don't want to leak the extra migration path to other railties tests.
|
| | |
|
|/
|
|
|
|
|
|
| |
Currently, all rails commands can be executed in engine,
but `server`, `console`, `dbconsole` and `runner` do not work.
This make all rails commands work in engine.
Related to #22588
|
|
|
|
| |
- Fixes #27591.
|
|
|
|
|
|
|
|
|
| |
mtsmfm/fix-generator-command-for-nested-rails-engine"
This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing
changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1.
Reason: It breaks the public API
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we create nested (namespaced) rails engine such like bukkits-admin,
`bin/rails g scaffold User name:string age:integer`
will create
`bukkits-admin/app/controllers/bukkits/users_controller.rb`
but it should create
`bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.
In #6643, we changed `namespaced_path` as root path
because we supposed application_controller is always in root
but nested rails engine's application_controller will not.
|
|
|
|
|
|
| |
- No need to remove bin/yarn separately for API only apps because
:skip_yarn is set to true for API only apps.
- Added a test for :skip_yarn config.
|
|
|
|
|
|
| |
Fixes #27447
[Matthew Draper & Yuuji Yaginuma]
|
| |
|
|
|
| |
Follow up to 0d20530e5edfd7d00fbc2a38ef5f87eca6ccc924
|
| |
|
| |
|
|
|
| |
Move node_modules, package.json, and yarn.lock file to vendor
|
|\
| |
| | |
Add Yarn support in new apps using --yarn option
|
| | |
|
| | |
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
`rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`.
```
% rails plugin new my_engine -S --full --skip-gemspec
% cd my_engine
% bin/rails test
rails aborted!
NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100>
```
|
| |
|
| |
|
| |
|
|
|
|
| |
If `sprockets` is not loaded, `Rails.application.config.assets` is not defined.
|
| |
|
|
|
|
|
|
|
| |
29f0fbd5db643b885665e4a14c7de3bf6c0d9c96 has changed that always call
`Minitest.autorun` in `active_support/testing/autorun`.
Therefore, when used directly `Minitest.run`, tests are performed twice.
|
|
|
|
|
|
| |
assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message
assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
|
|
|
|
| |
Follow up to 92703a9ea5d8b96f30e0b706b801c9185ef14f0e
|
|\
| |
| |
| |
| | |
y-yagi/remove_test_mailers_when_skipping_action-mailer
remove "test/mailers" directory when skipping action-mailer
|
| |
| |
| |
| | |
Related to #26146
|
|/
|
|
|
|
|
|
| |
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
|
|
|
|
| |
Closes #26145
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I dropped the version constraint in web-console with the idea it will be
easier to upgrade the console between Rails releases. However, issues
like #25899 started popping up.
I'm reintroducing the constraint, but this time, I don't set an upper
limit to the major version. This will keep the web-console in a version
that always works for the current Rails version and can be easily
upgraded to the last one with `bundle update`.
We may need to backport this for Rails 5.0.1.
Fixes #25899.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initializer
- By default the session store will be set to cookie store with
application name as session key.
- Older apps are not affected as they will have the session store
initializer generated by Rails in older versions, and Rails will not
overwrite the session store if it is already set or disabled.
- But new apps will not have the initializer, instead the session store
will be set to cookie store by default.
- Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
|