aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/generators
Commit message (Collapse)AuthorAgeFilesLines
* Do not run `bundle install` when generating a new plugin.Rafael Mendonça França2016-07-013-101/+102
| | | | | | Since bundler 1.12.0, the gemspec is validated so the `bundle install` command will fail just after the gem is created causing confusion to the users. This change was a bug fix to correctly validate gemspecs.
* Merge pull request #25319 from morgoth/generate-application-record-firstRafael França2016-06-134-18/+18
|\ | | | | Generate application_record.rb file before model file
| * Generate application_record.rb file before model fileWojciech Wnętrzak2016-06-084-18/+18
| | | | | | | | | | | | Previously model file was generated first, which resulted in inheriting from `ActiveRecord::Base`, but since application_record.rb is generated as well, it should already be used.
* | Merge pull request #25004 from ↵Eileen M. Uchitelle2016-06-122-0/+23
|\ \ | |/ |/| | | | | y-yagi/generate_mailer_layout_files_if_it_does_not_already_exist generate mailer layout files if it does not already exist
| * generate mailer layout files if it does not already existyuuji.yaginuma2016-05-152-0/+23
| | | | | | | | | | | | | | | | | | Currently, if `ApplicationMailer` does not exist, it is generated when run the mailer generator, but layouts files does not generate. However, because it uses the layouts in `ApplicationMailer`, layouts are required. Follow up to #24161
* | Fix API controller tests by assigning them the encoding typePrathamesh Sonpatki2016-06-071-2/+2
| | | | | | | | | | | | | | - Fixes #25183. - The `as: :json` feature was added in https://github.com/rails/rails/pull/21671 and recommended to use for JSON endpoints so let's use it by default for API controller tests.
* | Remove FORCE option as it was only needed for testsPrathamesh Sonpatki2016-06-071-1/+3
| | | | | | | | - Adjusted tests instead.
* | Fix minor regression about old apps not getting per_form_csrf and ↵Prathamesh Sonpatki2016-06-041-17/+6
| | | | | | | | | | | | | | | | | | | | | | | | request_forgery_protection configs - Earlier per_form_csrf_tokens and request_forgery_protection config files were generated for old apps upgraded to Rails 5. - But when we collapsed all initializers into one file, the entire file does not get created for old apps. - This commit fixes it and also changes values for all new defaults for old apps so that they will not break. - Also added a test for `rails app:update`.
* | Collapse all new default initializers into a single filePrathamesh Sonpatki2016-05-312-93/+19
| | | | | | | | | | | | - Adjusted tests also for this new behavior. - Based on the discussion in https://github.com/rails/rails/pull/25184#issuecomment-222454583.
* | Move new default initializers into separate directoryPrathamesh Sonpatki2016-05-282-19/+19
| | | | | | | | | | | | - These initializers are new defaults for Rails 5 and newly generated apps do not need to change them. - Fixes #25181
* | Fix more assertion counts.Kasper Timm Hansen2016-05-281-2/+2
| | | | | | | | Follow up to e45f388.
* | Remove public/ files for API appsPrathamesh Sonpatki2016-05-281-1/+7
| | | | | | | | - Fixes #25180
* | Cable: Generate .js or .coffee files while generating channel as per the ↵Prathamesh Sonpatki2016-05-171-4/+20
|/ | | | | | | | | | | | | | | | | | | | | javascript engine of the application - Now we will detect what javascript engine user is using and based on that we will generate either `.js` or `.coffee` version of the channel file. - This also needs a change in coffee-rails to override the `js_template` method. Related PR https://github.com/rails/coffee-rails/pull/72. - Currently coffee-rails gem sets `config.app_generators.javascript_engine` to `:coffee` and using this information we override the `js_template` to set the extension as `.coffee` in coffee-rails gem. - Using this approach, we can keep the `channel.js` and `channel.coffee` files in the Rails repository itself. - Additionally the `js_template` method can act as public interface for coffee-rails gem to hook into and change the extension to `.coffee` without maintaining the actual asset files. [Prathamesh Sonpatki, Matthew Draper]
* Add compatibility for Ruby 2.4 `to_time` changesAndrew White2016-04-231-0/+28
| | | | | | | | | | | | | | | In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will preserve the timezone of the receiver when converting to an instance of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we need to introduce a compatibility layer so that apps that upgrade do not break. New apps will have a config initializer file that defaults to match the new Ruby 2.4 behavior going forward. For information about the changes to Ruby see: https://bugs.ruby-lang.org/issues/12189 https://bugs.ruby-lang.org/issues/12271 Fixes #24617.
* don't remove `cable.js`yuuji.yaginuma2016-04-161-0/+12
| | | | `cable.js` is required for other Channels.
* Generate `cable.js` file if does not exist when generating channelPrathamesh Sonpatki2016-04-121-0/+8
| | | | | | | | | - Before this, while generating a channel, we were not creating `cable.js` if it does not already exist. - We have similar code for application mailer here - https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4. - Based on the comment - https://github.com/rails/rails/issues/24418#issuecomment-205421995.
* Merge pull request #24165 from y-yagi/generate_application_job_when_not_existEileen M. Uchitelle2016-04-092-0/+20
|\ | | | | generate ApplicationJob if it does not already exist
| * generate ApplicationJob if it does not already existyuuji.yaginuma2016-03-252-0/+20
| | | | | | | | | | | | ActiveJob jobs now inherit from ApplicationJob by default. However, when updating to Rails 5 from the old Rails, since there is a possibility that ApplicationJob does not exist.
* | Use new hash syntax (#24464)Jeroen Visser2016-04-081-2/+2
|/ | | | | | * Updated syntax * Updated tests to match syntax
* Merge pull request #24164 from prathamesh-sonpatki/fix-application-mailerRafael França2016-03-231-0/+13
|\ | | | | Correctly generate application_mailer.rb in mountable engines
| * Correctly generate application_mailer.rb in mountable enginesPrathamesh Sonpatki2016-03-121-0/+13
| | | | | | | | - Followup of https://github.com/rails/rails/pull/24161.
* | Merge pull request #24243 from dewski/dont-upgrade-file-watcherArthur Neves2016-03-211-0/+14
|\ \ | | | | | | | | | Comment out config.file_watcher during Rails upgrade process
| * | Add tests for file_watcher config on updateArthur Neves2016-03-211-0/+14
| |/ | | | | | | [related #24243]
* / Fix generator test to match to use the stringRafael Mendonça França2016-03-211-1/+1
|/
* generate application_mailer.rb if it is missingSen-Zhang2016-03-111-0/+6
|
* Merge pull request #23940 from prathamesh-sonpatki/rm-with-dispatchersRafael França2016-03-091-12/+12
|\ | | | | Remove passing `with_dispatchers` to AppGenerator
| * Remove passing `with_dispatchers` to AppGeneratorPrathamesh Sonpatki2016-03-091-12/+12
| | | | | | | | | | | | | | - While working on https://github.com/rails/rails/pull/22790 I found out that we pass `with_dispatchers: true` but it's not used at all by Rails. - We were passing `with_dispatchers: true` in few tests too but again it's not used by Rails.
* | AppGenerator: allow both 'rake' and 'rails'claudiob2016-03-091-5/+5
| | | | | | | | | | | | | | | | | | This commit comes from the comments made by @matthewd at https://github.com/rails/rails/pull/23795/files#r54469637 and by @rafaelfranca at https://github.com/rails/rails/pull/23795/files#r54609364 The idea is that if you type (for example) "rake db:migrate" in an AppGenerator, then this should actually invoke `rake db:migrate` on the command line, whereas if you type "rails_command db:migrate", this should invoke `rails db:migrate`.
* | Fix the tests after e594000Genadi Samokovarov2016-03-081-2/+2
| |
* | Drop the explicit version requirements for web-consoleGenadi Samokovarov2016-03-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Between major versions 2 and 3, we hit a bug. It's fixed in version 3, however, the explicit 2.x requirement of `~> '2.0'` will prevent people from getting the fix with `bundle update` and they would have to explicitly set the constraint to `~> '3.0'`. For more information see: rails/web-console#178. I propose we drop the explicit version constraints in the Gemfile. Web Console has been relatively stable for the past couple of years, and I don't anticipate any major alterations, like we saw between major versions 1 and 2.
* | Merge pull request #24001 from 5t111111/fix-gsub-cookies_serializerRafael França2016-03-021-1/+2
|\ \ | | | | | | Fix description in cookies_serializer.rb being corrupted by gsub when updating
| * | Fix description in cookies_serializer.rb being corrupted when updatingHirofumi Wakasugi2016-03-021-1/+2
| | |
* | | Fix typo in app_generator_test.rbHirofumi Wakasugi2016-03-021-1/+1
|/ /
* | Merge pull request #23935 from y-yagi/convert_cable_coffee_to_javascriptRafael França2016-03-011-1/+1
|\ \ | | | | | | convert cable.coffee to cable.js
| * | convert cable.coffee to cable.jsyuuji.yaginuma2016-02-281-1/+1
| |/ | | | | | | In order to eliminate the dependecy of CoffeeScript.
* | Mock fork twiceRafael Mendonça França2016-03-011-1/+1
| |
* | generate config/spring.rb in new applications [closes #18874]Xavier Noria2016-02-291-0/+2
| |
* | - Made changes to have test cases in actions_test more readable.Mohit Natoo2016-02-291-6/+6
| | | | | | | | Changed description with tests related to rails_command.
* | - Made changes to have test cases in actions_test more readable.Mohit Natoo2016-02-291-5/+5
| |
* | Address ruby warningsTeo Ljungberg2016-02-291-8/+8
|/ | | | | - Ambiguous first argument - Mismatched indentation
* remove rack cors initializer when updatingyuuji.yaginuma2016-02-271-0/+26
| | | | Rack cors initializer is only necessary to API-only applications, for when the update is unnecessary.
* [close #23681] Use puma 3.0.0+ schneems2016-02-261-0/+5
| | | | | Puma 3.0 and up introduced compatibility to read from `config/puma.rb` when booting from the command `$ rails server`https://github.com/puma/puma/pull/856.
* Merge pull request #23852 from prathamesh-sonpatki/hsts-subdomainsRafael França2016-02-251-0/+28
|\ | | | | Enable HSTS with IncludeSubdomains header by default for new apps
| * Old applications will not get the ssl_options initializerPrathamesh Sonpatki2016-02-251-0/+28
| | | | | | | | | | - We will remove the initializer for old apps which are migrated to Rails 5 so that they are not affected by this breaking change.
* | Merge pull request #23846 from ↵Rafael França2016-02-251-0/+14
|\ \ | |/ |/| | | | | y-yagi/correctly_check_ApplicationRecord_in_mountable_engine correctly check `ApplicationRecord` is exist in moutable engine
| * correctly check `ApplicationRecord` is exist in moutable engineyuuji.yaginuma2016-02-251-0/+14
| | | | | | | | Follow up to 1813b29fc7632959800252f36e4b2e6ed4ac7266
* | Enable Action Cable routes by defaultJon Moss2016-02-241-3/+0
| | | | | | | | This also marks Action Cable routes as internal to Rails.
* | Merge pull request #23795 from claudiob/replace-rack-with-rails-commandDavid Heinemeier Hansson2016-02-241-5/+43
|\ \ | | | | | | AppGenerator: Replace 'rake' with 'rails_command'
| * | Invoke 'rails' instead of 'rake' in AppGeneratorclaudiob2016-02-201-10/+10
| | | | | | | | | | | | | | | Follows the convention from Rails 5 of invoking tasks on the command-line with `rails …` rather than `rake …`.
| * | AppGenerator: Replace 'rake' with 'rails_command'claudiob2016-02-201-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Rails 5.0 is switching the Rails command line from 'rake …' to 'rails …', it makes sense to also replace the `rake` method in the Rails templates API. Based on feedback from @matthewd and @kaspth, I chose to replace `rake` with `rails_command`, which is less confusing than the alternatives `rails` or `command` or `rails_run` and is not Thor-reserved word like `task`.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 02:18:38 +0000