| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |
| |
| |
| |
| |
| | |
The changes in #18149 added tests for the app generator, but only fixed
it for the plugin generator (I should have let CI finish though I think
it would have failed as an allowed failure).
|
| | | |
|
| | | |
|
| |\ \
| | |
| | | |
Test coverage for ActiveJob generator
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Don't remove mailer layouts files
|
| | |/ / |
|
| |/ /
| |
| |
| |
| |
| |
| |
| | |
Fixes https://github.com/rails/rails/issues/17340.
Use Minitest::BacktraceFilter instead of removing all silencers. This
will allow the backtrace for all libraries in the plugin to be shown
while removing noise generated by Minitest's backtrace.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If you run a generator such as:
```
rails generate model accounts supplier:references
```
The resulting migration will now add the corresponding foreign key
constraint unless the reference was specified to be polymorphic.
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
tags to reduce spam score
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
https://travis-ci.org/rails/rails/jobs/39190983#L460
1) Failure:
AppGeneratorTest#test_psych_gem
[test/generators/app_generator_test.rb:495]:
Expected /gem 'psych',\s+'~> 2.0', \s+platforms: :rbx/ to match <snip>
http://git.io/uuLVag)\ngem 'psych', '~> 2.0', platforms: :rbx\n\n
|
| | |
| |
| |
| |
| |
| |
| | |
For the most part of cases --skip-gems option just remove one line in
the Gemfile. This is not worth for the complexity it adds.
Closes #17196
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Closes #17197.
Closes #17207.
`{required}` is a type modifier so it should be:
user:references{required}:index
and not:
user:references:index{required}
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
This was caused by #15327.
|
| | |
| |
| |
| | |
Change position of require active_job
|
| |\ \
| | |
| | | |
Add a `required` option to the model generator
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Syntax was chosen to follow the passing of multiple options to
decimal/numeric types. Curly braces, and allowing any of `,`, `.`, or
`-` to be used as a separator to avoid the need for shell quoting. (I'm
intending to expand this to all columns, but that's another PR.
The `required` option will cause 2 things to change. `required: true`
will be added to the association. `null: false` will be added to the
column in the migration.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
As per discussion, this changes the model generators to specify
`null: false` for timestamp columns. A warning is now emitted if
`timestamps` is called without a `null` option specified, so we can
safely change the behavior when no option is specified in Rails 5.
|
| |/ /
| |
| |
| | |
Broken by fbe38c9e9d4fe9f82518e8ffc1d757459b0c5f1c
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Add an after_bundle callback in Rails templates
Conflicts:
railties/CHANGELOG.md
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The template runs before the generation of binstubs – this does not
allow to write one, that makes an initial commit to version control.
It is solvable by adding an after_bundle callback.
|
| | | |
| | |
| | |
| | |
| | | |
Also keep the hook as other tools may rely on it,
we just don't do anything by default on Rails.
|
| | | | |
|
| | | | |
|
| |/ /
| |
| |
| | |
simply be tested as part of the view thats using them. If you need something beyond that, you can add a test yourself for them
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/
|
|
|
|
|
| |
This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing
changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d.
Closes #16343
|
| |
|
|
|
|
|
|
|
|
| |
Since the rubysl-yaml gem doesn't ship with Psych by default because of
its dependency on libyaml, on Rubinius, the default engine is Syck.
However, if we want to be able to run the application safely on
different rubies, we need to make people using Rubinius rely on Psych.
See http://git.io/uuLVag for further information.
|
| |\
| |
| |
| |
| | |
Conflicts:
actionpack/test/abstract_unit.rb
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We are planning to remove mocha from our test suite because of
performance problems. To make this possible we should stop require mocha
on ActionSupport::TestCase.
This should not affect applications since users still need to add mocha
to Gemfile and this already load mocha.
Added FIXME notes to place that still need mocha removal
|
| |/ |
|
| |
|
|
|
|
|
|
|
| |
As we are setting notice in destroy action we should display that
For more information see https://github.com/rails/rails/pull/14044
And https://github.com/rails/jbuilder/pull/191
closes #14044
|
| |
|
|
|
| |
This way it is possible to skip the addition of the 'get "foo/bar"' routes when
generating a controller.
|
| |
|
|
|
|
|
|
|
|
| |
Also remove --skip-turbolinks.
This option is useful if users want to remove some gems like jbuilder,
turbolinks, coffee-rails, etc that don't have specific options on the
generator.
rails new my_app --skip-gems turbolinks coffee-rails
|
| | |
|
| |\
| |
| | |
Swallow bundler exceptions when running tests
|
| | |
| |
| |
| | |
Let's avoid useless output when testing stuff related to Bundler.
|
| | | |
|
| |\ \
| | |
| | |
| | | |
Replace double quotes with single quotes while adding an entry into Gemfile
|
