aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/generators
Commit message (Collapse)AuthorAgeFilesLines
* Add mailer suffix to generated files and classesCarlos Souza2015-01-062-28/+35
| | | | | Following the same naming convention used in controllers and jobs.
* Remove debugger supportRafael Mendonça França2015-01-042-6/+0
| | | | | bebugger doesn't work with Ruby 2.2 so we don't need to support it anymore
* Change the default `null` value for `timestamps` to `false`Rafael Mendonça França2015-01-041-1/+1
|
* Remove deprecated methods at `Kernel`.Rafael Mendonça França2015-01-041-0/+10
| | | | `silence_stderr`, `silence_stream`, `capture` and `quietly`.
* Improve the matches on the scaffold generator testsCarlos Antonio da Silva2015-01-031-9/+8
| | | | Related to #13434.
* Merge pull request #13434 from tanraya/local_variablesCarlos Antonio da Silva2015-01-031-0/+11
|\ | | | | | | | | | | | | Use local variables in _form.html.erb generated by scaffold. Conflicts: railties/CHANGELOG.md
| * Use local variables in _form.html.erb generated by scaffold generator.tanraya2014-07-261-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | It seems a good idea to use local variables in generated partials instead of using instance variables. Before <%= render 'form' %> After <%= render 'form', product: @product %>
* | Merge pull request #17227 from claudiob/explicitly-abort-callbacksRafael Mendonça França2015-01-031-0/+32
|\ \ | | | | | | | | | | | | | | | | | | Introduce explicit way of halting callback chains by throwing :abort. Deprecate current implicit behavior of halting callback chains by returning `false` in apps ported to Rails 5.0. Completely remove that behavior in brand new Rails 5.0 apps. Conflicts: railties/CHANGELOG.md
| * | Add config to halt callback chain on return falseclaudiob2015-01-021-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This stems from [a comment](rails#17227 (comment)) by @dhh. In summary: * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning. * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning. For this purpose, this commit introduces a Rails configuration option: ```ruby config.active_support.halt_callback_chains_on_return_false ``` For new Rails 5.0 apps, this option will be set to `false` by a new initializer `config/initializers/callback_terminator.rb`: ```ruby Rails.application.config.active_support.halt_callback_chains_on_return_false = false ``` For existing apps ported to Rails 5.0, the initializers above will not exist. Even running `rake rails:update` will not create this initializer. Since the default value of `halt_callback_chains_on_return_false` is set to `true`, these apps will still accept `return true` as a way to halt callback chains, displaying a deprecation warning. Developers will be able to switch to the new behavior (and stop the warning) by manually adding the line above to their `config/application.rb`. A gist with the suggested release notes to add to Rails 5.0 after this commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
* | | Generated fixtures won't use parent_id when generated with parent:referencesPablo Olmos de Aguilera Corradini2015-01-021-5/+5
|/ / | | | | | | Fix #18301
* | Remove warningsCarlos Antonio da Silva2015-01-021-2/+2
| | | | | | | | | | warning: ambiguous first argument; put parentheses or a space even after `/' operator'`
* | Verify the helper name with plural as it is generatedCarlos Antonio da Silva2015-01-021-1/+1
| | | | | | | | Thanks @robin850.
* | Add --skip-action-mailer (or -M) to rails generateclaudiob2015-01-012-0/+56
| |
* | Fix scaffold generator with --helper=false optionRafael Mendonça França2015-01-011-0/+14
| |
* | Fix test description to match the test behaviourRafael Mendonça França2015-01-011-1/+1
| |
* | Remove some warning with Ruby 2.2Rafael Mendonça França2014-12-291-1/+1
| |
* | Add test missed by a03ea684efc3505647cf0327a501aa2dbb591ad2Sean Griffin2014-12-221-2/+3
| |
* | Use the new `foreign_key` option on `references` in generatorsSean Griffin2014-12-222-5/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes `rails g model Post user:references` from def change create_table :posts do |t| t.references :user, index: true end add_foreign_key :posts, :users end to def change create_table :posts do |t| t.references :user, index: true, foreign_key: true end end Changes `rails g migration add_user_to_posts user:references` from def change add_reference :posts, :users, index: true add_foreign_key :posts, :users end to def change add_reference :posts, :users, index: true, foreign_key: true end
* | Skip byebug on all non-MRI rubies, fix testsSean Griffin2014-12-222-2/+2
| | | | | | | | | | | | The changes in #18149 added tests for the app generator, but only fixed it for the plugin generator (I should have let CI finish though I think it would have failed as an allowed failure).
* | Only add debugger/byebug if on MRIArthur Neves2014-12-221-1/+1
| |
* | Fix Duplicate web-console entries in GemfileNorimasaAndo2014-12-141-0/+18
| |
* | Merge pull request #17953 from kirs/test-activejob-generatorRafael Mendonça França2014-12-081-0/+29
|\ \ | | | | | | Test coverage for ActiveJob generator
| * | Test coverage for ActiveJob generatorKir Shatrov2014-12-071-0/+29
| | |
* | | Merge pull request #17797 from y-yagi/donot_delete_mailer_layoutsRafael Mendonça França2014-12-041-0/+15
|\ \ \ | | | | | | | | Don't remove mailer layouts files
| * | | Don't remove mailer layouts filesyuuji.yaginuma2014-11-271-0/+15
| |/ /
* / / Silence Minitest for plugin tests.Guo Xiang Tan2014-12-021-0/+1
|/ / | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/17340. Use Minitest::BacktraceFilter instead of removing all silencers. This will allow the backtrace for all libraries in the plugin to be shown while removing noise generated by Minitest's backtrace.
* | Generators add foreign keys on referencesDerek Prior2014-11-252-1/+46
| | | | | | | | | | | | | | | | | | | | | | If you run a generator such as: ``` rails generate model accounts supplier:references ``` The resulting migration will now add the corresponding foreign key constraint unless the reference was specified to be polymorphic.
* | Generate mailer layouts even if no action is given.Guo Xiang Tan2014-11-251-0/+2
| |
* | Add tests which were incorrectly removed.Guo Xiang Tan2014-11-252-0/+6
| |
* | Creates an ApplicationMailer and layout by default, including html and body ↵Andy Jeffries2014-11-212-10/+22
| | | | | | | | tags to reduce spam score
* | Fix rbx generated Gemfile regexBenjamin Fleischer2014-10-271-1/+1
| | | | | | | | | | | | | | | | | | | | https://travis-ci.org/rails/rails/jobs/39190983#L460 1) Failure: AppGeneratorTest#test_psych_gem [test/generators/app_generator_test.rb:495]: Expected /gem 'psych',\s+'~> 2.0', \s+platforms: :rbx/ to match <snip> http://git.io/uuLVag)\ngem 'psych', '~> 2.0', platforms: :rbx\n\n
* | Add back --skip-turbolinks and remove --skip-gemsRafael Mendonça França2014-10-261-3/+2
| | | | | | | | | | | | | | For the most part of cases --skip-gems option just remove one line in the Gemfile. This is not worth for the complexity it adds. Closes #17196
* | test, `Generators::GeneratedAttribute` with references, required, index.Yves Senn2014-10-161-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | Closes #17197. Closes #17207. `{required}` is a type modifier so it should be: user:references{required}:index and not: user:references:index{required}
* | fix test_helper for mountable pluginmasarakki2014-10-131-0/+4
| |
* | Remove --skip-action-view option from application generatorDan Olson2014-09-241-5/+0
| |
* | Specify dummy app's db migrate path in plugin's test_helper.rbYukio Mizuta2014-09-161-3/+12
| |
* | Use dynamic path for dummy app location in plugin's test_helper.rbYukio Mizuta2014-09-141-1/+4
| |
* | Rails.root should be a PathnameAkira Matsuda2014-08-281-1/+1
| |
* | fix broken `gem` method with non-String arguments. Closes #16709.Yves Senn2014-08-271-0/+10
| | | | | | | | This was caused by #15327.
* | Require ActiveJob in case a skip_xxx option is givenslainer682014-08-201-0/+1
| | | | | | | | Change position of require active_job
* | Merge pull request #16062 from sgrif/sg-required-generatorsRafael Mendonça França2014-08-172-0/+56
|\ \ | | | | | | Add a `required` option to the model generator
| * | Add a `required` option to the model generatorSean Griffin2014-08-082-0/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Syntax was chosen to follow the passing of multiple options to decimal/numeric types. Curly braces, and allowing any of `,`, `.`, or `-` to be used as a separator to avoid the need for shell quoting. (I'm intending to expand this to all columns, but that's another PR. The `required` option will cause 2 things to change. `required: true` will be added to the association. `null: false` will be added to the column in the migration.
* | | Change the default `null` value for timestampsSean Griffin2014-08-121-1/+1
| | | | | | | | | | | | | | | | | | | | | As per discussion, this changes the model generators to specify `null: false` for timestamp columns. A warning is now emitted if `timestamps` is called without a `null` option specified, so we can safely change the behavior when no option is specified in Rails 5.
* | | Fixes test for Gemfile entry changesArun Agrawal2014-08-081-6/+11
|/ / | | | | | | Broken by fbe38c9e9d4fe9f82518e8ffc1d757459b0c5f1c
* | Merge pull request #16359 from skanev/after-bundle-in-rails-templatesYves Senn2014-08-061-0/+15
|\ \ | | | | | | | | | | | | | | | | | | Add an after_bundle callback in Rails templates Conflicts: railties/CHANGELOG.md
| * | Add an after_bundle callback in Rails templatesStefan Kanev2014-08-031-0/+15
| | | | | | | | | | | | | | | | | | The template runs before the generation of binstubs – this does not allow to write one, that makes an initial commit to version control. It is solvable by adding an after_bundle callback.
* | | Bring back the helpers testsJosé Valim2014-08-051-0/+39
| | | | | | | | | | | | | | | Also keep the hook as other tools may rely on it, we just don't do anything by default on Rails.
* | | A few more tests asserting the presence of helper test stubsDavid Heinemeier Hansson2014-08-034-12/+0
| | |
* | | Stubs are no longer generated for helpers, so dont test for itDavid Heinemeier Hansson2014-08-031-4/+0
| | |
* | | Generating stubs for helper tests is overly specific. Most helpers should ↵David Heinemeier Hansson2014-08-031-54/+0
|/ / | | | | | | simply be tested as part of the view thats using them. If you need something beyond that, you can add a test yourself for them