aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/generators/plugin_generator_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Define path with __dir__bogdanvlviv2017-05-231-6/+6
| | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f
* Should escape meta characters in regexpRyuta Kamizono2017-05-071-23/+23
|
* Add `app:update` task to enginesyuuji.yaginuma2017-03-201-0/+16
| | | | | | Occasionally we update the file generated by engine. Therefore, I think that there is a task for updating as well as application in the engine, it is convenient for updating.
* Merge pull request #28062 from ↵Rafael França2017-02-241-0/+15
|\ | | | | | | | | y-yagi/make_adding_gemfile_entry_work_even_if_specify_only_the_plugin_name Make adding gemfile entry work even if specify only the plugin name
| * Make adding gemfile entry work even if specify only the plugin nameyuuji.yaginuma2017-02-241-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | Whether the command was executed within the rails application is checked by whether or not the application's path matches `app_path`. https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/generators/rails/plugin/plugin_generator.rb#L439..L441 Therefore, if only plugin name is specified in `app_path`, addition to Gemfile is not done. However, in the rails guide an example of specifying only plugin name is given, and it is considered that there are many cases where only plugin name is specified. For that reason, made it work even if only plugin name was specified.
* | Do not run `git init` in dummy applicationyuuji.yaginuma2017-02-181-0/+1
|/
* make all rails commands work in engineyuuji.yaginuma2017-01-091-0/+1
| | | | | | | | Currently, all rails commands can be executed in engine, but `server`, `console`, `dbconsole` and `runner` do not work. This make all rails commands work in engine. Related to #22588
* Privatize unneededly protected methods in Railties testsAkira Matsuda2016-12-241-1/+1
|
* Don't add jQuery by default in new apps and use rails-ujs as UJS adapter insteadGuillermo Iguaran2016-11-211-1/+0
|
* Add `:skip_sprockets` to `Rails::PluginBuilder::PASSTHROUGH_OPTIONS`Tsukuru Tanimichi2016-11-141-0/+8
| | | | | | | | | | | | `rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`. ``` % rails plugin new my_engine -S --full --skip-gemspec % cd my_engine % bin/rails test rails aborted! NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100> ```
* fix broken generators testyuuji.yaginuma2016-09-141-1/+1
| | | | Follow up to 92703a9ea5d8b96f30e0b706b801c9185ef14f0e
* Add three new rubocop rulesRafael Mendonça França2016-08-161-6/+6
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-071-1/+0
|
* applies new string literal convention in railties/testXavier Noria2016-08-061-46/+46
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Do not run `bundle install` when generating a new plugin.Rafael Mendonça França2016-07-011-40/+41
| | | | | | Since bundler 1.12.0, the gemspec is validated so the `bundle install` command will fail just after the gem is created causing confusion to the users. This change was a bug fix to correctly validate gemspecs.
* generate mailer layout files if it does not already existyuuji.yaginuma2016-05-151-0/+15
| | | | | | | | | Currently, if `ApplicationMailer` does not exist, it is generated when run the mailer generator, but layouts files does not generate. However, because it uses the layouts in `ApplicationMailer`, layouts are required. Follow up to #24161
* generate ApplicationJob if it does not already existyuuji.yaginuma2016-03-251-0/+13
| | | | | | ActiveJob jobs now inherit from ApplicationJob by default. However, when updating to Rails 5 from the old Rails, since there is a possibility that ApplicationJob does not exist.
* Correctly generate application_mailer.rb in mountable enginesPrathamesh Sonpatki2016-03-121-0/+13
| | | | - Followup of https://github.com/rails/rails/pull/24161.
* correctly check `ApplicationRecord` is exist in moutable engineyuuji.yaginuma2016-02-251-0/+14
| | | | Follow up to 1813b29fc7632959800252f36e4b2e6ed4ac7266
* set `skip_listen` option to dummy appplicationyuuji.yaginuma2016-02-181-0/+8
| | | | | | If you want to use `EventedFileUpdateChecker`, need to specify `listen` to plugin's gemspec. However, the default is not specified `listen` to plugin's gemspec, `EventedFileUpdateChecker` should be disabled.
* Fix expected hash syntax.Kasper Timm Hansen2016-02-121-3/+3
| | | | | | 3f70e8bd2 set a new bar for tests, but they weren't updated. Update their expectation.
* Generated engines should protect from forgeryAaron Patterson2016-02-011-3/+3
| | | | | | Generated engines should call `protect_from_forgery`. If this method isn't called, then the Engine could be susceptible to XSS attacks. Thanks @tomekr for reporting this to us!
* make rake proxy work in rails enginesyuuji.yaginuma2016-01-311-1/+1
|
* Add an after_bundle callback in Rails plugin templatesRyan Manuel2016-01-281-0/+28
|
* allow symbol to end of string in `wrap_in_modules`yuuji.yaginuma2016-01-161-4/+4
|
* add application_mailer.rb to template of mountable engineyuuji.yaginuma2016-01-151-0/+4
| | | | | since 9446e38ba47c9ca3be2ad668d8a8bea0141be6fc, generated mailer inherents from ApplicationMailer, ApplicationMailer is required in the mountable engine.
* correctly presence check of `application_record.rb` in pluginyuuji.yaginuma2016-01-021-0/+9
|
* add test of that `application_record.rb` is generated in pluginyuuji.yaginuma2016-01-021-3/+7
|
* Do not check the version anymoreRafael Mendonça França2015-12-181-2/+2
| | | | | Our logic is complex now and we don't need to check the version to asset the behavior so I'm removing the checking here.
* README.rdoc -> README.md for newly generated pluginsyuuji.yaginuma2015-12-171-3/+3
| | | | I think Markdown is nowadays a better default.
* Remove test_files check from plugin checksRafael Mendonça França2015-12-041-4/+0
| | | | Related with 668c006cf33a63ac3f8a8f064c772a339341e70c.
* add `bin/test` script to rails pluginyuuji.yaginuma2015-11-281-1/+6
|
* remove unnecessary readme in dummy applicationyuuji.yaginuma2015-10-231-0/+13
| | | | `README` it is changed to `README.rdoc` in 6b126e2, it has been changed to` README.md` further 89a12c9.
* Merge pull request #20908 from y-yagi/generate_application_job_inside_engineArthur Nogueira Neves2015-10-131-0/+4
|\ | | | | add application_job.rb to template of mountable engine
| * add application_job.rb to template of mountable engineyuuji.yaginuma2015-07-171-0/+4
| | | | | | | | | | since cb012467214f6e4bb1ac3987554bb75020b4796b, generated job inherents from ApplicationJob, ApplicationJob is required in the mountable engine.
* | do not generate manifest.js in pluginsyuuji.yaginuma2015-10-121-0/+1
| | | | | | | | Since the plugin generator do not generate assets, I think manifest.js also that it unnecessary.
* | Removed mocha from Railites PluginGeneratorTestRonak Jangir2015-09-221-1/+0
| |
* | Updated tests for the generated version number changeDaniel Morris2015-08-161-3/+3
| |
* | Merge pull request #21043 from ↵Rafael Mendonça França2015-08-061-0/+1
|\ \ | | | | | | | | | | | | y-yagi/loading_fixtures_in_engine_integration_tests set the correct path to `ActionDispatch::IntegrationTest.fixture_path`
| * | set the correct path to `ActionDispatch::IntegrationTest.fixture_path`yuuji.yaginuma2015-07-281-0/+1
| |/ | | | | | | | | `ActionDispatch::IntegrationTest.fixture_path` set by `test_help.rb`, but if the engine, path under the dummy is will be set, fixtures under test was not loaded.
* | Enable the `api_only` option for API plugins' generatorsRobin Dupret2015-07-231-0/+26
| | | | | | | | | | | | | | This way, running a generator inside the plugin's directory, files that are not relevant won't be generated (e.g. views or assets). This won't interfere with the application's generators configuration.
* | Generate an API dummy application for API pluginsRobin Dupret2015-07-231-0/+8
| |
* | Make ApplicationController inherit from AC::API for API pluginsRobin Dupret2015-07-231-0/+8
| |
* | Skip assets, helpers and views generation for API pluginsRobin Dupret2015-07-231-0/+12
|/
* Display a more human readable list of reserved namesRobin Dupret2015-07-011-1/+1
| | | | | Interpolating an array inside a String will call #inspect on it. Let's call #join to display a more human-readable error message.
* list reserved words in generator errorSean Linsley2015-05-051-1/+1
|
* Dont check bundler output on plugin generator testArthur Neves2015-02-101-4/+2
|
* Actually fix the buildSean Griffin2015-02-101-1/+1
| | | | Like for real this time. I checked.
* Fix the buildSean Griffin2015-02-101-1/+1
|
* Fixed a few things from ee9e4c3Godfrey Chan2015-01-301-7/+7
| | | | | Mostly cosmetics, except that `isolate_namespace` should be applied to the last module in the chain.