Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -6/+6 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty lines | Ryuta Kamizono | 2016-08-07 | 1 | -1/+0 |
| | |||||
* | applies new string literal convention in railties/test | Xavier Noria | 2016-08-06 | 1 | -46/+46 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Do not run `bundle install` when generating a new plugin. | Rafael Mendonça França | 2016-07-01 | 1 | -40/+41 |
| | | | | | | Since bundler 1.12.0, the gemspec is validated so the `bundle install` command will fail just after the gem is created causing confusion to the users. This change was a bug fix to correctly validate gemspecs. | ||||
* | generate mailer layout files if it does not already exist | yuuji.yaginuma | 2016-05-15 | 1 | -0/+15 |
| | | | | | | | | | Currently, if `ApplicationMailer` does not exist, it is generated when run the mailer generator, but layouts files does not generate. However, because it uses the layouts in `ApplicationMailer`, layouts are required. Follow up to #24161 | ||||
* | generate ApplicationJob if it does not already exist | yuuji.yaginuma | 2016-03-25 | 1 | -0/+13 |
| | | | | | | ActiveJob jobs now inherit from ApplicationJob by default. However, when updating to Rails 5 from the old Rails, since there is a possibility that ApplicationJob does not exist. | ||||
* | Correctly generate application_mailer.rb in mountable engines | Prathamesh Sonpatki | 2016-03-12 | 1 | -0/+13 |
| | | | | - Followup of https://github.com/rails/rails/pull/24161. | ||||
* | correctly check `ApplicationRecord` is exist in moutable engine | yuuji.yaginuma | 2016-02-25 | 1 | -0/+14 |
| | | | | Follow up to 1813b29fc7632959800252f36e4b2e6ed4ac7266 | ||||
* | set `skip_listen` option to dummy appplication | yuuji.yaginuma | 2016-02-18 | 1 | -0/+8 |
| | | | | | | If you want to use `EventedFileUpdateChecker`, need to specify `listen` to plugin's gemspec. However, the default is not specified `listen` to plugin's gemspec, `EventedFileUpdateChecker` should be disabled. | ||||
* | Fix expected hash syntax. | Kasper Timm Hansen | 2016-02-12 | 1 | -3/+3 |
| | | | | | | 3f70e8bd2 set a new bar for tests, but they weren't updated. Update their expectation. | ||||
* | Generated engines should protect from forgery | Aaron Patterson | 2016-02-01 | 1 | -3/+3 |
| | | | | | | Generated engines should call `protect_from_forgery`. If this method isn't called, then the Engine could be susceptible to XSS attacks. Thanks @tomekr for reporting this to us! | ||||
* | make rake proxy work in rails engines | yuuji.yaginuma | 2016-01-31 | 1 | -1/+1 |
| | |||||
* | Add an after_bundle callback in Rails plugin templates | Ryan Manuel | 2016-01-28 | 1 | -0/+28 |
| | |||||
* | allow symbol to end of string in `wrap_in_modules` | yuuji.yaginuma | 2016-01-16 | 1 | -4/+4 |
| | |||||
* | add application_mailer.rb to template of mountable engine | yuuji.yaginuma | 2016-01-15 | 1 | -0/+4 |
| | | | | | since 9446e38ba47c9ca3be2ad668d8a8bea0141be6fc, generated mailer inherents from ApplicationMailer, ApplicationMailer is required in the mountable engine. | ||||
* | correctly presence check of `application_record.rb` in plugin | yuuji.yaginuma | 2016-01-02 | 1 | -0/+9 |
| | |||||
* | add test of that `application_record.rb` is generated in plugin | yuuji.yaginuma | 2016-01-02 | 1 | -3/+7 |
| | |||||
* | Do not check the version anymore | Rafael Mendonça França | 2015-12-18 | 1 | -2/+2 |
| | | | | | Our logic is complex now and we don't need to check the version to asset the behavior so I'm removing the checking here. | ||||
* | README.rdoc -> README.md for newly generated plugins | yuuji.yaginuma | 2015-12-17 | 1 | -3/+3 |
| | | | | I think Markdown is nowadays a better default. | ||||
* | Remove test_files check from plugin checks | Rafael Mendonça França | 2015-12-04 | 1 | -4/+0 |
| | | | | Related with 668c006cf33a63ac3f8a8f064c772a339341e70c. | ||||
* | add `bin/test` script to rails plugin | yuuji.yaginuma | 2015-11-28 | 1 | -1/+6 |
| | |||||
* | remove unnecessary readme in dummy application | yuuji.yaginuma | 2015-10-23 | 1 | -0/+13 |
| | | | | `README` it is changed to `README.rdoc` in 6b126e2, it has been changed to` README.md` further 89a12c9. | ||||
* | Merge pull request #20908 from y-yagi/generate_application_job_inside_engine | Arthur Nogueira Neves | 2015-10-13 | 1 | -0/+4 |
|\ | | | | | add application_job.rb to template of mountable engine | ||||
| * | add application_job.rb to template of mountable engine | yuuji.yaginuma | 2015-07-17 | 1 | -0/+4 |
| | | | | | | | | | | since cb012467214f6e4bb1ac3987554bb75020b4796b, generated job inherents from ApplicationJob, ApplicationJob is required in the mountable engine. | ||||
* | | do not generate manifest.js in plugins | yuuji.yaginuma | 2015-10-12 | 1 | -0/+1 |
| | | | | | | | | Since the plugin generator do not generate assets, I think manifest.js also that it unnecessary. | ||||
* | | Removed mocha from Railites PluginGeneratorTest | Ronak Jangir | 2015-09-22 | 1 | -1/+0 |
| | | |||||
* | | Updated tests for the generated version number change | Daniel Morris | 2015-08-16 | 1 | -3/+3 |
| | | |||||
* | | Merge pull request #21043 from ↵ | Rafael Mendonça França | 2015-08-06 | 1 | -0/+1 |
|\ \ | | | | | | | | | | | | | y-yagi/loading_fixtures_in_engine_integration_tests set the correct path to `ActionDispatch::IntegrationTest.fixture_path` | ||||
| * | | set the correct path to `ActionDispatch::IntegrationTest.fixture_path` | yuuji.yaginuma | 2015-07-28 | 1 | -0/+1 |
| |/ | | | | | | | | | `ActionDispatch::IntegrationTest.fixture_path` set by `test_help.rb`, but if the engine, path under the dummy is will be set, fixtures under test was not loaded. | ||||
* | | Enable the `api_only` option for API plugins' generators | Robin Dupret | 2015-07-23 | 1 | -0/+26 |
| | | | | | | | | | | | | | | This way, running a generator inside the plugin's directory, files that are not relevant won't be generated (e.g. views or assets). This won't interfere with the application's generators configuration. | ||||
* | | Generate an API dummy application for API plugins | Robin Dupret | 2015-07-23 | 1 | -0/+8 |
| | | |||||
* | | Make ApplicationController inherit from AC::API for API plugins | Robin Dupret | 2015-07-23 | 1 | -0/+8 |
| | | |||||
* | | Skip assets, helpers and views generation for API plugins | Robin Dupret | 2015-07-23 | 1 | -0/+12 |
|/ | |||||
* | Display a more human readable list of reserved names | Robin Dupret | 2015-07-01 | 1 | -1/+1 |
| | | | | | Interpolating an array inside a String will call #inspect on it. Let's call #join to display a more human-readable error message. | ||||
* | list reserved words in generator error | Sean Linsley | 2015-05-05 | 1 | -1/+1 |
| | |||||
* | Dont check bundler output on plugin generator test | Arthur Neves | 2015-02-10 | 1 | -4/+2 |
| | |||||
* | Actually fix the build | Sean Griffin | 2015-02-10 | 1 | -1/+1 |
| | | | | Like for real this time. I checked. | ||||
* | Fix the build | Sean Griffin | 2015-02-10 | 1 | -1/+1 |
| | |||||
* | Fixed a few things from ee9e4c3 | Godfrey Chan | 2015-01-30 | 1 | -7/+7 |
| | | | | | Mostly cosmetics, except that `isolate_namespace` should be applied to the last module in the chain. | ||||
* | Allow hyphenated names for `rails plugin new` generator. | Robin Böning | 2015-01-30 | 1 | -4/+102 |
| | | | | | | It was not possible to create a new gem with a hyphenated name via the `rails plugin new` generator. The naming guide of rubygems clearly says dashes should be used for gems that extend other gems. http://guides.rubygems.org/name-your-gem/ | ||||
* | Change option description and update test names | Melanie Gilman | 2015-01-29 | 1 | -1/+1 |
| | |||||
* | Update option to skip test in generators | Melanie Gilman | 2015-01-27 | 1 | -4/+4 |
| | | | | Rails no longer generates Test::Unit files by default. | ||||
* | Remove debugger support | Rafael Mendonça França | 2015-01-04 | 1 | -3/+0 |
| | | | | | bebugger doesn't work with Ruby 2.2 so we don't need to support it anymore | ||||
* | Add --skip-action-mailer (or -M) to rails generate | claudiob | 2015-01-01 | 1 | -0/+28 |
| | |||||
* | Skip byebug on all non-MRI rubies, fix tests | Sean Griffin | 2014-12-22 | 1 | -1/+1 |
| | | | | | | The changes in #18149 added tests for the app generator, but only fixed it for the plugin generator (I should have let CI finish though I think it would have failed as an allowed failure). | ||||
* | Silence Minitest for plugin tests. | Guo Xiang Tan | 2014-12-02 | 1 | -0/+1 |
| | | | | | | | | Fixes https://github.com/rails/rails/issues/17340. Use Minitest::BacktraceFilter instead of removing all silencers. This will allow the backtrace for all libraries in the plugin to be shown while removing noise generated by Minitest's backtrace. | ||||
* | fix test_helper for mountable plugin | masarakki | 2014-10-13 | 1 | -0/+4 |
| | |||||
* | Specify dummy app's db migrate path in plugin's test_helper.rb | Yukio Mizuta | 2014-09-16 | 1 | -3/+12 |
| | |||||
* | Use dynamic path for dummy app location in plugin's test_helper.rb | Yukio Mizuta | 2014-09-14 | 1 | -1/+4 |
| | |||||
* | Use default argument when testing generators without the need for extra args | Carlos Antonio da Silva | 2014-07-30 | 1 | -4/+4 |
| |