aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/generators/controller_generator_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Fix tests related to new JavaScript path for generatorsPrathamesh Sonpatki2018-10-051-2/+0
| | | | - Followup of https://github.com/rails/rails/commit/4838c1716a0340137d858fab49bf460e23be5a4b
* Make Webpacker the default JavaScript compiler for Rails 6 (#33079)David Heinemeier Hansson2018-09-301-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use Webpacker by default on new apps * Stop including coffee-rails by default * Drop using a js_compressor by default * Drop extra test for coffeescript inclusion by default * Stick with skip_javascript to signify skipping webpack * Don't install a JS runtime by default any more * app/javascript will be the new default directory for JS * Make it clear that this is just for configuring the default Webpack framework setup now * Start using the Webpack tag in the default layout * Irrelevant test * jQuery is long gone * Stop having asset pipeline compile default application.js * Add rails-ujs by default to the Webpack setup * Add Active Storage JavaScript to application.js pack by default * Consistent quoting * Add Turbolinks to default pack * Add Action Cable to default pack Need some work on how to set the global consumer that channels will work with. @javan? * Require all channels by default and use a separate consumer stub * Channel generator now targets Webpack style * Update task docs to match new generator style * Use uniform import style * Drop the JS assets generator It was barely helpful as it was. It’s no longer helpful in a Webpacked world. Sayonara! * Add app/javascript to the stats directories * Simpler import style Which match the other imports. * Address test failures from dropping JS compilation (and compression) * webpacker-default: Modify `AssetsGeneratorTest` Before: ``` $ bin/test test/generators/assets_generator_test.rb Run options: --seed 46201 F Failure: AssetsGeneratorTest#test_assets [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/assets_generator_test.rb:12]: Expected file "app/assets/javascripts/posts.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/assets_generator_test.rb:10 . Finished in 0.031343s, 63.8101 runs/s, 95.7152 assertions/s. 2 runs, 3 assertions, 1 failures, 0 errors, 0 skips ``` After: ``` $ bin/test test/generators/assets_generator_test.rb Run options: --seed 43571 .. Finished in 0.030370s, 65.8545 runs/s, 65.8545 assertions/s. 2 runs, 2 assertions, 0 failures, 0 errors, 0 skips ``` * webpacker-default: Modify `ChannelGeneratorTest` Before: ``` $ bin/test test/generators/channel_generator_test.rb Run options: --seed 8986 .F Failure: ChannelGeneratorTest#test_channel_with_multiple_actions_is_created [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:43]: Expected file "app/assets/javascripts/channels/chat.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:34 .F Failure: ChannelGeneratorTest#test_channel_is_created [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:29]: Expected file "app/assets/javascripts/channels/chat.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:22 E Error: ChannelGeneratorTest#test_cable_js_is_created_if_not_present_already: Errno::ENOENT: No such file or directory @ apply2files - /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/fixtures/tmp/app/assets/javascripts/cable.js bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:60 F Failure: ChannelGeneratorTest#test_channel_suffix_is_not_duplicated [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:87]: Expected file "app/assets/javascripts/channels/chat.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:80 F Failure: ChannelGeneratorTest#test_channel_on_revoke [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:77]: Expected file "app/assets/javascripts/cable.js" to exist, but does not bin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:68 Finished in 0.064384s, 108.7227 runs/s, 481.4861 assertions/s. 7 runs, 31 assertions, 4 failures, 1 errors, 0 skips ``` After: ``` $ bin/test test/generators/channel_generator_test.rb Run options: --seed 44857 ....... Finished in 0.060243s, 116.1961 runs/s, 697.1764 assertions/s. 7 runs, 42 assertions, 0 failures, 0 errors, 0 skips ``` * Fix shared generator tests. * webpacker-default: Modify `ControllerGeneratorTest` The JS assets generator was dropped. ref. https://github.com/rails/rails/commit/46215b179483d3e4d264555f5a4952f43eb8142a * Revert "Simpler import style". It's currently failing with an error of "TypeError: undefined is not an object (evaluating '__WEBPACK_IMPORTED_MODULE_2_activestorage___default.a.start')". Waiting for @javan to have a look. This reverts commit 5d3ebb71059f635d3756cbda4ab9752027e09256. * require webpacker in test app * Add webpacker without making the build hang/timeout. (#33640) * use yarn workspaces to allow for installing unreleased packages and only generate js/bootsnap when required * no longer need to have webpacker in env templates as webpacker moved this config to yml file * Fix rubocop violation * Got the test passing for the running scaffold * update expected lines of code * update middleware tests to account for webpacker * disable js in plugins be default to get the tests passing (#34009) * clear codeclimate report issues * Anything newer than currently released is good * Use Webpacker development version during development of Rails * Edge should get development webpacker as well * Add changelog entry for Webpacker change
* Gracefully handle extra "controller" when generating controllerfatkodima2018-03-231-0/+22
|
* Do not add routes when actions are not specifiedYuji Yaginuma2018-02-221-0/+7
| | | | | | | | | | Since #30241, if namepsace is specified, routes will be generated even if there is no actions. However, it seems that this behavior is not intentionally added behavior. As with 5.1, routes should not be generated if actions are not specified. Fixes #32072.
* Merge pull request #30241 from yhirano55/optimize_routes_indentationRafael Mendonça França2017-08-141-0/+7
|\ | | | | | | Optimize routes indentation
| * Optimize routes indentationYoshiyuki Hirano2017-08-141-0/+7
| |
* | Adding frozen_string_literal pragma to Railties.Pat Allan2017-08-141-0/+2
|/
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Correct indent-accounting in controller route generationMatthew Draper2016-12-251-1/+1
| | | | | | Fixes #27447 [Matthew Draper & Yuuji Yaginuma]
* Add three new rubocop rulesRafael Mendonça França2016-08-161-1/+1
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* applies new string literal convention in railties/testXavier Noria2016-08-061-2/+2
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* fix indent in routes when using namespaced controllersyuuji.yaginuma2015-04-141-1/+3
| | | | | | | | | | | | | | | | | | Before: namespace :foo do namespace :bar do get 'baz/index' end end After: namespace :foo do namespace :bar do get 'baz/index' end end
* A few more tests asserting the presence of helper test stubsDavid Heinemeier Hansson2014-08-031-2/+0
|
* Display notice in index.html pages in scaffolded generated viewsArun Agrawal2014-07-041-1/+1
| | | | | | | | | As we are setting notice in destroy action we should display that For more information see https://github.com/rails/rails/pull/14044 And https://github.com/rails/jbuilder/pull/191 closes #14044
* Add a '--skip-routes' flag for the Controller generator.Lucas Mazza2014-06-241-0/+7
| | | | | This way it is possible to skip the addition of the 'get "foo/bar"' routes when generating a controller.
* single quotes for controller generated routesCristian Mircea Messel2014-01-141-2/+2
| | | | | | | | | | Write routes in route.rb with single quotes get 'welcome/index' instead of get "welcome/index"
* Test for when controller with skip-assetsArun Agrawal2013-11-231-0/+6
|
* Generate namespaced routes correctly for generators. Fix for #11532Prathamesh Sonpatki2013-08-141-0/+5
|
* Update test locationsMike Moore2012-10-091-4/+4
| | | | | | | | | | | | | | Change the default test locations to avoid confusion around the common testing terms "unit" and "functional". Add new rake tasks for the new locations, while maintaining backwards compatibility with the old rake tasks. New testing locations are as follows: app/models -> test/models (was test/units) app/helpers -> test/helpers (was test/units/helpers) app/controllers -> test/controllers (was test/functional) app/mailers -> test/mailers (was test/functional)
* Move Coffee generators and templates to Coffee Railtie and create ↵Santiago Pastorino2011-06-291-1/+1
| | | | javascript_engine ("js") for apps that remove Coffee gem
* Move SCSS generators and default templates from Rails to the Sass Railtie ↵tomhuda2011-05-241-1/+1
| | | | | | | | (d435726312601edb3ba6f97b34f562221f72c1f8). * Sass gem registers a compressor * Sass gem registers generators for assets and scaffold * Create a default stylesheet_engine ("css") for apps that remove the Sass gem
* be sure to parenthesize the arguments when the first one is a RegExp literalAkira Matsuda2011-05-181-2/+2
| | | | | | this fixes: "warning: ambiguous first argument; put parentheses or even spaces" because: you need this to tell the parser that you're not calling :/ method (division) details (Japanese!): http://blade.nagaokaut.ac.jp/cgi-bin/vframe.rb/ruby/ruby-dev/42445?42370-43277
* What a lovely surprise, controller_generator_test was also failing.José Valim2011-04-171-2/+2
|
* The controller and resource generators will now automatically produce asset ↵David Heinemeier Hansson2011-04-141-0/+6
| | | | stubs (this can be turned off with --skip-assets). These stubs will use Coffee and Sass, if those libraries are available. [DHH]
* Load generators from both lib/rails/generators and lib/generators. Using the ↵José Valim2010-03-231-1/+1
| | | | former since it's less obstrusive.
* Controller generators should use routes shortcut.José Valim2010-03-221-1/+1
|
* Fix regression introduced in 8b50f89. Generated views mentioned the wrong path.Jeremy Kemper2010-03-211-2/+2
|
* Controller generator now creates routes as well [#4233 state:resolved]José Valim2010-03-191-2/+7
|
* Get generators tests running on Ruby 1.9.1José Valim2010-01-191-1/+2
|
* Generators load path now will be Ruby load path. If you want to use ↵José Valim2010-01-181-1/+1
| | | | rspec:install generator, you need generators/rspec/install_generator in your load path.
* Move all generators tests to use new test case syntax.José Valim2010-01-031-8/+1
|
* Create Rails::Generators::TestCase.José Valim2010-01-031-3/+3
|
* CI breakageYehuda Katz2009-11-021-1/+1
| | | | This reverts commit a288b74f1c75c6f100de7611a5093a421f1ad6d1.
* Generators should use Rails.root instead of Dir.pwd [#3408 status:resolved]José Valim2009-10-281-1/+1
| | | | Signed-off-by: Yehuda Katz <wycats@gmail.com>
* Move railties/lib/* into railties/lib/*Yehuda Katz + Carl Lerche2009-09-241-1/+1
|
* Updated vendored Thor to 0.11.1 and update Rails::Generators.José Valim2009-07-141-1/+1
|
* Added lookup to generators.José Valim2009-07-031-6/+3
|
* Added tessts for resources generator.José Valim2009-06-281-2/+5
|
* Show invoked generators options on meta generators.José Valim2009-06-271-0/+5
|
* Initial scratch of model generators.José Valim2009-06-271-0/+2
|
* Spec --no and --skip.José Valim2009-06-261-1/+12
|
* Added Controller Generators.José Valim2009-06-261-0/+62
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 02:25:12 +0000