| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
| |
(#28093)
|
|\
| |
| | |
Use Puma 3.7
|
| |
| |
| |
| | |
ref this commit seems that has not been merged into 3.7 https://github.com/puma/puma/commit/42bec4600c51ab8a1c1ee5a0e1b738a4ffd82bf2
|
|/
|
|
|
|
|
|
|
|
| |
* Adds test case test
* Adds driver adapter test
* Adds tests for capybara seleium driver (testing the settings not
actually opening the browser to test capybara w/ selenium because that
would so so so slow)
* Adds tests for rack test driver
* Adds tests for generators
|
| |
|
| |
|
|
|
|
|
| |
When specifying the `pretend` option, expect that no processing will be
done, so do not execute `git init` as well.
|
|
|
|
|
| |
* If `--skip-git` is not specified initalize git repo
when creating new rails app
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 8cb3cdffdb70f3575518d24ea96ec891e40d21d0, reversing
changes made to 3bc747bd8676dc940b531067e2861dcd4ac28efc.
Reason: This test already exists in `SharedGeneratorTests`.
Ref:
https://github.com/rails/rails/blob/master/railties/test/generators/shared_generator_tests.rb#L109..L112
https://github.com/rails/rails/blob/master/railties/test/generators/app_generator_test.rb#L55..L56
|
| |
|
|
|
|
|
|
| |
- No need to remove bin/yarn separately for API only apps because
:skip_yarn is set to true for API only apps.
- Added a test for :skip_yarn config.
|
| |
|
|
|
| |
Follow up to 0d20530e5edfd7d00fbc2a38ef5f87eca6ccc924
|
| |
|
|
|
| |
Move node_modules, package.json, and yarn.lock file to vendor
|
|\
| |
| | |
Add Yarn support in new apps using --yarn option
|
| | |
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
|
|
|
| |
If `sprockets` is not loaded, `Rails.application.config.assets` is not defined.
|
| |
|
| |
|
|\
| |
| |
| |
| | |
y-yagi/remove_test_mailers_when_skipping_action-mailer
remove "test/mailers" directory when skipping action-mailer
|
| |
| |
| |
| | |
Related to #26146
|
|/
|
|
|
|
|
|
| |
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
|
|
|
|
| |
Closes #26145
|
| |
|
|
|
|
|
| |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I dropped the version constraint in web-console with the idea it will be
easier to upgrade the console between Rails releases. However, issues
like #25899 started popping up.
I'm reintroducing the constraint, but this time, I don't set an upper
limit to the major version. This will keep the web-console in a version
that always works for the current Rails version and can be easily
upgraded to the last one with `bundle update`.
We may need to backport this for Rails 5.0.1.
Fixes #25899.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initializer
- By default the session store will be set to cookie store with
application name as session key.
- Older apps are not affected as they will have the session store
initializer generated by Rails in older versions, and Rails will not
overwrite the session store if it is already set or disabled.
- But new apps will not have the initializer, instead the session store
will be set to cookie store by default.
- Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
|
|
|
|
|
|
| |
Since bundler 1.12.0, the gemspec is validated so the `bundle install`
command will fail just after the gem is created causing confusion to the
users. This change was a bug fix to correctly validate gemspecs.
|
|
|
|
| |
- Adjusted tests instead.
|
|
|
|
|
|
|
|
|
|
|
|
| |
request_forgery_protection configs
- Earlier per_form_csrf_tokens and request_forgery_protection config
files were generated for old apps upgraded to Rails 5.
- But when we collapsed all initializers into one file, the entire file
does not get created for old apps.
- This commit fixes it and also changes values for all new defaults for
old apps so that they will not break.
- Also added a test for `rails app:update`.
|
|
|
|
|
|
| |
- Adjusted tests also for this new behavior.
- Based on the discussion in
https://github.com/rails/rails/pull/25184#issuecomment-222454583.
|
|
|
|
|
|
| |
- These initializers are new defaults for Rails 5 and newly generated
apps do not need to change them.
- Fixes #25181
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will
preserve the timezone of the receiver when converting to an instance
of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we
need to introduce a compatibility layer so that apps that upgrade do
not break. New apps will have a config initializer file that defaults
to match the new Ruby 2.4 behavior going forward.
For information about the changes to Ruby see:
https://bugs.ruby-lang.org/issues/12189
https://bugs.ruby-lang.org/issues/12271
Fixes #24617.
|
|
|
|
|
|
| |
* Updated syntax
* Updated tests to match syntax
|
|
|
|
| |
[related #24243]
|
|\
| |
| | |
Remove passing `with_dispatchers` to AppGenerator
|
| |
| |
| |
| |
| |
| |
| | |
- While working on https://github.com/rails/rails/pull/22790 I found out
that we pass `with_dispatchers: true` but it's not used at all by Rails.
- We were passing `with_dispatchers: true` in few tests too but again
it's not used by Rails.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Between major versions 2 and 3, we hit a bug. It's fixed in version 3,
however, the explicit 2.x requirement of `~> '2.0'` will prevent people
from getting the fix with `bundle update` and they would have to
explicitly set the constraint to `~> '3.0'`.
For more information see: rails/web-console#178.
I propose we drop the explicit version constraints in the Gemfile. Web
Console has been relatively stable for the past couple of years, and I
don't anticipate any major alterations, like we saw between major
versions 1 and 2.
|
|\ \
| | |
| | | |
Fix description in cookies_serializer.rb being corrupted by gsub when updating
|