| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Use duktape gem as default JS engine on Windows-MINGW
|
| |
| |
| |
| |
| |
| |
| |
| | |
The fallback javascript engine on Windows is Windows Script Host (JScript).
However this engine isn't able to process the default assets, because it supports
ES3 only but the coffeescript compiler requires ES5.
Fixes #30014
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, `app:update` generates all contents regardless of the
component using in application.
For example, even if not using Action Cable, `app:update` will generate
a contents related to Action Cable. This is a little inconvenient.
This PR checks the existence of the component and does not generate
unnecessary contents.
Can not check all options in this way. However, it will be able to
prevent the generation of unnecessary files.
|
| |
|
|
|
|
|
| |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
|\
| |
| |
| | |
Enforce frozen string in Rubocop
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Don't generate system test files if `skip_system_test` option is specified
|
| | |
|
|/
|
|
|
|
|
| |
Allows users to not have remote forms by default, since there's
more JS harness, e.g. bundling rails-ujs, otherwise.
Also don't skip creating defaults file anymore. Sprockets isn't the only new config.
|
|\
| |
| |
| | |
Remove -j (--javascript) option from `rails new`
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The "-j" option was added 5 years ago (https://github.com/rails/rails/commit/d9c39c3a)
when we wanted to support prototype-rails and jquery-rails.
Prototype is not as popular and jQuery is not a requirement anymore.
Still the "-j" option can be used to install *any* gem that ends in "-rails".
This "might" open security issues and does not bring great benefits anymore.
If you know which "-rails"-ending gem you want to install, you can manually
add it to the Gemfile just like any other gem.
|
|/ |
|
|
|
|
|
|
|
| |
This is necessary only when updating to Rails 5.0, it is not necessary
for updating to 5.1.
Related #24243
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It can not check correctly with `defined?`
```ruby
irb(main):001:0> Rails.application.config.active_record
=> {:maintain_test_schema=>true, :belongs_to_required_by_default=>true}
irb(main):002:0> defined?(Rails.application.config.active_record)
=> nil
```
Follow up to #28469
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of forcing new applications to carry an initializer that just
switches things to what their default "should" be, we can handle it
internally.
The initializer is then only used by upgraders: it shows what the new
default would be (commented out), while their upgraded application
continues to operate as it did before.
Under this model, a multiply-upgraded application could accumulate
several new_framework_defaults_*.rb files, for each release series it
has traversed. A given release series only needs to generate the latest,
though, because we don't support `rails app:upgrade` while skipping
releases.
|
|
|
|
|
| |
`rails:update` was changed to `app:update` in 6fb31638c8b61731103d4963272755b217a2df87.
Therefore, I think that it is better that the test name is also `app_update`.
|
| |
|
| |
|
| |
|
|
|
|
| |
(#28093)
|
|\
| |
| | |
Use Puma 3.7
|
| |
| |
| |
| | |
ref this commit seems that has not been merged into 3.7 https://github.com/puma/puma/commit/42bec4600c51ab8a1c1ee5a0e1b738a4ffd82bf2
|
|/
|
|
|
|
|
|
|
|
| |
* Adds test case test
* Adds driver adapter test
* Adds tests for capybara seleium driver (testing the settings not
actually opening the browser to test capybara w/ selenium because that
would so so so slow)
* Adds tests for rack test driver
* Adds tests for generators
|
| |
|
| |
|
|
|
|
|
| |
When specifying the `pretend` option, expect that no processing will be
done, so do not execute `git init` as well.
|
|
|
|
|
| |
* If `--skip-git` is not specified initalize git repo
when creating new rails app
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 8cb3cdffdb70f3575518d24ea96ec891e40d21d0, reversing
changes made to 3bc747bd8676dc940b531067e2861dcd4ac28efc.
Reason: This test already exists in `SharedGeneratorTests`.
Ref:
https://github.com/rails/rails/blob/master/railties/test/generators/shared_generator_tests.rb#L109..L112
https://github.com/rails/rails/blob/master/railties/test/generators/app_generator_test.rb#L55..L56
|
| |
|
|
|
|
|
|
| |
- No need to remove bin/yarn separately for API only apps because
:skip_yarn is set to true for API only apps.
- Added a test for :skip_yarn config.
|
| |
|
|
|
| |
Follow up to 0d20530e5edfd7d00fbc2a38ef5f87eca6ccc924
|
| |
|
|
|
| |
Move node_modules, package.json, and yarn.lock file to vendor
|
|\
| |
| | |
Add Yarn support in new apps using --yarn option
|
| | |
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
|
|
|
| |
If `sprockets` is not loaded, `Rails.application.config.assets` is not defined.
|
| |
|