aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/application
Commit message (Collapse)AuthorAgeFilesLines
* Manage ActionDispatch::ActionableExceptions from the default middleware stackGenadi Samokovarov2019-04-191-0/+2
|
* Factorize bin/update in bin/setup, and make bin/setup idempotentDavid Stosik2019-04-171-15/+11
| | | | | | | | | | | | | | | `bin/setup` and `bin/update` are currently almost the same file. The only thing that keeps them apart is that one is running `bin/rails db:setup` and the other `bin/rails db:migrate`. I'm suggesting here that they should be a unique script, which needs to be idempotent. - New to a project, need to get started? `bin/setup` - Need to install new dependencies that were added recently? `bin/setup`. Before deprecating `bin/update`, I'm suggesting we just have it call `bin/setup`.
* Merge pull request #35997 from ↵Rafael França2019-04-161-0/+7
|\ | | | | | | | | tjoyal/Rails/MailersController/do-not-leak-I18n-global-setting-changes [Rails::MailersController] Do not leak I18n global setting changes
| * [Rails::MailersController] Do not leak I18n global setting changesThierry Joyal2019-04-161-0/+7
| |
* | Squash warning: possibly useless use of a constantutilum2019-04-161-2/+2
|/ | | | in void context
* Remove the Amazon SES ingressGeorge Claghorn2019-04-141-1/+0
| | | It's unusable and not ready to ship in Rails 6.0. We'll rewrite it for 6.1.
* deprecates autoloading constants during initialization [closes #35745]Xavier Noria2019-04-141-0/+55
| | | | See rationale in the warning message included in the patch.
* improves the reloading disabled error messageXavier Noria2019-04-111-0/+9
| | | | | | | | The original message from Zeitwerk is "can't reload, please call loader.enable_reloading before setup (Zeitwerk::Error)", which is not very informative for Rails programmers. Rails should err with a message worded in terms of its interface.
* cleanup up constant in test suiteXavier Noria2019-04-091-0/+1
|
* depend on Zeitwerk 2.1.0Xavier Noria2019-04-091-9/+61
|
* depend on Zeitwerk 2Xavier Noria2019-04-071-0/+14
|
* Auto-correct rubocop offencesRyuta Kamizono2019-04-031-2/+2
|
* Merge pull request #35768 from robertomiranda/r/rake-db-prepareEileen M. Uchitelle2019-04-022-0/+36
|\ | | | | Add db:prepare rake task.
| * Add migration in case of db:drop assertionRoberto Miranda2019-04-021-0/+7
| |
| * 💇Roberto Miranda2019-04-022-2/+1
| |
| * Add test cases for rake db:prepareRoberto Miranda2019-04-022-0/+30
| |
* | url -> URL where apt except inside actionpack/Sharang Dashputre2019-04-015-8/+8
| |
* | [ci skip] Fix typo directores -> directoriesAbhay Nikam2019-03-301-1/+1
| |
* | optimizes eager loading in :zeitwerk modeXavier Noria2019-03-301-0/+14
| | | | | | | | | | | | | | | | | | | | | | During initialization, the eager load paths of engines are unshifted into AS::Dependencies.autoload_paths. After that, the collection is frozen. (See the initializers in railties/lib/rails/engine.rb.) Hence, there is no eager load path that is not an autoload path too, and so the array difference in the deleted code is always an empty array. Just do nothing.
* | fixes eager loading edge case in :zeitwerk modeXavier Noria2019-03-301-0/+28
|/
* Add config.disable_sandbox option to Rails consolePrem Sichanugrist2019-03-232-3/+34
| | | | | | | | | | | A long-running `rails console --sandbox` could cause a database server to become out-of-memory as it's holding on to changes that happen on the database. Given that it's common for Ruby on Rails application with huge traffic to have separate write database and read database, we should allow the developers to disable this sandbox option to prevent someone from accidentally causing the Denial-of-Service on their server.
* Fix server restart test on Puma 3.12.1yuuji.yaginuma2019-03-221-2/+2
| | | | | | | | | | | Since https://github.com/puma/puma/pull/1700, the default host is correctly used. So `localhost` is used instead of `0.0.0.0`. As a result, the log output on restart is changed, and the restart test fails on Puma 3.12.1. https://travis-ci.org/rails/rails/jobs/509239592#L2303-L2305 Specify binding explicitly to avoid being affected by Puma changes.
* Engines are reloaded in Zeitwerk mode [closes #35618]Xavier Noria2019-03-151-14/+19
|
* Properly expand the environment's name in all commandsyuuji.yaginuma2019-03-151-0/+4
| | | | | | | | | | | | | Since 3777701f1380f3814bd5313b225586dec64d4104, the environment's name is automatically expanded in console and dbconsole commands. In order to match the behavior between the commands, fixes it to have the same behavior of all the commands. This behavior is defined in `EnvironmentArgument`. Since `EnvironmentArgument` also defines the environment option, it is reused. However, since desc was not content that can be used in all comments, fixed desc to be defined for each command.
* Make application work without tmp directoryyuuji.yaginuma2019-03-141-0/+3
| | | | | | | | | | | | The tmp directory is added to version control in the newly created application. This was added in Rails 5.0.0(https://github.com/rails/rails/commit/f06ce4c12a396795a3b2c1812951d9277bcb3a82). However, applications created before that are not guaranteed to have the tmp directory. If the tmp directory does not exist, writing to the key file raise error. This is a bit incompatible. So I fixed that create the directory before writing a key.
* Fix secret_key_base for Railtieseileencodes2019-03-131-0/+1
| | | | | | This was missed in the security fix for local dev. CI doesn't have a tmp directory in the apps built for testing so these end up failing. This adds the secret_key_base so we don't need to generate one.
* Merge tag 'v6.0.0.beta3'eileencodes2019-03-131-1/+21
|\ | | | | | | v6.0.0.beta3 release
| * Fix possible dev mode RCEAaron Patterson2019-03-101-1/+21
| | | | | | | | | | | | | | | | | | | | | | | | If the secret_key_base is nil in dev or test generate a key from random bytes and store it in a tmp file. This prevents the app developers from having to share / checkin the secret key for dev / test but also maintains a key between app restarts in dev/test. [CVE-2019-5420] Co-Authored-By: eileencodes <eileencodes@gmail.com> Co-Authored-By: John Hawthorn <john@hawthorn.email>
* | Add test for runner command with `environment` optionyuuji.yaginuma2019-03-131-0/+4
| |
* | Add additional ERB DummyCompiler testsCliff Pruitt2019-03-121-0/+54
| | | | | | | | This adds a few additional tests to the commits by eileencodes (https://github.com/rails/rails/pull/35497) and rafaelfranca (https://github.com/rails/rails/commit/cfa22f1a4b5e8b95ee01a432168de2f831b3f788). The additional tests cover several more ERB tag formatting cases such as multiline tags, conditional statements that result in duplicate keys, and multiple erb statements on a single line.
* | Do not generate dummy string when the tag used is not the <%=Rafael Mendonça França2019-03-111-0/+1
| |
* | [ci skip] Minor documentation fixes for consistencyShailesh Kalamkar2019-03-091-1/+1
| |
* | Minor text changes to the db:seed:replant testsSharang Dashputre2019-03-091-2/+2
| |
* | Allow autoloader inflectors to be swaped outJean Boussier2019-03-081-0/+4
| |
* | Load YAML for rake tasks without parsing ERBeileencodes2019-03-061-12/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds a new method that loads the YAML for the database config without parsing the ERB. This may seem odd but bear with me: When we added the ability to have rake tasks for multiple databases we started looping through the configurations to collect the namespaces so we could do `rake db:create:my_second_db`. See #32274. This caused a problem where if you had `Rails.config.max_threads` set in your database.yml it will blow up because the environment that defines `max_threads` isn't loaded during `rake -T`. See #35468. We tried to fix this by adding the ability to just load the YAML and ignore ERB all together but that caused a bug in GitHub's YAML loading where if you used multi-line ERB the YAML was invalid. That led us to reverting some changes in #33748. After trying to resolve this a bunch of ways `@tenderlove` came up with replacing the ERB values so that we don't need to load the environment but we also can load the YAML. This change adds a DummyCompiler for ERB that will replace all the values so we can load the database yaml and create the rake tasks. Nothing else uses this method so it's "safe". DO NOT use this method in your application. Fixes #35468
* | Allow `truncate` for SQLite3 adapter and add `rails db:seed:replant` (#34779)Bogdan2019-03-041-1/+121
|/ | | | | | | | | | | | | * Add `ActiveRecord::Base.connection.truncate` for SQLite3 adapter. SQLite doesn't support `TRUNCATE TABLE`, but SQLite3 adapter can support `ActiveRecord::Base.connection.truncate` by using `DELETE FROM`. `DELETE` without `WHERE` uses "The Truncate Optimization", see https://www.sqlite.org/lang_delete.html. * Add `rails db:seed:replant` that truncates database tables and loads the seeds Closes #34765
* Make this test strongerXavier Noria2019-02-231-0/+7
| | | | | We test the inflections for both autoloaders, but we can also autoload the constant as a sort of integration test.
* Let Zeitwerk autoloaders inflect with Active SupportXavier Noria2019-02-231-0/+18
| | | | [Harry Brundage & Xavier Noria]
* simplifies Rails.autoloaders.logger=Xavier Noria2019-02-211-2/+2
| | | | Possible thanks to Zeitwerk 1.3.0.
* simplify AS::Dependencies.verbose=Xavier Noria2019-02-211-4/+4
| | | | Possible thanks to Zeitwerk 1.3.0.
* Define Rails.autoloaders.logger=Xavier Noria2019-02-211-0/+23
|
* let Zeitwerk integration unhook AS::DependenciesXavier Noria2019-02-194-2/+28
|
* Implement AS::Dependencies.verbose= compatibility for :zeitwerk modeXavier Noria2019-02-151-0/+36
|
* Replace autoloader accessors with Rails.autoloaders.{main,once}Xavier Noria2019-02-142-23/+32
| | | | | | | | | | | | | | | | Rails.autoloader and Rails.once_autoloader was just tentative API good enough for a first patch. Rails.autoloader is singular and does not convey in its name that there is another autoloader. That might be confusing, for example if you set a logger and miss traces. On the other hand, the name `once_autoloader` is very close to being horrible. Rails.autoloaders.main and Rails.autoloaders.once read better for my taste, and have a nice symmetry. Also, both "main" and "once" are four letters long, short and same length. They are tagged as "rails.main" and "rails.once", respectively. References #35235.
* Fix the `config_for` to always return a NonSymbolAccessDeprecatedHash:Edouard CHIN2019-02-141-0/+22
| | | | | | | | | | | | | | | | | | - If you have hashes inside array, the hashes were getting initialized as regular HWIA wereas we want them to be NonSymbolAccessDeprecatedHash in order to trigger a deprecation warning when keys are accessed with string. This patch fixes that by overwriting the `[]=` to to the same as what HWIA does (with the difference that we don't call `convert_key` to not trigger a deprecation when setting value). I also took the liberty to extract `hash.nested_under_indifferent_access`, into a separate method to allow subclasses to return whatever they want. Inheriting HWIA is not common, but I think it's useful for cases like this one where we want to preprocess reading and writing values in the hash (for deprecation purposes or other reasons).
* styleXavier Noria2019-02-121-3/+3
|
* Zeitwerk integrationXavier Noria2019-02-125-26/+190
|
* Fix assertion excpected/actual orderUfuk Kayserilioglu2019-02-111-6/+6
| | | | | | | | The assertion from the previous PR had the expected and the actual values in the wrong order, so when a test failed the error message was confusing. This commit fixes the problem by switching the order.
* Allow deprecated non-symbol access to nested `config_for` hashesUfuk Kayserilioglu2019-02-111-1/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | A change to `Rails::Application.config_for` in https://github.com/rails/rails/pull/33815 and https://github.com/rails/rails/pull/33882 has altered the behaviour of the returned object in a breaking manner. Before that change, nested hashes returned from `config_for` could be accessed using non-symbol keys. After the change, all keys are recursively symbolized so non-symbol access fails to read the expected values. This is a breaking change for any app that might be relying on the nested hashes returned from `config_for` calls, and thus should be deprecated before being removed from the codebase. This commit introduces a temporary `NonSymbolAccessDeprecatedHash` class that recursively wraps any nested hashes inside the `OrderedOptions` object returned from `config_for` and issues a deprecation notice when a non-symbol based access is performed. This way, apps that are still relying on the ability to access these nested hashes using non-symbol keys will be able to observe the deprecation notices and have time to implement changes before non-symbol access is removed for good. A CHANGELOG entry is also added to note that non-symbol access to nested `config_for` hashes is deprecated.
* Fix rubocop violationsyuuji.yaginuma2019-02-091-9/+7
|