aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib
Commit message (Collapse)AuthorAgeFilesLines
* Deprecate support of older `config.ru`yuuji.yaginuma2017-08-081-1/+8
| | | | | | | | Since Rails 4.0, `config.ru` generated by default uses instances of `Rails.application`. Therefore, I think that it is good to deprecate the old behavior. Related: #9669
* Fix wrong service name in the storage.ymldixpac2017-08-061-3/+3
|
* Add missing blank line between `config.active_storage` and `config.action_cable`Ryuta Kamizono2017-08-051-0/+1
|
* Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-0411-3/+71
|\ | | | | Add Active Storage to Rails
| * Include active_storage in all generated application.rb filesDavid Heinemeier Hansson2017-08-042-0/+2
| | | | | | | | And deal with a temporary test fix until we allow you to skip active storage.
| * Merge branch 'master' into active-storage-importDavid Heinemeier Hansson2017-08-015-7/+8
| |\
| * | Prevent interpolation of ERB elementsDavid Heinemeier Hansson2017-08-011-6/+6
| | |
| * | Add the storage.yml file by defaultDavid Heinemeier Hansson2017-08-011-0/+1
| | |
| * | We moved to storage.ymlDavid Heinemeier Hansson2017-08-012-35/+1
| | |
| * | Add Azure configuration to Active Storage templateMike Gunderloy2017-08-011-0/+8
| | | | | | | | | | | | | | | With Active Storage supporting Azure, we should show people how to set it up. Incorporates the minor changes originally in https://github.com/rails/activestorage/pull/88 as well
| * | Create the skeleton directories needed and ignore accordinglyDavid Heinemeier Hansson2017-07-312-0/+8
| | |
| * | Load activestorage by defaultDavid Heinemeier Hansson2017-07-312-0/+8
| | |
| * | Use config/storage.yml as part of the skeleton and loadingDavid Heinemeier Hansson2017-07-314-5/+44
| | |
| * | Require activestorage per default with asset pipelineDavid Heinemeier Hansson2017-07-311-0/+1
| | |
| * | Include default storage configurationDavid Heinemeier Hansson2017-07-314-0/+35
| | |
* | | Merge pull request #30058 from ↵Rafael França2017-08-041-1/+5
|\ \ \ | | | | | | | | | | | | | | | | y-yagi/use_assert_nil_if_value_is_nil_in_assert_field_default_value_ Use `assert_nil` if `value` is nil in `assert_field_default_value`
| * | | Use `assert_nil` if `value` is nil in `assert_field_default_value`yuuji.yaginuma2017-08-031-1/+5
| | |/ | |/| | | | | | | | | | It is deprecate to specify nil for expect argument of `assert_equal`. Ref: https://github.com/seattlerb/minitest/commit/922bc9151a622cb3ef0b9f170aa09c3bb72c7eb8
* | | Merge pull request #30022 from y-yagi/remove_extra_empty_lineEileen M. Uchitelle2017-08-041-1/+5
|\ \ \ | | | | | | | | Remove extra empty line
| * | | Remove extra empty lineyuuji.yaginuma2017-08-021-1/+5
| | |/ | |/|
* | | Merge pull request #29967 from naw/binstub-error-msgRichard Schneeman2017-08-031-5/+16
|\ \ \ | |_|/ |/| | Improve bundler binstub error message
| * | Revise bundle binstub error messageNathan Wenneker2017-08-031-8/+13
| | |
| * | Improve bundler binstub error messageNathan Wenneker2017-07-261-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails displays an error message if you have a bundler-generated binstub at `./bin/rails` instead of a Rails-generated binstub. This error message is misleading because it makes it seem as though Rails 5 introduced recent changes in how binstubs are used, when these changes were actually introduced way back in Rails 4. The suggested upgrade steps are appropriate for an app that was created in Rails 3, but they likely aren't the correct fix for someone who sees this error message today on a modern app. I believe the `--binstubs` option on bundler is a more likely culprit and troubleshooting path.
* | | Merge pull request #30015 from larskanis/use-duktake-on-mingwGuillermo Iguaran2017-08-011-0/+2
|\ \ \ | | | | | | | | Use duktape gem as default JS engine on Windows-MINGW
| * | | Use duktape gem as default JS engine on Windows-MINGW and MS-Visual-C buildsLars Kanis2017-08-011-0/+2
| |/ / | | | | | | | | | | | | | | | | | | | | | The fallback javascript engine on Windows is Windows Script Host (JScript). However this engine isn't able to process the default assets, because it supports ES3 only but the coffeescript compiler requires ES5. Fixes #30014
* | | Merge pull request #30023 from y-yagi/remove_unnecessary_doc_directory_deletionGuillermo Iguaran2017-08-011-1/+0
|\ \ \ | | | | | | | | Remove unnecessary `doc` directory deletion
| * | | Remove unnecessary `doc` directory deletionyuuji.yaginuma2017-08-011-1/+0
| | |/ | |/| | | | | | | Since 553b695, `doc` directory is not created in application.
* | | Merge pull request #30029 from yhirano55/fix_rails_command_commentsSean Griffin2017-08-011-3/+3
|\ \ \ | | | | | | | | [ci skip] Fix rails_command comments
| * | | [ci skip] Fix rails_command commentsYoshiyuki Hirano2017-08-011-3/+3
| | |/ | |/|
* | | Fix rubocop style issues in yarn and spring.rb templates"roberts10002017-07-312-3/+3
| |/ |/|
* | Set Ruby version in Gemfile and .ruby-version by defaultAlberto Almagro2017-07-313-0/+7
|/
* Merge pull request #29926 from pawandubey:fix-test-with-absolute-pathsKasper Timm Hansen2017-07-251-1/+4
|\
| * Allow bin/rails test task to take absolute paths as argumentsPawan Dubey2017-07-251-3/+3
|/ | | | | | | | | | | | | | | | | | | Solves #29923 This regression was caused due to a wrong regex to filter out paths, introduced in commit 796a1cf0e The regex was /^\w+\// which did not accept paths with a leading slash and hence all absolute paths were filtered out. This change introduces a change in regex which allows for a leading slash and acts on the matched term accordingly. While cascading through the case block, the paths are checked for line number specification, existence of a directory at that path and if none of those match, then it is considered to be a path to the file. The regex matchers specified are filtered out via the call to `Array#compact` since they do not match any of these conditions.
* Stop creating ApplicationRecord on model generationLisa Ugray2017-07-241-0/+9
| | | | | | | | | | | | | | When generating models, we created ApplicationRecord in the default location if no file existed there. That was annoying for people who moved it to somewhere else in the autoload path. At this point, the vast majority of apps should have either run the upgrade script or generated a model since upgrading. For those that haven't the error message after generating a new model should be helpful: NameError: uninitialized constant ApplicationRecord To ease friction in that case, this also adds a generator for ApplicationRecord.
* Merge pull request #29902 from y-yagi/fix_29880Rafael França2017-07-241-2/+6
|\ | | | | Do not show URL in boot info when using Puma
| * Do not show URL in boot info when using Pumayuuji.yaginuma2017-07-241-2/+6
| | | | | | | | | | | | | | | | | | | | | | Puma has its own configuration file(e.g. `config/puma.rb`). Can define a port and a URL to bind in the configuration file. Therefore, on Rails side, can not grasp which URI to bind finally. Because of that, it may show a URL different from the actually bound URL, so I think that it is better not to show it. Fixes #29880
* | Merge pull request #29853 from lugray/move_generator_namespacing_to_baseRafael França2017-07-242-36/+37
|\ \ | | | | | | Move generator namespacing to Base
| * | Move generator namespacing to BaseLisa Ugray2017-07-192-36/+37
| | | | | | | | | | | | | | | | | | | | | Generators need to be aware of namespace to work properly in engines. Methods to help with this lived in Rails::Generators::NamedBase. Moving them to Rails::Generators::Base (which NamedBase inherits from) allows a follow-up in which a namespace aware unnamed generator can be created.
* | | Revert "Include rack-mini-profiler by default"Rafael França2017-07-241-2/+0
| | |
* | | Include rack-mini-profiler by defaultschneems2017-07-241-0/+2
| |/ |/| | | | | | | | | | | | | | | | | | | | | I've used many development related performance tools, but the single most consistently helpful tool is `rack-mini-profiler`. The tool provides a lightweight UI element for each page, that shows the server response time. When clicked it expands to show more detail: ![](https://www.dropbox.com/s/0aciw4mk8c059n0/Screenshot%202017-07-24%2010.24.24.png?dl=1) This can be used to detect expensive queries, N+1 issues and general performance related problems.
* | Make `rails yarn:install` ignore dev dependenciesprintercu2017-07-191-1/+1
|/
* support `-` as an argument to `rails runner`Cody Cutrer2017-07-172-2/+7
| | | | | | | | | | | | | in Rails 4.0, you could use `/dev/stdin` on both Linux and Mac, but with the switch to Kernel.load in Rails 4.1, this broke on Linux (you get a LoadError). Instead, explicitly detect `-` as meaning stdin, then read from stdin explicitly, instead of performing file gymnastics. This should now work on any platform uniformly. Passing a script via stdin is useful when you're sshing to a server, and the script you want to run is stored locally. You could theoretically pass the entire script on the command line, but in reality you'll run into problems with the command being too long.
* Add bootsnap to default Gemfile:Burke Libbey2017-07-172-0/+4
| | | | | | Bootsnap precomputes load path resolution and caches ruby ISeq and YAML parsing/compilation, reducing application boot time by approximately 50% on supported configurations.
* Set `RAILS_ENV` before load application fileyuuji.yaginuma2017-07-171-1/+4
| | | | | | | Since #29725, load application file when `dbconsole` command is executed. However, if do not set `RAILS_ENV` before reading the application file, can not connect to the env specified in option, so added the setting of `RAILS_ENV`.
* Merge pull request #29782 from y-yagi/follow_up_29699Kasper Timm Hansen2017-07-161-1/+1
|\ | | | | Set `represent_boolean_as_integer` via `configuration`
| * Set `represent_boolean_as_integer` via `configuration`yuuji.yaginuma2017-07-161-1/+1
| |
* | Merge pull request #29358 from robin850/dbconsole-connectionKasper Timm Hansen2017-07-163-8/+25
|\ \ | | | | | | Allow to pass a connection to the `dbconsole` command
| * | Properly expand the environment's nameRobin Dupret2017-07-163-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | Running the `console` and `dbconsole` commands with a regular argument as the environment's name automatically expand it to match an existing environment (e.g. dev for development). This feature wasn't available using the `--environment` (a.k.a `-e`) option.
| * | Deprecate environment as an argument for dbconsole and consoleRobin Dupret2017-07-161-0/+6
| | | | | | | | | | | | | | | | | | People should rather rely on the `-e` or `--environment` options to specify in which environment they want to work. This will allow us to specify the connection to pick as a regular argument in the future.
| * | Allow to pass a connection to the `dbconsole` commandRobin Dupret2017-07-161-2/+14
| |/ | | | | | | | | | | | | | | | | | | | | Since 0a4f6009, it's possible to specify a 3-level database configuration to gather connections by environment. The `dbconsole` command will try to look for a database configuration which points to the current environment but with such flavour, the environment key is flushed out so let's add the ability to specify the connection and pick `primary` by default to be consistent with Active Record.
* / Fix root not being defined on Travis.Kasper Timm Hansen2017-07-161-1/+6
|/