| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/
|
|
|
|
|
| |
make connection_url_to_hash a class method
This als prevents loading database.yml if it doesn't exist
but DATABASE_URL does
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Most application developers shouldn't be adding paths to
`config.autoload_paths` as it won't be eagerly loaded so
remove it from the generated config/application.rb file.
If a developer does want to autoload from paths outside of the app
directory then they should add the path to `config.eager_load_paths`
as these paths are also autoloaded as well.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Whilst autoloading is known to be not threadsafe, leaving it in place
is a softer solution than failing hard when an application is deployed.
Many older applications will have paths added to `autoload_paths` and
ideally these should be eagerly loaded to be threadsafe. However one
of these paths is quite often lib which could lead to unintended
consequences due to the 'junk drawer' nature of this directory.
Developers should refrain from adding paths to `autoload_paths` or
`eager_load_paths` and use custom folders inside app for code that
needs to be eagerly loaded and use `require` or `require_dependency`
to explicitly load code from other locations.
|
|
|
|
|
|
|
|
|
|
|
| |
Because of the possibility of lib being unintentionally eager loaded
it's been agreed that we'll leave autoload paths and eager load paths
separate for Rails 4.0.
This reverts commit 0757b3388ffe4f44b60de950d40e18ef05055931.
Conflicts:
railties/CHANGELOG.md
|
|
|
|
|
|
| |
User should know that he can overwrite the previous migration. This
comes in handy especially when generating models which were previously
created then removed.
|
| |
|
| |
|
|
|
|
| |
Use 'some' instead of 'a/an'.
|
|
|
|
|
|
|
|
|
|
| |
Speed up depends on the number of test phases (N) you have for your
app, but it is roughly a 1/N improvement. In my app, it goes from
15.51s to 5.56s.
Inspired by http://ngauthier.com/2012/02/quick-tests-with-bash.html
Reviewed by @tenderlove
|
|\
| |
| | |
Add --rc description on the command line
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Fixes improper database name when creating a new rails app with a '.'
Conflicts:
railties/CHANGELOG.md
|
| |
| |
| |
| |
| |
| | |
application. EG: `rails new something.awesome.com`
Conflicts:
railties/CHANGELOG.md
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since the default in Rails 4.0 is to run in 'threadsafe' mode we need
to eager load all of the paths in `autoload_paths` so we alias
`eager_load_paths` to it. This may have unintended consequences if
you have added 'lib' to `autoload_paths` such as loading unneeded
code or code intended only for development and/or test environments.
If this applies to your application you should thoroughly check what
is being eager loaded.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 43e14f8ff203c21646f733d35bdde4e68da70a3b, reversing
changes made to bb17a0f085aba40a1952612f6c98b2a5804a1152.
Conflicts:
railties/lib/rails/generators/rails/app/templates/config/application.rb
railties/lib/rails/generators/rails/app/templates/config/initializers/locale.rb
Reason: setting the Time.zone in an after_initialize block can become a
problem for people upgrading, since it's not going to be available when
config/initializers run, and people might be relying on it.
An example that I noticed was with the Chronic gem, for date/time parsing.
It requires us to configure the time class to be Time.zone, and doing
that in an initializer no longer worked with these changes, so reverting
is the safer path for now.
|
| |
| |
| |
| | |
`require 'rubygems'` is already required in Ruby 1.9 or later.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Adding Back Rails::Engine::Railties#engines
Conflicts:
railties/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | | |
Removing it breaks functionality with gems such as Thinking Sphinx.
This restores it with a deprecation warning. Closes #8551
|
| | | |
|
| |/
|/| |
|
| |
| |
| |
| |
| |
| | |
Allows custom rake tasks to be defined using:
SourceAnnotationExtractor.enumerate 'TODO|FIXME', dirs: %w(app lib), tag: true
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Deprecate #update_attributes in favor of `#update`.
ORMs that implement `Generators::ActiveModel#update_attributes` should change
to `#update`. Scaffold controller generators should change calls like:
@orm_instance.update_attributes(...)
to:
@orm_instance.update(...)
This goes along with the addition of `ActiveRecord::Base#update`,
introduced in cb2bd4aa619d9329c42aaf6d9f8eacc616ce53f4.
|
|\ \
| | |
| | | |
Controller scaffold codestyle
|
| | | |
|
| | | |
|
|/ / |
|
| |
| |
| |
| | |
API. The default scaffold will now just create HTML if the user actively opts out of jbuilder
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
Conflicts:
guides/source/getting_started.md
|
| | | |
|
| | |
| | |
| | |
| | | |
It is semantically correct than relative path.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Don't require 'turn' from rails/test_help
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If 'turn' is in the Gemfile with `:require => nil`, Rails should
respect that.
This supports the case where 'turn' may or may not be required
depending on different developers' preference or environment. E.g., you
require turn for local testing, but not on your CI server by putting
this in `test/test_helper.rb`:
require 'turn' if ENV['TURN']
|
| | | |
| | | |
| | | |
| | | | |
actions.rb:34: warning: instance variable @in_group not initialized
|
| | | | |
|