| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
The comment on the +env_config+ method is repetitive, likely to get
outdated, and provides no useful information which cannot be gleamed
from the code. I'm therefore removing it. I'm also refactoring the check
for the presence of a secret_token in the configuration.
|
|
|
|
|
|
| |
This reverts commit 7098d6c9ab28931acc9562a00037567609f9e529, reversing
changes made to 9ec2e2ee91568af24e09760a6de2890b89c33f56.
This make some tests fail /cc @wangjohn
|
|\
| |
| | |
Creating a class to build the default middleware stack.
|
| |
| |
| |
| |
| |
| |
| | |
A lot of logic for building the default middleware stack is currently
kept in Application class, but this can be encapsulated and made more
modular by being moved to its own class. Also refactored a couple of the
helper methods.
|
| | |
|
|\ \
| | |
| | | |
Removing a repetitive comment and refactoring the Application class in Railties
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
Railties.
The comment on the +env_config+ method is repetitive, likely to get
outdated, and provides no useful information which cannot be gleamed
from the code. I'm therefore removing it. I'm also refactoring the check
for the presence of a secret_token in the configuration.
|
|/
|
|
|
|
|
|
|
|
| |
Is it more suitable that using ```<th colspan="3">``` instead of three empty ```<th>```? It is simple, but what i am missing about it?
Change repetitive th tags to use colspan attribute
Update CHANGELOG.md
Update CHANGELOG.md
|
| |
|
| |
|
|
|
|
|
|
|
| |
1. Used ActiveSupport::Autoload to dry-up the autoload definitions.
2. Used ActiveSupport's delegate to dry up the application proxied
attributes.
3. Did a little white space change on Rails.groups.
|
|
|
|
|
| |
Conflicts:
railties/test/application/loading_test.rb
|
|
|
|
| |
all directives
|
| |
|
|\
| |
| |
| | |
Fixes bug 10628.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently, ActiveModel is only loaded by ActiveRecord. If you skip ActiveRecord, ActiveModel will not be required (or even autoloaded) and including `ActiveModel::Model` into a plain Ruby class will raise `NameError`.
To reproduce this:
- create a new app with `rails new my_app -O`
- create a Ruby class that includes `ActiveModel::Model` in `app/models`
- load up a Rails console and try to do anything with the class :-)
Since ActionPack relies so heavily on the ActiveModel API, this should probably be considered a dependency of the app. Another possibility would be to make it a dependency of ActionController.
|
|\ \ |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When bundling a gem created with
rails plugin new
Bundler outputs the following warning when building the gem:
WARNING: licenses is empty
modified: railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec
|
|\ \ \
| | | |
| | | | |
exit with non-zero to signal failure
|
| | | | |
|
| | | | |
|
| |_|/
|/| |
| | |
| | |
| | |
| | | |
If you generate a fresh app without ActiverRecord, this template
exhibited a lone trailing line break. My watchful pre-commit hook
told me about it so I've fixed it here.
|
|/ /
| |
| |
| | |
stub command description
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Prior to this change, for the following command:
$ rails new
we received "Options should be given after the application name" as an error message.
This is outdated and should be "Application name should be provided in arguments".
|
|\ \
| |/
|/| |
Remove jruby-openssl from default Gemfile
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
Conflicts:
activesupport/lib/active_support/callbacks.rb
|
| | | |
|
| |/
|/| |
|
| | |
|
| | |
|
| |
| |
| |
| | |
See the comment in the rescue clause towards the top of the patch for the rationale.
|
| |
| |
| |
| | |
- http://help.github.com/ignore-files redirects to https://help.github.com/articles/ignoring-files
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Scaffold generator with --assets=false option
outputs an error
See #9525
|
|\ \
| | |
| | | |
generate 'app/assets/images' directory when creating new rails app. Fixes #10434
|
| | | |
|
|\ \ \
| | | |
| | | | |
Relaxed jbuilder dependency in Gemfile template
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A regression was introduced in 5b3bb6, generating route from within an
engine to an another engine resulted in prefixing a path with the
SCRIPT_NAME value.
The regression was caused by the fact that SCRIPT_NAME should be
appended only if it's the SCRIPT_NAME for the application, not if it's
SCRIPT_NAME from the current engine.
closes #10409
|
| | | |
|
| |/
|/| |
|
|\ \ |
|