aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #21021 from sgrif/sg-no-routes-commentSean Griffin2015-08-121-54/+1
|\ \ | | | | | | Replace the giant comment in routes.rb with a link to the guides
| * | Replace the giant comment in routes.rb with a link to the guidesSean Griffin2015-07-241-54/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This comment not only serves no purpose, but in my experience is actively detrimental to new developers getting started with Rails. Expereinced developers just end up deleting this comment, and are annoyed that they had to take this step. I also spend a lot of time mentoring brand new developers, and a consistent theme I've seen is that this comment just ends up intimidating them, and making them think it's dangerous to edit this file. One of my students just said this (due to the number of comments which even new developers don't actually read, they just see it as a sign that this thing is "dangerous"). > I don't edit any file that Rails generates for me, until my instructor > says that it's OK to do so. Realistically, this comment adds 0 value. We have very good documentation, which we can just link to instead. If someone is truly new enough to benefit from this info, they presumably just ran `gem install rails`, and have an internet connection that they can use to read the routing guide. The choice of language here was very specific. I chose "the DSL available" over "what is possible", because a consistent theme I've noticed among my students is that they aren't aware that this is actually a Ruby file, and can write any Ruby code here that they want. This file is not the only offender, but is by far the biggest point of pain that I've seen, and felt it was a good spot to open this discussion.
* | | Merge pull request #21124 from kirs/feature/reload-i18nKasper Timm Hansen2015-08-102-1/+11
|\ \ \ | | | | | | | | Reload I18n.load_path in development
| * | | Reload I18n locales in developmentKir Shatrov2015-08-102-1/+11
| | | |
* | | | Merge pull request #21176 from y-yagi/fix_scaffold_tests_inside_api_engineRafael Mendonça França2015-08-091-1/+4
|\ \ \ \ | | | | | | | | | | make generated scaffold functional tests work inside API engines
| * | | | make generated scaffold functional tests work inside API enginesyuuji.yaginuma2015-08-091-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | * set engine's route in setup * use fixture with engine namespace
* | | | | WhitespacesRafael Mendonça França2015-08-091-1/+1
|/ / / /
* | | | Fix deprecation warning in testseileencodes2015-08-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using the string version of the class reference is now deprecated when referencing middleware. This should be written as a class not as a string. Deprecation warning that this change fixes: ``` DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change them to actual class references. For example: "ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions ```
* | | | Added bin/update script to update application automaticallyMehmet Emin İNAÇ2015-08-071-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use system! fix changelog use bundle check first and use rake use system instead system! for bundle check
* | | | Only load statistics.rake once from inside engineErsin Akinci2015-08-061-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running rake stats from inside an engine, the engine's Rakefile attempts to reload statistics.rake after the test app loads it, which results in STATS_DIRECTORIES being redefined and an annoying warning. This patch skips loading statistics.rake from tasks.rb if rake's current scope isn't empty, i.e. if we are running from inside an engine and not the test app dir or a normal app. Fixes #20510.
* | | | Merge pull request #21043 from ↵Rafael Mendonça França2015-08-061-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | y-yagi/loading_fixtures_in_engine_integration_tests set the correct path to `ActionDispatch::IntegrationTest.fixture_path`
| * | | | set the correct path to `ActionDispatch::IntegrationTest.fixture_path`yuuji.yaginuma2015-07-281-0/+1
| | |/ / | |/| | | | | | | | | | | | | | `ActionDispatch::IntegrationTest.fixture_path` set by `test_help.rb`, but if the engine, path under the dummy is will be set, fixtures under test was not loaded.
* | | | stop using deprecated `render :text` in railtiesyuuji.yaginuma2015-08-062-2/+2
| | | |
* | | | routes in the env via the request objectAaron Patterson2015-08-051-3/+2
| | | |
* | | | allocate a request object to avoid hash allocationsAaron Patterson2015-08-051-3/+2
| | | | | | | | | | | | | | | | | | | | This decouples the `call` method from knowing the SCRIPT_NAME key and offloads decisions about how to access script_name
* | | | Use exist? instead of deprecated exists?Kasper Timm Hansen2015-08-051-2/+2
| | | |
* | | | Merge pull request #20961 from ccallebs/add-dev-mode-cachingKasper Timm Hansen2015-08-054-2/+51
|\ \ \ \ | |_|/ / |/| | | Add dev caching toggle / server options
| * | | Add rake dev:cache task to enable dev mode caching.Chuck Callebs2015-08-044-2/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Taken from @Sonopa's commits on PR #19091. Add support for dev caching via "rails s" flags. Implement suggestions from @kaspth. Remove temporary cache file if server does not have flags. Break at 80 characters in railties/CHANGELOG.md Remove ability to disable cache based on server options. Add more comprehensive options: --dev-caching / --no-dev-caching
* | | | Merge pull request #21105 from os97673/allow-minitest-pluginsRafael Mendonça França2015-08-031-0/+1
|\ \ \ \ | | | | | | | | | | Allow Minitest to load plugins. Fixes #21102
| * | | | Allow Minitest to load plugins. Fixes #21102Oleg Sukhodolsky2015-08-031-0/+1
| | | | |
* | | | | Inform user to add script in correct location into the application.js ↵Mehmet Emin İNAÇ2015-08-032-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | manifest file [ci skip] use it change the warning
* | | | | Revert "test runner should crash with non existing file argument."Yves Senn2015-08-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 465f0fbca3d4a1c269038b84ec9cc248fdab5fab. This breaks some cases where non file / directory arguments are passed to the runner (for example db:migrate). I still think that we can get this to work. From what I can tell there is no reason why db:migrate is passed along to `Minitest.run`. I'll revert and investigate possible solutions.
* | | | | Merge pull request #21104 from atul-shimpi/masterYves Senn2015-08-032-2/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Inform user to add styles in correct location in application.css [ci skip]
| * | | | | Inform user to add styles in correct location in application.cssatul-shimpi2015-08-032-2/+4
| |/ / / /
* / / / / test runner should crash with non existing file argument.Yves Senn2015-08-031-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this patch, using `bin/rails test` with a non existing file or directory argument would silently swallow the argument and run the whole test suite. After the patch the command fails with `cannot load such file --`.
* | | | Merge pull request #20992 from JuanitoFatas/fix/bin-setup-scriptYves Senn2015-07-311-1/+1
|\ \ \ \ | |/ / / |/| | | Don't fail when checking dependencies in bin/setup script
| * | | Don't fail when checking dependencies in bin/setup scriptJuanito Fatas2015-07-231-1/+1
| | |/ | |/|
* | | Add `:nodoc:` for internal testing methods [ci skip]Robin Dupret2015-07-281-2/+2
| | |
* | | Merge pull request #20759 from vngrs/fix_wrong_docRafael Mendonça França2015-07-271-2/+2
|\ \ \ | | | | | | | | Change wrong usage in documentation about autoload_paths [ci skip]
| * | | Change wrong usage in documentation about autoload_paths [ci skip]Mehmet Emin İNAÇ2015-07-021-2/+2
| | | | | | | | | | | | | | | | We can't use this configuration outside of the application.rb
* | | | Merge pull request #21003 from robin850/api-pluginsRafael Mendonça França2015-07-273-9/+25
|\ \ \ \ | |_|_|/ |/| | | Allow generating plugins for API applications
| * | | Enable the `api_only` option for API plugins' generatorsRobin Dupret2015-07-231-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This way, running a generator inside the plugin's directory, files that are not relevant won't be generated (e.g. views or assets). This won't interfere with the application's generators configuration.
| * | | Generate an API dummy application for API pluginsRobin Dupret2015-07-231-0/+1
| | | |
| * | | Make ApplicationController inherit from AC::API for API pluginsRobin Dupret2015-07-231-1/+1
| | | |
| * | | Skip assets, helpers and views generation for API pluginsRobin Dupret2015-07-231-8/+15
| | | |
| * | | Add the `--api` option for the plugin generatorRobin Dupret2015-07-231-0/+7
| | |/ | |/|
* | | Merge pull request #20928 from matthewd/unload-interlockMatthew Draper2015-07-241-1/+1
|\ \ \ | |/ / |/| | We need stricter locking before we can unload
| * | We need stricter locking before we can unloadMatthew Draper2015-07-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Specifically, the "loose upgrades" behaviour that allows us to obtain an exclusive right to load things while other requests are in progress (but waiting on the exclusive lock for themselves) prevents us from treating load & unload interchangeably: new things appearing is fine, but they do *not* expect previously-present constants to vanish. We can still use loose upgrades for unloading -- once someone has decided to unload, they don't really care if someone else gets there first -- it just needs to be tracked separately.
* | | Merge pull request #20926 from rsanheim/fail-fast-bin-setupRafael Mendonça França2015-07-211-5/+9
|\ \ \ | | | | | | | | add system! to fail fast in bin/setup
| * | | add system! to fail fast in bin/setupRob Sanheim2015-07-181-5/+9
| |/ /
* | | Merge pull request #20819 from y-yagi/rails_api_gemfileRafael Mendonça França2015-07-211-1/+3
|\ \ \ | | | | | | | | remove `web-console` from API app generated Gemfile
| * | | remove `web-console` from API app generated Gemfileyuuji.yaginuma2015-07-091-1/+3
| | | |
* | | | titleizing the New LinkThiago Pinto2015-07-201-1/+1
| |/ / |/| |
* | | [skip ci] Lookup can be a noun but it is not a verbJon Atack2015-07-171-3/+3
| | | | | | | | | | | | Various grammar corrections and wrap to 80 characters.
* | | make test runner work correctly inside engineyuuji.yaginuma2015-07-122-3/+9
| | |
* | | remove Rack::Lock for webrickAaron Patterson2015-07-101-11/+1
| | | | | | | | | | | | constant loading should be thread safe now, so lets remove this
* | | Rely on the load interlock for non-caching reloads, tooMatthew Draper2015-07-092-17/+11
| | |
* | | Soften the lock requirements when eager_load is disabledMatthew Draper2015-07-091-9/+29
|/ / | | | | | | | | We don't need to fully disable concurrent requests: just ensure that loads are performed in isolation.
* | Merge pull request #20767 from y-yagi/remove_unnecessary_fixture_methodYves Senn2015-07-061-4/+0
|\ \ | | | | | | remove unnecessary loading fixtures from `navigation_test.rb`
| * | remove unnecessary loading fixtures from `navigation_test.rb`yuuji.yaginuma2015-07-031-4/+0
| |/ | | | | | | | | it has been corrected in 0176aef1ebaa9f69001c7045a51727a8ea9b61b8 as for loading of fixtures in `test_helper.rb`, loading fixtures for each test is unnecessary.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-14 03:46:41 +0000