Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | Add Rails.groups to encapsulate available groups for require. | José Valim | 2011-06-21 | 1 | -0/+23 | |
| | | | | ||||||
* | | | | Removed rescue branch for Rails 2.x compatibility | Alexey Gaziev | 2011-06-20 | 1 | -3/+0 | |
| | | | | ||||||
* | | | | Fix regexp in generators for right catching error message | Alexey Gaziev | 2011-06-20 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #1784 from gazay/3-1-stable-shadowing-variables | José Valim | 2011-06-20 | 2 | -7/+7 | |
|\ \ \ \ | | | | | | | | | | | Removing shadowing outer local variables warnings | |||||
| * | | | | Removed warnings about shadowing variables | Alexey Gaziev | 2011-06-20 | 2 | -7/+7 | |
| | |_|/ | |/| | | ||||||
* / | | | assets:clean task now cleans up images | James A. Rosen | 2011-06-19 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-06-18 | 1 | -1/+1 | |
|\ \ \ | ||||||
| * | | | fixed typo for a methodname | thoefer | 2011-06-11 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Attributes on scaffold and model generators default to string. | José Valim | 2011-06-17 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | This allows the following: "rails g scaffold Post title body:text author" | |||||
* | | | | Patch for #1458 - [3.1.0.rc1] App plugins initialized before engines | Joseph Wong | 2011-06-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and plugins inside engines It seems that plugins inside a Rails 3.1 application proper (i.e. in /vendor/plugins) are initialized before engines and plugins inside engines. After some debugging, I found the culprit in Rails::Application::Railties#all: def all(&block) @all ||= railties + engines + super @all.each(&block) if block @all end The call to super here implicitly passes the &block argument, which has the unfortunate side-effect of adding the plugin initializers first (in front of other railties and engines) in the case of Rails::Engine#initializers: def initializers initializers = [] railties.all { |r| initializers += r.initializers } initializers += super initializers end The solution here is to replace the super call with a call to #plugins. | |||||
* | | | | Make the API for compression consistent between JS and CSS. By default, ↵ | wycats | 2011-06-16 | 1 | -3/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | users just need to say whether they want compression or not, and a default will be chosen by a Railtie. In the case of CSS, this default is already chosen by the sass-rails gem. Users can still explicitly choose a compressor in their application.rb if they have a preference, but will usually want to let plugins choose defaults in their Railties. | |||||
* | | | | Merge pull request #1733 from SAP-Oxygen/master-plugins_in_engine_patch | José Valim | 2011-06-16 | 2 | -8/+10 | |
|\ \ \ \ | | | | | | | | | | | Cherry-picking patch for https://github.com/rails/rails/issues/1460 from 3-1-stable to master | |||||
| * | | | | Cherry-picking patch for https://github.com/rails/rails/issues/1460 | Joseph Wong | 2011-06-16 | 2 | -8/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from 3-1-stable to master [3.1.0.rc1] Plugins inside engines not eager-loaded properly and their rake tasks ignored Working with the new support for plugins inside engines in Rails 3.1, I found that certain things that work for regular plugins don't work for these new nested plugins. In particular, these methods in Rails::Engine don't seem to understand that an engine could have nested plugins: #load_tasks #load_generators #load_console #eager_load! A solution which worked out for me is to move the calls to railties.all { ... } from the overriding methods in Rails::Application into Rails::Engine. | |||||
* | | | | | replace dev.ror.com plugin url with a dummy one | Vijay Dev | 2011-06-16 | 1 | -2/+2 | |
| |_|_|/ |/| | | | ||||||
* | | | | Improve the legacy wild controller route in app templates | Wen-Tien Chang | 2011-06-16 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | load_generators from engine should also handle self automatically. | José Valim | 2011-06-15 | 1 | -3/+3 | |
| | | | ||||||
* | | | namespace engine assets | Ryan Bates | 2011-06-12 | 2 | -7/+21 | |
| | | | ||||||
* | | | s/Bundle/Bundler/ | Xavier Noria | 2011-06-11 | 1 | -1/+1 | |
|/ / | ||||||
* | | shell out to run bundler on app generation, see rationale in the comment | Xavier Noria | 2011-06-10 | 1 | -6/+12 | |
| | | ||||||
* | | make 'rails runner' show usage when run without any options | Vijay Dev | 2011-06-10 | 1 | -0/+4 | |
| | | ||||||
* | | Merge pull request #1356 from flippingbits/fix_engine_generator | José Valim | 2011-06-09 | 10 | -23/+69 | |
|\ \ | | | | | | | Fix engine's generator | |||||
| * | | Use mattr_accessor :namespace | Stefan Sprenger | 2011-06-07 | 1 | -10/+2 | |
| | | | ||||||
| * | | Use namespace if it's a mountable engine | Stefan Sprenger | 2011-06-07 | 4 | -3/+17 | |
| | | | ||||||
| * | | We moved engine commands to rails/engine/commands | Stefan Sprenger | 2011-05-27 | 1 | -5/+1 | |
| | | | ||||||
| * | | Add destroy to engine's commands | Stefan Sprenger | 2011-05-27 | 1 | -2/+3 | |
| | | | ||||||
| * | | Generate script/rails only if --full is given | Stefan Sprenger | 2011-05-27 | 1 | -0/+2 | |
| | | | ||||||
| * | | Refactor identifying generator's destination root | Stefan Sprenger | 2011-05-27 | 1 | -5/+2 | |
| | | | ||||||
| * | | Move requiring engine out of the switch case | Stefan Sprenger | 2011-05-27 | 1 | -4/+3 | |
| | | | ||||||
| * | | Fix and test ENGINE_PATH and ENGINE_ROOT | Stefan Sprenger | 2011-05-27 | 1 | -2/+2 | |
| | | | ||||||
| * | | Introducing engine commands | Stefan Sprenger | 2011-05-26 | 3 | -3/+48 | |
| | | | ||||||
| * | | Move load_generators from Rails::Application to Rails::Engine | Stefan Sprenger | 2011-05-26 | 2 | -12/+12 | |
| | | | ||||||
* | | | sprockets gzips assets now | Xavier Noria | 2011-06-07 | 1 | -1/+4 | |
| | | | ||||||
* | | | Fixing Rails::Server#app under Rack::URLMap | Guillermo Iguaran | 2011-06-07 | 2 | -1/+5 | |
| | | | ||||||
* | | | adds missing require | Xavier Noria | 2011-06-07 | 1 | -0/+2 | |
| | | | ||||||
* | | | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-06-06 | 7 | -12/+12 | |
|\ \ \ | |_|/ |/| | | | | | | | | Conflicts: activerecord/RUNNING_UNIT_TESTS | |||||
| * | | Remove trailing white-spaces | Guillermo Iguaran | 2011-06-05 | 5 | -9/+9 | |
| | | | ||||||
| * | | fix incorrect module name for wrap parameters | Vijay Dev | 2011-06-04 | 1 | -1/+1 | |
| | | | ||||||
| * | | Upcoming version of Rails is upon us so no need to refer to it. [API DOCS] | Rohit Arondekar | 2011-06-03 | 1 | -2/+2 | |
| | | | ||||||
| * | | add alias info for runner command | Vijay Dev | 2011-06-02 | 1 | -1/+1 | |
| | | | ||||||
* | | | revises commit from pull request 1408 | Xavier Noria | 2011-05-31 | 1 | -4/+7 | |
| | | | ||||||
* | | | revises commit from pull request 1409 | Xavier Noria | 2011-05-31 | 1 | -4/+8 | |
| | | | ||||||
* | | | Modified generated text to explain where .js and .coffee files can be ↵ | Noel Gomez | 2011-05-31 | 1 | -3/+5 | |
| | | | | | | | | | | | | located and that there shouldn't be blank lines in manifest per this issue http://groups.google.com/group/rubyonrails-talk/browse_thread/thread/effb868290c2c0b8 | |||||
* | | | changed text to be more explicit about where stylesheets can be located | Noel Gomez | 2011-05-31 | 1 | -2/+5 | |
| | | | ||||||
* | | | Merge pull request #1404 from ↵ | José Valim | 2011-05-30 | 2 | -1/+5 | |
|\ \ \ | | | | | | | | | | | | | | | | | commuter/plugin_new_generator_should_properly_require_js properly require javascript libraries when generating mountable engine | |||||
| * | | | properly require javascript libraries when generating mountable engine | J. Edward Dewyea | 2011-05-30 | 2 | -1/+5 | |
| | |/ | |/| | ||||||
* | | | refectored assets:clean task | Vishnu Atrai | 2011-05-30 | 1 | -3/+1 | |
| | | | ||||||
* | | | rename task and Rake::FileList used | Vishnu Atrai | 2011-05-27 | 1 | -3/+3 | |
| | | | ||||||
* | | | Add rake task to implement assets:cleanup, fixes Github Issues # 1284 | Bhavin Kamani | 2011-05-27 | 1 | -0/+10 | |
|/ / | ||||||
* | | Use global namespace Rails | Stefan Sprenger | 2011-05-26 | 1 | -1/+1 | |
| | | ||||||
* | | Use plugin name consistently | Stefan Sprenger | 2011-05-26 | 1 | -1/+1 | |
| | |